[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/532 Thanks for tracking that down, it makes sense now that I see your changes. I tested the new changes, did a full build with contrib check (thanks for the earlier fix), and will merge. --- If your

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Just addressed the issue and rebased to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Actually, I think I see what the issue is. Going to verify my change and if all looks good, I'll update the PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Thanks for jumping in to review! I am not aware of this specific issue though I know we have a number of outside JIRAs surrounding templates and the 1.0.0 release. It doesn't surprise me that

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/532 I ran through the following steps to test this fix: 1. Confirm the bug a. Built a template on master/1.0 branch with a process group b. Exported the template c. Confirmed that

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/532 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the