[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on the pull request: https://github.com/apache/nifi/pull/281#issuecomment-197888150 @bbende code looks good. Just a few minor comments in-line (stylistic for the most part). There were a lot of files that were changed due to just white space and Java

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56506078 --- Diff:

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56410644 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosProperties.java --- @@ -0,0 +1,146 @@ +/* + * Licensed to the

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56411887 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/SecurityUtil.java --- @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-19 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56410960 --- Diff: nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosTicketRenewer.java --- @@ -0,0 +1,69 @@ +/* + * Licensed to the

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-18 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/281#discussion_r56505883 --- Diff: nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/test/resources/core-site.xml --- @@ -1,4 +1,5 @@ + --- End diff --

[GitHub] nifi pull request: NIFI-1488 Refactoring HBase Kerberos support

2016-03-15 Thread bbende
GitHub user bbende opened a pull request: https://github.com/apache/nifi/pull/281 NIFI-1488 Refactoring HBase Kerberos support - Storing UGI so we can support multiple HBaseClientServices with different configs - Creating nifi-hadoop-utils to hold utility code shared between