Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-221086451
@bbende The updated PR looks good to me. A number of great iterations here.
Definitely think this is a solid foundation to continue the policy based
authorizers managed
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-221046683
@mcgilman @jtstorck @alopresto pushed two new commits, the first contains
minor changes to address some of Matt's comments, the second is an attempt at
what Matt suggested
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r64086436
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r64076734
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software
Github user jtstorck commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220607952
+1 looks good to me at this point, though @mcgilman's earlier comment on
making MutableAuthorizer a base class does sound good, since the idea of the
MutableAuthorizer
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r64040788
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220469545
@alopresto Great comment about the UserService. The reason we cannot do
that directly is the extension point that is getting discovered is an
Authorizer. However, this
Github user alopresto commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220464739
@mcgilman thanks for the response above. It feels a little to me like the
authorizer has gotten conflated with user and group management tasks. If the
authorizer'
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220457062
With the builders included, looks good to me.
@jtstorck @alopresto Thoughts?
---
If your project is set up for it, you can reply to this email and have your
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63956868
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220307255
@alopresto Thanks for the very thorough review! This API is designed
strictly for handling the persistence of access policies which would also
include Users and Groups.
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63760082
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63759950
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220121052
@alopresto The intent was for the relationship to be bi-directional,
meaning you could add a user to a group by adding/updating a User with a new
group id in the set of
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63745403
--- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63744574
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user jtstorck commented on a diff in the pull request:
https://github.com/apache/nifi/pull/452#discussion_r63743405
--- Diff:
nifi-api/src/main/java/org/apache/nifi/authorization/AccessPolicy.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220025580
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the pull request:
https://github.com/apache/nifi/pull/452#issuecomment-220023481
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user bbende opened a pull request:
https://github.com/apache/nifi/pull/452
NIFI-1884 Defining API for Users, Groups, and Policies
This pull request introduces the concept of a MutableAuthorizer which is an
interface that extends the recently introduced Authorizer. A
20 matches
Mail list logo
