[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...

2016-02-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...

2016-02-25 Thread mattyb149
Github user mattyb149 commented on the pull request: https://github.com/apache/nifi/pull/220#issuecomment-188922521 Ran the tests, verified the Groovy JAR was available to the scripting NAR and that the Groovy unit tests ran successfully. LGTM, needs +1/merge from committer

[GitHub] nifi pull request: NIFI-1511 Incorporate Groovy unit tests as part...

2016-02-13 Thread apiri
GitHub user apiri opened a pull request: https://github.com/apache/nifi/pull/220 NIFI-1511 Incorporate Groovy unit tests as part of the build instead of via profile Incorporating Groovy unit tests as part of the main build and providing explicit compile scope on the Groovy

Re: Groovy unit tests

2016-01-11 Thread Andy LoPresto
Thanks to everyone who weighed in. This feature is documented in NIFI-1365 [1] and there is a patch available [2]. The tests do not run by default and are triggered with a Java variable named `groovy` being set to `test`. It can be invoked as follows: `mvn clean test -Dgroovy=test` [1]

Re: Groovy unit tests

2016-01-10 Thread Joshua Davis
+1 Excellent idea Joshua Davis Senior Consultant Hortonworks Professional Services (407)476-6752 On 1/9/16, 11:52 AM, "Oleg Zhurakousky" wrote: >Big +1 > >Sent from my iPhone > >On Jan 4, 2016, at 18:30, Andy LoPresto

Re: Groovy unit tests

2016-01-09 Thread Oleg Zhurakousky
Big +1 Sent from my iPhone On Jan 4, 2016, at 18:30, Andy LoPresto > wrote: I am considering writing unit tests in for new development/regression testing in Groovy. There are numerous advantages to this [1][2] (such as map

Groovy unit tests

2016-01-04 Thread Andy LoPresto
I am considering writing unit tests in for new development/regression testing in Groovy. There are numerous advantages to this [1][2] (such as map coercion, relaxed permissions on dependency injection, etc.). Mocking large and complex objects, such as NiFiProperties, when only one feature is

Re: Groovy unit tests

2016-01-04 Thread Matt Burgess
+1, Groovy is a great way to rapidly generate tests, remove boilerplate, and enable powerful test frameworks like Spock. Sent from my iPhone > On Jan 4, 2016, at 7:29 PM, Andy LoPresto wrote: > > I am considering writing unit tests in for new development/regression

Re: Groovy unit tests

2016-01-04 Thread Joe Witt
Andy, I am supportive of this because we clearly have at least a couple folks in the community who know and are interested in Groovy. I just want to make sure we aren't increasing the burden on people to setup their environments. As long as this is seamless from a Maven user perspective (and be