Re: Help Wanted

Totally makes sense. My only comment was just in regards to the fact that on that Wiki page there is no mention of looking at GH PR's. I agree that in this day and age looking to GH, may be first inclination for many. However, perhaps calling that out in the contribution guide would eliminate

Re: Help Wanted

The "Patch Available" state in JIRA can mean a patch is attached to the JIRA, or a PR is submitted. It is really just a manual state transition on the ticket after In-Progress... the next state is patch available which tells people there is something to review. On Tue, May 3, 2016 at 11:29 AM,

Re: Help Wanted

Totally agree on all fronts. Would seem like it makes sense for a documentation PR to be opened soon with updates to the https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess page to remove the ambiguity. On Tue, May 3, 2016 at 11:27 AM, Bryan

Re: Help Wanted

They are treated with same priority, but as Oleg mentioned, the PRs do make it easier for collaborative review and has the built in integration with Travis, although currently some issues to get it consistently working. On Tue, May 3, 2016 at 11:26 AM, Suneel Marthi wrote: >

Re: Help Wanted

PR is the standard now across most Apache projects. On Tue, May 3, 2016 at 11:25 AM, Oleg Zhurakousky < ozhurakou...@hortonworks.com> wrote: > Andrew > > Regarding PR vs. Patch. > > This has been an ongoing discussion and i’ll let other’s to contribute to > this. Basically we support both. That

Re: Help Wanted

Andrew Regarding PR vs. Patch. This has been an ongoing discussion and i’ll let other’s to contribute to this. Basically we support both. That said, personally (and it appears to be embraced by the rest of the community) PR is the preference specifically due to the inline review/comment

Re: Help Wanted

Thank you Oleg! Yeah, that page with the Code Review, has a little refresh link, but it really just points to this JIRA query: https://issues.apache.org/jira/browse/NIFI-1837?filter=12331874 As a community is there a preference given to JIRA's with Patch or GH PR's or are they all treated with

Re: Help Wanted

Andrew Thank you so much for following up on this. I am assuming you have GitHub account. If not please create one as most of our contributions deal with pull requests (PR). Then you can go to https://github.com/apache/nifi , click on “Pull Requests” and review them by commenting in line (you