[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Also just created another PR to consider building something to automated the conversion of the nifi.properties [1]. [1] https://issues.apache.org/jira/browse/NIFI-1967 --- If your project

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/488 Modifications that you proposed look good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752022 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752750 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread brosander
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65756258 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,352 @@ +/*

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65756334 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/458 I'm having trouble understanding the naming convention here. "DebugFlow" would indicate that it is debugging the flow that you are putting together, but the comment states "Create DebugFlow processor

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread brosander
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/492 @pvillard31 thanks for the review so far! I'll try and beef up the comments a bit. I think the Java 8 features make for a much cleaner implementation so I'd like to keep them in for now.

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread brosander
GitHub user brosander opened a pull request: https://github.com/apache/nifi/pull/492 NIFI-1502 - Processor for parsing evtx files You can merge this pull request into a Git repository by running: $ git pull https://github.com/brosander/nifi NIFI-1502-rebase-pr Alternatively

[GitHub] nifi issue #303: NIFI-1660 - Enhance the expression language with jsonPath f...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/303 @ckmcd an example would be something like: ${ hello:jsonPath( '$.${elementOfInterest}.items[0]') } Here, we are referencing an attribute within the JSON Path, so it is not a String

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752318 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753157 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65752470 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753430 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
GitHub user markap14 opened a pull request: https://github.com/apache/nifi/pull/491 NIFI-1960: Update admin guide regarding documentation for clustering You can merge this pull request into a Git repository by running: $ git pull https://github.com/markap14/nifi NIFI-1960

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65753532 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65755030 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65757147 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65755477 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,352 @@ +/*

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread pvillard31
Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/492 I am running out of time right now, but will have a deeper look later and give it a try asap. As a general comment, I'd say, even if I know how boring it can be, that some comments in the code

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65771143 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,35 @@ +nifi-evtx-nar +Copyright 2016 The

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/492 ok i reviewed the handling of the ported python evtx library. I provided my suggestions on what I believe would be correct. Given that it was apache licensed making derived works is fortunately

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 This has been merged into master. Discovered a few new items and identified a few old items that we'll still need to knock out. Another item that we still need to tackle is ensuring that all node

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65769083 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-nar/src/main/resources/META-INF/NOTICE --- @@ -0,0 +1,35 @@ +nifi-evtx-nar +Copyright 2016 The

Re: Apache NiFi git

2016-06-03 Thread Joe Witt
The github location is purely a mirror. Code should only be pushed to the git-wip-us repository. When you push to the asf git repo you simply need to ensure the commit message includes 'This closes #444.' and you should be good. Thanks Joe On Fri, Jun 3, 2016 at 1:38 PM, Michael Moser

[GitHub] nifi pull request #489: NIFI-1951: Custom UIs

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/489 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #488: NIFI-1897: Refactoring to allow requests to be repli...

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65770640 --- Diff: NOTICE --- @@ -7,3 +7,7 @@ The Apache Software Foundation (http://www.apache.org/). This product includes the following work from the Apache

[GitHub] nifi issue #489: NIFI-1951: Custom UIs

2016-06-03 Thread bbende
Github user bbende commented on the issue: https://github.com/apache/nifi/pull/489 +1 full build passed contrib-check, ran the app and verified custom UIs still work --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread brosander
Github user brosander commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65769603 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,353 @@ +/*

[GitHub] nifi issue #458: NIFI-1829 - Create new DebugFlow processor.

2016-06-03 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/458 The name isn't great but not sure what would be better. It is indeed a debugger for the framework and less so for a flow. It is perhaps good to call it 'CreateChaos'. That said i personally think

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread brosander
Github user brosander commented on the issue: https://github.com/apache/nifi/pull/492 Added the notice to the root and assembly, updated it in the nar Added some comments to the code --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request #473: NIFI-1916 Updating FileAuthorizer to extend Abstract...

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/473 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on the issue: https://github.com/apache/nifi/pull/492 regarding Java8 angle obviously that just means this can only go in 1.x line and not 0.x. That is ok though. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request #492: NIFI-1502 - Processor for parsing evtx files

2016-06-03 Thread joewitt
Github user joewitt commented on a diff in the pull request: https://github.com/apache/nifi/pull/492#discussion_r65769425 --- Diff: nifi-nar-bundles/nifi-evtx-bundle/nifi-evtx-processors/src/main/java/org/apache/nifi/processors/evtx/ParseEvtx.java --- @@ -0,0 +1,353 @@ +/*

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/473 @bbende The updates for ensuring thread-safe access looks good as do the converting of existing authorized-users.xml. +1 Merging to master. --- If your project is set up for it, you can

Re: UpdateAttribute Combining Multiple Attributes

2016-06-03 Thread Andy LoPresto
Hi Ronnie, Glad you figured it out, but just to confirm for the list, you can combine them with your original expression. Andy LoPresto alopre...@apache.org alopresto.apa...@gmail.com PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Jun 3, 2016, at 5:14 PM, Joe Witt

Re: UpdateAttribute Combining Multiple Attributes

2016-06-03 Thread Ronnie Dove
Nevermind I figured it out : ) haha it was something incorrect on my end. Also found you can do this too ${allAttributes("attr1", "attr2"):join("_")} On Fri, Jun 3, 2016 at 7:47 PM, Ronnie Dove wrote: > Is it possible to combine two attributes like this? > > new_attr =

[GitHub] nifi issue #491: NIFI-1960: Update admin guide regarding documentation for c...

2016-06-03 Thread markap14
Github user markap14 commented on the issue: https://github.com/apache/nifi/pull/491 Thanks, @alopresto. I have merged to master. I am sure that we will end up updating this a few more times before 1.0.0 is released, but at least I wanted to get this into master so that those trying

UpdateAttribute Combining Multiple Attributes

2016-06-03 Thread Ronnie Dove
Is it possible to combine two attributes like this? new_attr = ${attr2}_${attr1} Whenever I try to use ${attr2}_${attr1}, it only takes the first attribute even though both are present in the attributes. Is this by design and any work arounds?

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 closed the pull request at: https://github.com/apache/nifi/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] nifi issue #239: Nifi 1540 - AWS Kinesis Get and Put Processors

2016-06-03 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/239 Thanks for your latest changes to the error handling. The changes look OK, I don't think we need the failure relationship. The integration tests for PutKinesisStream and GetKinesisStream both worked

Re: UpdateAttribute Combining Multiple Attributes

2016-06-03 Thread Joe Witt
Glad you got it sorted and thanks for following up. Joe On Fri, Jun 3, 2016 at 5:01 PM, Ronnie Dove wrote: > Nevermind I figured it out : ) haha it was something incorrect on my end. > Also found you can do this too ${allAttributes("attr1", "attr2"):join("_")} > > On Fri, Jun

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65751497 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread alopresto
Github user alopresto commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65754466 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -1351,66 +1389,81 @@ in the file specified in

[GitHub] nifi pull request #491: NIFI-1960: Update admin guide regarding documentatio...

2016-06-03 Thread markap14
Github user markap14 commented on a diff in the pull request: https://github.com/apache/nifi/pull/491#discussion_r65755845 --- Diff: nifi-docs/src/main/asciidoc/administration-guide.adoc --- @@ -485,98 +485,137 @@ It is preferable to request upstream/downstream systems to switch

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into a small issue with node (re)connection regarding Templates. It appears that Templates local to that node are replaced with the cluster set of Templates. There is an

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Just ran into an issue with the fields that are used in the flow fingerprint. I think we need to reconsider which fields are included. Specifically I had modified the penalty

[GitHub] nifi issue #483: NIFI-1899 - Introduce ExtractEmailAttachments processor

2016-06-03 Thread trixpan
Github user trixpan commented on the issue: https://github.com/apache/nifi/pull/483 @joewitt Second tests are ready and hopefully the code should be ready to merge. I will start working on ListenSMTP during the weekend but I expect it to take longer than those two

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into another issue around cluster coordinator selection. When the selected coordinator has a unheritable flow it is treated as the 'golden' copy as they are the coordinator.