Re: Should the elastic search client service impl get renamed before 1.7?

2018-06-10 Thread Mark Payne
I think it’s a good idea to go ahead and rename it. Even if 6.x doesn’t make breaking changes, 7.x may. And I’d rather not have an ElasticSearchClient that works for 5.x and 6.x and then an ElasticSearchClient_7 that deals with 7. It makes it look like the simply named ElasticSearchClient is

Re: Should the elastic search client service impl get renamed before 1.7?

2018-06-10 Thread Sivaprasanna
I feel if the upgrade from 5.x to 6.x client doesn't introduce any breaking changes, we can continue with the name that we are having now. - Sivaprasanna On Sun, Jun 10, 2018 at 5:16 PM, Mike Thomsen wrote: > The current implementation uses the last stable release of the 5.X client > from

Re: Should the elastic search client service impl get renamed before 1.7?

2018-06-10 Thread Mike Thomsen
I think types are required in 5.X and optional in 6.X. By 8.X types are going to be firmly eliminated, so that's at least one area of research that needs to be done I suppose. On Sun, Jun 10, 2018 at 7:53 AM Sivaprasanna wrote: > I feel if the upgrade from 5.x to 6.x client doesn't introduce

Re: Should the elastic search client service impl get renamed before 1.7? I'm I getting muyyiugjjjjj your lkpmllomnj is like o huglll is m

2018-06-10 Thread Charlie Meyer
I'm going out for dinner tonight if we Mom mmomnlokk let other LM sorry to be homlmmmkmmolle with On Sun, Jun 10, 2018, 06:46 Mike Thomsen wrote: > The current implementation uses the last stable release of the 5.X client > from Elastic, and 6.X is already mature so we'll need to be able to

Should the elastic search client service impl get renamed before 1.7?

2018-06-10 Thread Mike Thomsen
The current implementation uses the last stable release of the 5.X client from Elastic, and 6.X is already mature so we'll need to be able to have room to create a new implementation copy that uses that client if there are things we have to change between them. So does it make sense to throw in a

Re: Should the elastic search client's tllmomorrow and ask service impl get renamed before 1.7?

2018-06-10 Thread Charlie Meyer
I'm gonna jump me know a day without women are you going so let a man and I'll nknnock knock it k and I'll fill n never get mm forget kkjinnock it out and let it me I can illoyiintjvhjhmbmhbnnnjkyolokiklu to the of you know know if I meNikki'sklnobn the I don't own the car parked Atkins I will be

Re: [DISCUSS] Release candidate timeframe for Apache NiFi 1.7.0

2018-06-10 Thread Matt Burgess
I reviewed, tested, and merged, thanks for the fix! On Sat, Jun 9, 2018 at 3:43 PM Mike Thomsen wrote: > > Fixed an ugly bug in PutMongoRecord that relates to the MongoDB driver > apparently not liking Java arrays: > > https://issues.apache.org/jira/browse/NIFI-5288 > > It really needs to be