Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Joe Witt
We are following rtc and specifically the form of rtc we adopted long ago for commits to Nifi. It simply requires a +1 before a merge and no apparent lack of consensus. Even then should there be disagreement after the fact there are procedures to resolve. Consensus forming is central to the apac

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Andre
James, There's no doubt the Sign-off-by is redundant (as GIT itself holds that information, reason why GH is still able to show the information without the sign-of-by stamp), however, I agree with your view around positive action and easy to refer as Bryan pointed. Joe, Thanks for the clarificat

Re: Controller Services tab

2017-03-02 Thread Bryan Bende
Hi Mark, Controller services from the global menu are only for use by reporting tasks that might use a controller service. For example, the SiteToSiteProvenanceReportingTask uses an optional SSLContextService, which would need to be defined at the global level. All controller services used by pro

Controller Services tab

2017-03-02 Thread Mark Bean
Can someone please clarify the difference between the Global Menu -> Controller Settings -> Controller Services tab and Root Canvas -> Configuration button from palette -> Controller Services tab? I would expect that a Controller Service added via the Global Menu would be available at all levels o

Re: Hosting API's on Nifi

2017-03-02 Thread Joe Witt
definitely ignore my suggestion - i didn't read the question properly. If you want to use a single port to address multiple applications you'll need something a little more capable than simply port forwarding. On Thu, Mar 2, 2017 at 2:30 PM, Joe Gresock wrote: > I believe the traditional approach

Re: Hosting API's on Nifi

2017-03-02 Thread Joe Gresock
I believe the traditional approach would be to specify another port like 8443 in the NiFi HandleHttpRequest processor, and use a reverse proxy like nginx or httpd running on 80/443 that directs traffic to NiFi. We have done this on our own project, and there are several articles floating around on

Re: Hosting API's on Nifi

2017-03-02 Thread Joe Witt
You can run the processor on another port and use port forwarding to go from 80 to whatever port you're really using. This is a good practice anyway since you don't want to run nifi as root ideally (you could also allow nifi to bind to lower ports, but..). Lots of ways to slice it. Thanks joe O

Re: Hosting API's on Nifi

2017-03-02 Thread Oleg Zhurakousky
Anil Aside from opening another port I don’t se how you can overcome this issue. HandleHttpRequest essentially starts another web server and this server needs a port to listen on. Further more, there are many other network based Processors that come with NiFi that would fall int the same catego

Hosting API's on Nifi

2017-03-02 Thread Rai, Anil (GE Digital)
Hello All, I am exposing an API using HandleHttpRequest on my local nifi instance. The HandleHttpRequest processor requires a Listening port that I need to provide. If I enter 80 in that field, the processor fails when it starts saying “unable to initialize the server”. Which is expected as

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread James Wing
I recommend the practice. Although the signoff may not be authoritative, it requires a positive action that suggests you purposefully merged the commit, as opposed to commits you might have accidentally merged and pushed. Thanks, James On Thu, Mar 2, 2017 at 7:49 AM, Joe Witt wrote: > "If th

Re: accidently deleted my Nifi Template

2017-03-02 Thread Scott Aslan
Maybe you could check your trash or recycle bin and attempt to restore the file? You may also need to import the template into NiFi again... On Thu, Mar 2, 2017 at 10:43 AM, Joe Witt wrote: > Depending on the version of nifi you're using the nifi/conf directory > may contain backups of the flow

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Joe Witt
"If this not the expected process, we should definitely update the Contributor Guide." I think it is fine to encourage it. It is not a requirement though. The signoff is not an apache thing. Committer privileges to push code to a given repo is an apache thing. We're an RTC community and the on

Re: accidently deleted my Nifi Template

2017-03-02 Thread Joe Witt
Depending on the version of nifi you're using the nifi/conf directory may contain backups of the flow for you automatically and you could likely recover from that if your template was already on any part of the flow. Thanks Joe On Thu, Mar 2, 2017 at 10:32 AM, Oleg Zhurakousky wrote: > Ssingh >

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Joe Skora
Like Andre, I originally got the requirement for signoff from the Contributor Guide[1] when I started working on the project and later from this email thread[2]. If this not the expected process, we should definitely update the Contributor Guide. >From the Apache perspective the signoff confirms

Re: accidently deleted my Nifi Template

2017-03-02 Thread Oleg Zhurakousky
Ssingh Sorry to hear that. If you deleted an un-exported template there is no way you can recover it. If however, you did export the template and deleted the template file, then it may still be in your recycling bin or use OS level utilities to recover reference to the deleted file. Oleg > O

accidently deleted my Nifi Template

2017-03-02 Thread ssingh singh
Hi, I have accidently deleted my nifi template. Please help me how can I recover it. Is there any way so that I can recover it. Thanks, Ssingh

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Joe Witt
For what it is worth this is definitely not a requirement and not something I knew anything of so I never do it. I think it is a perfectly fine idea and a good practice to follow so occasional reminders of its utility are fair game. That said, to Bryan's point I rely on the JIRA/issues history if

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Matt Burgess
I didn't realize it was required either, I usually only sign off (using the same thing Bryan Bende does) if the PR author couldn't merge it on their own (i.e. not a NiFi committer/PMC). Certainly I can start always signing off commits. Regards, Matt On Thu, Mar 2, 2017 at 8:35 AM, Oleg Zhurakousk

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Oleg Zhurakousky
Thanks Bryan. If ‘-s’ is only for showcasing the committer I don’t believe anyone would have any issues with it, but my concern at the moment is purely legal, so I am not sure who is the right person to answer that, but figured raising the concern is the least I can do. Cheers Oleg > On Mar

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Bryan Bende
The sign-off is so we can easily see who the reviewer/merger was from the git history. We can always go back to the JIRA or PR and the reviewer/merger should have commented there, but its convenient to see it in the git history in my opinion. Personally, whenever merging someones contribution I u

Re: [REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Oleg Zhurakousky
Andre Thanks for the reminder. I admit that I did not know that we require it in the Contributor Guide, so thanks for pointing it out. However, your email did prompt me to look at the purpose and origin of the ‘-s’ flag and led me to this thread on Stack Overflow - http://stackoverflow.com/ques

[REMINDER] Please signoff when committing other people's changes

2017-03-02 Thread Andre
dev, May I remind you to ensure we follow the Contributor Guide and use: git commit --amend -s when merging commits from your peers? While git pretty-format can be used to reveal the committer, I am sure that all of us will agree that as an inclusive community we value both the pretty and ugly