Re: Getting lost a bit

2018-01-07 Thread Brett Ryan
I must be an odd one, I’m more comfortable resolving conflicts from the cli ;) The simplest way is the CSV resolution strategy. Edit each file looking for <<< —- >>> blocks where conflicts are presented. Keep the section you want deleting the other side, then git add the file. Do for all

Getting lost a bit

2018-01-07 Thread Mikhail Sosonkin
Hi Devs, I'm trying to create a PR for this branch in my fork https://github.com/nologic/nifi/tree/NIFI-4731. I see that master has moved on to 1.5.0 but I'd like to have the processor built for 1.4 and later. It's the version we're using. However, I don't see an origin/1.4.0 based on the

Re: Enrichment plugin for adding attributes from SQL

2018-01-07 Thread Joey Frazee
Brett, I think it’s great that you brought this up and made some specific suggestions, because it’s easy for people to overlook and hard to know how to do the right thing without that kind of feedback. -joey On Jan 7, 2018, 5:51 AM -0600, Brett Ryan , wrote: > > Probably

Re: Enrichment plugin for adding attributes from SQL

2018-01-07 Thread Joey Frazee
Hey Brett, So as for the LookupAttribute only doing a single key lookup, that was a bit of a coin flip on whether it makes more sense to allow multiple lookups at once, each with a single key, or a single lookup with multiple AND-ed constraints. I opted for the former since that was the use

Re: Enrichment plugin for adding attributes from SQL

2018-01-07 Thread Brett Ryan
> On 5 Jan 2018, at 10:17, Andrew Lim wrote: > > Hi Brett, > > Thanks for your feedback on the “Add Processor” window. I’m sorry you had > trouble identifying the right processor to use for your data flow. As it turns out the right processor doesn't yet exist :)

Re: Enrichment plugin for adding attributes from SQL

2018-01-07 Thread Brett Ryan
MongoDBLookupService can't be used with an UpdateAttribute processor though, it returns a Record type, and has no required keys. The whole purpose of the processor that I originally wrote was to update an attribute from SQL on a FF. The implementation of LookupAttribute requires -