[GitHub] nifi pull request: Nifi 1324

2016-01-12 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/162#issuecomment-170906614 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: Nifi 1324

2016-01-12 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/162#issuecomment-170932242 Code changes look good. Verified compatability existing NiFi installs. Needed to address a few minor contrib-check issues. --- If your project is set up for it, you

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Also just created another PR to consider building something to automated the conversion of the nifi.properties [1]. [1] https://issues.apache.org/jira/browse/NIFI-1967 --- If your project

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 I've been reviewing this PR and have some initial findings. As I'm reviewing I'm updating various comments and naming that still reflect the previous clustering model. I've gone

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 This has been merged into master. Discovered a few new items and identified a few old items that we'll still need to knock out. Another item that we still need to tackle is ensuring that all node

[GitHub] nifi issue #473: NIFI-1916 Updating FileAuthorizer to extend AbstractPolicyB...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/473 @bbende The updates for ensuring thread-safe access looks good as do the converting of existing authorized-users.xml. +1 Merging to master. --- If your project is set up for it, you can

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into a small issue with node (re)connection regarding Templates. It appears that Templates local to that node are replaced with the cluster set of Templates

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Just ran into an issue with the fields that are used in the flow fingerprint. I think we need to reconsider which fields are included. Specifically I had modified the penalty

[GitHub] nifi pull request: NIFI-1800: Providing access to Controller Servi...

2016-05-26 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/469 NIFI-1800: Providing access to Controller Services based on a given context - UI style updates to make the components stand out better. - Reusing controller service table in different contexts

[GitHub] nifi pull request #518: NIFI-1901: Component based access control tests

2016-06-10 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/518 NIFI-1901: Component based access control tests - Building component based access control tests for Connections, Funnels, Labels, Input Ports, Output Ports, Processors, and Process Groups

[GitHub] nifi pull request #507: NIFI-1804 Adding ability for FileAuthorizer to autom...

2016-06-13 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/507#discussion_r66836344 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-file-authorizer/src/main/java/org/apache/nifi/authorization/Resources.java --- @@ -0,0

[GitHub] nifi issue #515: NIFI-826 [REVIEW ONLY] Initial commit for deterministic tem...

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/515 @olegz I believe that we're going to need to introduce the templateId or inceptionId into the flow.xml not just the template DTO. The reasoning is that we need to support the following case

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959842 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/UsersResource.java --- @@ -0,0

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959717 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/UserGroupsResource.java

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66962729 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java --- @@ -24,7 +24,7 @@ /** * A group that users can belong

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66968920 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/resources/nifi-web-api-context.xml --- @@ -114,7 +123,23

[GitHub] nifi issue #518: NIFI-1901: Component based access control tests

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/518 It appears that the unit tests I have added take a long time to complete and causes Travis to timeout and fail. Specifically, the slow running tests stand up an embedded Jetty server and deploys NiFi

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66959598 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/AccessPolicyResource.java

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-14 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r66960292 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/resources/nifi-web-api-context.xml --- @@ -114,7 +123,23

[GitHub] nifi issue #526: NIFI-1952 Create REST endpoints for user/group/policy manag...

2016-06-14 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/526 @jtstorck Lets knock out these couple trivial items. Looks good so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] nifi pull request #524: NIFI-1781: UI updates

2016-06-13 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/524 NIFI-1781: UI updates - Listening for window resize events more selectively. - Fixing malformed request when configuring remote process group ports. - Fixing malformed request when starting

[GitHub] nifi issue #526: NIFI-1952 Create REST endpoints for user/group/policy manag...

2016-06-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/526 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #523: [NIFI-1879] Responsive dialogs and dialog UX refresh

2016-06-13 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/523 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-03 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 @markap14 Ran into another issue around cluster coordinator selection. When the selected coordinator has a unheritable flow it is treated as the 'golden' copy as they are the coordinator

[GitHub] nifi pull request: NIFI-1916 Updating FileAuthorizer to extend AbstractPolic...

2016-05-31 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/473 @bbende Just realized that we'll need to introduce some thread safety here. The RevisionManager in the web tier will handle locking during the User/Group/Policy CRUD operations. However

[GitHub] nifi pull request: NIFI-1554: Updating Cluster endpoints

2016-05-26 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/470 NIFI-1554: Updating Cluster endpoints - Refactoring Cluster endpoints. - Updating frontend to accommodate clustering endpoints. - Remove the 'Make Primary' action. This is phase one

[GitHub] nifi pull request: NIFI-1265: Upgrading to Jetty 9.3

2016-05-27 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/472 NIFI-1265: Upgrading to Jetty 9.3 This PR should only be applied to master as Jetty 9.3 requires Java 8. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-27 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/471#issuecomment-12578 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #489: NIFI-1951: Custom UIs

2016-06-02 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/489 NIFI-1951: Custom UIs - Removing deprecated NiFiWebContext and related classes. - Adding authorization to Custom UIs. - Fixing issue when creating ControllerService inline. - Addressing

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 +1 Looks good. Verified functionality exporting/importing templates across 0.x and 1.x versions. Merged to master. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #485: NIFI-1948 Fixed encoding-version attribute not getting crea...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/485 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/482 This has been merged into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request #482: NIFI-1928: Remove registration

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #488: NIFI-1897: Refactoring to allow requests to be replicated f...

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/488 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman closed the pull request at: https://github.com/apache/nifi/pull/472 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi issue #472: NIFI-1265: Upgrading to Jetty 9.3

2016-06-02 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/472 Will do. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request: NIFI-1928: Remove registration

2016-06-01 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/482 NIFI-1928: Remove registration - Fixing UI action for bulk delete. - Removing registration form. - Fixing default visibility of the anonymous user warning. You can merge this pull request

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65096361 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/471#issuecomment-222539446 Other changes look good! Will merge to master. During my testing of a 1.x template in an 0.x instance I discovered a separate issue that the templates from an 1

[GitHub] nifi pull request: NIFI-1850 - Initial Commit for JSON-to-JSON Sch...

2016-05-30 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/424#issuecomment-222531466 @YolandaMDavis I'm having some issues saving the JSON specification in the Custom UI while running in a clustered instance. When I click save, the value

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65095238 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi pull request: NIFI-1908 Added encoding-version attribute to T...

2016-05-30 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/471#discussion_r65097776 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi issue #559: NIFI-2075: Addressing issues with Provenance Page

2016-06-22 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/559 Thanks @scottyaslan! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/517 @markap14 When exporting a template with controller services at multiple levels, it appears the services all end up at the top level group. These should probably retain the same scoping as the source

[GitHub] nifi pull request #535: NIFI-2041: Unable to refresh Controller Services whe...

2016-06-16 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/535 NIFI-2041: Unable to refresh Controller Services when scoped by Process Group - Fixing issue when attempting to refresh Controller Services when scoped by Process Group. You can merge this pull

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Thanks for jumping in to review! I am not aware of this specific issue though I know we have a number of outside JIRAs surrounding templates and the 1.0.0 release. It doesn't surprise me

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Actually, I think I see what the issue is. Going to verify my change and if all looks good, I'll update the PR. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi issue #532: NIFI-1941: Child group contents in exported templates

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/532 @jvwing Just addressed the issue and rebased to current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi issue #540: NIFI-2033: Allow Controller Services to be scoped at Contro...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/540 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #526: NIFI-1952 Create REST endpoints for user/group/polic...

2016-06-17 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/526#discussion_r67553151 --- Diff: nifi-api/src/main/java/org/apache/nifi/authorization/Group.java --- @@ -24,7 +24,7 @@ /** * A group that users can belong

[GitHub] nifi issue #540: NIFI-2033: Allow Controller Services to be scoped at Contro...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/540 Looks good! Thanks for knocking this out! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi issue #523: [NIFI-1879] Responsive dialogs and dialog UX refresh

2016-06-21 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/523 @scottyaslan Looks great! The additions made since the initial PR have really improved the performance of various parts. I've merged this to master. --- If your project is set up

[GitHub] nifi issue #507: NIFI-1804 Adding ability for FileAuthorizer to automaticall...

2016-06-17 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/507 Looks great @bbende Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67739510 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi pull request #541: NIFI-2032 fixed 'enableControllerServices' logic

2016-06-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/541#discussion_r67739760 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/service

[GitHub] nifi issue #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/511 Looks great @YolandaMDavis I'm merged this into master. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] nifi issue #517: NIFI-1994: Fixed issues with controller services and templa...

2016-06-20 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/517 Looks good @markap14 Had one minor issue ensuring controller services are copied as part of a process group dto. I tweak your commit to include the additionally functionality. --- If your

[GitHub] nifi pull request #532: NIFI-1941: Child group contents in exported template...

2016-06-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/532 NIFI-1941: Child group contents in exported templates - Ensuring child group contents are included in exported templates. You can merge this pull request into a Git repository by running: $ git

[GitHub] nifi pull request #531: NIFI-2007: Restoring bulletin functionality

2016-06-15 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/531 NIFI-2007: Restoring bulletin functionality - Restoring bulletin functionality. - Ensuring appropriate merging of bulletins in clustered responses. You can merge this pull request into a Git

[GitHub] nifi issue #566: NIFI-2061 Ensure nodes in a cluster use consistent authoriz...

2016-06-23 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/566 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #572: NIFI-2059: Ensure that we properly pass along proxie...

2016-06-23 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/572#discussion_r68293664 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-cluster/src/main/java/org/apache/nifi/cluster/coordination/http/replication

[GitHub] nifi issue #577: [NIFI-2027] Responsive Tables

2016-06-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/577 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi pull request #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/511#discussion_r67456463 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/pom.xml --- @@ -355,10 +355,5 @@ spock-core

[GitHub] nifi pull request #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/511#discussion_r67456561 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java

[GitHub] nifi issue #511: NIFI-1850 - JSON-to-JSON Schema Converter Editor

2016-06-16 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/511 @YolandaMDavis While reading over your PR I noticed that the ControllerService and ReportingTask URI's in the StandandNiFiWebConfigurationContext are incorrect. They shouldn't contain the path

[GitHub] nifi pull request #567: NIFI-1554: Continuing to incorporate component based...

2016-06-23 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/567 NIFI-1554: Continuing to incorporate component based authorization - Addressing access controls for the Controller resource. - Addressing access controls for RAW site to site clients

[GitHub] nifi pull request: NIFI-923: Upgrade to Spring 4.2.1.RELEASE

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/82#issuecomment-172551960 Sorry this PR has lingered this long. It looks like the current release of Spring is 4.2.4.RELEASE. Would you be able to update your branch to reflect this version

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172646806 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172668316 Yep, I realize this PR was just trying to establish the baseline and create the build infrastructure. I can certainly +1 that aspect. I was just wondering if this sort

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172657153 The build infrastructure changes look good. I realize the motivation for this ticket was establishing this baseline. However, I wanted to try to run the integration

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172665743 Highlighting the existence of the new profile is a good idea and we should do that. However, I was specifically referring to the AWS integration tests that are part

[GitHub] nifi pull request #579: NIFI-1554: Changing process for cluster detection

2016-06-24 Thread mcgilman
GitHub user mcgilman opened a pull request: https://github.com/apache/nifi/pull/579 NIFI-1554: Changing process for cluster detection - Updating cluster detection to support access through the flow resource. - Using the correct resource when authorizing a root group port during

[GitHub] nifi issue #581: NIFI-1916 Improvements to FileAuthorizer to not parse flow ...

2016-06-24 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/581 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi issue #582: NIFI-1952 Updates to REST resources for user/group manageme...

2016-06-26 Thread mcgilman
Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/582 I've merged this to master. Looks good @jtstorck! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: [NIFI-1496] State Manager documentation link wr...

2016-02-10 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/214#issuecomment-182384398 +1 Thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: [NIFI-1496] State Manager documentation link wr...

2016-02-10 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/214#issuecomment-182368423 Reviewing now... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-27 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/148#issuecomment-175755889 Would just like to confirm with @trkurc before merging in. Sounds like he may have been still working through some of the details. If he's content I'm happy to merge

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-27 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/148#issuecomment-175758510 Sounds good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: NIFI-1257 and 1259

2016-02-02 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/201#discussion_r51630553 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/pom.xml --- @@ -124,4 +124,92 @@ provided

[GitHub] nifi pull request: NIFI-1333 fixed FlowController shutdown deadloc...

2016-01-28 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/148#issuecomment-176187058 With the github outage last night, ended up merging today. Thanks @trkurc and @olegz !!! --- If your project is set up for it, you can reply to this email and have your

[GitHub] nifi pull request: NIFI-1539 - Add normalization of content type f...

2016-02-22 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/242#discussion_r53682786 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-content-viewer/pom.xml --- @@ -104,6 +104,14

[GitHub] nifi pull request: NIFI-1539 - Add normalization of content type f...

2016-02-22 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/242#issuecomment-187358663 Overall, the changes look good. Just need to clarify the point about the Java version and verify it works now that NIFI-1546 is addressed. Thanks! --- If your

[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors

2016-02-25 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/221#issuecomment-188962296 I additionally addressed some whitespaces at the end of lines causing contrib-check to fail. --- If your project is set up for it, you can reply to this email and have

[GitHub] nifi pull request: NIFI-1539 - Add normalization of content type f...

2016-02-25 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/242#issuecomment-188776138 Will be finishing this review today --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] nifi pull request: NIFI-1539 - Add normalization of content type f...

2016-02-25 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/242#discussion_r54100675 --- Diff: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-content-viewer/src/main/java/org/apache/nifi/web/ContentViewerController.java

[GitHub] nifi pull request: NIFI-1539 - Add normalization of content type f...

2016-02-25 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/242#issuecomment-188831478 This has been merged into master. Thanks again for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] nifi pull request: NIFI-1548 Fixing Controller Service Usage Butto...

2016-02-22 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/245#issuecomment-187482738 @jvwing Thanks for the contribution! Merged to master and 0.5.1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] nifi pull request: NIFI-1548 Fixing Controller Service Usage Butto...

2016-02-22 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/245#issuecomment-187468431 reviewing now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1513: fixed some easy to fix errors

2016-02-25 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/221#issuecomment-188847619 Reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-21 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/179#discussion_r50451076 --- Diff: nifi-commons/nifi-processor-utilities/src/main/java/org/apache/nifi/processor/util/listen/dispatcher/DatagramChannelDispatcher.java --- @@ -0,0

[GitHub] nifi pull request: NIFI-1393 Providing the ability to send using g...

2016-01-20 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/175#discussion_r50262265 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PostHTTP.java --- @@ -534,12

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-21 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/179#issuecomment-173707708 Spent some time reviewing the patch. Overall, I think the code looks good. Additional nit-picky item outside of my previous comment. - I could see possibly

[GitHub] nifi pull request: NIFI-1273 Adding ListenRELP Processor

2016-01-22 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/179#issuecomment-174050331 Awesome @bbende great work! I'll go ahead and merge this in now. Thanks everyone! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: Nifi 1365

2016-01-26 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/163#issuecomment-175247876 These warning appear to be coming from a artifact repository being decommisioned. As a result, we are seeing unexpected downloads into local maven repositories

[GitHub] nifi pull request: NIFI-569 Creating basis for integration-tests i...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/173#issuecomment-172864860 +1 Went ahead and merged the proposed changes for the build infrastructure. Specifics for this integration test can be updated as needed. --- If your project is set up

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172874349 Build looks good. No more artifacts showing up in user home directory. Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] nifi pull request: [NIFI-1394] - Unit test creates resources in HO...

2016-01-19 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/174#issuecomment-172880667 I wasn't aware of any issues with the other JDBC tests. This JIRA was created to specifically address the tests resources being created in the user's HOME directory

[GitHub] nifi pull request: NIFI-1393 Providing the ability to send using g...

2016-01-20 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/175#issuecomment-173215720 Reviewing... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] nifi pull request: Nifi 1274

2016-03-18 Thread mcgilman
Github user mcgilman commented on the pull request: https://github.com/apache/nifi/pull/284#issuecomment-197504323 Reviewing... :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] nifi pull request: Nifi 1274

2016-03-18 Thread mcgilman
Github user mcgilman commented on a diff in the pull request: https://github.com/apache/nifi/pull/284#discussion_r56510044 --- Diff: nifi-nar-bundles/nifi-kerberos-iaa-providers-bundle/nifi-kerberos-iaa-providers/src/test/resources/nifi.properties --- @@ -0,0 +1,185

  1   2   3   >