Hi,
+1 from me.
I checked:
- Incubating in name
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- Checked PGP signatures
- Checked Checksums
- Code compiles and tests successfully run
- Apache rat checks are OK
PS 1: Thanks for following my advice on using separat
+1
Checked on MacOS only:
- mvn clean package verify (JDK 8 and JDK 11)
- signatures
Thanks,
Sergey
On Sat, May 30, 2020 at 12:24 PM Sergey Kamov wrote:
>
> +1
>
> Checked:
> - files, signatures etc
> - mvn clear verify (mac OS and win10, both under java8)
> - project examples (mac OS under j
+1
Checked:
- files, signatures etc
- mvn clear verify (mac OS and win10, both under java8)
- project examples (mac OS under java8)
Note please that tag
https://github.com/apache/incubator-nlpcraft/tree/v0.6.0 is not correct
- pom.xml file scm tag name should be `v0.6.0` but not `0.6.0`
- ta
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:49 AM:
--
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:38 AM:
--
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:37 AM:
--
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov edited comment on NLPCRAFT-67 at 5/30/20, 8:36 AM:
--
[
https://issues.apache.org/jira/browse/NLPCRAFT-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17120153#comment-17120153
]
Sergey Kamov commented on NLPCRAFT-67:
--
Hi, I guess we need
1. Move sources under s
Yup, completely agree!
--
With regards,
Cos
On 2020-05-30 03:04, Furkan KAMACI wrote:
Hi,
Let me explain what to do for this kind of situations:
Lazy consensus is the most "proper" way for it and no need for a non-lazy
consensus voting. Lazy consensus is simply an announcement of 'silence
g
