Re: Should we relax precheck a little bit?

On Mon, Mar 9, 2020 at 12:52 PM Justin Mclean wrote: > > Hi, > > > I basically agree with most of the things you say here, but in an Apache > > project, you cannot set rules unilaterally. No one person has that > > authority over the project. We all all equals. Decisions can only be made >

Build failed in Jenkins: NuttX-Nightly-Build #58

See Changes: -- [...truncated 504.43 KB...] Copy files Select CONFIG_HOST_LINUX=y Refreshing... Building NuttX...

Re: Should we relax precheck a little bit?

Hi, > I basically agree with most of the things you say here, but in an Apache > project, you cannot set rules unilaterally. No one person has that authority > over the project. We all all equals. Decisions can only be made with > concurrence from other team members and we can only get

Re: NuttX Companion introductory docs

Thanks Brennan. That worked. I put a link to the NuttX Companion on the Getting Started page and also on the main Documentation page at the bottom. cheers adam

Re: NuttX Companion introductory docs

Nathan, I'm sorry for being abrupt with that "no." :) I just think for now the best approach would be to link to the docs, and if people want to collaborate or fill in missing pieces, they can open PRs or Issues. If that doesn't work, we can look at other ways to go. cheers adam On Sun, Mar 8,

Re: NuttX Companion introductory docs

On Sun, Mar 8, 2020, 3:03 PM Adam Feuer wrote: > My suggestion would be to simply put a link from the wiki docs to this > book. I can't do that because I tried to create a Apache Confluence account > that had edit rights a few weeks ago, and failed. I tried to get tech > support from Apache but

Re: NuttX Companion introductory docs

On Sun, Mar 8, 2020 at 2:35 PM Nathan Hartman wrote: > Cool! Would it be possible to convert these to Confluence and make them > available directly on the official Apache NuttX site? No. You're welcome to do that if you want. But I think there's value in having this set of docs in source

Re: squashing commits or not

If we go back to my original email on this subject a couple of months ago, I suggested to begin with a tl;dr; section and then follow it with the detailed text. Now that we have the detailed text, it's a simple matter to summarize it and put the summary at the top. Only slightly related...

Re: squashing commits or not

On Fri, Mar 6, 2020 at 10:20 AM Abdelatif Guettouche < abdelatif.guettou...@gmail.com> wrote: > I think you made it clear that you prefer a TL;DR; document. Maybe we > can have both. If we go back to my original email on this subject a couple of months ago, I suggested to begin with a tl;dr;

Re: NuttX Companion introductory docs

On Sun, Mar 8, 2020 at 4:08 PM Adam Feuer wrote: > Hi, > > Over the past 6 weeks I decided to keep all my notes about learning NuttX > in a set of Sphinx ReStructured Text docs. I thought they might be useful > to others. > > It's not complete by any means, and they could use improvement

Re: Should we relax precheck a little bit?

Pre- or post- processor I meant, depending on what would work best. -adam On Sun, Mar 8, 2020 at 2:29 PM Adam Feuer wrote: > Thanks Greg. I haven't tried indent, I will try it with the config you > suggest, if it can get close I'll try a pre-processor script with it too. > > -adam > > On Sun,

Re: Should we relax precheck a little bit?

Thanks Greg. I haven't tried indent, I will try it with the config you suggest, if it can get close I'll try a pre-processor script with it too. -adam On Sun, Mar 8, 2020 at 2:21 PM Gregory Nutt wrote: > The best pretty printer for NuttX that I am aware of is still > tools/indent.sh. It

Re: Re: Should we relax precheck a little bit?

Thanks Peter! I will try out your config. If it can get close, I will see if I can create a post-processor like David said. cheers adam On Sun, Mar 8, 2020 at 2:09 PM Peter Van Der Perk wrote: > Hi Adam, > > I've been trying to make a clang-format for NuttX however I did run in > some nasty

Re: Should we relax precheck a little bit?

The best pretty printer for NuttX that I am aware of is still tools/indent.sh.  It consistently screws up a few things (as listed in tools/README.txt).  But the screw-ups are relatively easy and probably could be postprocesses.  The astyle and uncrustify stuff in tools/ is pretty must useles.

RE: Re: Should we relax precheck a little bit?

Hi Adam, I've been trying to make a clang-format for NuttX however I did run in some nasty bugs with clang-format. Mostly the inconsistent spacing caused by preprocessor directives (#ifdef) etc. I've filed a bug on the LLVM bugtracker (https://bugs.llvm.org/show_bug.cgi?id=44843) unfortunely I

NuttX Companion introductory docs

Hi, Over the past 6 weeks I decided to keep all my notes about learning NuttX in a set of Sphinx ReStructured Text docs. I thought they might be useful to others. It's not complete by any means, and they could use improvement especially in showing the use of other boards and thread-aware

Re: FW: Should we relax precheck a little bit?

Got it. Thanks. On Sun, Mar 8, 2020 at 11:10 AM David Sidrane wrote: > > When you said you got 95% of the way there, do you have a .clang-format > file that I could use as a starting point? > > No. I did not get there. I was just referring to to the last % as a script. > > -Original

FW: Should we relax precheck a little bit?

> When you said you got 95% of the way there, do you have a .clang-format file that I could use as a starting point? No. I did not get there. I was just referring to to the last % as a script. -Original Message- From: Adam Feuer [mailto:a...@starcat.io] Sent: Sunday, March 08, 2020 9:11

Re: Should we relax precheck a little bit?

Thanks David. I'll try your approach. If there are some things that don't quite work with Clang-Format (I already found a few) I'll see about adding a fixup script pass at the end, or contributing some rules back to Clang. I'll try your idea about combining all the files under sched into a set.

Re: Should we relax precheck a little bit?

Hi, Xiang, I basically agree with most of the things you say here, but in an Apache project, you cannot set rules unilaterally.  No one person has that authority over the project.  We all all equals.  Decisions can only be made with concurrence from other team members and we can only get

Re: NuttX github action pull request check build CI enabled

I maintain only the Bitbucket tool repository. Greg, can we migrate the bitucket tool to https://github.com/nuttx? No, I am going to keep my repositories on Bitbucket.

Re: Should we relax precheck a little bit?

Hi, > But how we measure the release become better and better? Very simply you succeeded if you attract more users and committers. Being welcoming to new committers and having a simple process which that are able to take part helps that. I think you are looking though this from a technical

RE: Should we relax precheck a little bit?

Hi Adam, Have a look at https://github.com/mikr/whatstyle I got furthest with clang-format and it. It may be we get a 95% of the way there with it and we can add a backend secondary scripts. I was unable to convince Greg to create a master template so my approach was to combine all the files

Re: Should we relax precheck a little bit?

Xiang, Ok. see your point. It is valid and true the new changes do not add to the problem. I just do not agree with the way of contributing. I look at it as if I touch a file, I take ownership and pride in making it better. We would not be being having this discussion if we had a tool that

Re: Should we relax precheck a little bit?

On Sun, Mar 8, 2020 at 4:52 PM Justin Mclean wrote: > > Hi, > > > Yes, this is the key point why I am asking this question: we need > > stable the mainline and make the first apache release. > > Apache doesn’t actually care if your release works or not [*], it not an ASF > requirement that a

Re: NuttX github action pull request check build CI enabled

On Sun, Mar 8, 2020 at 5:51 AM Gregory Nutt wrote: > > I maintain only the Bitbucket tool repository. > Greg, can we migrate the bitucket tool to https://github.com/nuttx? The benefit is that: 1.The end user can get all stuff from a single website 2.All contributor can use the same workflow for

Re: Should we relax precheck a little bit?

Hi, > Yes, this is the key point why I am asking this question: we need > stable the mainline and make the first apache release. Apache doesn’t actually care if your release works or not [*], it not an ASF requirement that a build must pass all tests. What matters is that the next build is

Re: SPI controllers with 32bit transfer mode

Yes, it's better to open PR in github, then all people come from community can give the feedback interactively. it is especially important for the change like this one which may impact many user. On Sun, Mar 8, 2020 at 11:02 AM Gregory Nutt wrote: > > Hi, Petro, > > > I'm currently working on