[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362412237 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -0,0 +1,196 @@ +/***

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362412188 ## File path: arch/arm/src/stm32h7/stm32_fmc.c ## @@ -0,0 +1,196 @@ +/***

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362418718 ## File path: arch/arm/src/stm32/stm32_fmc.c ## @@ -1,7 +1,7 @@ /**

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362419439 ## File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h ## @@ -0,0 +1,390 @@ +/**

[GitHub] [incubator-nuttx] yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
yukihiratype2 commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362421158 ## File path: arch/arm/src/stm32h7/hardware/stm32_fmc.h ## @@ -0,0 +1,390 @@ +/***

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
raiden00pl commented on a change in pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22#discussion_r362422489 ## File path: arch/arm/include/stm32h7/chip.h ## @@ -167,9 +167,9 @@ #endif #if defined(CONFIG_STM32F7_HA

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #23: Minor fix

2020-01-02 Thread GitBox
xiaoxiang781216 opened a new pull request #23: Minor fix URL: https://github.com/apache/incubator-nuttx/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #4: Application.mk remove _main suffix from REGLIST

2020-01-02 Thread GitBox
xiaoxiang781216 opened a new pull request #4: Application.mk remove _main suffix from REGLIST URL: https://github.com/apache/incubator-nuttx-apps/pull/4 since the file generated by REGISTER macro don't have such suffix Change-Id: I6814f5bd257563f897c63d9698f8892d9649dcef Signed-of

[GitHub] [incubator-nuttx] acassis merged pull request #22: Add FMC SDRAM for STM32H7x3 chip

2020-01-02 Thread GitBox
acassis merged pull request #22: Add FMC SDRAM for STM32H7x3 chip URL: https://github.com/apache/incubator-nuttx/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-nuttx] patacongo merged pull request #23: Minor fix

2020-01-02 Thread GitBox
patacongo merged pull request #23: Minor fix URL: https://github.com/apache/incubator-nuttx/pull/23 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request #5: Unify the void cast usage

2020-01-02 Thread GitBox
xiaoxiang781216 opened a new pull request #5: Unify the void cast usage URL: https://github.com/apache/incubator-nuttx-apps/pull/5 1.Remove void cast for function because many place ignore the returned value witout cast 2.Replace void cast for variable with UNUSED macro Change-Id:

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #24: Fix wait loop and void cast

2020-01-02 Thread GitBox
xiaoxiang781216 opened a new pull request #24: Fix wait loop and void cast URL: https://github.com/apache/incubator-nuttx/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #5: Unify the void cast usage

2020-01-02 Thread GitBox
patacongo merged pull request #5: Unify the void cast usage URL: https://github.com/apache/incubator-nuttx-apps/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-nuttx-apps] patacongo merged pull request #4: Application.mk remove _main suffix from REGLIST

2020-01-02 Thread GitBox
patacongo merged pull request #4: Application.mk remove _main suffix from REGLIST URL: https://github.com/apache/incubator-nuttx-apps/pull/4 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx] patacongo merged pull request #24: Fix wait loop and void cast

2020-01-02 Thread GitBox
patacongo merged pull request #24: Fix wait loop and void cast URL: https://github.com/apache/incubator-nuttx/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-nuttx] macman88 opened a new pull request #25: Same54

2020-01-02 Thread GitBox
macman88 opened a new pull request #25: Same54 URL: https://github.com/apache/incubator-nuttx/pull/25 Adds basic support for Microchip SAM E54 Xplained Pro board. Adds an Ethernet driver for the SAME5x family (based on the SAMA5 GMAC driver).

[GitHub] [incubator-nuttx] patacongo commented on issue #24: Fix wait loop and void cast

2020-01-02 Thread GitBox
patacongo commented on issue #24: Fix wait loop and void cast URL: https://github.com/apache/incubator-nuttx/pull/24#issuecomment-570288836 Removing the (void) cast actually violates the coding standard. Look at: http://nuttx.org/Documentation/NuttXCCodingStandard.html#retvalues

[GitHub] [incubator-nuttx] patacongo merged pull request #25: SAME5x Ethernet Support

2020-01-02 Thread GitBox
patacongo merged pull request #25: SAME5x Ethernet Support URL: https://github.com/apache/incubator-nuttx/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-nuttx] wingunder commented on issue #14: Fixed includes in arch/arm/src/stm32l4/hardware/.

2020-01-02 Thread GitBox
wingunder commented on issue #14: Fixed includes in arch/arm/src/stm32l4/hardware/. URL: https://github.com/apache/incubator-nuttx/pull/14#issuecomment-570303541 Hi @patacongo & @acassis, Thank you for you feedback. I accept your reasoning. Regards -

[GitHub] [incubator-nuttx] patacongo opened a new pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix some warnings found in build te…

2020-01-02 Thread GitBox
patacongo opened a new pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix some warnings found in build te… URL: https://github.com/apache/incubator-nuttx/pull/26 arch/arm/src/imxrt/imxrt_enet.c: Fix two warnings found in build testing at lines 1657 and 1705: "warning: unused variab

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix compilation error

2020-01-02 Thread GitBox
raiden00pl opened a new pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix compilation error URL: https://github.com/apache/incubator-nuttx/pull/27 This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx] acassis merged pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix some warnings found in build te…

2020-01-02 Thread GitBox
acassis merged pull request #26: arch/arm/src/imxrt/imxrt_enet.c: Fix some warnings found in build te… URL: https://github.com/apache/incubator-nuttx/pull/26 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] patacongo opened a new pull request #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors.

2020-01-02 Thread GitBox
patacongo opened a new pull request #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors. URL: https://github.com/apache/incubator-nuttx/pull/28 This is an automated message from the Apache Git S

[GitHub] [incubator-nuttx] patacongo merged pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix compilation error

2020-01-02 Thread GitBox
patacongo merged pull request #27: arch/arm/src/stm32/stm32_fmc.c: fix compilation error URL: https://github.com/apache/incubator-nuttx/pull/27 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx] patacongo commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors.

2020-01-02 Thread GitBox
patacongo commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors. URL: https://github.com/apache/incubator-nuttx/pull/28#issuecomment-570322631 Duplicate of pr27 This is an automa

[GitHub] [incubator-nuttx] patacongo closed pull request #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors.

2020-01-02 Thread GitBox
patacongo closed pull request #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors. URL: https://github.com/apache/incubator-nuttx/pull/28 This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx] acassis commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors.

2020-01-02 Thread GitBox
acassis commented on issue #28: arch/arm/src/stm32/stm32_fmc.c: Missing semicolons cause compilation errors. URL: https://github.com/apache/incubator-nuttx/pull/28#issuecomment-570322897 Ok This is an automated message from

[GitHub] [incubator-nuttx] macman88 opened a new pull request #29: LPC17xx serial updates

2020-01-02 Thread GitBox
macman88 opened a new pull request #29: LPC17xx serial updates URL: https://github.com/apache/incubator-nuttx/pull/29 For LPC17xx/LPC40xx parts: - Adds hardware RS-485 support on UART1 - Avoids compiling up_earlyserialinit when USE_EARLYSERIALINIT is not defined - Incorporates the U

[GitHub] [incubator-nuttx] patacongo merged pull request #29: LPC17xx serial updates

2020-01-02 Thread GitBox
patacongo merged pull request #29: LPC17xx serial updates URL: https://github.com/apache/incubator-nuttx/pull/29 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
xiaoxiang781216 opened a new pull request #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30 Change-Id: Icfb7af6f1e31397dcadf3e652590cd2a55dc96a7 Signed-off-by: Xiang Xiao -

[GitHub] [incubator-nuttx] patacongo commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570437294 I think your fork is corrupted. It says there are 13 commits and 1,647 files changed. I think you need a new fork.

[GitHub] [incubator-nuttx] patacongo commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570437654 Or perhaps just rebase your fork from upstream? This is an au

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
xiaoxiang781216 commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438325 Done, do you see any change? This is an automated messa

[GitHub] [incubator-nuttx] patacongo commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438609 Yes, now it says one commit, two files changed. Thanks! This

[GitHub] [incubator-nuttx] patacongo commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570438960 But when I changed the base branch, it went back to 13 commits and 1,647 files. let me recreate the branch.

[GitHub] [incubator-nuttx] patacongo commented on issue #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo commented on issue #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30#issuecomment-570439283 Yes, sorry. The problem was my branch. This is an automated

[GitHub] [incubator-nuttx] patacongo merged pull request #30: fix modem/altair semaphore related compiler warning

2020-01-02 Thread GitBox
patacongo merged pull request #30: fix modem/altair semaphore related compiler warning URL: https://github.com/apache/incubator-nuttx/pull/30 This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [incubator-nuttx] patacongo opened a new pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor…

2020-01-02 Thread GitBox
patacongo opened a new pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor… URL: https://github.com/apache/incubator-nuttx/pull/31 Documentation/NuttXCCodingStandard.html: Remove requirement to decorate ignored returned values with (void).

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #32: Fix stm32l4_otgfshost.c: error: 'ret' undeclared

2020-01-03 Thread GitBox
xiaoxiang781216 opened a new pull request #32: Fix stm32l4_otgfshost.c: error: 'ret' undeclared URL: https://github.com/apache/incubator-nuttx/pull/32 result by commit 6a3c2aded683e8284e793eb3ee8793d2960ae000 Change-Id: I68ba79417d8da102da8d91c74496961aef242dd9 Signed-off-by: Xian

[GitHub] [incubator-nuttx] acassis merged pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor…

2020-01-03 Thread GitBox
acassis merged pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor… URL: https://github.com/apache/incubator-nuttx/pull/31 This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #33: drivers/sensors/lsm6dsl.c: fix various compiler warnings

2020-01-03 Thread GitBox
raiden00pl opened a new pull request #33: drivers/sensors/lsm6dsl.c: fix various compiler warnings URL: https://github.com/apache/incubator-nuttx/pull/33 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-nuttx] acassis merged pull request #32: Fix stm32l4_otgfshost.c: error: 'ret' undeclared

2020-01-03 Thread GitBox
acassis merged pull request #32: Fix stm32l4_otgfshost.c: error: 'ret' undeclared URL: https://github.com/apache/incubator-nuttx/pull/32 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-nuttx] patacongo merged pull request #33: drivers/sensors/lsm6dsl.c: fix various compiler warnings

2020-01-03 Thread GitBox
patacongo merged pull request #33: drivers/sensors/lsm6dsl.c: fix various compiler warnings URL: https://github.com/apache/incubator-nuttx/pull/33 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-nuttx] patacongo opened a new pull request #34: Todo

2020-01-03 Thread GitBox
patacongo opened a new pull request #34: Todo URL: https://github.com/apache/incubator-nuttx/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] acassis merged pull request #34: Todo

2020-01-03 Thread GitBox
acassis merged pull request #34: Todo URL: https://github.com/apache/incubator-nuttx/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor…

2020-01-03 Thread GitBox
davids5 commented on a change in pull request #31: Documentation/NuttXCCodingStandard.html: Remove requirement to decor… URL: https://github.com/apache/incubator-nuttx/pull/31#discussion_r362895441 ## File path: Documentation/NuttXCCodingStandard.html ## @@ -2182,9 +2182,

[GitHub] [incubator-nuttx] liuguo09 opened a new pull request #35: tools/nxstyle.c: Add -r option to check specified range lines

2020-01-04 Thread GitBox
liuguo09 opened a new pull request #35: tools/nxstyle.c: Add -r option to check specified range lines URL: https://github.com/apache/incubator-nuttx/pull/35 Usage: ./nxstyle -r start,count filename nxstyle with -r option used to parse the range lines rather than the whole file.

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #36: sx127x: fix some coding standard problems

2020-01-04 Thread GitBox
raiden00pl opened a new pull request #36: sx127x: fix some coding standard problems URL: https://github.com/apache/incubator-nuttx/pull/36 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-nuttx] raiden00pl opened a new pull request #37: Improvements for NRF52

2020-01-04 Thread GitBox
raiden00pl opened a new pull request #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-nuttx] acassis merged pull request #36: sx127x: fix some coding standard problems

2020-01-04 Thread GitBox
acassis merged pull request #36: sx127x: fix some coding standard problems URL: https://github.com/apache/incubator-nuttx/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #37: Improvements for NRF52

2020-01-04 Thread GitBox
acassis commented on a change in pull request #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#discussion_r363031912 ## File path: arch/arm/src/nrf52/nrf52_lowputc.c ## @@ -216,7 +216,7 @@ void nrf52_usart_configure(uintptr_t base, const st

[GitHub] [incubator-nuttx] raiden00pl commented on a change in pull request #37: Improvements for NRF52

2020-01-04 Thread GitBox
raiden00pl commented on a change in pull request #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#discussion_r363032825 ## File path: arch/arm/src/nrf52/nrf52_lowputc.c ## @@ -216,7 +216,7 @@ void nrf52_usart_configure(uintptr_t base, const

[GitHub] [incubator-nuttx] acassis merged pull request #37: Improvements for NRF52

2020-01-04 Thread GitBox
acassis merged pull request #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
acassis commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570783029 Thank you Mateusz, please verify if everything is fine. Every nice improvements! I think now we can run NuttX on PineTime Watch and on other Watches/Bands po

[GitHub] [incubator-nuttx] patacongo merged pull request #35: tools/nxstyle.c: Add -r option to check specified range lines

2020-01-04 Thread GitBox
patacongo merged pull request #35: tools/nxstyle.c: Add -r option to check specified range lines URL: https://github.com/apache/incubator-nuttx/pull/35 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-nuttx] raiden00pl commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
raiden00pl commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570787762 I think we still need support for SPI and GPIO interrupts to do something useful. I'll add them next week. ---

[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
patacongo commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570789186 @acassis FAR is not normally used in ARM code. It is only required in the common code where it needs to have a value for some architectures. It is fine i

[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
acassis commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570790833 @patacongo You are right! I saw a FAR in a function that he submitted and assumed it should be presented for all functions. My fault! ---

[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
patacongo commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570790945 @acassis Well, it should be used consistently in ARM code. Either always user FAR or never use it in an ARM file.

[GitHub] [incubator-nuttx] raiden00pl commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
raiden00pl commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570794215 At the moment in arch/nrf52 in some places there is FAR in some not. So for now it is far from consistent. But I think it is also true for other ARM chips.

[GitHub] [incubator-nuttx] acassis commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
acassis commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570798176 Well, it appears at least 15182 inside arch/arm: alan@dev:~/incubator-nuttx/arch/arm$ grep -r "FAR " | wc -l 15182 -

[GitHub] [incubator-nuttx] patacongo commented on issue #37: Improvements for NRF52

2020-01-04 Thread GitBox
patacongo commented on issue #37: Improvements for NRF52 URL: https://github.com/apache/incubator-nuttx/pull/37#issuecomment-570799199 Don't be tempted to change that with a simple substitution. That would mess up the alignment. It would require lots of manual effort or a very intelligent

[GitHub] [incubator-nuttx] patacongo opened a new pull request #38: sched_mergepending.c: Correct some errors in comments.

2020-01-04 Thread GitBox
patacongo opened a new pull request #38: sched_mergepending.c: Correct some errors in comments. URL: https://github.com/apache/incubator-nuttx/pull/38 Fixes miscalleanous typos and errors in C comments. This is an automated

[GitHub] [incubator-nuttx] acassis merged pull request #38: sched_mergepending.c: Correct some errors in comments.

2020-01-04 Thread GitBox
acassis merged pull request #38: sched_mergepending.c: Correct some errors in comments. URL: https://github.com/apache/incubator-nuttx/pull/38 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-nuttx-website] btashton commented on issue #6: publish the website

2020-01-04 Thread GitBox
btashton commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570828725 @huahang Sorry it took me so long to get back. So I think this is OK for now, effectively running the "build" on your machine and then committing to th

[GitHub] [incubator-nuttx-website] btashton commented on issue #6: publish the website

2020-01-04 Thread GitBox
btashton commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570828975 Also there is a nice little script on this apache project for generating the site and commiting it to the right branch. Maybe we can pull that in, just

[GitHub] [incubator-nuttx-website] btashton edited a comment on issue #6: publish the website

2020-01-04 Thread GitBox
btashton edited a comment on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570828975 Also there is a nice little script on this apache project for generating the site and commiting it to the right branch. Maybe we can pull that in

[GitHub] [incubator-nuttx-website] justinmclean commented on issue #6: publish the website

2020-01-04 Thread GitBox
justinmclean commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570832763 Hi, > What I would say is we really should make this an orphan branch which is not connected to master since is has no history related to master.

[GitHub] [incubator-nuttx-website] btashton commented on issue #6: publish the website

2020-01-04 Thread GitBox
btashton commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570833916 @justinmclean I don't think there is any real need to do that. Keeping the branch in the same repo makes things cleaner for linking as is done with that

[GitHub] [incubator-nuttx-website] btashton opened a new pull request #7: Add publisher script

2020-01-04 Thread GitBox
btashton opened a new pull request #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7 Running this script will generate the static website content and make a commit in the asf-site branch that is linking to the commit that it generated from. This also t

[GitHub] [incubator-nuttx-website] btashton commented on issue #6: publish the website

2020-01-04 Thread GitBox
btashton commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570843135 @huahang What do you think about using this to generate the PR against the asf-site branch for a release? I also have an example of what I am talking a

[GitHub] [incubator-nuttx-website] btashton edited a comment on issue #6: publish the website

2020-01-04 Thread GitBox
btashton edited a comment on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570843135 @huahang What do you think about using this script in #7 to generate the PR against the asf-site branch for a release? I also have an example of

[GitHub] [incubator-nuttx-website] btashton opened a new pull request #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
btashton opened a new pull request #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8 Signed-off-by: Brennan Ashton This is an automated message from the Apache

[GitHub] [incubator-nuttx-website] btashton opened a new pull request #9: Update community page issue and repo references

2020-01-04 Thread GitBox
btashton opened a new pull request #9: Update community page issue and repo references URL: https://github.com/apache/incubator-nuttx-website/pull/9 Update the community page to include both OS and Apps repositories Remove references to JIRA until we have settled on a issue tracking syst

[GitHub] [incubator-nuttx-website] justinmclean commented on issue #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
justinmclean commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570874045 Hi, The information n this page is not correct. Currently the roster [1] shows. Mentors are: Flavio Paiv

[GitHub] [incubator-nuttx-website] justinmclean commented on issue #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
justinmclean commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570874287 Hi, Note that all Mentors are PPMC members (and IPMC members) and all PPMC members are committers as well.

[GitHub] [incubator-nuttx-website] btashton commented on issue #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
btashton commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570878451 That is what I looked at to update this. Are you asking to break it out to also include PPMC or to enumerate all, so for you

[GitHub] [incubator-nuttx-website] justinmclean commented on issue #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
justinmclean commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570879653 HI, > That is what I looked at to update this. Are you asking to break it out to also include PPMC or to enumerate al

[GitHub] [incubator-nuttx-website] btashton commented on issue #8: Update contributors information and alphabetize

2020-01-04 Thread GitBox
btashton commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570881097 Ok, fully enumerated it is. Updated the PR. This is an auto

[GitHub] [incubator-nuttx] yukihiratype2 opened a new pull request #39: Implement QSPI for STM32H7

2020-01-04 Thread GitBox
yukihiratype2 opened a new pull request #39: Implement QSPI for STM32H7 URL: https://github.com/apache/incubator-nuttx/pull/39 The code is copy and modified from STM32F7. I tested on my board with W25Q128 flash chip. This i

[GitHub] [incubator-nuttx] yukihiratype2 commented on issue #39: Implement QSPI for STM32H7

2020-01-04 Thread GitBox
yukihiratype2 commented on issue #39: Implement QSPI for STM32H7 URL: https://github.com/apache/incubator-nuttx/pull/39#issuecomment-570885964 Note: CONFIG_STM32[H7| F7]_QSPI_FLASH_SIZE define in both H7 and F7 will cause a problem, because the range (1-2147483648) is too big. This prob

[GitHub] [incubator-nuttx-website] huahang commented on issue #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
huahang commented on issue #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#issuecomment-570901800 LGTM This is an automated message from the Apache Git Service

[GitHub] [incubator-nuttx-website] huahang commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang commented on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570901797 LGTM This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [incubator-nuttx-website] huahang commented on issue #6: publish the website

2020-01-05 Thread GitBox
huahang commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570903011 @btashton The `publish.sh` script looks cool! :-) I think the orphan branch makes sense. But it seems that Github won't allow a PR from an orphan branch

[GitHub] [incubator-nuttx-website] huahang closed pull request #6: publish the website

2020-01-05 Thread GitBox
huahang closed pull request #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [incubator-nuttx-website] huahang commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang commented on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed is tha

[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed

[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed

[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed

[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed

[GitHub] [incubator-nuttx-website] huahang edited a comment on issue #7: Add publisher script

2020-01-05 Thread GitBox
huahang edited a comment on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570908074 @btashton Hi Brennan, I tried the `publish.sh` script. I think the link to the original version is very nice~ :-) One thing I've noticed

[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#discussion_r363093639 ## File path: _data/contributors.yml ## @@ -18,82 +18,88 @@ # Please keep the lis

[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize

2020-01-05 Thread GitBox
xiaoxiang781216 commented on a change in pull request #8: Update contributors information and alphabetize URL: https://github.com/apache/incubator-nuttx-website/pull/8#discussion_r363093568 ## File path: _data/contributors.yml ## @@ -18,82 +18,88 @@ # Please keep the lis

[GitHub] [incubator-nuttx] patacongo merged pull request #39: Implement QSPI for STM32H7

2020-01-05 Thread GitBox
patacongo merged pull request #39: Implement QSPI for STM32H7 URL: https://github.com/apache/incubator-nuttx/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #6: publish the website

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #6: publish the website URL: https://github.com/apache/incubator-nuttx-website/pull/6#issuecomment-570913628 Let's me delete and recreate asf-site as an empty branch? This is an automated me

[GitHub] [incubator-nuttx-website] xiaoxiang781216 commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
xiaoxiang781216 commented on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570918462 > I have an example of a orphaned asf-site branch as well that I would recommend we use as a starting branch. Someone would need to force it over

[GitHub] [incubator-nuttx-website] btashton commented on issue #7: Add publisher script

2020-01-05 Thread GitBox
btashton commented on issue #7: Add publisher script URL: https://github.com/apache/incubator-nuttx-website/pull/7#issuecomment-570921968 I just tweaked it to include the asf.yaml @huahang can you use the publish script to create a PR against it now? (Probably need to hard reset your lo

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
xiaoxiang781216 opened a new pull request #40: Format all shell scripts in tools folder URL: https://github.com/apache/incubator-nuttx/pull/40 Change-Id: Ieef2eb93d56c03972b4dc63a1c55aabf1fb0d169 Signed-off-by: Xiang Xiao

[GitHub] [incubator-nuttx] patacongo merged pull request #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
patacongo merged pull request #40: Format all shell scripts in tools folder URL: https://github.com/apache/incubator-nuttx/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [incubator-nuttx] patacongo commented on issue #40: Format all shell scripts in tools folder

2020-01-05 Thread GitBox
patacongo commented on issue #40: Format all shell scripts in tools folder URL: https://github.com/apache/incubator-nuttx/pull/40#issuecomment-570928984 If there is a coding standard for shell scripts, we should document it. Or was this done using a tool? If a tools was used, we should d

<    1   2   3   4   5   6   >