Re: svn commit: r742013 - in /ofbiz/trunk/framework: base/config/ base/src/org/ofbiz/base/util/template/ entity/src/org/ofbiz/entity/ webapp/src/org/ofbiz/webapp/control/ widget/src/org/ofbiz/widget/s

2009-02-09 Thread Jacques Le Roux
I thought that I should have takeen into account case unsensitive (but anyway, as I said maybe there is a better/more general solution) Jacques From: David E Jones david.jo...@hotwaxmedia.com I'm looking into this now. -David On Feb 8, 2009, at 9:21 AM, Jacques Le Roux wrote: This

[jira] Created: (OFBIZ-2174) Request with missing security attributes not getting executed

2009-02-09 Thread Pranay Pandey (JIRA)
Request with missing security attributes not getting executed - Key: OFBIZ-2174 URL: https://issues.apache.org/jira/browse/OFBIZ-2174 Project: OFBiz Issue Type: Bug

Re: svn commit: r742234 - in /ofbiz/trunk: applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ specialpurpose/webpos/webapp/webpos/includes/

2009-02-09 Thread David E Jones
No problem. I hope everyone's in favor of these painful changes I'm working on. They'll definitely have side effects and break things as we restrict various things, for the sake of security. Whatever the case, I'll be around to help pick up the pieces and resolve issues that I miss in

[jira] Updated: (OFBIZ-2174) Request with missing security attributes not getting executed

2009-02-09 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pranay Pandey updated OFBIZ-2174: - Attachment: OFBIZ-2174.patch Here is the patch for the resolution of this issue. Request with

Re: svn commit: r742234 - in /ofbiz/trunk: applications/order/webapp/ordermgr/WEB-INF/actions/entry/catalog/ specialpurpose/webpos/webapp/webpos/includes/

2009-02-09 Thread Hans Bakker
Hi David, I highly appreciate the work you are doing in this area. If you would not be there, i do not know when it would be done.(if ever) thanks again, Hans On Mon, 2009-02-09 at 01:37 -0700, David E Jones wrote: No problem. I hope everyone's in favor of these painful changes I'm working

[jira] Assigned: (OFBIZ-2174) Request with missing security attributes not getting executed

2009-02-09 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-2174: -- Assignee: Ashish Vijaywargiya Request with missing security attributes not

[jira] Closed: (OFBIZ-2174) Request with missing security attributes not getting executed

2009-02-09 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-2174. -- Resolution: Fixed Thanks Pranay for your contribution. Your patch is in trunk rev

[jira] Commented: (OFBIZ-2170) Providing Functionality of ProductFeatureIactn Entity

2009-02-09 Thread Arpit Singh Pandya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671769#action_12671769 ] Arpit Singh Pandya commented on OFBIZ-2170: --- Thanks Jacques, I will definitely go

[jira] Commented: (OFBIZ-2170) Providing Functionality of ProductFeatureIactn Entity

2009-02-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671771#action_12671771 ] Jacques Le Roux commented on OFBIZ-2170: Thanks Arpit, Looking forward for your

[jira] Assigned: (OFBIZ-2146) Quote to order - manual adjustments amount not included in cart grand total

2009-02-09 Thread Bilgin Ibryam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam reassigned OFBIZ-2146: Assignee: Bilgin Ibryam Quote to order - manual adjustments amount not included in cart

Discussion: Mysql Db Performance

2009-02-09 Thread madppiper
Hey everyone, while taking a closer look at the fieldtypemysql.xml file i noticed that we are using predominantly varchars, which got me thinking. I know out of my own experience (and from several authors), that the use of dynamic datatypes results in increased query times. A well formatted

[jira] Commented: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Anurag Singh Senger (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671787#action_12671787 ] Anurag Singh Senger commented on OFBIZ-2171: Hello Scott, My current revision

Re: Discussion: Mysql Db Performance

2009-02-09 Thread David E Jones
The most important thing I know about performance is that until you know with proof from tests you're just guessing, and even with lots of experience acting on a guess can hurt as much as help. In fact, ask anyone with a lot of profiling experience and they'll know based on lots of wrong

[jira] Created: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread Erwan de FERRIERES (JIRA)
paginate-size-field and paginate-index-field on lists - Key: OFBIZ-2175 URL: https://issues.apache.org/jira/browse/OFBIZ-2175 Project: OFBiz Issue Type: Bug Components: ALL

[jira] Updated: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES updated OFBIZ-2175: -- Attachment: ModelForm.java.patch Made by Antoine Bourre , Louis Briolet, Alexandre

[jira] Issue Comment Edited: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Anurag Singh Senger (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671787#action_12671787 ] anuragsse edited comment on OFBIZ-2171 at 2/9/09 2:08 AM:

Re: Security Issues

2009-02-09 Thread David E Jones
With my latest commit (rev 742352) I've finished a first pass on a few things for this. My commit log for that is included below (and has some important notes). Now in place are: 1. canonicalization for all incoming parameters 2. encoding of output for all String fields in forms, and for

[jira] Commented: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671795#action_12671795 ] David E. Jones commented on OFBIZ-2175: --- Rejecting this initial patch. Even a few

Re: What is happening with OrderItemShipGroup.productStoreShipMethId?

2009-02-09 Thread David E Jones
We've had another complaint about this on the mailing list now... Here is the commit that Jacques is referring to:

[jira] Commented: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671798#action_12671798 ] Erwan de FERRIERES commented on OFBIZ-2175: --- The problem is when you want to

[jira] Commented: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671801#action_12671801 ] Jacopo Cappellato commented on OFBIZ-2175: -- paginate-size-field and

Re: What is happening with OrderItemShipGroup.productStoreShipMethId?

2009-02-09 Thread Jacopo Cappellato
I think this is related to something I suggested: modifying the primary key of the shipping estimates entity to enhance flexibility. Probably the code that is broken now should be updated to reflect that change. Just my 2 cents... I will try to look at this as soon as I have some free

[jira] Closed: (OFBIZ-2175) paginate-size-field and paginate-index-field on lists

2009-02-09 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-2175. - Resolution: Invalid My mistake.. A total misreading of the DTDs.. paginate-size-field

Re: What is happening with OrderItemShipGroup.productStoreShipMethId?

2009-02-09 Thread Ashish Vijaywargiya
Hello David, I am reviewing this now and will do the needful soon. -- Ashish On Mon, Feb 9, 2009 at 4:30 PM, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com wrote: I think this is related to something I suggested: modifying the primary key of the shipping estimates entity to enhance

Major Bug in create order in order application

2009-02-09 Thread rohit2006
Hi, I recently discovered there was a major bug in the create order in the 'Order' application. To reproduce the buy, please do as following: Login to the admin side and select 2 different party in the 'party' application in 2 different browser windows and proceed to create a order for, say

Re: Major Bug in create order in order application

2009-02-09 Thread Divesh Dutta
I tried this steps and found the same behavior.I think this is a bug.Please correct if we are wrong some where. Divesh Hi, I recently discovered there was a major bug in the create order in the 'Order' application. To reproduce the buy, please do as following: Login to the admin side and

[jira] Updated: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Anurag Singh Senger (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anurag Singh Senger updated OFBIZ-2171: --- Attachment: proper_success_message.patch Here is the patch that can resolve the

Re: Major Bug in create order in order application

2009-02-09 Thread Deepesh Kapoor
Guys , i followed the steps to trace the behavior. To be more precise i took these steps : 1. Used two different browser windows. 2. Used two different parties and simultaniously moved forward to create order. Result : Only one order gets created ( the first one ) and the second

Re: svn commit: r741948 - /ofbiz/trunk/applications/order/webapp/ordermgr/order/findOrders.ftl

2009-02-09 Thread Vikas Mayur
Just curious to know what should be the expected behavior when a user select Any Role Type along with any other specific Roles in Role Type select box ? Vikas On Feb 8, 2009, at 2:55 AM, Jacques Le Roux wrote: Thanks for the pointer Scott! Done in revision: 741964 I checked the only

Re: svn commit: r741948 - /ofbiz/trunk/applications/order/webapp/ordermgr/order/findOrders.ftl

2009-02-09 Thread Jacques Le Roux
I did not test this case but I suppose Any Role Type subsumes any other role type. So, as soon as you select it, selecting anything else has no meaning. Jacques From: Vikas Mayur vikas.ma...@hotwaxmedia.com Just curious to know what should be the expected behavior when a user select Any Role

Re: svn commit: r741948 - /ofbiz/trunk/applications/order/webapp/ordermgr/order/findOrders.ftl

2009-02-09 Thread Jacques Le Roux
Actually not, I tested and if you select another role with Any Role Type it seems to make a set intersection and not an union. But I did not find (yet) a role that allows to show the defaut demo order when selected alone (there are a bunch). It seems that by default nothing is selected and that

[jira] Created: (OFBIZ-2176) Fixed the bug regarding cancellation of order reported by Rohit on user ML.

2009-02-09 Thread Arun Patidar (JIRA)
Fixed the bug regarding cancellation of order reported by Rohit on user ML. --- Key: OFBIZ-2176 URL: https://issues.apache.org/jira/browse/OFBIZ-2176 Project: OFBiz

[jira] Updated: (OFBIZ-2176) Fixed the bug regarding cancellation of order reported by Rohit on user ML.

2009-02-09 Thread Arun Patidar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Patidar updated OFBIZ-2176: Attachment: shippingEvents.patch Fixed the bug regarding cancellation of order item reported by

Re: What is happening with OrderItemShipGroup.productStoreShipMethId?

2009-02-09 Thread Arun Patidar
Hello All, It was our mistake, we apologize for this. We Created a jira issue and also attached patch with proper solution. Please let me now if there is any more issue regarding this. Thanks and Regards --- Jyotsna Rathore Arun Patidar Ashish Vijaywargiya wrote: Hello David, I am

[jira] Assigned: (OFBIZ-2176) Fixed the bug regarding cancellation of order reported by Rohit on user ML.

2009-02-09 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato reassigned OFBIZ-2176: Assignee: Jacopo Cappellato Fixed the bug regarding cancellation of order

[jira] Closed: (OFBIZ-2176) Fixed the bug regarding cancellation of order reported by Rohit on user ML.

2009-02-09 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato closed OFBIZ-2176. Resolution: Fixed Thanks Arun, it is in rev. 742556 Fixed the bug regarding cancellation

entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread Hans Bakker
David? In webtools the entityreference still work but when i click on a specific entity on the left, or on 'view data' or 'artifact info' i get the error message: org.ofbiz.webapp.control.RequestHandlerException: No defitinition found for view with name [] -- http://www.antwebsystems.com :

Re: Major Bug in create order in order application

2009-02-09 Thread Anil Patel
Deepesh, Can you confirm that you used 1) Two different browsers like firefox and IE 2) Check URL if sessionId of two windows was same. In case if sessionid of both windows is same then consider this as normal behavior. This issues is resolved by some frameworks by introducing conversation

[jira] Commented: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671921#action_12671921 ] Adrian Crum commented on OFBIZ-2171: Anurag, The attached patch can not be committed

[jira] Commented: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12671931#action_12671931 ] Jacques Le Roux commented on OFBIZ-2171: No need to say that I totally agree with

[jira] Closed: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2171. -- Resolution: Invalid Assignee: Jacques Le Roux Thanks for your effort Anurag, I commited

applications/accounting/webapp/accounting/chartofaccounts

2009-02-09 Thread Jacques Le Roux
The FTL templates in applications/accounting/webapp/accounting/chartofaccounts are unused (and not localised ;o). Are they intended to be used later or should we get rid of them ? Also applications/accounting/webapp/accounting/billingaccount and

Re: svn commit: r742770 [1/2] - in /ofbiz/trunk: applications/accounting/config/ applications/accounting/webapp/accounting/payment/ applications/accounting/widget/ applications/accounting/widget/ap/ a

2009-02-09 Thread Adrian Crum
Marco, Why are we removing all of the other translations? -Adrian mrisal...@apache.org wrote: Author: mrisaliti Date: Mon Feb 9 22:13:57 2009 New Revision: 742770 URL: http://svn.apache.org/viewvc?rev=742770view=rev Log: A lot of hardcoded labels cleaning and changes some wrong references

Re: Major Bug in create order in order application

2009-02-09 Thread David E Jones
Stepping back a little the simple fact is that the Order Manager Order Entry was built to only support one outstanding order at a time. It sounds like it is working correctly, you're just editing the same order in both tabs/windows. Notice that there is no way to see a list of orders

[jira] Commented: (OFBIZ-1700) To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz

2009-02-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672075#action_12672075 ] Jacques Le Roux commented on OFBIZ-1700: Bruno, It seems that your last comment

[jira] Commented: (OFBIZ-1700) To show Current Revision number of OFBiz on its home site that will facilate in testing and comparing things with a local copy of OFBiz

2009-02-09 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672078#action_12672078 ] Jacques Le Roux commented on OFBIZ-1700: Hi Bruno, Please forget my last comment :

ApacheCon Europe 2009: Early Bird Deadline Extended until 13th of February

2009-02-09 Thread David E Jones
A note from the Conference Committee: = Subject: ApacheCon Europe 2009: Early Bird Deadline Extended until 13th of February Here's some great news for everyone who's thinking of traveling to Amsterdam for this year's ApacheCon Europe. The Early Bird

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread Hans Bakker
it looks like the following string: /control/view/#47;webtools#47; is added to the begin of the url causing this problem. not only happens in webtools but at many places. On Mon, 2009-02-09 at 22:17 +0700, Hans Bakker wrote: David? In webtools the entityreference still work but when i

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread David E Jones
On Feb 9, 2009, at 7:34 PM, Hans Bakker wrote: it looks like the following string: /control/view/#47;webtools#47; is added to the begin of the url causing this problem. not only happens in webtools but at many places. Could you be more specific about these many places? I don't

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread Hans Bakker
Hi David, please read my original email: In webtools the entityreference still work but when i click on a specific entity on the left, or on 'view data' or 'artifact info' i get the error message: org.ofbiz.webapp.control.RequestHandlerException: No defitinition found for view with

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread David E Jones
Wait, so by many places do you mean many places on that same screen? I guess I'm having a hard time understanding this... -David On Feb 9, 2009, at 7:57 PM, Hans Bakker wrote: Hi David, please read my original email: In webtools the entityreference still work but when i click on a

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread Hans Bakker
We are trying to finish the myportal conversion and are a bit stuck now. besides that the links in the entity reference not works click on preferences in myportal in the log it says: Exception: java.lang.IllegalArgumentException Message: Could not resolve location to URL:

[jira] Commented: (OFBIZ-2176) Fixed the bug regarding cancellation of order reported by Rohit on user ML.

2009-02-09 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672144#action_12672144 ] Ashish Vijaywargiya commented on OFBIZ-2176: Thanks Jacopo. -- Ashish Fixed

Re: Order cancellation on ecommerce application fails.

2009-02-09 Thread Ashish Vijaywargiya
Thanks Rohit for reporting this issue. The fix for this issue has been committed in rev 742556. If you would like to see the details of cause please refer to JIRA issue no. OFBIZ-2176 -- Ashish On Mon, Feb 9, 2009 at 8:51 AM, rohit2006 rohitksur...@yahoo.com wrote: Hi, Cancelling a order

Re: Major Bug in create order in order application

2009-02-09 Thread Jacques Le Roux
From: David E Jones david.jo...@hotwaxmedia.com Notice that there is no way to see a list of orders being worked on or switch between them. What you are imagining should work, ie different orders in different windows, would only be the case (as Anil mentioned) if those different windows used

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread David E Jones
The problem with these links is they are using an odd way of making the URLs, ie like this: #assign encodeURL = response.encodeURL(controlPath + /view/ entityref_main# + packageName) a href=${encodeURL} target=entityFrame${packageName}/abr/ ...instead of this: a

Re: Major Bug in create order in order application

2009-02-09 Thread David E Jones
On Feb 9, 2009, at 10:38 PM, Jacques Le Roux wrote: From: David E Jones david.jo...@hotwaxmedia.com Notice that there is no way to see a list of orders being worked on or switch between them. What you are imagining should work, ie different orders in different windows, would only be the

Re: [jira] Closed: (OFBIZ-2171) success messages are not displaying properly.

2009-02-09 Thread Anurag S Sengar
Thanks Jacques! -- Thanks and Regards Anurag Singh Jacques Le Roux (JIRA) wrote: [ https://issues.apache.org/jira/browse/OFBIZ-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2171. -- Resolution:

Show error when click on Quick Ship Enter Order

2009-02-09 Thread Akash Jain
Hello All, After creating order when I click on Quick Ship Enter Order button for complete order than i get error message org.ofbiz.webapp.control.RequestHandlerException: Unknown request [ordervieworderId=WSCO10003]; this request does not exist or cannot be called directly But order is

Re: svn commit: r742866 - /ofbiz/trunk/framework/common/webcommon/portal/editPortalPage.ftl

2009-02-09 Thread Hans Bakker
thank you for your help David. On Tue, 2009-02-10 at 06:43 +, jone...@apache.org wrote: Author: jonesde Date: Tue Feb 10 06:43:05 2009 New Revision: 742866 URL: http://svn.apache.org/viewvc?rev=742866view=rev Log: Fixed issue with general html encoding in edit portal page template,

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread David E Jones
Thanks for the details. I don't think I would have found that by randomly clicking around... ;) The issue is fixed in rev 742866. The problem was a string was assembled in the FTL file and then used, triggering the html encoding. The fix is to not assemble the String at all since it

Re: svn commit: r742866 - /ofbiz/trunk/framework/common/webcommon/portal/editPortalPage.ftl

2009-02-09 Thread David E Jones
No problem. I just sent a reply to your email reporting this problem that talks about the fix and alternative fixes just in case I'm not available to respond in a timely manner should such issues arise in the future. -David On Feb 9, 2009, at 11:50 PM, Hans Bakker wrote: thank you

Re: entityreference show, but links do not work (requestHandlerException)

2009-02-09 Thread Hans Bakker
Thanks Divid, for the info, very usefull. On Mon, 2009-02-09 at 23:54 -0700, David E Jones wrote: Thanks for the details. I don't think I would have found that by randomly clicking around... ;) The issue is fixed in rev 742866. The problem was a string was assembled in the FTL file and