Re: Remove the 91% message from gradle when running tasks (ofbiz, ofbizDebug, etc) or altogether

Hi Jacque, I have raised the issue at https://issues.apache.org/jira/browse/OFBIZ-9285 and uploaded a patch. Regards, James Yong Jacques Le Roux wrote > That's quite a good idea James, > > Did you try it's possible? > > Thanks > > Jacques > > > Le 16/03/2017 à 04:53, james yong a écrit : >

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

Thanks for your detailed analysis. And yes this sentence cynical. I know exactly why I did so in each case, contrary as what you seem to think. Jacques Le 27/03/2017 à 23:05, Taher Alkhateeb a écrit : Well, if you think using UtilGenerics or removing unused variables or refactoring code to re

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

Le 25/03/2017 à 13:21, Michael Brohl a écrit : +1 The lack of code documentation is not a free ticket to just change the code behaviour without proper analysis. It's not because the swallowed exceptions where not documented that I decided to catch them. I rather proposed later to at least doc

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

Well, if you think using UtilGenerics or removing unused variables or refactoring code to remove unnecessary warnings is FUD, then I have no comment. On Mon, Mar 27, 2017 at 4:26 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > This if FUD > > Jacques > > > > Le 27/03/2017 à 13:40, Ta

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

This if FUD Jacques Le 27/03/2017 à 13:40, Taher Alkhateeb a écrit : All of them. On Mon, Mar 27, 2017 at 2:29 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Please specify which ones you see not fit Thanks Jacques Le 27/03/2017 à 12:14, Taher Alkhateeb a écrit : I believ

Re: Drop plugins/birt/webapp/birt/webcontent ?

Done at https://issues.apache.org/jira/browse/LEGAL-296 Jacques Le 27/03/2017 à 11:57, Jacques Le Roux a écrit : Thanks for the help Jacopo. I'll ask legal (create a Jira) and will report here Jacques Le 27/03/2017 à 09:54, Jacopo Cappellato a écrit : On Mon, Mar 27, 2017 at 8:48 AM, Jacqu

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

All of them. On Mon, Mar 27, 2017 at 2:29 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Please specify which ones you see not fit > > Thanks > > Jacques > > > > Le 27/03/2017 à 12:14, Taher Alkhateeb a écrit : > >> I believe the @SuppressWarnings tags are used incorrectly in this c

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

Please specify which ones you see not fit Thanks Jacques Le 27/03/2017 à 12:14, Taher Alkhateeb a écrit : I believe the @SuppressWarnings tags are used incorrectly in this commit and in some cases hide the root problem. On Mon, Mar 27, 2017 at 12:54 PM, wrote: Author: jleroux Date: Mon Ma

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Hi Everyone I'd like to suggest a call on Thursday this week (30th March). We have a lot potential times and I've included the details below CZ/FR/IT Kuwait India 09.00 10.00 12.30 10.00

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexible: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

I believe the @SuppressWarnings tags are used incorrectly in this commit and in some cases hide the root problem. On Mon, Mar 27, 2017 at 12:54 PM, wrote: > Author: jleroux > Date: Mon Mar 27 09:54:18 2017 > New Revision: 1788869 > > URL: http://svn.apache.org/viewvc?rev=1788869&view=rev > Log:

Re: Drop plugins/birt/webapp/birt/webcontent ?

Thanks for the help Jacopo. I'll ask legal (create a Jira) and will report here Jacques Le 27/03/2017 à 09:54, Jacopo Cappellato a écrit : On Mon, Mar 27, 2017 at 8:48 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: OK I was wrong, this is used as explained at https://cwiki.apache

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

On Sat, Mar 25, 2017 at 8:23 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > [...] > Now feel free to revert my commit if you still think it's a bad thing, but > sincerely I'm not convinced! If you do so I'll then at least add comments > to explain the situation... The analysis and

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

On Mon, Mar 27, 2017 at 10:24 AM, Michael Brohl wrote: > Hi Jacopo, > > I'm not for a general change to Review-Then-Commit but pleading for a more > sensible way to handle these things as a responsible committer. > > As a guideline: if in doubt, always provide a patch and describe what the > chan

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

Hi Jacopo, I'm not for a general change to Review-Then-Commit but pleading for a more sensible way to handle these things as a responsible committer. As a guideline: if in doubt, always provide a patch and describe what the change should do or fix and let others review. Of course not for tr

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

On Sat, Mar 25, 2017 at 1:21 PM, Michael Brohl wrote: > +1 > > The lack of code documentation is not a free ticket to just change the > code behaviour without proper analysis. > > The right process should be > > 1. discuss > > 2. provide a patch > > 3. let others review/comment > > 4. decide > >

Re: Drop plugins/birt/webapp/birt/webcontent ?

On Mon, Mar 27, 2017 at 8:48 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > OK I was wrong, this is used as explained at > https://cwiki.apache.org/confluence/display/OFBIZ/Using+BIRT+with+OFBiz > > Now the question is: is it sufficient to keep it? Because we have a kinda > license i

Re: Drop plugins/birt/webapp/birt/webcontent ?

Getting the insight of the Apache Legal officers is always smart when in doubt. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon, Mar 27, 2017 at 8:48 AM, Jacques Le Roux < jacques.l