[OFBIZ-10147] Buildbot script refactoring to put in a R17 branch build

2018-01-05 Thread Jacques Le Roux
Hi, I created OFBIZ-10147 for that, so bear with me if we encounter some quirks with Buildbot in the next days... Jacques

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Jacopo Cappellato
Thank you, both changes are implemented in rev. 1820297 Jacopo On Fri, Jan 5, 2018 at 11:18 AM, Michael Brohl wrote: > +1 > > I think we should also change the headline "Apache OFBiz 13.07 and > earlier" to "Earlier Releases" or similar, so that we do not have to >

Minilang to Groovy: login-required tag questions

2018-01-05 Thread Dennis Balkir
Hi Devs, at the moment I am doing some Minilang to Groovy conversions (CategoryServices to be precise) and I found a simple method (getAssociatedProductsList), which set the tag „login-required“ to false. I then checked the service-definition of this method (which it had), and there it also

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Ratnesh Upadhyay
+1 Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Fri, Jan 5, 2018 at 3:32 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Hi all, > > I think we should now remove the section titled "Special Notice Regarding > Branches 14.12 and 15.12" from the OFBiz

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Ashish Vijaywargiya
+1 Kind Regards Ashish Vijaywargiya HotWax Systems - est. 1997 On Fri, Jan 5, 2018 at 3:32 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > Hi all, > > I think we should now remove the section titled "Special Notice Regarding > Branches

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Deepak Dixit
+1 Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Fri, Jan 5, 2018 at 4:21 PM, Sharan Foga wrote: > +1 > > Thanks > Sharan > > > On 05/01/18 11:43, Taher Alkhateeb wrote: > >> +1 >> >> On Jan 5, 2018 1:34 PM, "Jacques Le Roux"

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Sharan Foga
+1 Thanks Sharan On 05/01/18 11:43, Taher Alkhateeb wrote: +1 On Jan 5, 2018 1:34 PM, "Jacques Le Roux" wrote: +1 for both Jacques Le 05/01/2018 à 11:18, Michael Brohl a écrit : +1 I think we should also change the headline "Apache OFBiz 13.07 and

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Taher Alkhateeb
+1 On Jan 5, 2018 1:34 PM, "Jacques Le Roux" wrote: +1 for both Jacques Le 05/01/2018 à 11:18, Michael Brohl a écrit : > +1 > > I think we should also change the headline "Apache OFBiz 13.07 and > earlier" to "Earlier Releases" or similar, so that we do not

Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 10:03, Jacopo Cappellato a écrit : On Fri, Jan 5, 2018 at 9:26 AM, Michael Brohl wrote: [...] So, -1 for applying this as a general rule, +1 for a thorough review of the 53 cases and changes where they make sense. I agree with the reasoning and

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Jacques Le Roux
+1 for both Jacques Le 05/01/2018 à 11:18, Michael Brohl a écrit : +1 I think we should also change the headline "Apache OFBiz 13.07 and earlier" to "Earlier Releases" or similar, so that we do not have to maintain this section when the releases change. Regards, Michael Am 05.01.18 um

Re: Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Michael Brohl
+1 I think we should also change the headline "Apache OFBiz 13.07 and earlier" to "Earlier Releases" or similar, so that we do not have to maintain this section when the releases change. Regards, Michael Am 05.01.18 um 11:02 schrieb Jacopo Cappellato: Hi all, I think we should now

Proposal to remove the "Special Notice" section from the OFBiz download page

2018-01-05 Thread Jacopo Cappellato
Hi all, I think we should now remove the section titled "Special Notice Regarding Branches 14.12 and 15.12" from the OFBiz download page: https://ofbiz.apache.org/download.html The page should only list the most recent release from each actively maintained branch; the section has been useful

Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 09:26, Michael Brohl a écrit : Hi Jacques, inline.. Am 05.01.18 um 08:31 schrieb Jacques Le Roux: Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me.

Re: Variables created from properties should not be final

2018-01-05 Thread Jacques Le Roux
Le 05/01/2018 à 08:45, Taher Alkhateeb a écrit : -1 This is a perfect example of why mass-updates following a certain pattern are a bad idea. I did not say that all should be done. Of course every case should be checked. The properties files in the start component define critical startup

Re: Variables created from properties should not be final

2018-01-05 Thread Jacopo Cappellato
On Fri, Jan 5, 2018 at 9:26 AM, Michael Brohl wrote: > [...] So, > > -1 for applying this as a general rule, > +1 for a thorough review of the 53 cases and changes where they make sense. > I agree with the reasoning and conclusions above; to them I would add my: +1

Re: Variables created from properties should not be final

2018-01-05 Thread Michael Brohl
Hi Jacques, inline.. Am 05.01.18 um 08:31 schrieb Jacques Le Roux: Hi, We have roughly 3514 variables created from properties, either from properties files or from DB values. Among them 53 are declared final, this does not make sense to me. It might make sense depending on the business