Hello,
The difference with the documentation and Mathieu's example is the
presence of String concatenation. Here lies the performance improvment.
If there a simple String is used, the if is uneeded :)
Regards
Gil
Le 19:58 - mardi 11 déc., Taher Alkhateeb a écrit :
> The official documentation
My + 1 to Mathieu's method, as I have confidence it will not affect
dependencies check and tasks such as eclipseClasspath.
-邮件原件-
发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com]
发送时间: 2018年12月11日 23:13
收件人: dev@ofbiz.apache.org
主题: Re: OFBIZ-10693 vs OFBIZ-10694
Le
Hello,
Michael Brohl writes:
> Although I appreciate this kind of work, we should definetely commit
> in smaller chunks (package or even class level).
>
> I thought that we agreed upon that.
Althought I strongly agree with the choice of making small commits that
are easier to review and
The official documentation mentions that performance is hit [1] with metrics.
[1] https://logging.apache.org/log4j/2.x/performance.html#asyncLoggingWithParams
On Tue, Dec 11, 2018 at 7:19 PM Mathieu Lirzin
wrote:
>
> Hello Michael,
>
> Michael Brohl writes:
>
> > Yes, right, but it's certainly
Hello Michael,
Michael Brohl writes:
> Yes, right, but it's certainly less costly than the direct execution
> of Debug.logXxxx... And that's the point. You don't want to run these
> statments thousands of times within a minute (in production systems),
> which is the case in central
Hi Michael,
Le 11/12/2018 à 15:57, Michael Brohl a écrit :
Am 11.12.18 um 13:42 schrieb Jacques Le Roux:
Because
1. The if condition has a cost (3 times more than nothing according to
Mathieu's reference[1])
Yes, right, but it's certainly less costly than the direct execution of
Le 22/11/2018 à 16:43, jler...@apache.org a écrit :
Also, so far in Buildbot log only (not locally) I saw a message saying
asciidoctor: WARNING: could not embed image:
/home/buildslave/slave/ofbizTrunkFrameworkPlugins/build/plugins/birt/src/docs/asciidoc/images/Report-Master.png;
PNG uses
Le 07/12/2018 à 11:06, Jacques Le Roux a écrit :
Hi,
Mathieu and I propose 2 solutions for "gradlew generateOfbizDocumentation’ fails
with Gradle 5.0"
Please check which one you would prefer to be committed
Thanks
Jacques
I think I did not give enough elements.
Mathieu suggested to use
Although I appreciate this kind of work, we should definetely commit in
smaller chunks (package or even class level).
I thought that we agreed upon that.
Thanks,
Michael
Am 11.12.18 um 14:54 schrieb Taher Alkhateeb:
This smells very much like a mass-update which we objected to many
times
Hi Jacques,
inline...
Am 11.12.18 um 13:42 schrieb Jacques Le Roux:
Because
1. The if condition has a cost (3 times more than nothing according to
Mathieu's reference[1])
Yes, right, but it's certainly less costly than the direct execution of
Debug.logXxxx... And that's the point. You
This smells very much like a mass-update which we objected to many
times before. I think without proper review this could very well
introduce bugs or issues.
On Tue, Dec 11, 2018 at 4:33 PM wrote:
>
> Author: jleroux
> Date: Tue Dec 11 13:33:49 2018
> New Revision: 1848673
>
> URL:
Because
1. The if condition has a cost (3 times more than nothing according to
Mathieu's reference[1])
2. and is not consistently used.
3. Using "Beautiful Logger" could be a better solution:
https://github.com/forax/beautiful_logger
drawbacks:
* needs Java 11 to build. But will we
Hi,
This is a quite interesting feature.
Unfortunately the last patch is totally deprecated.
I tried to change the paths but it's not enough.
There are several chunks that needs to be placed on the right location by hand
So the question is: do we really want to drop this effort and forget it
We already agreed and decided to keep the if condition. I'm not sure
why this subject is being reopened.
On Mon, Dec 10, 2018 at 9:49 PM Jacques Le Roux
wrote:
>
> The question is quite simple. It's about always using or not the /if
> (Debug.levelOn()) {/ expression for the info and debug level
14 matches
Mail list logo
