Re: ContactNumber optional on service definition

2019-12-16 Thread Rishi Solanki
Dear Suraj, Calling service without contactNumber should not null the value in db using these services. In case parameters send the null value then only service will do that, if you do not want to null the value then do not pass it. Below is example to clarify what I am suggesting; CASE1: Pass

Re: ContactNumber optional on service definition

2019-12-16 Thread Suraj Khurana
Thanks everyone for your inputs. Here is a case, please check these services 'createUpdateCustomerAndShippingAddress', 'createUpdateBillingAddressAndPaymentMethod'. If we are calling these already available services without contactNumber, as per current flow they will nullify existing

Re: ContactNumber optional on service definition

2019-12-15 Thread Rishi Solanki
After Michael and Jacques input, I would say no need to change the existing behavior and in case required then it can be simply taking care by overriding the service definition in custom project. So my vote change now, no need to change ootb behavior. Best Regards, -- Rishi Solanki *CTO, Mindpath

Re: ContactNumber optional on service definition

2019-12-12 Thread Michael Brohl
Hi Suraj, I don't see a reason why we should make this field mandatory. It's one of a few other fields in the table. It *could* be of value to remove the contactNumber, in case this part of the number is wrong and should not be displayed as long as it is fixed. Or the telecom number ist

Re: ContactNumber optional on service definition

2019-12-12 Thread Jacques Le Roux
Hi, I tend to agree, I see not reason to have it optional. Now I don't know what it implies in term of related changes, notably for custom projects... All in all I don't see a lot of positive doing so. Did you cross a specific issue Suraj? Jacques Le 03/12/2019 à 16:42, Rishi Solanki a

Re: ContactNumber optional on service definition

2019-12-03 Thread Rishi Solanki
Hi Suraj, It seems writing this service just to wrap the create and update logic in one service. So it uses the same IN parameters and constraints as inner services have. IMO, we can change the wrapper service behavior based on business requirements and override it. +1 for changing it. Best

ContactNumber optional on service definition

2019-12-03 Thread Suraj Khurana
Hello team, There is a service named 'createUpdatePartyTelecomNumber' in which contactNumber field is optional on service definition. >From DB fields perspective it seems good to have it optional, ideally I think it should not. Whether you are creating or updating any party telecom details,