Re: Documentation commits (.adoc file type)

Done in r1827510 Michael Am 22.03.18 um 10:46 schrieb Jacques Le Roux: Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : So all should be OK after that. Michael, For educational purpose, I still let you complete ofbiz/tools/rat-excludes.txt Thanks Jacques smime.p7s Description:

Re: Documentation commits (.adoc file type)

Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : So all should be OK after that. Michael, For educational purpose, I still let you complete ofbiz/tools/rat-excludes.txt Thanks Jacques

Re: Documentation commits (.adoc file type)

Yikes, forgot to update in Eclipse so there was actually nothing missing after Gil's commit. I'll force the damned BUildBot ! Jacques Le 22/03/2018 à 10:31, Jacques Le Roux a écrit : Michael , I fixed the framework with r1827457 https://ci.apache.org/builders/ofbizTrunkFramework and it was

Re: Documentation commits (.adoc file type)

Michael , I fixed the framework with r1827457 https://ci.apache.org/builders/ofbizTrunkFramework and it was the reason why Buildbot did not trigger RAT. It only triggers on successful trunk framework commits: https://ci.apache.org/builders/ofbizTrunkFrameworkRat Gill just improved r1827457

Re: Documentation commits (.adoc file type)

Sure. I‘m off for a few days so it will take some time if not someone else beats me to it ;-) Regards, Michael > Am 19.03.2018 um 11:26 schrieb Jacques Le Roux : > > I forgot that I looked at > https://ci.apache.org/builders/ofbizTrunkFrameworkRat few days ago

Re: Documentation commits (.adoc file type)

I forgot that I looked at https://ci.apache.org/builders/ofbizTrunkFrameworkRat few days ago and then said in this thread >>Weirdly Buildbot did not grasp the commit >>Let's wait, it's OK anyway So I double checked today and still ofbizTrunkFrameworkRat was last ran few days ago. I started

Re: Documentation commits (.adoc file type)

Not at all, it checks that we are putting the license header in our files as it's requested by ASF policy Jacques Le 19/03/2018 à 09:44, Taher Alkhateeb a écrit : I'm not sure why we're using RAT anymore? I thought this is mostly for incubating projects to help them transition and license

Re: Documentation commits (.adoc file type)

I'm not sure why we're using RAT anymore? I thought this is mostly for incubating projects to help them transition and license their files. Perhaps it might be simpler to remove it from the build script to reduce complexity? On Mon, Mar 19, 2018 at 11:23 AM, Jacques Le Roux

Re: Documentation commits (.adoc file type)

Hi Michael, RAT still reports .adoc files as missing a license header https://ci.apache.org/projects/ofbiz/rat-output.html I see 2 reasons: * RAT does not know how to handle comment in .adoc files (more likely) so does not find the license header * It's not the right way to comment a

Re: Documentation commits (.adoc file type)

Thanks Taher, for file in $( find . -name "*.adoc" ); do cat ../license.txt ${file} > ${file}.tmp; mv ${file}.tmp ${file}; done did the trick ;-) Regards, Michael Am 18.03.18 um 14:23 schrieb Taher Alkhateeb: That was quick! Great work Michael On Sun, Mar 18, 2018, 4:06 PM Michael Brohl

Re: Documentation commits (.adoc file type)

Thanks Michael, Weirdly Buildbot did not grasp the commit Let's wait, it's OK anyway Jacques Le 18/03/2018 à 14:06, Michael Brohl a écrit : Done. Michael Am 18.03.18 um 13:27 schrieb Michael Brohl: Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc

Re: Documentation commits (.adoc file type)

That was quick! Great work Michael On Sun, Mar 18, 2018, 4:06 PM Michael Brohl wrote: > Done. > > Michael > > Am 18.03.18 um 13:27 schrieb Michael Brohl: > > Thanks for the hint, Pierre. > > > > I will take care of it and complete the existing .adoc files, also > >

Re: Documentation commits (.adoc file type)

Done. Michael Am 18.03.18 um 13:27 schrieb Michael Brohl: Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc files, also leave a notice in the wiki. Thanks, Michael Am 18.03.18 um 12:28 schrieb Pierre Smits: Hi All, Please be aware that when an .adoc

Re: Documentation commits (.adoc file type)

Thanks for the hint, Pierre. I will take care of it and complete the existing .adoc files, also leave a notice in the wiki. Thanks, Michael Am 18.03.18 um 12:28 schrieb Pierre Smits: Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache

Re: Documentation commits (.adoc file type)

Hi Pierre, We crossed on wire, I guess because of https://s.apache.org/hsXA :) Jacques Le 18/03/2018 à 12:28, Pierre Smits a écrit : Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache header in place. Best regards, Pierre Smits

Documentation commits (.adoc file type)

Hi All, Please be aware that when an .adoc artefact is committed to the repo that the file has the Apache header in place. Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OEM - The OFBiz Extensions Marketplace1 http://oem.ofbizci.net/oci-2/ 1 not