Re: Keep javaScriptEnabled manage on the framework ?

2017-09-01 Thread Gareth Carter
: Keep javaScriptEnabled manage on the framework ? Hi Nicolas, Let's try, but we should also check that the common-theme has not broke some features Please see the issues broken by https://issues.apache.org/jira/browse/OFBIZ-9138 Thanks Jacques Le 30/08/2017 à 09:26, Nicolas Malin a écrit : > Hi

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-31 Thread Jacques Le Roux
+1 Jacques Le 31/08/2017 à 17:30, Nicolas Malin a écrit : Ok I solved the different problem (I hope) with the common-theme migration, I wait one week and if it's ok, I will remove it Nicolas Le 30/08/2017 à 10:21, Jacques Le Roux a écrit : Thanks Nicolas, Much appreciated, I'll try to

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-31 Thread Nicolas Malin
Ok I solved the different problem (I hope) with the common-theme migration, I wait one week and if it's ok, I will remove it Nicolas Le 30/08/2017 à 10:21, Jacques Le Roux a écrit : Thanks Nicolas, Much appreciated, I'll try to help also (I'm used to manually "bisect" svn ;)) Jacques Le

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-30 Thread Jacques Le Roux
Done Jacques Le 29/08/2017 à 11:36, Jacques Le Roux a écrit : I we agree I'll close https://issues.apache.org/jira/browse/OFBIZ-4120 and subtasks as "won't fix" Jacques Le 29/08/2017 à 09:21, Jacques Le Roux a écrit : Hi Nicolas, Paul, I got to the same conclusion than Nicolas after

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-30 Thread Jacques Le Roux
Thanks Nicolas, Much appreciated, I'll try to help also (I'm used to manually "bisect" svn ;)) Jacques Le 30/08/2017 à 09:49, Nicolas Malin a écrit : Yes Jacques I will help to fix them before Nicolas Le 30/08/2017 à 09:39, Jacques Le Roux a écrit : Hi Nicolas, Let's try, but we should

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-30 Thread Nicolas Malin
Yes Jacques I will help to fix them before Nicolas Le 30/08/2017 à 09:39, Jacques Le Roux a écrit : Hi Nicolas, Let's try, but we should also check that the common-theme has not broke some features Please see the issues broken by https://issues.apache.org/jira/browse/OFBIZ-9138 Thanks

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-30 Thread Jacques Le Roux
Hi Nicolas, Let's try, but we should also check that the common-theme has not broke some features Please see the issues broken by https://issues.apache.org/jira/browse/OFBIZ-9138 Thanks Jacques Le 30/08/2017 à 09:26, Nicolas Malin a écrit : Hi Paul, Hi Jacques, Thanks for your return,

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-30 Thread Nicolas Malin
Hi Paul, Hi Jacques, Thanks for your return, this interesting threads confirm to manage the javascript or not increase the code complexity. Now how we can manage it by a specific theme, if no objection I will remove this complexity. If we detect that impact some users, we restore this

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-29 Thread Jacques Le Roux
I we agree I'll close https://issues.apache.org/jira/browse/OFBIZ-4120 and subtasks as "won't fix" Jacques Le 29/08/2017 à 09:21, Jacques Le Roux a écrit : Hi Nicolas, Paul, I got to the same conclusion than Nicolas after discussing with Adrian then (2011) See last of

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-29 Thread Jacques Le Roux
Hi Nicolas, Paul, I got to the same conclusion than Nicolas after discussing with Adrian then (2011) See last of https://issues.apache.org/jira/browse/OFBIZ-4121 (thanks Paul) Jacques Le 29/08/2017 à 02:15, Paul Foxworthy a écrit : See also

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-28 Thread Paul Foxworthy
See also https://lists.apache.org/thread.html/ffec3d998998db85655e1003f64268d52f9c7e9b6a4e537008e4b691@1295177952@%3Cdev.ofbiz.apache.org%3E https://issues.apache.org/jira/browse/OFBIZ-4120 https://issues.apache.org/jira/browse/OFBIZ-4121 Cheers Paul Foxworthy On 29 August 2017 at 10:08, Paul

Re: Keep javaScriptEnabled manage on the framework ?

2017-08-28 Thread Paul Foxworthy
Hi Nicolas, Adrian said something about this in https://issues.apache.org/jira/browse/OFBIZ-1648 . Cheers Paul Foxworthy On 29 August 2017 at 07:46, Nicolas Malin wrote: > Hello, > > During my refactoring to introduce the common-theme I saw that we > currently

Keep javaScriptEnabled manage on the framework ?

2017-08-28 Thread Nicolas Malin
Hello, During my refactoring to introduce the common-theme I saw that we currently manage on the framework a variable naming javaScriptEnabled to indicate if a user want or not use the javascipt. This functionality has been introduction by Adrian in 2008 (1) and I not found the origin thread