Re: Check for only QOH while doing reservations

2018-04-15 Thread Jacques Le Roux
opo Cappellato <jacopo.cappell...@hotwaxsystems.com> Sent: Tuesday, April 10, 2018 1:47 PM To: dev@ofbiz.apache.org Subject: Re: Check for only QOH while doing reservations Thanks Suraj, after reviewing that old commit I am inclined to think that the change you are suggesting makes sense. B

Re: Check for only QOH while doing reservations

2018-04-14 Thread Vaibhav Jain
at the > > > time > > > of order submission or adding items to cart rather than ATP. At high > > level > > > ATO for any given SKU could be determined on run time as follows: > > > ATO = QOH + Incoming Shipments(Scheduled Receipts) - (Total unshipped > >

Re: Check for only QOH while doing reservations

2018-04-12 Thread Suraj Khurana
pts) - (Total unshipped > units > > on Open Orders & Carts) > > > > I hope such cases could help in providing more holistic view while > > leveraging or relying upon the reservation logic. > > > > Thanks, > > Swapnil > > > > -Origina

Re: Check for only QOH while doing reservations

2018-04-11 Thread Rishi Solanki
> Swapnil > > -Original Message----- > From: Jacopo Cappellato <jacopo.cappell...@hotwaxsystems.com> > Sent: Tuesday, April 10, 2018 1:47 PM > To: dev@ofbiz.apache.org > Subject: Re: Check for only QOH while doing reservations > > Thanks Suraj, > > af

RE: Check for only QOH while doing reservations

2018-04-10 Thread Swapnil Shah
uesday, April 10, 2018 1:47 PM To: dev@ofbiz.apache.org Subject: Re: Check for only QOH while doing reservations Thanks Suraj, after reviewing that old commit I am inclined to think that the change you are suggesting makes sense. Before that old commit all the inventory items (regardless of the

Re: Check for only QOH while doing reservations

2018-04-10 Thread Jacopo Cappellato
Thanks Suraj, after reviewing that old commit I am inclined to think that the change you are suggesting makes sense. Before that old commit all the inventory items (regardless of their type and qty) were selected and there was logic to iterate thru the result set and exclude the ones with the

Re: Check for only QOH while doing reservations

2018-04-09 Thread Suraj Khurana
Thanks Scott, I looked around and found some relevant commit. IMO, it has been mistakenly committed as commit log also doesn't shows any functional change in commit. Here

Re: Check for only QOH while doing reservations

2018-04-06 Thread Scott Gray
Hi Suraj, I haven't reviewed the code in question so I don't have any comment at this stage. But one thing I want to point out is that OFBiz has many years of history available in commit logs, jira and mailing lists. It's often quite a simple task to look back over that history and determine why