Re: Rule to deprecated a service

Thanks for the work Jacques. Nicolas Le 29/09/2017 à 09:49, Jacques Le Roux a écrit : Done at https://s.apache.org/12Uq Jacques Le 14/08/2017 à 18:05, Jacques Le Roux a écrit : Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o

Re: Rule to deprecated a service

Done at https://s.apache.org/12Uq Jacques Le 14/08/2017 à 18:05, Jacques Le Roux a écrit : Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o answers I will soon consider the status quo a consensus ans will write the rules in wiki Jacques

Re: Rule to deprecated a service

Yes Nicolas. Nicely explained. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Mon, Aug 14, 2017 at 6:21 PM, Nicolas Malin wrote: > Le 14/08/2017 à 07:48, Deepak Dixit a écrit : > >> Thank Jacques, >> >> The code that has been deprecated

Re: Rule to deprecated a service

Thanks Nicolas :) It's with mine at least and I guess Jacopo's, Scott's and Deepak's, right guys? W/o answers I will soon consider the status quo a consensus ans will write the rules in wiki Jacques Le 14/08/2017 à 14:51, Nicolas Malin a écrit : Le 14/08/2017 à 07:48, Deepak Dixit a écrit

Re: Rule to deprecated a service

Le 14/08/2017 à 07:48, Deepak Dixit a écrit : Thank Jacques, The code that has been deprecated before December 2014 will be released in the releases of the 14.12 branch: in this way users will be notified about deprecated methods/code. I am also on same page . We tag code deprecated as a

Re: Rule to deprecated a service

Thanks Deepak, You said > We tag code deprecated as a part of release and these code will be removed from next release. I agree this is the process once we have removed all deprecated stuff. But there still are older stuff pending. So we need 1st to remove all what is deprecated to simply

Re: Rule to deprecated a service

Thank Jacques, >>>The code that has been deprecated before December 2014 will be released in the releases of the 14.12 branch: in this way users will be notified about deprecated methods/code. I am also on same page . We tag code deprecated as a part of release and these code will be removed

Re: Rule to deprecated a service

Since we do a major release only once a year, maybe more, I think it is enough time for users to follow-up the changes if we proceed as you described. There might be exceptions, e.g. if we make changes in an API which is widely used. One thing I would like to add: if we deprecate code, we

Re: Rule to deprecated a service

Thanks Nicolas, Actually when I read OFBIZ-6273 it seems Jacopo are on the same page than me: The code that has been deprecated before December 2014 will be released in the releases of the 14.12 branch: in this way users will be notified about deprecated methods/code. For this reason we can

Re: Rule to deprecated a service

This is interesting too https://issues.apache.org/jira/browse/OFBIZ-6273 (thanks Deepak at OFBIZ-9569) Jacques Le 11/08/2017 à 17:05, Jacques Le Roux a écrit : Hi Nicolas, I'm unsure about your point "remove all element contains with a since not on the last stable branch on trunk" I

Re: Rule to deprecated a service

Imagine we are the 30 december 2019 and we decide to create a new release. We have on trunk : * addCatalogMember deprecated since="next release" * deleteRateAmount deprecated since="17.11" * deleteWorkEffortAssignment depraceted since="18.12" We prepare the release, we have on trunk : *

Re: Rule to deprecated a service

Hi Nicolas, I'm unsure about your point "remove all element contains with a since not on the last stable branch on trunk" I guess you mean "to remove on trunk all elements which contains a 'since=releaseBranchNumber' with releaseBranchNumber being different from the last stable branch just

Re: Rule to deprecated a service

Hello, I imagine the following process : * deprecated on trunk an element and indicate since="$NextReleaseBranch" (or somethink like that) * When before create the new release branch like 17.11 : ** run a replaceAll $NextReleaseBranch by 17.11 ** update the trunk * Create the new stable branch

Re: Rule to deprecated a service

Le 10/08/2017 à 13:25, Scott Gray a écrit : I think we've had these discussions before Jacques, I'd search the mailing lists and then perhaps only continue the conversation if you have concerns about what was agreed previously. I'm pretty sure the policy was "remove after the next release is

Re: Rule to deprecated a service

I think we've had these discussions before Jacques, I'd search the mailing lists and then perhaps only continue the conversation if you have concerns about what was agreed previously. I'm pretty sure the policy was "remove after the next release is out", and actually released, not just when a

Re: Rule to deprecated a service

+1 Nicolas Thanks & Regards Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Wed, Aug 9, 2017 at 5:04 PM, Suraj Khurana < suraj.khur...@hotwaxsystems.com> wrote: > +1 Nicolas. > > -- > Thanks and Regards, > *Suraj Khurana* | Sr. Enterprise Software Engineer > HotWax Commerce

Re: Rule to deprecated a service

Hi All, After Nicolas's work at OFBIZ-9558 I want to create a "Code deprecation rules" wiki page. Before doing so I think we need to get a consensus about when to remove deprecated code (Java, Groovy, XML, etc.) and services definitions. Then we could plan to remove all deprecated code in

Re: Rule to deprecated a service

+1 Nicolas. -- Thanks and Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 On Sat, Aug 5, 2017 at 1:34 AM, Nicolas Malin

Re: Rule to deprecated a service

+1 Thanks Nicolas, This is inline with what I proposed. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Sun, Aug 6, 2017 at 10:34 PM, Nicolas Malin wrote: > Thanks for your return Deepak and Taher. > > I suggested to use comment to deprecated

Re: Rule to deprecated a service

Hello, I implemented a first solution on the issue OFBIZ-9558 [1]. If you have a reviewer heart, It would be great :) Nicolas [1] https://issues.apache.org/jira/browse/OFBIZ-9558 Le 07/08/2017 à 09:24, Nicolas Malin a écrit : Thanks Scott, your suggestions complete like a charm this theme

Re: Rule to deprecated a service

Thanks Scott, your suggestions complete like a charm this theme :) I will implement the deprecated service process and complete the documentation for the future Nicolas Le 07/08/2017 à 09:05, Jacques Le Roux a écrit : Nice suggestions Thanks Scott Jacques Le 07/08/2017 à 00:02, Scott

Re: Rule to deprecated a service

Nice suggestions Thanks Scott Jacques Le 07/08/2017 à 00:02, Scott Gray a écrit : +1 for logging a warning instead of an error +1 for using an element to deprecate. Although I'd prefer "deprecated" for the element name and I'd prefer "use-instead" for the attribute name. Would keep us

Re: Rule to deprecated a service

+1 for logging a warning instead of an error +1 for using an element to deprecate. Although I'd prefer "deprecated" for the element name and I'd prefer "use-instead" for the attribute name. Would keep us consistent with java conventions, @deprecated and the text is often "use X instead". I think

Re: Rule to deprecated a service

+1 Jacques Le 06/08/2017 à 19:04, Nicolas Malin a écrit : Thanks for your return Deepak and Taher. I suggested to use comment to deprecated because it's really fast to implement with a combination of process and small modification code. Like Taher, just I found not enough just a comment.

Re: Rule to deprecated a service

Thanks for your return Deepak and Taher. I suggested to use comment to deprecated because it's really fast to implement with a combination of process and small modification code. Like Taher, just I found not enough just a comment. What do you think about add a new xml element to service

Re: Rule to deprecated a service

I agree with Nicolas and Taher, A POC would help to remove hesitations Jacques Le 06/08/2017 à 08:03, Taher Alkhateeb a écrit : Hmmm I am not sure if comments are the most appropriate form for deprecation. Usually deprecation is useful when it is programmatic because it goes beyond raw text

Re: Rule to deprecated a service

Hmmm I am not sure if comments are the most appropriate form for deprecation. Usually deprecation is useful when it is programmatic because it goes beyond raw text to logging warnings and highlighting by tools. You want the system to constantly remind you (both the developer and author) to get rid

Re: Rule to deprecated a service

Hi Nicolas, Idea is to mark service deprecated is looks good to me, What I think instead of adding deprecated as engine we can set annotation for deprecated service like we set in java, annotation can be simple comment or xml annotation. And ideally we have to mark services deprecate instead of

Rule to deprecated a service

Hello with the thread https://lists.apache.org/thread.html/Zoz5yfpkrfcxts1 and the voluntary to have a good coherence on crud service name, I would be have your suggest to manage old name and deprecated process. I review the issue OFBIZ-9550 [1] that contains this problematic : -*