[jira] [Closed] (OFBIZ-4418) Replace String concatenation in a loop

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4418. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri. Your Patch is in Trunk

Re: New link between communication event and sales opportunity

2011-09-15 Thread Hans Bakker
Sure I am all in favor to use the existing datamodel, this means however that every communication event will have a workeffort connected to it because somebody has to handle it? sounds a it bureaucratic?, then as a result of the creation of the opportunity more emails are sent from the

Re: New link between communication event and sales opportunity

2011-09-15 Thread Scott Gray
Not necessarily every communication event, but if it requires action then a WorkEffort seems like the logic choice to track the work done. If you were to send more emails in connection with the opportunity then they would be linked to the existing WorkEffort. Ask yourself this, why is there a

[jira] [Closed] (OFBIZ-4414) Missing UiLabel and typos on Anonymous Checkout

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4414. -- Resolution: Fixed Fix Version/s: SVN trunk Release Branch 11.04

Re: New link between communication event and sales opportunity

2011-09-15 Thread Adrian Crum
Just curious - how is a SalesOpportunity different from a Request (or CustRequest in OFBiz)? What does SalesOpportunity model? -Adrian On 9/15/2011 7:19 AM, Scott Gray wrote: Not necessarily every communication event, but if it requires action then a WorkEffort seems like the logic choice to

[jira] [Created] (OFBIZ-4419) getOrderStatus service is defined with export=true

2011-09-15 Thread Dimitri Unruh (JIRA)
getOrderStatus service is defined with export=true Key: OFBIZ-4419 URL: https://issues.apache.org/jira/browse/OFBIZ-4419 Project: OFBiz Issue Type: Bug Components: order

[jira] [Updated] (OFBIZ-4419) getOrderStatus service is defined with export=true

2011-09-15 Thread Dimitri Unruh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Unruh updated OFBIZ-4419: - Attachment: OFBIZ-4419.patch getOrderStatus service is defined with export=true

Re: Should the getOrderStatus Service be exported?

2011-09-15 Thread Dimitri Unruh
Scott, Sascha, thank you for your opinion... I did create a new issue (https://issues.apache.org/jira/browse/OFBIZ-4419 ) to close it. Viele Grüße Best Regards Dimitri Unruh Consultant AEW Lynx-Consulting GmbH Johanniskirchplatz 6 33615 Bielefeld Deutschland Fon: +49 521 5247-0 Fax: +49 521

Re: New link between communication event and sales opportunity

2011-09-15 Thread Hans Bakker
I do not agree, i want to list all commevents on an opportunity which gets now too difficul Hans On Thu, 2011-09-15 at 18:19 +1200, Scott Gray wrote: Not necessarily every communication event, but if it requires action then a WorkEffort seems like the logic choice to track the work done.

Re: New link between communication event and sales opportunity

2011-09-15 Thread Scott Gray
It really doesn't seem very difficult to me and coupling SalesOpportunity and WorkEffort will give you much more flexibility in the future. Regards Scott On 15/09/2011, at 7:00 PM, Hans Bakker wrote: I do not agree, i want to list all commevents on an opportunity which gets now too difficul

[jira] [Assigned] (OFBIZ-4417) blockingTestScv Service is set to export=true

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4417: -- Assignee: Sascha Rodekamp blockingTestScv Service is set to export=true

[jira] [Assigned] (OFBIZ-4419) getOrderStatus service is defined with export=true

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4419: -- Assignee: Sascha Rodekamp getOrderStatus service is defined with export=true

Re: New link between communication event and sales opportunity

2011-09-15 Thread Hans Bakker
then we have to agree to disagree? Ok my last question, you are going to block this?' cannot spend too much time on this... Regards, Hans On Thu, 2011-09-15 at 19:08 +1200, Scott Gray wrote: It really doesn't seem very difficult to me and coupling SalesOpportunity and WorkEffort will give

Re: New link between communication event and sales opportunity

2011-09-15 Thread Scott Gray
Ask for comments and then ignore them, well done Hans. If you don't have time to wait for opinions and have proper discussions then keep your changes local until you do. Regards Scott On 15/09/2011, at 7:33 PM, Hans Bakker wrote: then we have to agree to disagree? Ok my last question,

Re: New link between communication event and sales opportunity

2011-09-15 Thread Hans Bakker
Ok sounds fair, let wait for other comments. On Thu, 2011-09-15 at 19:37 +1200, Scott Gray wrote: Ask for comments and then ignore them, well done Hans. If you don't have time to wait for opinions and have proper discussions then keep your changes local until you do. Regards Scott On

[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2011-09-15 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105193#comment-13105193 ] Adrian Crum commented on OFBIZ-4274: A clear distinction needs to be made between HTTP

Re: New link between communication event and sales opportunity

2011-09-15 Thread BJ Freeman
even if it is done automatically, all efforts cost time which is what workeffort is about. This feed back to budgets. and since this system is about business, tracking cost is very important. on a coding level I think the Model for SFA is sprawl and could have been developed with in the frame

[jira] [Closed] (OFBIZ-4419) getOrderStatus service is defined with export=true

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4419. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri. Your Patch is in Trunk

Re: svn commit: r1170442 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

2011-09-15 Thread Dimitri Unruh
So, if there are so much different opinions and personal preferences, why not creating an eclipse code formatter? We could add it to the project, so that there will be no more discussions about things like that :) (I think it is important, that every developer in a project is following some

[jira] [Closed] (OFBIZ-4417) blockingTestScv Service is set to export=true

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4417. -- Resolution: Fixed Fix Version/s: SVN trunk Thanks Dimitri, your patch is in Trunk

[jira] [Closed] (OFBIZ-4399) Possible null pointer exception

2011-09-15 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4399. -- Resolution: Not A Problem Assignee: Adrian Crum I agree with Adrian, putIfAbsent would

Re: svn commit: r1170442 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

2011-09-15 Thread Jacques Le Roux
Yes that's what I was suggesting. See my previous message about that (look for Eclipse Java/Code Style/Formatter template based on default (Java Conventions [built-in]) ) But you need to agree before on what to put in the formatter... Jacques Dimitri Unruh wrote: So, if there are so much

Re: svn commit: r1170442 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/form/ModelFormField.java

2011-09-15 Thread Dimitri Unruh
Sorry Jacques, I missed your last message... :) Viele Grüße Best Regards From: Jacques Le Roux jacques.le.r...@les7arts.com To: dev@ofbiz.apache.org Date: 15.09.2011 13:03 Subject:Re: svn commit: r1170442 -

[jira] [Updated] (OFBIZ-4274) Implement a REST Servlet

2011-09-15 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrian Crum updated OFBIZ-4274: --- Attachment: RestXmlRepresentation.pdf RestXmlRepresentation.pdf is the proposed XML representation.

[jira] [Created] (OFBIZ-4420) IO stream objects are not closed

2011-09-15 Thread Dimitri Unruh (JIRA)
IO stream objects are not closed Key: OFBIZ-4420 URL: https://issues.apache.org/jira/browse/OFBIZ-4420 Project: OFBiz Issue Type: Bug Components: framework Reporter: Dimitri Unruh

[jira] [Updated] (OFBIZ-4420) IO stream objects are not closed

2011-09-15 Thread Dimitri Unruh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Unruh updated OFBIZ-4420: - Attachment: OFBIZ-4420.patch IO stream objects are not closed

[jira] [Assigned] (OFBIZ-4420) IO stream objects are not closed

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4420: -- Assignee: Sascha Rodekamp IO stream objects are not closed

[jira] [Commented] (OFBIZ-4420) IO stream objects are not closed

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13105376#comment-13105376 ] Sascha Rodekamp commented on OFBIZ-4420: Jap that looks good, but we should keep

Re: widgetVerbose

2011-09-15 Thread Jacques Le Roux
Someone I work with suggested: I have to point out though that I kind of agree with the way David put it in that the false setting could have a priority, i.e. it's like in security permissions where deny has precedence over allow, so if you set it in widget.properties to false then you're sure

[jira] [Created] (OFBIZ-4421) Impossible ClassCast

2011-09-15 Thread Dimitri Unruh (JIRA)
Impossible ClassCast Key: OFBIZ-4421 URL: https://issues.apache.org/jira/browse/OFBIZ-4421 Project: OFBiz Issue Type: Bug Components: product Reporter: Dimitri Unruh Attachments:

[jira] [Updated] (OFBIZ-4421) Impossible ClassCast

2011-09-15 Thread Dimitri Unruh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Unruh updated OFBIZ-4421: - Attachment: OFBIZ-4421.patch Impossible ClassCast Key:

[jira] [Updated] (OFBIZ-4422) Using equals() with different object types

2011-09-15 Thread Dimitri Unruh (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dimitri Unruh updated OFBIZ-4422: - Attachment: OFBIZ-4422.patch Using equals() with different object types

[jira] [Created] (OFBIZ-4422) Using equals() with different object types

2011-09-15 Thread Dimitri Unruh (JIRA)
Using equals() with different object types -- Key: OFBIZ-4422 URL: https://issues.apache.org/jira/browse/OFBIZ-4422 Project: OFBiz Issue Type: Bug Components: framework Reporter:

[jira] [Assigned] (OFBIZ-4421) Impossible ClassCast

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4421: -- Assignee: Sascha Rodekamp Impossible ClassCast

[jira] [Assigned] (OFBIZ-4422) Using equals() with different object types

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4422: -- Assignee: Sascha Rodekamp Using equals() with different object types

Re: widgetVerbose

2011-09-15 Thread Jacopo Cappellato
I am going to feel bad if I don't add my 2 cents to this thread :-) I agree with Jacques that the formatting of boundary comments should be output specific (i.e no output for CSV etc...) instead of always rendering as html comments. As regards the logic to determine if comments should be enabled

Re: widgetVerbose

2011-09-15 Thread BJ Freeman
Some time ago there was a discussion about coding pattern if not true it is false. it was WidgetVerbose which says it had to be true to be verbose. I don't see changing widget.properties. to enableBoundaryComments it means those that have production have to become familiar with new. this goes

[jira] [Created] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.

2011-09-15 Thread Leon (JIRA)
very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog. Key: OFBIZ-4423

[jira] [Updated] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.

2011-09-15 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4423: Attachment: OFBIZ-4423-fieldlookup.patch very trivial update to filedlookup.js: encodeURI before construct a new

[jira] [Assigned] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp reassigned OFBIZ-4423: -- Assignee: Sascha Rodekamp very trivial update to filedlookup.js: encodeURI before

FYI - Current trunk content redirection brings up empty content

2011-09-15 Thread Ruth Hoffman
Background: Thur. Sept 15, 2011 3:30pm ET downloaded latest trunk zip file. Ran ant run-install. Ran ./startofbiz.sh. Navigate my browser to: http://localhost:8080/ecommerce/control/MainBlog?blogContentId=BLOGROOTMADMAX Click on: http://localhost:8080/2008-Elections-BLG10007-content Empty

Re: FYI - Current trunk content redirection brings up empty content

2011-09-15 Thread Hans Bakker
We will have a look at this Ruth, it is specific from the blog though, look at the policies at the bottom of the screen, there it works, Regards, Hans -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Alternative ofbiz website: http://www.ofbiz.info http://www.antwebsystems.com : Quality

Re: New link between communication event and sales opportunity

2011-09-15 Thread Anne
I wonder if this business case is analogous to Marketing Tasks on page 293 of Volume 2 of the Data Model book? Cheers, Anne. On 15 September 2011 18:12, Hans Bakker mailingl...@antwebsystems.com wrote: Ok sounds fair, let wait for other comments. On Thu, 2011-09-15 at 19:37 +1200, Scott Gray

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-15 Thread Paul Foxworthy
Hi Hans, If you're working in the ItemIssuance area, you might want to look at https://issues.apache.org/jira/browse/OFBIZ-4386 . I reckon there's a nasty bug there, and the Jira issue has a unit test to demonstrate it and a patch. Since your change is for service products, I doubt there's any

Re: svn commit: r1171093 - in /ofbiz/trunk/applications: accounting/servicedef/ order/src/org/ofbiz/order/order/ product/script/org/ofbiz/shipment/issuance/ product/script/org/ofbiz/shipment/receipt/

2011-09-15 Thread Hans Bakker
I see Jacques is working on your issue. The changes we made are for the specific product type only, so i do not expect a conflict here. Regards, Hans On Thu, 2011-09-15 at 19:24 -0700, Paul Foxworthy wrote: Hi Hans, If you're working in the ItemIssuance area, you might want to look at

[jira] [Closed] (OFBIZ-4423) very trivial update to filedlookup.js: encodeURI before construct a new href value for nav-buttons in layered lookup dialog.

2011-09-15 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp closed OFBIZ-4423. -- Resolution: Fixed Thanks Leon your patch is in Trunk @Rev.1171391 very trivial update to