Re: [PROPOSAL] deprecate mini lang

Hi all, thank you for your replies and comments to the proposal to deprecate minilang in OFBiz. We had mostly +1's, some questions and remarks and no -1's. It was not an official vote but I think we can take these results as a confirmation that the community wants to follow the proposal,

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

It will more clear there where this is at least some limited ways of formatting (code, etc.) Jacques Typo It will more clear there where there is at least some limited ways of formatting (code, etc.) Jacques

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Hi Jacques You're probably right but with not many people signed up to attend, maybe it can be better handled offline. Also if people are interested in looking at it again in the future then we can do something then. Thanks Sharan On 29/03/17 18:07, Jacques Le Roux wrote: Maybe more time

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

There is some truth in what you say, but I like action. So I'll remove these last useless PatternSyntaxException with the useless comment I put in. Then "Fix Default or Empty Catch block in Java files" OFBIZ-8341 will be done. I will explain each commit in the Jira to answer Jacopo and

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Hi All I'm going to cancel this call proposal as I've not really had any feedback on this. Thanks Sharan On 2017-03-27 13:28 (+0200), "Sharan Foga" wrote: > Hi Everyone > > I'd like to suggest a call on Thursday this week (30th March). We have a lot > potential times and

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Maybe more time between the announce and the meeting would help? Jacques Le 29/03/2017 à 18:01, Sharan Foga a écrit : Hi All I'm going to cancel this call proposal as I've not really had any feedback on this. Thanks Sharan On 2017-03-27 13:28 (+0200), "Sharan Foga"

buildbot success in on ofbiz-branch14

The Buildbot has detected a restored build on builder ofbiz-branch14 while building . Full details are available at: https://ci.apache.org/builders/ofbiz-branch14/builds/355 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: orcus_ubuntu Build Reason: forced: by IRC user

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

+1, well appreciated, Jacques. Regards, Michael Am 29.03.17 um 17:30 schrieb Jacques Le Roux: Hi Taher, OK, I got back to this and finally understood what happened. I was fed up by the "swallowed exceptions" convo and was in a bull mindset[1]. So when you rightly wrote >I believe the

Re: [PROPOSAL] deprecate mini lang

On Sat, Feb 18, 2017 at 10:17 AM, Michael Brohl wrote: > [...] > I therefore like to propose to deprecate the mini lang implementation > which means: > > 1. there will be no new implementations based on mini lang accepted to go > into the code base. > > 2. mini lang and

Re: [PROPOSAL] deprecate mini lang

+1 For those interested, thanks to Jacopo, we have already a beginning of a Groovy DSL https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

Hi Taher, OK, I got back to this and finally understood what happened. I was fed up by the "swallowed exceptions" convo and was in a bull mindset[1]. So when you rightly wrote >I believe the @SuppressWarnings tags are used incorrectly in this commit >and in some cases hide the root problem.

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

Le 29/03/2017 à 15:27, Jacques Le Roux a écrit : It will more clear there where this is at least some limited ways of formatting (code, etc.) Jacques Typo It will more clear there where there is at least some limited ways of formatting (code, etc.) Jacques :D still a word missing It

Re: [PROPOSAL] deprecate mini lang

+1 I recommend that you put somewhere in the wiki page the _reasons_ why minilang is deprecated (the ones you listed in this thread). On Wed, Mar 29, 2017 at 6:12 PM, Michael Brohl wrote: > Hi all, > > thank you for your replies and comments to the proposal to

Re: [PROPOSAL] deprecate mini lang

Good idea, thanks Taher! Cheers, Michael Am 29.03.17 um 19:47 schrieb Taher Alkhateeb: +1 I recommend that you put somewhere in the wiki page the _reasons_ why minilang is deprecated (the ones you listed in this thread). On Wed, Mar 29, 2017 at 6:12 PM, Michael Brohl

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

inline On Wed, Mar 29, 2017 at 6:43 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > There is some truth in what you say, but I like action. > > So I'll remove these last useless PatternSyntaxException with the useless > comment I put in. > Then "Fix Default or Empty Catch block in

Re: svn commit: r1788869 - in /ofbiz/ofbiz-plugins/trunk/birt/src/main/java/org/apache/ofbiz/birt/flexibl e: BirtMasterReportServices.java BirtServices.java BirtUtil.java ReportDesignGenerator.java

Thank you for reviewing the work. I think at a later stage we can also simplify this code. The methods are hundreds of lines long with lots of declarations and commented out code, quite a mess at the moment. On Wed, Mar 29, 2017 at 6:44 PM, Michael Brohl wrote: > +1,

Re: [PROPOSAL] deprecate mini lang

Thanks for the reference, Jacques. Am 29.03.17 um 18:12 schrieb Jacques Le Roux: +1 For those interested, thanks to Jacopo, we have already a beginning of a Groovy DSL https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

On Tue, Mar 28, 2017 at 7:38 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Yikes, I thought it was clear. I mean that people should not be worried > about this swallowed exception because it's intended since no > PatternSyntaxException should not occur there > I can confirm that

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

Okay so your reply is making a point. If you were not entirely sure about the purpose of the exception handling block, and whether there is a need for the replaceAll call, then why did you commit this comment? Why introduce this confusion on what is essentially already confusing and old code that

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

On Wed, Mar 29, 2017 at 12:25 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Mmm, maybe I was not totally clear if you did not read my answer to Taher. > > I meant to remove the useless try and catch. We have 70+ other cases like > that w/o try and catch I would recommend to

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

Le 29/03/2017 à 13:53, Jacopo Cappellato a écrit : On Wed, Mar 29, 2017 at 12:25 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Mmm, maybe I was not totally clear if you did not read my answer to Taher. I meant to remove the useless try and catch. We have 70+ other cases like that

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

I think we can all agree to remove it Jacques Le 29/03/2017 à 09:45, Jacopo Cappellato a écrit : On Tue, Mar 28, 2017 at 7:38 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: Yikes, I thought it was clear. I mean that people should not be worried about this swallowed exception

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

Mmm, maybe I was not totally clear if you did not read my answer to Taher. I meant to remove the useless try and catch. We have 70+ other cases like that w/o try and catch Jacques Le 29/03/2017 à 11:01, Jacques Le Roux a écrit : I think we can all agree to remove it Jacques Le 29/03/2017

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

Hi Jacques, Am 28.03.17 um 05:47 schrieb Jacques Le Roux: Le 25/03/2017 à 13:21, Michael Brohl a écrit : +1 The lack of code documentation is not a free ticket to just change the code behaviour without proper analysis. It's not because the swallowed exceptions where not documented that I

Re: svn commit: r1787906 - in /ofbiz/ofbiz-framework/trunk/applications: manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ order/src/main/java/org/apache/ofbiz/order/shoppingcart/

Le 27/03/2017 à 10:01, Jacopo Cappellato a écrit : On Sat, Mar 25, 2017 at 8:23 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: [...] Now feel free to revert my commit if you still think it's a bad thing, but sincerely I'm not convinced! If you do so I'll then at least add comments

Re: svn commit: r1789163 - in /ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbi z/widget/model: AbstractModelAction.java ModelFormAction.java ModelTreeAction.java

On Wed, Mar 29, 2017 at 2:17 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Le 29/03/2017 à 13:53, Jacopo Cappellato a écrit : > >> On Wed, Mar 29, 2017 at 12:25 PM, Jacques Le Roux < >> jacques.le.r...@les7arts.com> wrote: >> >> Mmm, maybe I was not totally clear if you did not