Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-19 Thread Jacques Le Roux
Hi Scott, Thanks for your review, much appreciated. You are right my mechanism was flawed. It did not occur to me that by using JavaScript I opened the client side. For instance by using what follows, I can log as a limited admin. function getJwtToken1(webAppName) {     var JwtToken = "";    

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

2018-08-19 Thread Pierre Smits
Please read the comment in the related ticket [1] https://issues.apache.org/jira/browse/OFBIZ-7482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584721#comment-16584721 Best regards, Pierre Smits Apache Trafodion , Vice President Apache

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

2018-08-19 Thread Michael Brohl
I have not the time to dig into the specific details right now so will just give my thoughts on the process in general because of the citations: 1. we have to distinguish between (a) completely new functionality or major refactorings and (b) the enhancement of functionality which is already

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-19 Thread Jacques Le Roux
ôOps missed some words... Le 19/08/2018 à 12:33, Jacques Le Roux a écrit : I simply send a JWT token: https://en.wikipedia.org/wiki/JSON_Web_Token and https://jwt.io/ to allow an user to connect to another OFBiz instance (using same version than source) on another server (target) on another

Re: [Proposal] Enhance the controller logic to accommodate HTTP methods and prepare for REST

2018-08-19 Thread Taher Alkhateeb
Well, I guess Shi rushed another commit without a proper review. And now we have a bug reported in [1]. The strange thing is that Shi suggested he's no longer interested in this work! [1]

Re: [Proposal] Enhance the controller logic to accommodate HTTP methods and prepare for REST

2018-08-19 Thread Shi Jinghai
Thanks Taher! I noticed this bug report, and I have tested it, I cannot reproduce it in my local and online trunk demo environments. As Rishi Solanki suggested, if it's a bug, please reopen the OFBIZ-10438 or create a new jira. I'm waiting a further feedback from Deepak Nigam or anyone else.

Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/ we

2018-08-19 Thread Shi Jinghai
Hi Deepak, As Rishi suggested, could you please reopen OFBIZ-10438 or create a new jira for the bug you mentioned here? I cannot reproduce it in my local and online trunk demo environments, I guess my test case is not the same as yours. Thanks, Shi Jinghai -邮件原件- 发件人: Rishi Solanki

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-19 Thread Shi Jinghai
Thanks Jacques! If so, I'll release a CAS plugin to make OFBiz offer OAuth2 alliance next week. I have cas 4.2.x version running in production environment, I'll upgrade it to cas 5.2.x and then release it. -邮件原件- 发件人: Jacques Le Roux [mailto:jacques.le.r...@les7arts.com] 发送时间:

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-19 Thread Jacques Le Roux
Hi Jinghai, Actually I did not pick auth0 (not to be confused with https://en.wikipedia.org/wiki/OAuth) nor https://oauth.net/2/ because those need a central Identify server (as is the SAML protocol). I simply send a JWT token: https://en.wikipedia.org/wiki/JSON_Web_Token and https://jwt.io/

Component and Component Set Dependencies

2018-08-19 Thread Jacques Le Roux
Hi Deepak, Before I remove all the comments at https://cwiki.apache.org/confluence/display/OFBIZ/Component+and+Component+Set+Dependencies and remove in the graph the dependency from the accounting to workeffort introduced by r1710178 ;

Re: OFBIZ-10307: Navigate from a domain to another with automated signed in authentication

2018-08-19 Thread Taher Alkhateeb
Wow, so after having a long, long email (as usual) talking about how good the work is and you deployed for a client (my god!), now you reverted because of a fundamental flaw pointed out by Scott. And now you want to apply lazy consensus despite my objections and the obvious flaw which you

Re: svn commit: r1838320 - in /ofbiz/ofbiz-framework/trunk/applications: datamodel/data/seed/OrderSeedData.xml datamodel/data/seed/ProductSeedData.xml order/src/main/java/org/apache/ofbiz/order/shoppi

2018-08-19 Thread Nicolas Malin
I assist Michael's response On 19/08/2018 11:28, Michael Brohl wrote: If you have additional requirements, you are encouraged to provide solutions or concepts for them. Be positive, be happy I added just, if you not understand an improvement because comment or example are too poor, help

OFBiz Contributors Best Practices was [Re: svn commit: r1838320 ...]

2018-08-19 Thread Jacques Le Roux
Hi All, Yesterday Suraj asked me on HipChat what to do about OFBIZ-7598 where Gil spotted an issue. Here is my answer: Hi @SurajKhurana , we have not a clearly established policy for that case. Should we reuse the current Jira or should

Re: Component and Component Set Dependencies

2018-08-19 Thread Deepak Dixit
Hi Jacques, I'll check and share details ASAP. On Sun, Aug 19, 2018 at 3:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Deepak, > > Before I remove all the comments at https://cwiki.apache.org/ > confluence/display/OFBIZ/Component+and+Component+Set+Dependencies and > remove

Re: svn commit: r1838381 - in /ofbiz: ofbiz-framework/trunk/applications/order/groovyScripts/entry/catalog/ ofbiz-framework/trunk/applications/product/groovyScripts/catalog/find/ ofbiz-plugins/trunk/e

2018-08-19 Thread Deepak Dixit
Hi Jacques, I think instead of setting dispatcher in groovy files I think we can fix the work done under OFBIZ-9164 Instead of getting dispatcher from a session we can get this from the request or can use the different method signature of searchGetConstraintStrings method. {code}

Re: svn commit: r1838081 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ base/src/test/java/org/apache/ofbiz/base/collections/ webapp/config/ we

2018-08-19 Thread deepak nigam
Hi Shi/Rishi, I was using the trunk downloaded from GitHub ( https://github.com/apache/ofbiz-framework). I will reverify this issue on SVN trunk and will let you know the details. On Mon, Aug 20, 2018 at 1:37 AM Shi Jinghai wrote: > Hi Deepak, > > As Rishi suggested, could you please reopen