[jira] [Created] (OFBIZ-5953) Problem with new UtilCodec code caused by HTMLEntityCodec.decode()

2015-01-08 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-5953:
---

 Summary: Problem with new UtilCodec code caused by 
HTMLEntityCodec.decode()
 Key: OFBIZ-5953
 URL: https://issues.apache.org/jira/browse/OFBIZ-5953
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Christian Carlow


From Adrian on ML:

When I navigate to 
https://localhost:8443/accounting/control/paymentOverview?paymentId=8004 many 
exceptions are thrown and the screen fails to render.  I tried changing 
WidgetWorker.java line 74 to localRequestName = 
UtilCodec.canonicalize(localRequestName, false, false); which fixed the 
exceptions, but the generated link is wrong.  I don't know how to fix it.

Errors related to this class are also thrown at 
accounting/control/invoiceOverview.  Setting a breakpoint at line 167 of 
UtilCodec.java shows that 2 HTMLEntityCodec.decode calls transforms the URL from
EditAcctgTrans?acctgTransId=10070amp;organizationPartyId=10010 to
EditAcctgTrans?acctgTransId=10070organizationPartyId=10010 to
EditAcctgTrans?acctgTransId=10070∨ganizationPartyId=10010.

Not sure if the error is in class UtilCode or HTMLEntityCodec.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Problem with new UtilCodec code

2015-01-08 Thread Pierre Smits
Feel free to register a JIRA issue.

Regards,

Pierre Smits

*ORRTIZ.COM http://www.orrtiz.com*
Services  Solutions for Cloud-
Based Manufacturing, Professional
Services and Retail  Trade
http://www.orrtiz.com

On Thu, Jan 8, 2015 at 8:56 PM, Adrian Crum 
adrian.c...@sandglass-software.com wrote:

 When I navigate to

 https://localhost:8443/accounting/control/paymentOverview?paymentId=8004

 many exceptions are thrown and the screen fails to render.

 I tried changing WidgetWorker.java line 74 to

 localRequestName = UtilCodec.canonicalize(localRequestName, false, false);

 which fixed the exceptions, but the generated link is wrong.

 I don't know how to fix it.

 --
 Adrian Crum
 Sandglass Software
 www.sandglass-software.com



[jira] [Created] (OFBIZ-5952) IncomeStatement page broken

2015-01-08 Thread Deepak Dixit (JIRA)
Deepak Dixit created OFBIZ-5952:
---

 Summary: IncomeStatement page broken
 Key: OFBIZ-5952
 URL: https://issues.apache.org/jira/browse/OFBIZ-5952
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk, 14.12.01
Reporter: Deepak Dixit


IncomeStatement page has been broken, it throwing following exception:
{code}
ERROR rendering error page [/error/error.jsp], but here is the error text: 
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
[component://accounting/widget/ReportFinancialSummaryScreens.xml#IncomeStatement]:
 java.lang.IllegalArgumentException: Error running script at location 
[component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
 org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
Administrative 
Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
 03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
 with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' due 
to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could not 
find modelEntity for entityName null (Error running script at location 
[component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
 org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
Administrative 
Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
 03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
 with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' due 
to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could not 
find modelEntity for entityName null)
{code}

https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5781) Convert Javolution collections into Java collections

2015-01-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5781?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-5781:

Attachment: OFBIZ-5781.patch

Here is the patch for the javolution collection into groovy collection.
Done following changes :
- Removed the FastSet, FastList and FastMap from groovy classes.
- Used groovy collections for all the javolution collection
- Replace FastList with []
- Replace FastMap with [:]
- Replace FastSet with [] as Set

http://groovy.codehaus.org/Collections

 Convert Javolution collections into Java collections
 

 Key: OFBIZ-5781
 URL: https://issues.apache.org/jira/browse/OFBIZ-5781
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Deepak Dixit
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5781.patch






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5947) Move cloneWorkEffortPartyAssignments to workEffortServices.java

2015-01-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269018#comment-14269018
 ] 

Jacques Le Roux commented on OFBIZ-5947:


For me it does not need to be changed, until someone really need it, YAGNI ...

But if you are this person please provide a patch and maybe someone will commit 
it

 Move cloneWorkEffortPartyAssignments to workEffortServices.java
 ---

 Key: OFBIZ-5947
 URL: https://issues.apache.org/jira/browse/OFBIZ-5947
 Project: OFBiz
  Issue Type: Improvement
  Components: manufacturing, workeffort
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Jacques Le Roux
Priority: Minor

 Currently cloneWorkEffortPartyAssignments is in ProductionRunServices.java. 
 But the better location would be in WorkEffortServices.java.
 That way, when other components want to use that function the dependency 
 would be on workeffort in stead of manufacturing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-5939) Dialogue window is not working for webpos screens. Seems JS load issue on page.

2015-01-08 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya closed OFBIZ-5939.
--
Resolution: Duplicate

Duplicate issue does exists - OFBIZ-5940. Closing this one.

 Dialogue window is not working for webpos screens. Seems JS load issue on 
 page.
 ---

 Key: OFBIZ-5939
 URL: https://issues.apache.org/jira/browse/OFBIZ-5939
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk
Reporter: Arun Patidar
Priority: Critical

 Steps to regenerate the issue:
 1. Login into webpos application 
 http://demo-trunk-ofbiz.apache.org/webpos/control/main
 2. Click on any menu item like: Pay Cash
 3. A popup window will open on the click but when you type anything in popup 
 filed, window goes disappear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-5951) Product Costs page actions cause incorrect listings

2015-01-08 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-5951:
---

 Summary: Product Costs page actions cause incorrect listings
 Key: OFBIZ-5951
 URL: https://issues.apache.org/jira/browse/OFBIZ-5951
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Christian Carlow
 Fix For: Trunk


The cost listings on the product page load incorrectly when adding and deleting 
cost components.

To reproduce:
1.  Navigate to Catalog-Products-Costs
2.  Continually click Submit under Add New Cost Component section and notice 
the listings are not updated to reflect the components added
3.  Refresh the page by clicking Catalog-Products-Costs again to display the 
components added
4.  Click the delete button for a component and notice listings disappear



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5952) IncomeStatement page broken

2015-01-08 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-5952:

Attachment: OFBIZ-5952.patch

Here is the patch for this issue. This is due to typo while converting entity 
engine method EntityQuery.

 IncomeStatement page broken
 ---

 Key: OFBIZ-5952
 URL: https://issues.apache.org/jira/browse/OFBIZ-5952
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk, 14.12.01
Reporter: Deepak Dixit
 Attachments: OFBIZ-5952.patch


 IncomeStatement page has been broken, it throwing following exception:
 {code}
 ERROR rendering error page [/error/error.jsp], but here is the error text: 
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://accounting/widget/ReportFinancialSummaryScreens.xml#IncomeStatement]:
  java.lang.IllegalArgumentException: Error running script at location 
 [component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
  org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
 object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
 03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
 Administrative 
 Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
  03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
  with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' 
 due to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could 
 not find modelEntity for entityName null (Error running script at location 
 [component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
  org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
 object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
 03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
 Administrative 
 Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
  03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
  with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' 
 due to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could 
 not find modelEntity for entityName null)
 {code}
 https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Documentation tools documentation

2015-01-08 Thread Sharan-F
Hi Jacques

I think that if we already have an internal dedicated tool that we can use
for diagrams etc then it would be good to use it.

The issue that we had (and still have) is that some of the diagrams were
made using software that we dont have access to anymore so cant update them.
We didnt know about the internal tool and as a result  Ron suggested some
possible open source tools we could use and updated a diagram using one of
them.

I will update the documentation roadmap to say that we recommend using the
internal tool.

Thanks
Sharan







--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Documentation-tools-documentation-tp4659862p4660987.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] [Assigned] (OFBIZ-5952) IncomeStatement page broken

2015-01-08 Thread Ashish Vijaywargiya (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashish Vijaywargiya reassigned OFBIZ-5952:
--

Assignee: Ashish Vijaywargiya

 IncomeStatement page broken
 ---

 Key: OFBIZ-5952
 URL: https://issues.apache.org/jira/browse/OFBIZ-5952
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk, 14.12.01
Reporter: Deepak Dixit
Assignee: Ashish Vijaywargiya
 Attachments: OFBIZ-5952.patch


 IncomeStatement page has been broken, it throwing following exception:
 {code}
 ERROR rendering error page [/error/error.jsp], but here is the error text: 
 org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen 
 [component://accounting/widget/ReportFinancialSummaryScreens.xml#IncomeStatement]:
  java.lang.IllegalArgumentException: Error running script at location 
 [component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
  org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
 object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
 03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
 Administrative 
 Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
  03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
  with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' 
 due to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could 
 not find modelEntity for entityName null (Error running script at location 
 [component://accounting/webapp/accounting/WEB-INF/actions/reports/IncomeStatement.groovy]:
  org.codehaus.groovy.runtime.typehandling.GroovyCastException: Cannot cast 
 object '[[GenericEntity:GlAccountClass][createdStamp,2015-01-08 
 03:08:36.933(java.sql.Timestamp)][createdTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][description,Selling, General, and 
 Administrative 
 Expense(java.lang.String)][glAccountClassId,SGA_EXPENSE(java.lang.String)][isAssetClass,null()][lastUpdatedStamp,2015-01-08
  03:08:36.933(java.sql.Timestamp)][lastUpdatedTxStamp,2015-01-08 
 03:08:35.054(java.sql.Timestamp)][parentClassId,CASH_EXPENSE(java.lang.String)]]'
  with class 'java.util.LinkedList' to class 'org.ofbiz.entity.GenericValue' 
 due to: java.lang.IllegalStateException: [GenericEntity.getModelEntity] could 
 not find modelEntity for entityName null)
 {code}
 https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Documentation tools documentation

2015-01-08 Thread Jacques Le Roux

Yes I know that Shara thanks, if I get enough time I will re-create with Giffy, 
I was hoping Ron could ;)

Jacques

Le 08/01/2015 09:55, Sharan-F a écrit :

Hi Jacques

I think that if we already have an internal dedicated tool that we can use
for diagrams etc then it would be good to use it.

The issue that we had (and still have) is that some of the diagrams were
made using software that we dont have access to anymore so cant update them.
We didnt know about the internal tool and as a result  Ron suggested some
possible open source tools we could use and updated a diagram using one of
them.

I will update the documentation roadmap to say that we recommend using the
internal tool.

Thanks
Sharan







--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Documentation-tools-documentation-tp4659862p4660987.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.



[jira] [Closed] (OFBIZ-5940) Dialogue window is not working for webpos screens. Seems JS load issue on page.

2015-01-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5940.
--
   Resolution: Fixed
Fix Version/s: Upcoming Branch
   14.12.01

Thanks Arun,

Your patch is in
trunk r1650240  
R14.12 r1650241


 Dialogue window is not working for webpos screens. Seems JS load issue on 
 page.
 ---

 Key: OFBIZ-5940
 URL: https://issues.apache.org/jira/browse/OFBIZ-5940
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk
Reporter: Arun Patidar
Assignee: Jacques Le Roux
Priority: Critical
 Fix For: 14.12.01, Upcoming Branch

 Attachments: OFBIZ-5940.patch


 Steps to regenerate the issue:
 1. Login into webpos application 
 http://demo-trunk-ofbiz.apache.org/webpos/control/main
 2. Click on any menu item like: Pay Cash
 3. A popup window will open on the click but when you type anything in popup 
 filed, window goes disappear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-5950) addOrderShipmentToShipment Should Return shipmentItemSeqId

2015-01-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-5950:
--

Assignee: Jacques Le Roux

 addOrderShipmentToShipment Should Return shipmentItemSeqId
 --

 Key: OFBIZ-5950
 URL: https://issues.apache.org/jira/browse/OFBIZ-5950
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Forrest Rae
Assignee: Jacques Le Roux
  Labels: patch
 Attachments: addOrderShipmentToShipment-return-shipmentItemSeqId.patch


 addOrderShipmentToShipment service should return shipmentItemSeqId.  I 
 believe this is simply a convenience change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-5940) Dialogue window is not working for webpos screens. Seems JS load issue on page.

2015-01-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-5940:
--

Assignee: Jacques Le Roux

 Dialogue window is not working for webpos screens. Seems JS load issue on 
 page.
 ---

 Key: OFBIZ-5940
 URL: https://issues.apache.org/jira/browse/OFBIZ-5940
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk
Reporter: Arun Patidar
Assignee: Jacques Le Roux
Priority: Critical
 Attachments: OFBIZ-5940.patch


 Steps to regenerate the issue:
 1. Login into webpos application 
 http://demo-trunk-ofbiz.apache.org/webpos/control/main
 2. Click on any menu item like: Pay Cash
 3. A popup window will open on the click but when you type anything in popup 
 filed, window goes disappear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-5950) addOrderShipmentToShipment Should Return shipmentItemSeqId

2015-01-08 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-5950.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thanks Forrest,

Your patch is in trunk at revision: 1650250  


 addOrderShipmentToShipment Should Return shipmentItemSeqId
 --

 Key: OFBIZ-5950
 URL: https://issues.apache.org/jira/browse/OFBIZ-5950
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Forrest Rae
Assignee: Jacques Le Roux
  Labels: patch
 Fix For: Upcoming Branch

 Attachments: addOrderShipmentToShipment-return-shipmentItemSeqId.patch


 addOrderShipmentToShipment service should return shipmentItemSeqId.  I 
 believe this is simply a convenience change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-5940) Dialogue window is not working for webpos screens. Seems JS load issue on page.

2015-01-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269093#comment-14269093
 ] 

Jacques Le Roux commented on OFBIZ-5940:


I missed it when I updated Jqueyr libs last year. I can't find an easy way to 
download jquery.hotkeys-0.8 so I will rathe apply the patch

 Dialogue window is not working for webpos screens. Seems JS load issue on 
 page.
 ---

 Key: OFBIZ-5940
 URL: https://issues.apache.org/jira/browse/OFBIZ-5940
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk
Reporter: Arun Patidar
Assignee: Jacques Le Roux
Priority: Critical
 Attachments: OFBIZ-5940.patch


 Steps to regenerate the issue:
 1. Login into webpos application 
 http://demo-trunk-ofbiz.apache.org/webpos/control/main
 2. Click on any menu item like: Pay Cash
 3. A popup window will open on the click but when you type anything in popup 
 filed, window goes disappear.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-5765) missing request map for changing currency

2015-01-08 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258182#comment-14258182
 ] 

Jacques Le Roux edited comment on OFBIZ-5765 at 1/8/15 1:56 PM:


Mridul, I do agree. 
However, this very same patch is part of my attempts to handle orders in 
multiple currencies.
After applying OFBIZ-5765 and OFBIZ-4412 I discovered shipping estimates ignore 
currency - shipping prices are taken as they are entered, they are not 
recalculated, nor even filtered by currency of order.

So I gave up multi-currency store, and made two stores, each having it's own 
currency. (and switched from 12 to 13.07)

But then I discovered that backoffice takes currency based on session locale, 
not the store currency. I.e. I have to click on language button when working 
with EUR and then again to work with HRK.
I also encountered troubles working with anything but default currency, right 
now I can't remember what.
Furthermore, currency conversion doesn't seem to work at all - when I print 
invoices in default currency, conversion rate is 1, no matter what I enter in 
currency conversion tables.
And I'm required by law to print the same invoice in two currencies, one for 
the foreign customer and the other one for accountant and tax authority.

Right now I'm confused, for I don't know what intended design is.
As it is now, it's incosistent.


was (Author: jalmasi):
Mridul, I do agree. 
However, this very same patch is part of my attempts to handle orders in 
multiple currencies.
After applying https://issues.apache.org/jira/browse/OFBIZ-5765 and 
https://issues.apache.org/jira/browse/OFBIZ-4412 I discovered shipping 
estimates ignore currency - shipping prices are taken as they are entered, they 
are not recalculated, nor even filtered by currency of order.

So I gave up multi-currency store, and made two stores, each having it's own 
currency. (and switched from 12 to 13.07)

But then I discovered that backoffice takes currency based on session locale, 
not the store currency. I.e. I have to click on language button when working 
with EUR and then again to work with HRK.
I also encountered troubles working with anything but default currency, right 
now I can't remember what.
Furthermore, currency conversion doesn't seem to work at all - when I print 
invoices in default currency, conversion rate is 1, no matter what I enter in 
currency conversion tables.
And I'm required by law to print the same invoice in two currencies, one for 
the foreign customer and the other one for accountant and tax authority.

Right now I'm confused, for I don't know what intended design is.
As it is now, it's incosistent.

 missing request map for changing currency
 -

 Key: OFBIZ-5765
 URL: https://issues.apache.org/jira/browse/OFBIZ-5765
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/ecommerce
Affects Versions: 12.04.04, 12.04.05
Reporter: Josip Almasi
Assignee: Ashish Vijaywargiya
 Attachments: ecommerce-multicurrency.patch


 By analyzing eccommerce controller.xml and appropriate java code, I found out 
 there is a way to set session currency, with a get request:
 ECOMMERCEURL/control/setSessionCurrencyUom?currencyUom=UOMID
 However, shopping cart igores session currency. That can be demonstrated by 
 changing minicart.ftl, like this:
 div id=minicart
 h3${uiLabelMap.OrderCartSummary} ${Request.currencyUomId} 
 ${shoppingCart.getCurrency()}  @ofbizCurrency 
 amount=shoppingCart.getDisplayGrandTotal() 
 isoCode=shoppingCart.getCurrency()//h3
 I also found methods in place to set shopping cart currency, just, they are 
 were mapped to any requests in eccommerce controller.xml.
 The patch to add mapping attached.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: ListEntityIterator not close and extend form

2015-01-08 Thread Adrian Crum
This should be fixed in rev 1650348. Let me know if you see any more ELI 
warnings.


Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/8/2015 8:26 AM, Adrian Crum wrote:

I think I know what is causing this. I will take care of it.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/6/2015 3:15 PM, Nicolas Malin wrote:

Hello,

I think with the thread safe improvement on the screen engine we have an
other regression on extend form.

I detected it on sfa form and I have the confirmation of the reason with
this test :
* run the search on
https://localhost:8443/accounting/control/FindAgreement - no error in
log
* apply this

Index: applications/accounting/widget/AgreementForms.xml
===
--- applications/accounting/widget/AgreementForms.xml(révision
1649945)
+++ applications/accounting/widget/AgreementForms.xml(copie de
travail)
@@ -49,7 +49,19 @@
  /field
  /form

-form name=ListAgreements list-name=listIt target= title=
type=list paginate-target=FindAgreement
+form name=ListAgreements extends=ListAgreementsBase
+actions
+set field=entityName value=Agreement/
+service service-name=performFind result-map=result
result-map-list=listIt
+field-map field-name=inputFields
from-field=requestParameters/
+field-map field-name=entityName
from-field=entityName/
+field-map field-name=orderBy
from-field=parameters.sortField/
+field-map field-name=viewIndex
from-field=viewIndex/
+field-map field-name=viewSize from-field=viewSize/
+/service
+/actions
+/form
+form name=ListAgreementsBase list-name=listIt target=
title= type=list paginate-target=FindAgreement
  odd-row-style=alternate-row default-table-style=basic-table
hover-bar header-row-style=header-row-2
  actions
  set field=entityName value=Agreement/

  * run the same search and on log we have :
 [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
|ServiceDispatcher |T| Sync service [accounting/performFind]
finished in [3] milliseconds
  [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
|ServiceDispatcher |T| Sync service [accounting/performFind]
finished in [3] milliseconds
  [java] 2015-01-06 23:33:45,056 |Finalizer
|EntityListIterator|E|
  [java]

  [java]  EntityListIterator Not Closed for Entity [Agreement],
caught in Finalize
  [java]


If I found the time I will try to check this week.

Nicolas


[jira] [Closed] (OFBIZ-5933) state/province dropdown contains incorrect items when Canada is chosen in country dropdown

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai closed OFBIZ-5933.
--
Resolution: Not a Problem

Cannot reproduce the issue as of version 1650250

 state/province dropdown contains incorrect items when Canada is chosen in 
 country dropdown
 --

 Key: OFBIZ-5933
 URL: https://issues.apache.org/jira/browse/OFBIZ-5933
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai

 When creating a postal address, selecting Canada for country automatically 
 filled the state/province dropdown with values.  The issue is that the values 
 of the state/province dropdown list are incorrect.
 I was expecting the options for the state/province dropdown to have the 
 following:
 name=Alberta, value=AB
 name=British Columbia, value=BC
 ...
 What is actually present in the drop down is:
 name=AB, value=AB
 name=AB, value=BC
 ...
 One observation is that this issue does not appear when the country selected 
 is the United States.  It seems to happen with Canada.
 Another observation is that this issue applies to the 'en' locale.  It seems 
 to work fine for 'fr' locale.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Reopened] (OFBIZ-5933) state/province dropdown contains incorrect items when Canada is chosen in country dropdown

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai reopened OFBIZ-5933:


closed by mistake. reopen.

 state/province dropdown contains incorrect items when Canada is chosen in 
 country dropdown
 --

 Key: OFBIZ-5933
 URL: https://issues.apache.org/jira/browse/OFBIZ-5933
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai

 When creating a postal address, selecting Canada for country automatically 
 filled the state/province dropdown with values.  The issue is that the values 
 of the state/province dropdown list are incorrect.
 I was expecting the options for the state/province dropdown to have the 
 following:
 name=Alberta, value=AB
 name=British Columbia, value=BC
 ...
 What is actually present in the drop down is:
 name=AB, value=AB
 name=AB, value=BC
 ...
 One observation is that this issue does not appear when the country selected 
 is the United States.  It seems to happen with Canada.
 Another observation is that this issue applies to the 'en' locale.  It seems 
 to work fine for 'fr' locale.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-5926) postal address. country dropdown does cause state/province dropdown with proper selections

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai closed OFBIZ-5926.
--
Resolution: Not a Problem

Cannot reproduce the issue as of version 1650250

 postal address. country dropdown does cause state/province dropdown with 
 proper selections
 --

 Key: OFBIZ-5926
 URL: https://issues.apache.org/jira/browse/OFBIZ-5926
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai
 Attachments: OFBIZ-5926.patch


 When creating a postal address.  The state/province dropdown is not properly 
 initialized with appropriate values associated with the selection in country 
 dropdown. Making another selection has no effect.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5949) ofbizsetup create product store cause exception

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-5949:
---
Summary: ofbizsetup create product store cause exception  (was: Remove 
generation of temp file when loading entity xml file containing placeholders)

 ofbizsetup create product store cause exception
 ---

 Key: OFBIZ-5949
 URL: https://issues.apache.org/jira/browse/OFBIZ-5949
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai
 Attachments: OFBIZ-5949.patch


 Currently, when creating a new product store using ofbizsetup component 
 default data associated with the product store is loaded into the database 
 using the following steps.
 1. read default data from entity xml file and replace specific items in the 
 read data and write to temp file.
 2. use service=parseEntityXmlFile to load the processed file into database.
 The issue with this method is that the temp file can present a problem when 
 ofbiz is operating in multitenant mode.
 The solution is to modify the relevant services so that no temp file needs 
 generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5949) ofbizsetup create product store cause exception

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-5949:
---
Description: 
The exception is caused by foreign key constraint violation between 
ShipmentCostEstimate and  CarrierShipmentMethod entities.

Currently, when creating a new product store using ofbizsetup component default 
data associated with the product store is loaded into the database using the 
following steps.

1. read default data from entity xml file and replace specific items in the 
read data and write to temp file.
2. use service=parseEntityXmlFile to load the processed file into database.

The issue with this method is that the temp file can present a problem when 
ofbiz is operating in multitenant mode.

The solution is to modify the relevant services so that no temp file needs 
generated.

  was:
Currently, when creating a new product store using ofbizsetup component default 
data associated with the product store is loaded into the database using the 
following steps.

1. read default data from entity xml file and replace specific items in the 
read data and write to temp file.
2. use service=parseEntityXmlFile to load the processed file into database.

The issue with this method is that the temp file can present a problem when 
ofbiz is operating in multitenant mode.

The solution is to modify the relevant services so that no temp file needs 
generated.


 ofbizsetup create product store cause exception
 ---

 Key: OFBIZ-5949
 URL: https://issues.apache.org/jira/browse/OFBIZ-5949
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai
 Attachments: OFBIZ-5949.patch


 The exception is caused by foreign key constraint violation between 
 ShipmentCostEstimate and  CarrierShipmentMethod entities.
 Currently, when creating a new product store using ofbizsetup component 
 default data associated with the product store is loaded into the database 
 using the following steps.
 1. read default data from entity xml file and replace specific items in the 
 read data and write to temp file.
 2. use service=parseEntityXmlFile to load the processed file into database.
 The issue with this method is that the temp file can present a problem when 
 ofbiz is operating in multitenant mode.
 The solution is to modify the relevant services so that no temp file needs 
 generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-5949) ofbizsetup create product store cause exception, remove use of temp file to load entity data

2015-01-08 Thread Wai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wai updated OFBIZ-5949:
---
Summary: ofbizsetup create product store cause exception, remove use of 
temp file to load entity data  (was: ofbizsetup create product store cause 
exception)

 ofbizsetup create product store cause exception, remove use of temp file to 
 load entity data
 

 Key: OFBIZ-5949
 URL: https://issues.apache.org/jira/browse/OFBIZ-5949
 Project: OFBiz
  Issue Type: Bug
  Components: framework
Affects Versions: Trunk
Reporter: Wai
 Attachments: OFBIZ-5949.patch


 The exception is caused by foreign key constraint violation between 
 ShipmentCostEstimate and  CarrierShipmentMethod entities.
 Currently, when creating a new product store using ofbizsetup component 
 default data associated with the product store is loaded into the database 
 using the following steps.
 1. read default data from entity xml file and replace specific items in the 
 read data and write to temp file.
 2. use service=parseEntityXmlFile to load the processed file into database.
 The issue with this method is that the temp file can present a problem when 
 ofbiz is operating in multitenant mode.
 The solution is to modify the relevant services so that no temp file needs 
 generated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: Documentation tools documentation

2015-01-08 Thread Ron Wheeler
Is this Gliffy http://www.gliffy.com/products/confluence-plugin/ rather 
than Giffy.


Ron

On 08/01/2015 4:14 AM, Jacques Le Roux wrote:
Yes I know that Shara thanks, if I get enough time I will re-create 
with Giffy, I was hoping Ron could ;)


Jacques

Le 08/01/2015 09:55, Sharan-F a écrit :

Hi Jacques

I think that if we already have an internal dedicated tool that we 
can use

for diagrams etc then it would be good to use it.

The issue that we had (and still have) is that some of the diagrams were
made using software that we dont have access to anymore so cant 
update them.
We didnt know about the internal tool and as a result  Ron suggested 
some
possible open source tools we could use and updated a diagram using 
one of

them.

I will update the documentation roadmap to say that we recommend 
using the

internal tool.

Thanks
Sharan







--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Documentation-tools-documentation-tp4659862p4660987.html

Sent from the OFBiz - Dev mailing list archive at Nabble.com.






--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: Documentation tools documentation

2015-01-08 Thread Jacques Le Roux

I put a link into my 1st message in this thread 
http://markmail.org/message/kjwmvlqscztbsxv2

Jacques

Le 08/01/2015 15:59, Ron Wheeler a écrit :

I am willing to look at converting to the internal tool, if there is some 
documentation on it and I can find a way to use it.

How do I get started?

Ron

On 08/01/2015 3:55 AM, Sharan-F wrote:

Hi Jacques

I think that if we already have an internal dedicated tool that we can use
for diagrams etc then it would be good to use it.

The issue that we had (and still have) is that some of the diagrams were
made using software that we dont have access to anymore so cant update them.
We didnt know about the internal tool and as a result  Ron suggested some
possible open source tools we could use and updated a diagram using one of
them.

I will update the documentation roadmap to say that we recommend using the
internal tool.

Thanks
Sharan







--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Documentation-tools-documentation-tp4659862p4660987.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.






Re: Documentation tools documentation

2015-01-08 Thread Ron Wheeler
I am willing to look at converting to the internal tool, if there is 
some documentation on it and I can find a way to use it.


How do I get started?

Ron

On 08/01/2015 3:55 AM, Sharan-F wrote:

Hi Jacques

I think that if we already have an internal dedicated tool that we can use
for diagrams etc then it would be good to use it.

The issue that we had (and still have) is that some of the diagrams were
made using software that we dont have access to anymore so cant update them.
We didnt know about the internal tool and as a result  Ron suggested some
possible open source tools we could use and updated a diagram using one of
them.

I will update the documentation roadmap to say that we recommend using the
internal tool.

Thanks
Sharan







--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/Documentation-tools-documentation-tp4659862p4660987.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.




--
Ron Wheeler
President
Artifact Software Inc
email: rwhee...@artifact-software.com
skype: ronaldmwheeler
phone: 866-970-2435, ext 102



Re: ListEntityIterator not close and extend form

2015-01-08 Thread Adrian Crum

I think I know what is causing this. I will take care of it.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 1/6/2015 3:15 PM, Nicolas Malin wrote:

Hello,

I think with the thread safe improvement on the screen engine we have an
other regression on extend form.

I detected it on sfa form and I have the confirmation of the reason with
this test :
* run the search on
https://localhost:8443/accounting/control/FindAgreement - no error in log
* apply this

Index: applications/accounting/widget/AgreementForms.xml
===
--- applications/accounting/widget/AgreementForms.xml(révision 1649945)
+++ applications/accounting/widget/AgreementForms.xml(copie de travail)
@@ -49,7 +49,19 @@
  /field
  /form

-form name=ListAgreements list-name=listIt target= title=
type=list paginate-target=FindAgreement
+form name=ListAgreements extends=ListAgreementsBase
+actions
+set field=entityName value=Agreement/
+service service-name=performFind result-map=result
result-map-list=listIt
+field-map field-name=inputFields
from-field=requestParameters/
+field-map field-name=entityName
from-field=entityName/
+field-map field-name=orderBy
from-field=parameters.sortField/
+field-map field-name=viewIndex from-field=viewIndex/
+field-map field-name=viewSize from-field=viewSize/
+/service
+/actions
+/form
+form name=ListAgreementsBase list-name=listIt target=
title= type=list paginate-target=FindAgreement
  odd-row-style=alternate-row default-table-style=basic-table
hover-bar header-row-style=header-row-2
  actions
  set field=entityName value=Agreement/

  * run the same search and on log we have :
 [java] 2015-01-06 23:33:45,026 |http-bio-8443-exec-4
|ServiceDispatcher |T| Sync service [accounting/performFind]
finished in [3] milliseconds
  [java] 2015-01-06 23:33:45,029 |http-bio-8443-exec-4
|ServiceDispatcher |T| Sync service [accounting/performFind]
finished in [3] milliseconds
  [java] 2015-01-06 23:33:45,056 |Finalizer
|EntityListIterator|E|
  [java]

  [java]  EntityListIterator Not Closed for Entity [Agreement],
caught in Finalize
  [java]


If I found the time I will try to check this week.

Nicolas


Problem with new UtilCodec code

2015-01-08 Thread Adrian Crum

When I navigate to

https://localhost:8443/accounting/control/paymentOverview?paymentId=8004

many exceptions are thrown and the screen fails to render.

I tried changing WidgetWorker.java line 74 to

localRequestName = UtilCodec.canonicalize(localRequestName, false, false);

which fixed the exceptions, but the generated link is wrong.

I don't know how to fix it.

--
Adrian Crum
Sandglass Software
www.sandglass-software.com


[jira] [Commented] (OFBIZ-5950) addOrderShipmentToShipment Should Return shipmentItemSeqId

2015-01-08 Thread Forrest Rae (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269903#comment-14269903
 ] 

Forrest Rae commented on OFBIZ-5950:


No problem!  I've been meaning to figure out how to submit changes, just hadn't 
been through the process just yet.  I suspect I'll have a few more of these 
over the next few months, and I'm happy to help.

This maybe a newbie question, but will this be backported to release13.07 
branch?  I doing my work based off a branch of release13.07, and just want to 
make sure things don't get weird between SVN and my repository.  If not, can I 
request that it does get backported?

 addOrderShipmentToShipment Should Return shipmentItemSeqId
 --

 Key: OFBIZ-5950
 URL: https://issues.apache.org/jira/browse/OFBIZ-5950
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Forrest Rae
Assignee: Jacques Le Roux
  Labels: patch
 Fix For: Upcoming Branch

 Attachments: addOrderShipmentToShipment-return-shipmentItemSeqId.patch


 addOrderShipmentToShipment service should return shipmentItemSeqId.  I 
 believe this is simply a convenience change.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)