[jira] [Commented] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Pranay Pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309338#comment-15309338
 ] 

Pranay Pandey commented on OFBIZ-7146:
--

Thanks Amardeep for explanation. 

> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Pranay Pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pranay Pandey reassigned OFBIZ-7146:


Assignee: Pranay Pandey  (was: Amardeep Singh Jhajj)

> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Pranay Pandey
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-05-31 Thread Arun Patidar (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309313#comment-15309313
 ] 

Arun Patidar commented on OFBIZ-7147:
-

Hi [~pfm.smits],

Here, my suggestion is to fix the data only, as hasParentType() working as 
expected. There should be empty parentTypeId field for 
invoiceTypeId="SALES_INVOICE" and  invoiceTypeId="PURCHASE_INVOICE".

Please let me know if you have any other solution or concern.

> Remove parentTypeId from InvoiceType data where InvoiceTypeId and 
> parentTypeId are equal
> 
>
> Key: OFBIZ-7147
> URL: https://issues.apache.org/jira/browse/OFBIZ-7147
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
>  invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
>  invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
> parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
> method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15309270#comment-15309270
 ] 

Yashwant Dhakad commented on OFBIZ-6026:


Thanks, Jacques. I will take care of all these suggestions in future.

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: quote, roles
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7061) Autocompletion for Compound Widget

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308092#comment-15308092
 ] 

Jacques Le Roux commented on OFBIZ-7061:


I will ask opinions on the dev ML...

> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7061) Autocompletion for Compound Widget

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7061.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Thanks James,

Your patch is in trunk at r1746302

Good work (but the tabs ;)), I simply replaced tabs by spaces in Java files and 
removed this commented out line
{code}
  http://www.w3.org/2001/XMLSchema-instance; 
xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
  {code}
in ExampleCompoundWidgets.xml

I mentionned that we decided to duplicate the simple-methods.xsd rather than 
updating all concerned files. Else we would have to update the attributes at 
document level for rest of the controllers, menus, forms, simple methods and 
screens. For example, in controller.xml, we would have to change
{code}
  xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd�
  {code}
to
{code}
  xmlns="http://ofbiz.apache.org/sc� 
xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd�>
  {code}
But especially we would have to use the same syntax with namespaces prefixes 
than in ExampleCompoundWidgets.xml (see example above). This can be discussed 
because with auto-completion it's not a big deal, but could be overwhelming for 
existing custom projects...



> Autocompletion for Compound Widget
> --
>
> Key: OFBIZ-7061
> URL: https://issues.apache.org/jira/browse/OFBIZ-7061
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7061.patch, OFBIZ-7061.patch, OFBIZ-7061.patch
>
>
> I am trying to enable auto-completion when coding compound widget.
> My plan as follows:
> 1. The following xsd will be modified to use namespace
> site-conf.xsd
> widget-form.xsd
> widget-screen.xsd
> widget-menu.xsd
> simple-methods.xsd
> For example, in site-conf.xsd, we add the following document level attribute
> {code}
> xmlns="http://ofbiz.apache.org/sc; 
> targetNamespace="http://ofbiz.apache.org/sc;
> {code}
> 2. Import the above schema into compound-widgets.xsd so that compound widgets 
> use only one consolidated schema. 
> 3. Update ExampleCompoundWidgets.xml to use the new compound-widgets.xsd. For 
> example
> {code}
> http://www.w3.org/2001/XMLSchema-instance; 
> xmlns:sc="http://ofbiz.apache.org/sc;
> xmlns:m="http://ofbiz.apache.org/m;
> xmlns:s="http://ofbiz.apache.org/s;
> xmlns:f="http://ofbiz.apache.org/f;
> xmlns:sm="http://ofbiz.apache.org/sm;
> 
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/compound-widgets.xsd;>
> 
> 
> 
>  path="component://example/widget/example/ExampleCompoundWidgets.xml"/>
> 
> 
>  auth="true"/> value="CompoundWidgets2"/>
> 
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets1"/>
>  page="component://example/widget/example/ExampleCompoundWidgets.xml#CompoundWidgets2"/>
> 
> .. the rest
> {code}
> 4. Change java code to support reading xml with namespace (i.e. xml for 
> compound widgets)
> 5. Update the attributes at document level for rest of the controllers, 
> menus, forms, simple methods and screens. Current setting will not work for 
> schema with a namespace. For example, in controller.xml, we will change 
> {code}
> xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/site-conf.xsd”
> {code} 
> to 
> {code}
> xmlns="http://ofbiz.apache.org/sc” 
> xsi:schemaLocation="http://ofbiz.apache.org/dtds/site-conf-ns.xsd”>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: CAS Single Sign On (SSO)

2016-05-31 Thread james yong
Thanks Jacques for the heads up. Yes, it is related to
https://issues.apache.org/jira/browse/OFBIZ-6963.


Jacques Le Roux wrote
> This is related with https://issues.apache.org/jira/browse/OFBIZ-6963,
> right?
> 
> Jacques
> 
> 
> Le 31/05/2016 à 17:31, james yong a écrit :
>> OFBiz is made up of several web applications.
>>
>> To allow the user to sign in only once, a unique token value is presented
>> for verification each time the user navigates to an unvisited web
>> application.
>>
>> I propose to add CAS SSO server as a component to OFBiz framework, and to
>> use it as a basis for OFBiz SSO solution.
>>
>> This new approach will allow us to use AJAX to update content partially,
>> without invalidating the menu links.
>>
>> CAS is now Apache-licensed. See https://www.apereo.org/projects/cas
>>
>>
>>
>> --
>> View this message in context:
>> http://ofbiz.135035.n4.nabble.com/CAS-Single-Sign-On-SSO-tp4681963.html
>> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>>





--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/CAS-Single-Sign-On-SSO-tp4681963p4681966.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


Re: CAS Single Sign On (SSO)

2016-05-31 Thread Jacques Le Roux

This is related with https://issues.apache.org/jira/browse/OFBIZ-6963, right?

Jacques


Le 31/05/2016 à 17:31, james yong a écrit :

OFBiz is made up of several web applications.

To allow the user to sign in only once, a unique token value is presented
for verification each time the user navigates to an unvisited web
application.

I propose to add CAS SSO server as a component to OFBiz framework, and to
use it as a basis for OFBiz SSO solution.

This new approach will allow us to use AJAX to update content partially,
without invalidating the menu links.

CAS is now Apache-licensed. See https://www.apereo.org/projects/cas



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/CAS-Single-Sign-On-SSO-tp4681963.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.





[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread james yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15308012#comment-15308012
 ] 

james yong commented on OFBIZ-6994:
---

Ok. Just raised the issue at 
http://ofbiz.135035.n4.nabble.com/CAS-Single-Sign-On-SSO-td4681963.html

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


CAS Single Sign On (SSO)

2016-05-31 Thread james yong
OFBiz is made up of several web applications. 

To allow the user to sign in only once, a unique token value is presented
for verification each time the user navigates to an unvisited web
application.

I propose to add CAS SSO server as a component to OFBiz framework, and to
use it as a basis for OFBiz SSO solution.

This new approach will allow us to use AJAX to update content partially,
without invalidating the menu links.

CAS is now Apache-licensed. See https://www.apereo.org/projects/cas 



--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/CAS-Single-Sign-On-SSO-tp4681963.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.


[jira] [Commented] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-05-31 Thread Pierre Smits (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307988#comment-15307988
 ] 

Pierre Smits commented on OFBIZ-7147:
-

That is not good. How do you suggest to fix this?


> Remove parentTypeId from InvoiceType data where InvoiceTypeId and 
> parentTypeId are equal
> 
>
> Key: OFBIZ-7147
> URL: https://issues.apache.org/jira/browse/OFBIZ-7147
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, Release Branch 15.12
>Reporter: Arun Patidar
>Assignee: Arun Patidar
>
> In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 
> Please refer AccountingTypeData.xml.
>  invoiceTypeId="PURCHASE_INVOICE"  parentTypeId="PURCHASE_INVOICE"/>
>  invoiceTypeId="SALES_INVOICE" parentTypeId="SALES_INVOICE"/>
> Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
> parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 
> This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
> method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307955#comment-15307955
 ] 

Jacques Le Roux commented on OFBIZ-6994:


Sounds like you need to make some noise about it, a special thread on dev ML 
for instance...

Remember that by getting no feedback lazy consensus can be used (ie go ahead 
and show)...

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6026.
--
   Resolution: Done
Fix Version/s: Upcoming Branch

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: quote, roles
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307919#comment-15307919
 ] 

Jacques Le Roux commented on OFBIZ-6026:


Thanks Yashwant,

Your slightly modified patch is in trunk at revision: 1746290  

I moved the party field line to have the lookup show. Note: in case of error 
the message is still awful, not a big deal

FYI: when the patches are "the same" you don't need to provide a patch for 
releases branches, we can easily backport. Anyway we normally don't backport 
improvements (because of possible regressions) and I'll not backport this one. 
Also please create your patch based on trunk HEAD, there was a small fuzz 
factor to be applied for QuoteServices.xml.

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: quote, roles
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux reassigned OFBIZ-6026:
--

Assignee: Jacques Le Roux  (was: Pierre Smits)

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread james yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307891#comment-15307891
 ] 

james yong commented on OFBIZ-6994:
---

I will work on OFBIZ-6963 when there is a consensus to use this approach.

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307874#comment-15307874
 ] 

Jacques Le Roux commented on OFBIZ-6994:


I'd them make this issue a subtask of OFBIZ-6963

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7148) Create New Product Config Item Content page form is missing field names

2016-05-31 Thread Ravi Lodhi (JIRA)
Ravi Lodhi created OFBIZ-7148:
-

 Summary:  Create New Product Config Item Content page form is 
missing field names
 Key: OFBIZ-7148
 URL: https://issues.apache.org/jira/browse/OFBIZ-7148
 Project: OFBiz
  Issue Type: Bug
  Components: product
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Step to regenerate:
1) Go to Catalog -> Configuration and select any config item from the list. 
(https://localhost:8443/catalog/control/FindProductConfigItems)
2) Navigate to Content page by clicking Content from the tab bar.
3) Under Create New Product Config Item Content section select a content type 
and go to prepare content.
4) Here is the problem where form doesn't have field name. 




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-6226) Webpos F4-F11 label mismatch

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-6226.
--
   Resolution: Fixed
Fix Version/s: (was: Upcoming Branch)
   15.12.01

This was finally fixed with OFBIZ-7144. To be checked though, is there still a 
mismatch?

> Webpos F4-F11 label mismatch
> 
>
> Key: OFBIZ-6226
> URL: https://issues.apache.org/jira/browse/OFBIZ-6226
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk, 12.04.05
>Reporter: Christian Carlow
>Assignee: Mridul Pathak
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6226-1204.patch, OFBIZ-6226-1412.patch, 
> OFBIZ-6226.patch, OFBIZ-6226.patch
>
>
> At webpos/control/Login the payGiftCard F4 button incorrectly uses label 
> WebPosShortcutF5 (Pay Pin) when it should be using WebPosShortcutF6.  The 
> same mismatch applies to all buttons higher than F4 and should be incremented 
> by 1 as well.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7144) Missing UiLabels for shortcuts in webpos

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-7144.
--
   Resolution: Fixed
Fix Version/s: 14.12.01

> Missing UiLabels for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 14.12.01
>
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7144) Missing UiLabels for shortcuts in webpos

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307813#comment-15307813
 ] 

Jacques Le Roux commented on OFBIZ-7144:


Thanks Amardeep,

I was curious about that so I checked and it's "a bit" more complicated (took 
me some time to sort it out). This is related with OFBIZ-6226 where Mridul 
Pathak committed in
Trunk - r1720910
14.12 - r1720916
12.04 - r1720930

But there was duplicated labels so I partially reverted (only the duplicated 
labels) at
Trunk - r1726529
14.12 - r1726539
12.04 - r1726540

Later I noticed r1720910 was committed in Trunk before R15.12 creation, so I 
reverted there also at revision: 1729098, but not partially hence the 
inconsistency.  But actually I should have reverted all everywhere! In other 
words it's a chance that it works in R15.12, because this was initially due to 
"an error".

So I agree about your patches and they are committed at r1746283 for both 
R14.12 and trunk. I did not take care of R12.04

Remains that Mridul and Suraj were somewhere right. Like them (I guess) I don't 
like the names of the labels, I believe that (eg) WebPosCheckout is far better 
than WebPosShortcutF7. So they were partiallly wrong at OFBIZ-6226, they 
duplicated labels but the names would be better if they were not refering to 
keyboard keys numbers...



> Missing UiLabels for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread james yong (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307778#comment-15307778
 ] 

james yong commented on OFBIZ-6994:
---

I am proposing to use this solution OFBIZ-6963 to solve the current problem.

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7147) Remove parentTypeId from InvoiceType data where InvoiceTypeId and parentTypeId are equal

2016-05-31 Thread Arun Patidar (JIRA)
Arun Patidar created OFBIZ-7147:
---

 Summary: Remove parentTypeId from InvoiceType data where 
InvoiceTypeId and parentTypeId are equal
 Key: OFBIZ-7147
 URL: https://issues.apache.org/jira/browse/OFBIZ-7147
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12
Reporter: Arun Patidar
Assignee: Arun Patidar


In InvoiceType data, we have invoiceTypeId value with same parentTypeId. 

Please refer AccountingTypeData.xml.




Here, invoiceTypeId="PURCHASE_INVOICE"  has "PURCHASE_INVOICE" as its 
parentTypeId. Same applies for invoiceTypeId="SALES_INVOICE" 

This also causes issue of infinite loop with EntityTypeUtil.hasParentType() 
method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: (was: OFBIZ-6026-15.12.patch)

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: OFBIZ-6026-15.12.patch

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: (was: OFBIZ-6026-trunk.patch)

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: (was: OFBIZ-6026-15.12.patch)

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: OFBIZ-6026-trunk.patch
OFBIZ-6026-15.12.patch

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch, 
> OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7142) Error on updating product categories from Product's Quick Admin page

2016-05-31 Thread Ravi Lodhi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-7142:
--
Assignee: Ashish Vijaywargiya  (was: Ravi Lodhi)

> Error on updating product categories from Product's Quick Admin page
> 
>
> Key: OFBIZ-7142
> URL: https://issues.apache.org/jira/browse/OFBIZ-7142
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ashish Vijaywargiya
> Attachments: OFBIZ-7142_1307.patch, OFBIZ-7142_1412.patch, 
> OFBIZ-7142_1512.patch, OFBIZ-7142_trunk.patch
>
>
> Step to regenerate:
> 1) Go to FindProduct screen and go to the detail screen of product.
> 2) Now navigate to the quick admin screen.
> 3) Update categories under category section. Here error message will appear.
> Cause:
> Cannot cast java.lang.String to java.sql.Timestamp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307754#comment-15307754
 ] 

Amardeep Singh Jhajj commented on OFBIZ-7146:
-

Thanks Pranay and Deepak for suggestions.

This issue occurs when we don't have any term associated with the quote. Demo 
Quote https://localhost:8443/ordermgr/control/QuoteReport?quoteId=CQ0001 has 
terms. This issue can be reproduced by creating a new quote where no terms 
initially associated to quote.

> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7142) Error on updating product categories from Product's Quick Admin page

2016-05-31 Thread Ravi Lodhi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-7142:
--
Attachment: OFBIZ-7142_trunk.patch
OFBIZ-7142_1307.patch
OFBIZ-7142_1412.patch
OFBIZ-7142_1512.patch

Converted fromDate from String to Timestamp when creating ProductCategoryMember 
record on updating categories from Quick Admin page. Uploaded patch for review.

> Error on updating product categories from Product's Quick Admin page
> 
>
> Key: OFBIZ-7142
> URL: https://issues.apache.org/jira/browse/OFBIZ-7142
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
> Attachments: OFBIZ-7142_1307.patch, OFBIZ-7142_1412.patch, 
> OFBIZ-7142_1512.patch, OFBIZ-7142_trunk.patch
>
>
> Step to regenerate:
> 1) Go to FindProduct screen and go to the detail screen of product.
> 2) Now navigate to the quick admin screen.
> 3) Update categories under category section. Here error message will appear.
> Cause:
> Cannot cast java.lang.String to java.sql.Timestamp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307726#comment-15307726
 ] 

Deepak Dixit commented on OFBIZ-7146:
-

Hi Amardeep,

Please check it with OFBIZ-7090, Similar issue has been fixed in mentioned 
ticket.

> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yashwant Dhakad updated OFBIZ-6026:
---
Attachment: OFBIZ-6026-trunk.patch
OFBIZ-6026-15.12.patch

Here are the patches for trunk and vendor 15.12 branches.

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-15.12.patch, 
> OFBIZ-6026-OrderQuoteRoles.patch, OFBIZ-6026-trunk.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6026) Creating a QuoteRole doesn't return to overview of QuoteRoles

2016-05-31 Thread Yashwant Dhakad (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307718#comment-15307718
 ] 

Yashwant Dhakad commented on OFBIZ-6026:


Verified the patch and found that success message not shown on the screen, so 
updated the patch and now shown the success message when added role 
successfully.

> Creating a QuoteRole doesn't return to overview of QuoteRoles
> -
>
> Key: OFBIZ-6026
> URL: https://issues.apache.org/jira/browse/OFBIZ-6026
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>  Labels: quote, roles
> Attachments: OFBIZ-6026-OrderQuoteRoles.patch
>
>
> Currently, when adding a QuoteRole to a Quote the user stays in the screen 
> associated with 'EditQuoteRole'. Thus the user has no confirmation that the 
> QuoteRole is added successfully.
> It is better to show the overviews of the quote roles.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Pranay Pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307706#comment-15307706
 ] 

Pranay Pandey commented on OFBIZ-7146:
--

Hi [~amardeepsj],

Please check this URL 
https://localhost:8443/ordermgr/control/QuoteReport?quoteId=CQ0001
This is Demo Quote PDF from OOTB OFBiz. There must be some data elements which 
are if missed causing the issue. Please provide the specific details while 
providing the patch for the issue.

Thanks


> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (OFBIZ-6837) relocate .ftl files in the specialpurpose/webpos component

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15223262#comment-15223262
 ] 

Jacques Le Roux edited comment on OFBIZ-6837 at 5/31/16 1:09 PM:
-

This was reopened because of an history issue and finally done with 
r1737557+1737565+1737566


was (Author: jacques.le.roux):
This was reopened because of an history issue and finally done with 
r+1737557+1737565+1737566

> relocate .ftl files in the specialpurpose/webpos component
> --
>
> Key: OFBIZ-6837
> URL: https://issues.apache.org/jira/browse/OFBIZ-6837
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/webpos
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6837-webpos-ftl-relocation.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7146:

Attachment: OFBIZ-7146-ScreenShot.png

> Quote PDF is not opening, getting error
> ---
>
> Key: OFBIZ-7146
> URL: https://issues.apache.org/jira/browse/OFBIZ-7146
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
> Attachments: OFBIZ-7146-ScreenShot.png
>
>
> Please find attached screenshot of error.
> Steps to regenerate:
> 1. Go to https://localhost:8443/ordermgr/control/FindQuote
> 2. Click on "Create New Quote" button and create quote.
> 3. Now click on pdf on view quote screen, error occurs in rendering pdf.
> I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7141) Upgrade apache fop to 2.1

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307698#comment-15307698
 ] 

Jacques Le Roux commented on OFBIZ-7141:


Also with xmlgraphics-commons updated  to 2.1.

> Upgrade apache fop to 2.1
> -
>
> Key: OFBIZ-7141
> URL: https://issues.apache.org/jira/browse/OFBIZ-7141
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> Upgrade apache fop to 2.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7146) Quote PDF is not opening, getting error

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)
Amardeep Singh Jhajj created OFBIZ-7146:
---

 Summary: Quote PDF is not opening, getting error
 Key: OFBIZ-7146
 URL: https://issues.apache.org/jira/browse/OFBIZ-7146
 Project: OFBiz
  Issue Type: Bug
  Components: order
Affects Versions: Release Branch 15.12, Trunk, Release Branch 14.12, 
Release Branch 13.07
Reporter: Amardeep Singh Jhajj
Assignee: Amardeep Singh Jhajj


Please find attached screenshot of error.

Steps to regenerate:

1. Go to https://localhost:8443/ordermgr/control/FindQuote
2. Click on "Create New Quote" button and create quote.
3. Now click on pdf on view quote screen, error occurs in rendering pdf.

I will provide the patch for fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Closed] (OFBIZ-7141) Upgrade apache fop to 2.1

2016-05-31 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-7141.
---
   Resolution: Fixed
 Assignee: Deepak Dixit
Fix Version/s: Upcoming Branch

> Upgrade apache fop to 2.1
> -
>
> Key: OFBIZ-7141
> URL: https://issues.apache.org/jira/browse/OFBIZ-7141
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Deepak Dixit
>Assignee: Deepak Dixit
> Fix For: Upcoming Branch
>
>
> Upgrade apache fop to 2.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7141) Upgrade apache fop to 2.1

2016-05-31 Thread Deepak Dixit (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit updated OFBIZ-7141:

Description: Upgrade apache fop to 2.1

> Upgrade apache fop to 2.1
> -
>
> Key: OFBIZ-7141
> URL: https://issues.apache.org/jira/browse/OFBIZ-7141
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Deepak Dixit
>
> Upgrade apache fop to 2.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7141) Upgrade apache fop to 2.1

2016-05-31 Thread Deepak Dixit (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307678#comment-15307678
 ] 

Deepak Dixit commented on OFBIZ-7141:
-

This has been done at r#1746270

> Upgrade apache fop to 2.1
> -
>
> Key: OFBIZ-7141
> URL: https://issues.apache.org/jira/browse/OFBIZ-7141
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Deepak Dixit
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: JIRA Ticket for Documentation Effort

2016-05-31 Thread Pranay Pandey
Hi Community,

Here is the link to ticket for the renewal of OFBiz Tutorial -
https://issues.apache.org/jira/browse/OFBIZ-7145

Please put your comments on the ticket for the improvements you would like
to see in the existing tutorial or any ideas that you would like to
incorporate in this new tutorial.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Mon, May 23, 2016 at 4:56 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Thanks for giving thoughts to it.
> Looks like everyone is in favor. Will plan the effort further with JIRA
> Ticket.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Sat, May 21, 2016 at 5:10 PM, Pierre Smits 
> wrote:
>
>> +1
>> Documentation is also a product of the project. Incorporating it into
>> release notes, helps communication. Helps adoption.
>>
>> Pierre Smits
>>
>> ORRTIZ.COM 
>> OFBiz based solutions & services
>>
>> OFBiz Extensions Marketplace
>> http://oem.ofbizci.net/oci-2/
>>
>> On Sat, May 21, 2016 at 1:18 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> > +1!
>> >
>> > Things are clearer in/with Jira
>> >
>> > Jacques
>> >
>> >
>> >
>> > Le 21/05/2016 à 06:59, Pranay Pandey a écrit :
>> >
>> >> Hi Community,
>> >>
>> >> What do you think of this option, should we create a Ticket in JIRA for
>> >> any
>> >> of the documentation effort?
>> >>
>> >> I am going to start work on OFBiz Beginners Tutorial overhaul(Will
>> create
>> >> a
>> >> new one and open it for review to the community for feedback) and was
>> >> thinking to map the effort with a JIRA Ticket. Please let me know your
>> >> thoughts.
>> >>
>> >>
>> >>
>> >> Best regards,
>> >>
>> >> Pranay Pandey
>> >> HotWax Systems
>> >> http://www.hotwaxsystems.com/
>> >>
>> >>
>> >
>>
>
>


[jira] [Created] (OFBIZ-7145) Renew OFBiz Tutorial

2016-05-31 Thread Pranay Pandey (JIRA)
Pranay Pandey created OFBIZ-7145:


 Summary: Renew OFBiz Tutorial 
 Key: OFBIZ-7145
 URL: https://issues.apache.org/jira/browse/OFBIZ-7145
 Project: OFBiz
  Issue Type: Task
  Components: Confluence
Reporter: Pranay Pandey
Assignee: Pranay Pandey


The plan is to go through existing OFBiz tutorial and renew it. I am thinking 
of starting up from scratch instead of making any edits to the existing one. 
The new version will be available to everyone for review anytime. 

High level plan-
# Making it short, easy to understand and to follow. 
# Divide into multiple child documents based on complexity level. Basically a 
trail of tutorials for developers, where one can feel confident to start using 
the framework for building custom solutions.
# Gather all existing developer tutorials at one place.
# Followed by a series of video tutorials to make it a handy reference for 
those developers who like learning things from videos.
# Will be following the latest OFBiz release i.e. 15.12

Any ideas are welcome, please put your ideas for improvement as a comment on 
this ticket. You can also put anything on your wishlist that you wanted to see 
in OFBiz tutorial.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7144) Missing UiLabels for shortcuts in webpos

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-7144:
---
Summary: Missing UiLabels for shortcuts in webpos  (was: Missing UiLables 
for shortcuts in webpos)

> Missing UiLabels for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread Jacques Le Roux (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-6994:
---
Description: 
Problem
===

1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
login credentials, enter the credentials.
 
2) Click on the help button on the top right.

3) Navigate to another application, and the login screen appears again.

  was:
Problem
===

1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
login credentials. 
 
2) Click on the help button on the top right.

3) Navigate to another application, and the login screen appears again.


> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials, enter the credentials.
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6994) Multiple logins required when using help screen before navigating to another application

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307500#comment-15307500
 ] 

Jacques Le Roux commented on OFBIZ-6994:


It works if you close the help window; I guess we should do that automatically 
before switching to another app

> Multiple logins required when using help screen before navigating to another 
> application
> 
>
> Key: OFBIZ-6994
> URL: https://issues.apache.org/jira/browse/OFBIZ-6994
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: james yong
>Priority: Minor
>
> Problem
> ===
> 1) Go to https://localhost:8443/catalog/ and a login screen appears requiring 
> login credentials. 
>  
> 2) Click on the help button on the top right.
> 3) Navigate to another application, and the login screen appears again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7144) Missing UiLables for shortcuts in webpos

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7144:

Assignee: Jacques Le Roux  (was: Amardeep Singh Jhajj)

> Missing UiLables for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Jacques Le Roux
>Priority: Minor
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-7144) Missing UiLables for shortcuts in webpos

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307485#comment-15307485
 ] 

Amardeep Singh Jhajj commented on OFBIZ-7144:
-

Hi [~jacques.le.roux],

I found missing UiLabels for shortcuts in webpos in trunk and Release 14.12, it 
was committed in Release 15.12 at -r1729098. I think you somehow missed to 
commit it in trunk and Release 14.12. Please have a look on patches attached 
and commit it in their respective branches.

Thanks.

> Missing UiLables for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Minor
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7144) Missing UiLables for shortcuts in webpos

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7144:

Attachment: OFBIZ-7144-Release14.12.patch
OFBIZ-7144-trunk.patch

> Missing UiLables for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Minor
> Attachments: OFBIZ-7144-Release14.12.patch, 
> OFBIZ-7144-ScreenShot.png, OFBIZ-7144-trunk.patch
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7144) Missing UiLables for shortcuts in webpos

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Amardeep Singh Jhajj updated OFBIZ-7144:

Attachment: OFBIZ-7144-ScreenShot.png

> Missing UiLables for shortcuts in webpos
> 
>
> Key: OFBIZ-7144
> URL: https://issues.apache.org/jira/browse/OFBIZ-7144
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/webpos
>Affects Versions: Release Branch 14.12, Trunk
>Reporter: Amardeep Singh Jhajj
>Assignee: Amardeep Singh Jhajj
>Priority: Minor
> Attachments: OFBIZ-7144-ScreenShot.png
>
>
> Please find attached screenshot.
> Steps to regenerate:
> 1. Go to https://localhost:8443/webpos/control/main
> I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7144) Missing UiLables for shortcuts in webpos

2016-05-31 Thread Amardeep Singh Jhajj (JIRA)
Amardeep Singh Jhajj created OFBIZ-7144:
---

 Summary: Missing UiLables for shortcuts in webpos
 Key: OFBIZ-7144
 URL: https://issues.apache.org/jira/browse/OFBIZ-7144
 Project: OFBiz
  Issue Type: Bug
  Components: specialpurpose/webpos
Affects Versions: Trunk, Release Branch 14.12
Reporter: Amardeep Singh Jhajj
Assignee: Amardeep Singh Jhajj
Priority: Minor


Please find attached screenshot.

Steps to regenerate:

1. Go to https://localhost:8443/webpos/control/main

I will provide the patch for it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


buildbot success in on ofbiz-trunk

2016-05-31 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk while 
building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk/builds/750

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: orcus_ubuntu

Build Reason: The AnyBranchScheduler scheduler named 'on-ofbiz-commit' 
triggered this build
Build Source Stamp: [branch ofbiz/trunk] 1746254
Blamelist: jleroux

Build succeeded!

Sincerely,
 -The Buildbot





[jira] [Commented] (OFBIZ-6849) Use only HTTPS in OFBiz

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307457#comment-15307457
 ] 

Jacques Le Roux commented on OFBIZ-6849:


At revision: 1746254, I fixed and issue with xmlrpc tests. The tests did not 
pass because of xmlrpc. Simply adding it in http.request-map.list in 
url.properties and like for SOAPService request setting  did it.

> Use only HTTPS in OFBiz
> ---
>
> Key: OFBIZ-6849
> URL: https://issues.apache.org/jira/browse/OFBIZ-6849
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6849.patch, OFBIZ-6849.patch, OFBIZ-6849.patch
>
>
> I recently (~4 weeks ago) started the ["Performance over security, is that 
> reasonable?"|http://markmail.org/message/ubgacfzfxvlvlqva] thread on dev ML. 
> I think I did not explain me well then. I must say it's easy to drown down in 
> details with this subject when you want to illustrate the reasons.
> So instead of only answering on the dev ML, I decided it will be good to 
> create a Jira task with maybe related tasks, here it is.
> For now I consider it only an improvement, but since it's a security matter 
> we can discuss backporting later.
> \\
> 
> h2. TL;DR
> h3. Performance over security?
> So why was this thread opposing performance and security? First we need to 
> understand that here performance stands for HTTP and security for HTTPS.
> h5. Why is HTTP standing for performance?
> Actually is now not much performance difference between the 2 protocols, but 
> you can't cache HTTPS requests and it sometimes (inter-continental requests) 
> matters.
> h3. And why the question about being reasonable or not?
> I think it's unreasonable to put performance over security. And nowadays you 
> are not secure when you use HTTP mixed with HTTPS. Most of the time when you 
> mix both is because you want to identity an user using a sessionId. So with 
> HTTPS, after the user started with HTTP. As concisely explained Forrest in 
> the above referenced thread
> {quote}
> If you're switching between HTTPS and HTTP based on some criteria, an 
> attacker can leverage that to trick the user into all kind of things.
> {quote}
> It's also well and simply explained (with other things) in [this 
> article|http://arstechnica.com/business/2011/03/https-is-great-here-is-why-everyone-needs-to-use-it-so-ars-can-too/]:
> {quote}
> The HTTP spec defines a “Secure” flag for cookies, which instructs the 
> browser to only send that cookie value over SSL. If sites set that cookie 
> like they’re supposed to, then yes, SSL is helping you out. Most sites don’t, 
> however, and browsers will happily send the sensitive cookies over 
> unencrypted HTTP. Our hypothetical skeezebag really just needs some way to 
> trick you into opening a normal HTTP URL, maybe by e-mailing you a link to 
> http://yourbank.com/a-picture-of-ponies-and-rainbows.gif so he can sniff the 
> plain-text cookie off your unencrypted HTTP request, or by surreptitiously 
> embedding a JavaScript file via some site’s XSS vulnerability.
> {quote}
> Of course if you site is only showing things but nobody has never to 
> identify, then you are not at risk and HTTP only is perfect. But with 
> ecommerce kind of site or such, it's rarely the case, most of the time users 
> need to identify!
> 
> \\
> So why are people still mixing HTTP and HTTPS on their site? In the 1st 
> answer at 
> [\[1\]|https://security.stackexchange.com/questions/4369/why-is-https-not-the-default-protocol#answer-4376]
>  Thomas Pornin and others gave some interesting points and answers. At 
> [\[2\]|http://arstechnica.com/business/2011/03/https-is-more-secure-so-why-isnt-the-web-using-it/]
>  Yves Lafon gave also a good summary even if a bit old now. I took some 
> questions/answers from 
> [\[3\]|https://stackoverflow.com/questions/2746047/why-not-use-https-for-everything]
>  also. So you might check those links by yourself, here is an abstract:
> # *"Some browsers may not support SSL"* Only old Lynx versions, negligible
> # *"Connection initiation requires some extra network roundtrips"* Negligible 
> but for sites which serve mostly static contents, see "static content takes a 
> hit" below.
> # *"the SSL initial key exchange adds to the latency"* As [completely 
> explained 
> here|https://security.stackexchange.com/questions/4369/why-is-https-not-the-default-protocol#comment-6560]:
>  "most TLS server use a RSA key and the client part of RSA is cheap (the 
> server incurs most of the cost in RSA)". Still better to have [not too short 
> sessions as explained 
> here|https://stackoverflow.com/questions/149274/http-vs-https-performance]
> # *"static 

[jira] [Commented] (OFBIZ-7137) ExampleReportPdfOptions no longer works

2016-05-31 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307451#comment-15307451
 ] 

Jacques Le Roux commented on OFBIZ-7137:


This is all with trunk HEAD, right?

> ExampleReportPdfOptions no longer works
> ---
>
> Key: OFBIZ-7137
> URL: https://issues.apache.org/jira/browse/OFBIZ-7137
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Jacques Le Roux
>Priority: Minor
> Attachments: Screen Shot 2016-05-30 at 6.39.46 PM.png, Screen Shot 
> 2016-05-30 at 6.40.09 PM.png
>
>
> While working on OFBIZ-7136 "Ugrade PDFBox to 1.8.12 (or 2.0.1?) due to 
> vulnerability" I noticed these PDF options no longer work. This was done with 
> OFBIZ-6504 "how to Create PDF with password Protected in Ofbiz"
> # I did not get any error with ExampleReportPdfOptions but a blank screen. 
> # Here is the error in log for ExampleReportPdfBarcode 
> {code}
> 2016-05-27 14:11:35,737 |http-nio-8443-exec-7 |FOUserAgent   
> |E| Image not available. URI: 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=b
> mp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for /examp
> le/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
> org.apache.xmlgraphics.image.loader.ImageException: The file format is not 
> supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201
> ormat=bmp=UTF-8=true=20=20
> at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
> at org.apache.fop.fo.FObj.processNode(FObj.java:129) [fop-2.0.jar:?]
> at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
> at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> [...]
> 2016-05-27 14:11:36,084 |http-nio-8443-exec-7 |FOUserAgent   
> |E| Image not found. URI: 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=bmp
> ncoding=UTF-8=true=20=20. 
> (No context info available)
> 2016-05-27 14:11:36,088 |http-nio-8443-exec-7 |ServerHitBin  
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2016-05-27 14:11:36,099 |http-nio-8443-exec-7 |ControlServlet
> |T| [[[ExampleReportPdfBarcode(Domain:https://localhost)] Request Done- 
> total:1.131,since last([ExampleReportPdf...):1.131]]
> {code}
> But, as Pierre mentionned in a comment below this is already reported at 
> OFBIZ-7034



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7143) Error on cancelling agreement

2016-05-31 Thread Ravi Lodhi (JIRA)
Ravi Lodhi created OFBIZ-7143:
-

 Summary: Error on cancelling agreement
 Key: OFBIZ-7143
 URL: https://issues.apache.org/jira/browse/OFBIZ-7143
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Trunk
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi
Priority: Minor


Step to regenerate:
1) Go to Agreements screen under Accounting 
component.(https://localhost:8443/accounting/control/FindAgreement)
2) Cancel an agreement from the list.
3) See the error on Search Results section.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7142) Error on updating product categories from Product's Quick Admin page

2016-05-31 Thread Ravi Lodhi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-7142:
--
Component/s: product

> Error on updating product categories from Product's Quick Admin page
> 
>
> Key: OFBIZ-7142
> URL: https://issues.apache.org/jira/browse/OFBIZ-7142
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>
> Step to regenerate:
> 1) Go to FindProduct screen and go to the detail screen of product.
> 2) Now navigate to the quick admin screen.
> 3) Update categories under category section. Here error message will appear.
> Cause:
> Cannot cast java.lang.String to java.sql.Timestamp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7142) Error on updating product categories from Product's Quick Admin page

2016-05-31 Thread Ravi Lodhi (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ravi Lodhi updated OFBIZ-7142:
--
Affects Version/s: Trunk

> Error on updating product categories from Product's Quick Admin page
> 
>
> Key: OFBIZ-7142
> URL: https://issues.apache.org/jira/browse/OFBIZ-7142
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ravi Lodhi
>Assignee: Ravi Lodhi
>
> Step to regenerate:
> 1) Go to FindProduct screen and go to the detail screen of product.
> 2) Now navigate to the quick admin screen.
> 3) Update categories under category section. Here error message will appear.
> Cause:
> Cannot cast java.lang.String to java.sql.Timestamp



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7142) Error on updating product categories from Product's Quick Admin page

2016-05-31 Thread Ravi Lodhi (JIRA)
Ravi Lodhi created OFBIZ-7142:
-

 Summary: Error on updating product categories from Product's Quick 
Admin page
 Key: OFBIZ-7142
 URL: https://issues.apache.org/jira/browse/OFBIZ-7142
 Project: OFBiz
  Issue Type: Bug
Reporter: Ravi Lodhi
Assignee: Ravi Lodhi


Step to regenerate:
1) Go to FindProduct screen and go to the detail screen of product.
2) Now navigate to the quick admin screen.
3) Update categories under category section. Here error message will appear.

Cause:
Cannot cast java.lang.String to java.sql.Timestamp




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307303#comment-15307303
 ] 

Taher Alkhateeb commented on OFBIZ-6783:


Okay fixed everything and committed in r1746236

I think if we continue on this trend then the start component is going to be so 
lean it can compete in the Olympics. Okay, I have my eye now on that darned 
ClassLoader

> Refactor the start component
> 
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component 
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at 
> Start! Given that this is an important component, I will provide a patch to 
> be reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Jacopo Cappellato (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307297#comment-15307297
 ] 

Jacopo Cappellato commented on OFBIZ-6783:
--

You are indeed right Taher! I didn't notice it because I don't use Eclipse :-)

> Refactor the start component
> 
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component 
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at 
> Start! Given that this is an important component, I will provide a patch to 
> be reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307283#comment-15307283
 ] 

Taher Alkhateeb commented on OFBIZ-6783:


Hi Jacopo,

The patch you provided breaks in eclipse. I think the reason is that you 
removed the entire line when you should just remove the "excluding" clause

In other words, you change from:
{code:xml}

{code}

to
{code:xml}

{code}

> Refactor the start component
> 
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component 
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at 
> Start! Given that this is an important component, I will provide a patch to 
> be reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6783) Refactor the start component

2016-05-31 Thread Taher Alkhateeb (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15307272#comment-15307272
 ] 

Taher Alkhateeb commented on OFBIZ-6783:


Nice catch Jacopo, I always forget to do a second grep on hidden files. Or 
maybe I need to learn a combo to grep everything in one shot.

> Refactor the start component
> 
>
> Key: OFBIZ-6783
> URL: https://issues.apache.org/jira/browse/OFBIZ-6783
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Taher Alkhateeb
>Assignee: Taher Alkhateeb
>  Labels: framework, main, refactoring, start
> Attachments: OFBIZ-6783-hiddenfiles.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, OFBIZ-6783.patch, 
> OFBIZ-6783.patch, StartCommandUtil.java, error.log, ofbiz.log
>
>
> Looking at the main method and design of Start.java and the start component 
> overall looks ugly. The things I would like to fix so far are:
> - the files are too long
> - some variables are not even needed (loaderArgs?)
> - the level of abstraction is wrong
> - main throws an exception!
> - the arguments processing logic is terrible, need to move it to commons-cli
> It's just so messy and ugly to look at. So for me refactoring starts at 
> Start! Given that this is an important component, I will provide a patch to 
> be reviewed by the community before committing just to be on the safe side.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)