Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

[Jacques Le Roux]

Yes thanks Pierre, just found it in svn annotations, then understood your 
answer :/

Jacques


Le 20/03/2017 à 11:22, Pierre Smits a écrit :

Hey Jacques,

This appears to be the related issue: OFBIZ-7848

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Mar 20, 2017 at 11:19 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


What is the situation here, please? Is there a Jira? Should I take care of
that?

Thanks

Jacques



Le 01/09/2016 à 15:28, Harsh Vijaywargiya a écrit :


Thanks Jacques,

Sounds good. I will take care of this suggestion in coming commits.

Thanks & Regards,
Harsh
On Wednesday 31 August 2016 04:51 PM, Jacques Le Roux wrote:


OK I checked, the commented out lines were from pre Apache Era. So
indeed it was not an easy decision.

For

 public void print(List arr, BigDecimal quantity, int depth,
boolean excludeWIPs) {

I believe the lines were commented out because it's a recursive method.
I still believe we should never let exceptions escape. The probability it
happens is low. Another reason to not let it escape: it should not clutter
the log but when really needed.

So I simply suggest to add

 Debug.logError(e, "Problem calling the " + serviceName + " service
(called by the createManufacturingOrder service)", module);

there.

Globally here is my take

Index: applications/manufacturing/src/main/java/org/apache/ofbiz/
manufacturing/bom/BOMNode.java
===
--- 
applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
(revision 1758522)
+++ 
applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
(working copy)
@@ -292,7 +292,7 @@
  variantProduct =
variantProducts.get(0);
  }
  } catch (GenericServiceException e) {
-if (Debug.infoOn())
Debug.logInfo("Error calling getProductVariant service " + e.getMessage(),
module);
+Debug.logError("Error calling
getProductVariant service " + e.getMessage(), module);
  }
  if (variantProduct != null) {
  newNode = new
BOMNode(variantProduct, dispatcher, userLogin);
@@ -433,7 +433,7 @@
  this.quantity = calcQuantity;
  }
  } catch (GenericServiceException e) {
-
+Debug.logError(e, "Problem calling the " + serviceName
+ " service (called by the createManufacturingOrder service)", module);
  }
  } else {
  this.quantity = quantity.multiply(quantityMult
iplier).multiply(scrapFactor);
@@ -573,7 +573,7 @@
  }
  }
  } catch (GenericEntityException e) {
-
+Debug.logError(e, "Problem calling the
getManufacturingComponents service", module);
  }
  }
  return UtilMisc.toMap("productionRunId", productionRunId,
"endDate", endDate);

What to you think?

Jacques


Le 30/08/2016 à 11:21, Jacques Le Roux a écrit :


Le 30/08/2016 à 08:29, Jacopo Cappellato a écrit :


Highlighting code that could be improved rather than fixing it is a
good
way to help potential contributors.
However, and I think this is the reason for Scott's remark, you should
not
have addressed your review/request to individual committer/contributor
(if
the defect you have noticed was not introduced by their contribution,
as in
this case).


OK, got the subtle nuance, thanks

Jacques

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

[Taher Alkhateeb]

Hello Shi, if you have other topics to discuss then i suggest to start a
new thread

On Mar 21, 2017 6:50 AM, "Shi Jinghai"  wrote:

> Sorry, I'm afraid I'm wrong, I cannot add a NER component to OFBiz, as the
> license of NER is GPL v2+, which is not compatible with our Apache License
> V2, see:
> http://www.apache.org/licenses/GPL-compatibility.html
>
> -邮件原件-
> 发件人: Shi Jinghai [mailto:huaru...@hotmail.com]
> 发送时间: 2017年3月21日 9:14
> 收件人: dev@ofbiz.apache.org
> 主题: Re: [SKYPE CALL] Mentoring Support for New and Existing Committers
>
> +1 if we can join the google summer of code. I asked my niece to build a
> NER component last summer before her graduate school, she did it in one
> month. So I think we can make some efforts by the summer-code way in OFBiz
> clouding and AI areas.
>
> BTW, I'll submit the NER component in OFBIZ-7954 later.
>
> Shi Jinghai
>
> -邮件原件-
> 发件人: Sharan Foga [mailto:sha...@apache.org]
> 发送时间: 2017年3月21日 1:19
> 收件人: dev@ofbiz.apache.org
> 主题: Re: [SKYPE CALL] Mentoring Support for New and Existing Committers
>
> Hi Everyone
>
> I'm posting a reminder to see if anyone else would like to participate in
> this call.
>
> At this stage we have 6 attendees of which 4 are mentors. Based on the
> locations (Europe, Kuwait and India) we have a good range of potential
> meeting times.
>
> I'd like to really encourage people to participate to find out how having
> a mentor could really help (Why not think of it as our own OFBiz Summer of
> Code :-) and a chance to do something that will benefit the project and
> also help you learn something new.
>
> Perhaps you want to take on a particular task or area but are unsure where
> to start? Perhaps you would like to get started writing or converting some
> of our plug-ins? What about doing some simple cleanup and refactoring?
> Having someone to speak to can help you to get started on whatever it is
> you want to do.
>
> Anyway I'll leave this open for a few more days and then will look at
> scheduling a call for next week.
>
> Thanks
> Sharan
>
> On 2017-03-13 15:01 (+0100), "Sharan Foga" wrote:
> > Hi Everyone
> >
> > I'm bringing up a topic that has been raised in the past regarding
> committer mentoring. [1][2][3].
> >
> > As  project we don't have any on-boarding process to help new committers
> or support existing ones. Sometimes people assume that by the time you
> become a committer then you should know how everything works! (and that
> isn't always the case. )
> >
> > In the past year with the re-factoring, the framework, plugins, gradle
> etc we have a lot of changes happening and people may be a little
> overwhelmed about how they can continue to contribute. Getting feedback and
> sharing knowledge helps make people more confident in their way of working
> and contributions, and the end result is better code which is a great thing
> for the project.
> >
> > So I would  like invite all of our committers (and also any interested
> contributors) to a Skype call to about mentoring and the support that you
> can get from our more experienced project committers. The call will be
> approximately 1 hour and will include an opportunity to ask questions.
> >
> > If you'd like to attend then please add your details, location and
> timezone to the table at the bottom of the following wiki page so that I
> can find a suitable time for everyone.
> >
> > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors
> >
> > I really think that mentoring will help empower committers more,
> standardise work and coding practices and generally improve our working
> relationships.
> >
> > As always, feedback welcome and please don't forget to add your name if
> you'd like to attend.
> >
> > Thanks
> > Sharan
> >
> > [1]  https://s.apache.org/FzI0
> > [2]  https://s.apache.org/60t1
> > [3]  https://s.apache.org/GWtv
> >
>

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

[Shi Jinghai]

Sorry, I'm afraid I'm wrong, I cannot add a NER component to OFBiz, as the 
license of NER is GPL v2+, which is not compatible with our Apache License V2, 
see:
http://www.apache.org/licenses/GPL-compatibility.html

-邮件原件-
发件人: Shi Jinghai [mailto:huaru...@hotmail.com] 
发送时间: 2017年3月21日 9:14
收件人: dev@ofbiz.apache.org
主题: Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

+1 if we can join the google summer of code. I asked my niece to build a NER 
component last summer before her graduate school, she did it in one month. So I 
think we can make some efforts by the summer-code way in OFBiz clouding and AI 
areas.

BTW, I'll submit the NER component in OFBIZ-7954 later.

Shi Jinghai

-邮件原件-
发件人: Sharan Foga [mailto:sha...@apache.org] 
发送时间: 2017年3月21日 1:19
收件人: dev@ofbiz.apache.org
主题: Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Hi Everyone

I'm posting a reminder to see if anyone else would like to participate in this 
call.

At this stage we have 6 attendees of which 4 are mentors. Based on the 
locations (Europe, Kuwait and India) we have a good range of potential meeting 
times. 

I'd like to really encourage people to participate to find out how having a 
mentor could really help (Why not think of it as our own OFBiz Summer of Code 
:-) and a chance to do something that will benefit the project and also help 
you learn something new.

Perhaps you want to take on a particular task or area but are unsure where to 
start? Perhaps you would like to get started writing or converting some of our 
plug-ins? What about doing some simple cleanup and refactoring? Having someone 
to speak to can help you to get started on whatever it is you want to do.

Anyway I'll leave this open for a few more days and then will look at 
scheduling a call for next week.

Thanks
Sharan

On 2017-03-13 15:01 (+0100), "Sharan Foga" wrote: 
> Hi Everyone
> 
> I'm bringing up a topic that has been raised in the past regarding committer 
> mentoring. [1][2][3]. 
>  
> As  project we don't have any on-boarding process to help new committers or 
> support existing ones. Sometimes people assume that by the time you become a 
> committer then you should know how everything works! (and that isn't always 
> the case. )
> 
> In the past year with the re-factoring, the framework, plugins, gradle etc we 
> have a lot of changes happening and people may be a little overwhelmed about 
> how they can continue to contribute. Getting feedback and sharing knowledge 
> helps make people more confident in their way of working and contributions, 
> and the end result is better code which is a great thing for the project.
> 
> So I would  like invite all of our committers (and also any interested 
> contributors) to a Skype call to about mentoring and the support that you can 
> get from our more experienced project committers. The call will be 
> approximately 1 hour and will include an opportunity to ask questions. 
> 
> If you'd like to attend then please add your details, location and timezone 
> to the table at the bottom of the following wiki page so that I can find a 
> suitable time for everyone.
> 
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors
> 
> I really think that mentoring will help empower committers more, standardise 
> work and coding practices and generally improve our working relationships. 
> 
> As always, feedback welcome and please don't forget to add your name if you'd 
> like to attend.
> 
> Thanks
> Sharan
> 
> [1]  https://s.apache.org/FzI0
> [2]  https://s.apache.org/60t1
> [3]  https://s.apache.org/GWtv
> 

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

[Shi Jinghai]

+1 if we can join the google summer of code. I asked my niece to build a NER 
component last summer before her graduate school, she did it in one month. So I 
think we can make some efforts by the summer-code way in OFBiz clouding and AI 
areas.

BTW, I'll submit the NER component in OFBIZ-7954 later.

Shi Jinghai

-邮件原件-
发件人: Sharan Foga [mailto:sha...@apache.org] 
发送时间: 2017年3月21日 1:19
收件人: dev@ofbiz.apache.org
主题: Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

Hi Everyone

I'm posting a reminder to see if anyone else would like to participate in this 
call.

At this stage we have 6 attendees of which 4 are mentors. Based on the 
locations (Europe, Kuwait and India) we have a good range of potential meeting 
times. 

I'd like to really encourage people to participate to find out how having a 
mentor could really help (Why not think of it as our own OFBiz Summer of Code 
:-) and a chance to do something that will benefit the project and also help 
you learn something new.

Perhaps you want to take on a particular task or area but are unsure where to 
start? Perhaps you would like to get started writing or converting some of our 
plug-ins? What about doing some simple cleanup and refactoring? Having someone 
to speak to can help you to get started on whatever it is you want to do.

Anyway I'll leave this open for a few more days and then will look at 
scheduling a call for next week.

Thanks
Sharan

On 2017-03-13 15:01 (+0100), "Sharan Foga" wrote: 
> Hi Everyone
> 
> I'm bringing up a topic that has been raised in the past regarding committer 
> mentoring. [1][2][3]. 
>  
> As  project we don't have any on-boarding process to help new committers or 
> support existing ones. Sometimes people assume that by the time you become a 
> committer then you should know how everything works! (and that isn't always 
> the case. )
> 
> In the past year with the re-factoring, the framework, plugins, gradle etc we 
> have a lot of changes happening and people may be a little overwhelmed about 
> how they can continue to contribute. Getting feedback and sharing knowledge 
> helps make people more confident in their way of working and contributions, 
> and the end result is better code which is a great thing for the project.
> 
> So I would  like invite all of our committers (and also any interested 
> contributors) to a Skype call to about mentoring and the support that you can 
> get from our more experienced project committers. The call will be 
> approximately 1 hour and will include an opportunity to ask questions. 
> 
> If you'd like to attend then please add your details, location and timezone 
> to the table at the bottom of the following wiki page so that I can find a 
> suitable time for everyone.
> 
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors
> 
> I really think that mentoring will help empower committers more, standardise 
> work and coding practices and generally improve our working relationships. 
> 
> As always, feedback welcome and please don't forget to add your name if you'd 
> like to attend.
> 
> Thanks
> Sharan
> 
> [1]  https://s.apache.org/FzI0
> [2]  https://s.apache.org/60t1
> [3]  https://s.apache.org/GWtv
> 

Re: Syntax in descriptions of tasks with parameters

[Jacques Le Roux]

I have created https://issues.apache.org/jira/browse/OFBIZ-9274 for that and 
I'd appreciate other opinions than Taher's

Thanks

Jacques


Le 17/03/2017 à 11:23, Taher Alkhateeb a écrit :

I don't want to repeat myself, my reply is in the original thread, however,
in addition, you will note that some tasks take a lot of flags, documenting
all flags for each task would make the output of ./gradlew tasks unreadable.

So I recommend not doing that.

On Fri, Mar 17, 2017 at 1:20 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Because I'm not satisfied with (eg)



--

"gradlew help --task pullPluginSource"

:help
Detailed task information for pullPluginSource
Path
  :pullPluginSource
Type
  Task (org.gradle.api.Task)
Description
  Download and install a plugin from source control
Group
  OFBiz Plugin



--

In other words, I have to look into the README file each time I don't
remember the string to pass behind -P , here pluginId

So I'd like to change the description
 -task pullPluginSource(group: ofbizPlugin, description: 'Download
and install a plugin from source control') {
 +task pullPluginSource(group: ofbizPlugin, description: 'Download
and install a plugin from source control, parameter: pluginId') {

same for all tasks with parameters.

Agreed?

Jacques



Le 17/03/2017 à 10:43, Taher Alkhateeb a écrit :


Why are you repeating conversations we already had?

https://s.apache.org/E1dE

On Fri, Mar 17, 2017 at 12:14 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Hi,

There was something very convenient with "Ant -p" "documentation": syntax
examples.

I believe we miss that, at least found it when using "g help --task
pullPluginSource". You get what it does but not how to do it (syntax).

Of course you can open the README.md file and look for reference but
that's tedious and counter-intuitive.

Would you agree to add the syntax in descriptions of tasks with
parameters
?

Jacques

Re: [SKYPE CALL] Mentoring Support for New and Existing Committers

[Sharan Foga]

Hi Everyone

I'm posting a reminder to see if anyone else would like to participate in this 
call.

At this stage we have 6 attendees of which 4 are mentors. Based on the 
locations (Europe, Kuwait and India) we have a good range of potential meeting 
times. 

I'd like to really encourage people to participate to find out how having a 
mentor could really help (Why not think of it as our own OFBiz Summer of Code 
:-) and a chance to do something that will benefit the project and also help 
you learn something new.

Perhaps you want to take on a particular task or area but are unsure where to 
start? Perhaps you would like to get started writing or converting some of our 
plug-ins? What about doing some simple cleanup and refactoring? Having someone 
to speak to can help you to get started on whatever it is you want to do.

Anyway I'll leave this open for a few more days and then will look at 
scheduling a call for next week.

Thanks
Sharan

On 2017-03-13 15:01 (+0100), "Sharan Foga" wrote: 
> Hi Everyone
> 
> I'm bringing up a topic that has been raised in the past regarding committer 
> mentoring. [1][2][3]. 
>  
> As  project we don't have any on-boarding process to help new committers or 
> support existing ones. Sometimes people assume that by the time you become a 
> committer then you should know how everything works! (and that isn't always 
> the case. )
> 
> In the past year with the re-factoring, the framework, plugins, gradle etc we 
> have a lot of changes happening and people may be a little overwhelmed about 
> how they can continue to contribute. Getting feedback and sharing knowledge 
> helps make people more confident in their way of working and contributions, 
> and the end result is better code which is a great thing for the project.
> 
> So I would  like invite all of our committers (and also any interested 
> contributors) to a Skype call to about mentoring and the support that you can 
> get from our more experienced project committers. The call will be 
> approximately 1 hour and will include an opportunity to ask questions. 
> 
> If you'd like to attend then please add your details, location and timezone 
> to the table at the bottom of the following wiki page so that I can find a 
> suitable time for everyone.
> 
> https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Mentors
> 
> I really think that mentoring will help empower committers more, standardise 
> work and coding practices and generally improve our working relationships. 
> 
> As always, feedback welcome and please don't forget to add your name if you'd 
> like to attend.
> 
> Thanks
> Sharan
> 
> [1]  https://s.apache.org/FzI0
> [2]  https://s.apache.org/60t1
> [3]  https://s.apache.org/GWtv
> 

Re: Plugins separated API (Javadoc)?

[Jacques Le Roux]

OK, let's wait

Jacques


Le 20/03/2017 à 13:12, Taher Alkhateeb a écrit :

Too early and too messy to worry about it at the moment. The plugins
require a lot of refactoring work and some plugins need to be deleted
altogether (ebaystore, ebay, etc ..). Just run ./gradlew javadoc and
observe how many problems are there.

To have any real value of JavaDocs, we need to cleanup the docs in the
first place. Most of the JavaDocs in our java code base are either a)
non-existent or b) poorly formatted for javadoc output. I for one never use
any javadocs to investigate the code base because I know right now it's not
very reliable and you have to dig through the code to get a real
understanding.

On Mon, Mar 20, 2017 at 2:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

Currently the plugins branch has no means to create Javadoc, nor any
others actually (not Gradle there)

If we want the Plugins to be a real apart product should we not worry
about that?

Thanks

Jacques

Re: Plugins separated API (Javadoc)?

[Taher Alkhateeb]

Too early and too messy to worry about it at the moment. The plugins
require a lot of refactoring work and some plugins need to be deleted
altogether (ebaystore, ebay, etc ..). Just run ./gradlew javadoc and
observe how many problems are there.

To have any real value of JavaDocs, we need to cleanup the docs in the
first place. Most of the JavaDocs in our java code base are either a)
non-existent or b) poorly formatted for javadoc output. I for one never use
any javadocs to investigate the code base because I know right now it's not
very reliable and you have to dig through the code to get a real
understanding.

On Mon, Mar 20, 2017 at 2:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> Currently the plugins branch has no means to create Javadoc, nor any
> others actually (not Gradle there)
>
> If we want the Plugins to be a real apart product should we not worry
> about that?
>
> Thanks
>
> Jacques
>
>

Re: New Website Branch Created

[Sharan Foga]

Hi Julien

Thanks for the feedback. Responses inline.

Thanks
Sharan


On 20/03/17 15:35, Julien NICOLAS wrote:

Bonjour Sharan and the community,


I don't know if you prefer to open Jira about new website issue but I 
listed below what I found on a fast review. I think it could be a good 
thing to be able to assign task and to avoid double work on the same one.




I think there is already a JIra but I'd like to check to see if we use 
it or close it and create a new one. It all depends on what is in it and 
how confusing it might be. I'll take a look and decide.




1 - Multi-browser compatibility

I try it locally but it seems that the hover on the menu is not 
working on Firefox... Is anybody have the same trouble ?


I try on Chromium (Linux) and there is no problem to navigate between 
pages.


I've focussed on writing all the pages so haven't tested it on different 
browsers, so this needs to be added to the to-do list. Also all the 
pages may not be in their final formats so not sure how this will affect 
that testing.





2 - External link

About the user experience and to be sure to not lost the user. I 
prefer to create a new tab when the user follow an external link 
(Twitter, blog, technical information, etc.)


Yes - I think that is nicer. When I set it up I was focussed on getting 
the right links, rather than new windows etc, but I agree this would be 
a good change and stops people navigating away from the site!





3 - Typo

I found a typo on the "Go ahead and take OFBiz for a spin!" in this 
sentence :


All you _*is*_ need is to install the Java...


Thanks although, I'm sure there will be more than this one!



4 - wrong link

Link press is wrong (News)

Link User documentation is wrong (Documentation)

Link Source Repository is wrong (Community)

All link in Users is pointing to the same page.

Maybe I can help to correct issue (maybe browser compatibility ?).


I'll investigate.



Have a nice day,


Well I'll surely have a nice 'busy' day now! :-)


Julien.



On 20/03/2017 13:54, Sharan Foga wrote:

Hi Everyone

A quick update. I've created a new branch called under the branches 
directory called ofbiz-new-website and have uploaded all the work 
done so far on the new website structure and pages.


The plan is to complete the work in this branch and then copy it over 
to the new site when we are ready. I think the content itself is the 
most important so will continue to to tidy up and complete any 
missing pages or information. It's in our repository now so hopefully 
more accessible to people who want to help out.


I'd encourage you all to take a look at what has been done to so that 
I can get some feedback of what people think of the general look and 
feel.


Once again – I'd like to thank Kenneth Paskett for helping out with 
the graphics.


Thanks
Sharan

Re: New Website Branch Created

[Sharan Foga]

Hi Taher

Yes - the freemarker thing sounds good, I've been having fun with the 
php page generation manually that makes you really appreciate automated 
scripts!


Anyway I know that there is some tidy up and linking etc to be done.  I 
will look at putting together a little project plan with the main tasks 
so that we can track where we are. I seem to remember that we did have a 
Jira created for the new website but I'll need to re-visit it as it 
might be way out of date. Also if these are sizeable things then it 
makes sense to break it up into manageable milestone chunks.


Thanks
Sharan


On 20/03/17 15:54, Taher Alkhateeb wrote:

Great job Sharan, and thank you for pulling this through and not giving up
:)

My recommendations to make this website an easier, more managable task is
as follows:

- Replace PHP templates with freemarker. I remember creating them quickly
just to get something rolling for the header/footer/shared regions
- Introduce a build script .. naturally I would recommend gradle. The build
script would include a few tasks to automate the publication of the
website. For example:
   - generateHtml: from the freemarker templates
   - publishWebsite: to get the final thing on the web server
   - clean: to remove any generated artifacts

I think treating this as a project with a build script using tools everyone
is familiar with is going to help in code contributions.

On Mar 20, 2017 3:54 PM, "Sharan Foga"  wrote:


Hi Everyone

A quick update. I've created a new branch called under the branches
directory called ofbiz-new-website and have uploaded all the work done so
far on the new website structure and pages.

The plan is to complete the work in this branch and then copy it over to
the new site when we are ready. I think the content itself is the most
important so will continue to to tidy up and complete any missing pages or
information. It's in our repository now so hopefully more accessible to
people who want to help out.

I'd encourage you all to take a look at what has been done to so that I
can get some feedback of what people think of the general look and feel.

Once again – I'd like to thank Kenneth Paskett for helping out with the
graphics.

Thanks
Sharan

Re: New Website Branch Created

[Taher Alkhateeb]

Great job Sharan, and thank you for pulling this through and not giving up
:)

My recommendations to make this website an easier, more managable task is
as follows:

- Replace PHP templates with freemarker. I remember creating them quickly
just to get something rolling for the header/footer/shared regions
- Introduce a build script .. naturally I would recommend gradle. The build
script would include a few tasks to automate the publication of the
website. For example:
  - generateHtml: from the freemarker templates
  - publishWebsite: to get the final thing on the web server
  - clean: to remove any generated artifacts

I think treating this as a project with a build script using tools everyone
is familiar with is going to help in code contributions.

On Mar 20, 2017 3:54 PM, "Sharan Foga"  wrote:

> Hi Everyone
>
> A quick update. I've created a new branch called under the branches
> directory called ofbiz-new-website and have uploaded all the work done so
> far on the new website structure and pages.
>
> The plan is to complete the work in this branch and then copy it over to
> the new site when we are ready. I think the content itself is the most
> important so will continue to to tidy up and complete any missing pages or
> information. It's in our repository now so hopefully more accessible to
> people who want to help out.
>
> I'd encourage you all to take a look at what has been done to so that I
> can get some feedback of what people think of the general look and feel.
>
> Once again – I'd like to thank Kenneth Paskett for helping out with the
> graphics.
>
> Thanks
> Sharan
>

Re: New Website Branch Created

[Julien NICOLAS]

Bonjour Sharan and the community,


I don't know if you prefer to open Jira about new website issue but I 
listed below what I found on a fast review. I think it could be a good 
thing to be able to assign task and to avoid double work on the same one.



1 - Multi-browser compatibility

I try it locally but it seems that the hover on the menu is not working 
on Firefox... Is anybody have the same trouble ?


I try on Chromium (Linux) and there is no problem to navigate between pages.


2 - External link

About the user experience and to be sure to not lost the user. I prefer 
to create a new tab when the user follow an external link (Twitter, 
blog, technical information, etc.)



3 - Typo

I found a typo on the "Go ahead and take OFBiz for a spin!" in this 
sentence :


All you _*is*_ need is to install the Java...

4 - wrong link

Link press is wrong (News)

Link User documentation is wrong (Documentation)

Link Source Repository is wrong (Community)

All link in Users is pointing to the same page.

Maybe I can help to correct issue (maybe browser compatibility ?).

Have a nice day,

Julien.



On 20/03/2017 13:54, Sharan Foga wrote:

Hi Everyone

A quick update. I've created a new branch called under the branches directory 
called ofbiz-new-website and have uploaded all the work done so far on the new 
website structure and pages.

The plan is to complete the work in this branch and then copy it over to the 
new site when we are ready. I think the content itself is the most important so 
will continue to to tidy up and complete any missing pages or information. It's 
in our repository now so hopefully more accessible to people who want to help 
out.

I'd encourage you all to take a look at what has been done to so that I can get 
some feedback of what people think of the general look and feel.

Once again – I'd like to thank Kenneth Paskett for helping out with the 
graphics.

Thanks
Sharan

New Website Branch Created

[Sharan Foga]

Hi Everyone

A quick update. I've created a new branch called under the branches directory 
called ofbiz-new-website and have uploaded all the work done so far on the new 
website structure and pages.

The plan is to complete the work in this branch and then copy it over to the 
new site when we are ready. I think the content itself is the most important so 
will continue to to tidy up and complete any missing pages or information. It's 
in our repository now so hopefully more accessible to people who want to help 
out.

I'd encourage you all to take a look at what has been done to so that I can get 
some feedback of what people think of the general look and feel. 

Once again – I'd like to thank Kenneth Paskett for helping out with the 
graphics.

Thanks
Sharan

Re: Plugins separated API (Javadoc)?

[Pierre Smits]

We could take a hint from the Apache Commons project.

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Mar 20, 2017 at 1:42 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> It's not yet clear to me, but I guess at 99% the entire branch (only ASF
> has a repo, not products they have only branches)
>
> Managing plugins as separated products would be a real pain for the
> release manager. Except if we can delegate...
>
> Jacques
>
>
> Le 20/03/2017 à 13:19, Pierre Smits a écrit :
>
>> Is the entire repo a product? Or are the individual components?
>>
>> Best regards,
>>
>> Pierre Smits
>>
>> ORRTIZ.COM 
>> OFBiz based solutions & services
>>
>> OFBiz Extensions Marketplace
>> http://oem.ofbizci.net/oci-2/
>>
>> On Mon, Mar 20, 2017 at 12:56 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Hi,
>>>
>>> Currently the plugins branch has no means to create Javadoc, nor any
>>> others actually (not Gradle there)
>>>
>>> If we want the Plugins to be a real apart product should we not worry
>>> about that?
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>

Re: svn commit: r1787742 [1/49] - in /ofbiz/branches/ofbiz-new-website: ./ bootstrap/ bootstrap/css/ bootstrap/img/ bootstrap/js/ bootstrap/js/with carousel/ css/ documentation/ documentation/assets/

[Jacques Le Roux]

Hi Sharan,

Great news :)

Could we have a Jira to possibly share the load there?

Thanks

Jacques


Le 20/03/2017 à 13:28, sha...@apache.org a écrit :

Author: sharan
Date: Mon Mar 20 12:28:40 2017
New Revision: 1787742

URL: http://svn.apache.org/viewvc?rev=1787742=rev
Log:
Improved: First main commit for new OFBiz website structure and format

Added:
 ofbiz/branches/ofbiz-new-website/about-ofbiz.html   (with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/
 ofbiz/branches/ofbiz-new-website/bootstrap/css/
 ofbiz/branches/ofbiz-new-website/bootstrap/css/bootstrap.css   (with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/css/bootstrap.min.css   (with 
props)
 ofbiz/branches/ofbiz-new-website/bootstrap/img/
 
ofbiz/branches/ofbiz-new-website/bootstrap/img/glyphicons-halflings-white.png   
(with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/img/glyphicons-halflings.png   
(with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/js/
 ofbiz/branches/ofbiz-new-website/bootstrap/js/bootstrap-carousel.js   
(with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/js/bootstrap.js   (with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/js/bootstrap.min.js   (with 
props)
 ofbiz/branches/ofbiz-new-website/bootstrap/js/with carousel/
 ofbiz/branches/ofbiz-new-website/bootstrap/js/with carousel/bootstrap.js   
(with props)
 ofbiz/branches/ofbiz-new-website/bootstrap/js/with 
carousel/bootstrap.min.js   (with props)
 ofbiz/branches/ofbiz-new-website/business-users.html   (with props)
 ofbiz/branches/ofbiz-new-website/css/
 ofbiz/branches/ofbiz-new-website/css/black-white.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/blue.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/coffee.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/colors.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-black-white.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-blue.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-coffee.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-green.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-light.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-orange.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-pink.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-red.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-sea-green.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/dark-yellow.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/green.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/icon-demo.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/layout.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/light.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/orange.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/pink.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/red.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/sea-green.css   (with props)
 ofbiz/branches/ofbiz-new-website/css/yellow.css   (with props)
 ofbiz/branches/ofbiz-new-website/developers.html   (with props)
 ofbiz/branches/ofbiz-new-website/documentation/
 ofbiz/branches/ofbiz-new-website/documentation/assets/
 ofbiz/branches/ofbiz-new-website/documentation/assets/css/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/css/documenter_style.css  
 (with props)
 ofbiz/branches/ofbiz-new-website/documentation/assets/css/img/
 ofbiz/branches/ofbiz-new-website/documentation/assets/css/img/info.png   
(with props)
 ofbiz/branches/ofbiz-new-website/documentation/assets/css/img/warning.png  
 (with props)
 ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/docu.json
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/images/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/images/image_1.jpg
   (with props)
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/images/image_2.gif
   (with props)
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/assets/images/image_3.png
   (with props)
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/css/
 
ofbiz/branches/ofbiz-new-website/documentation/assets/doc-external-plugins/RS-slider/css/documenter_style.css
   (with props)
 

Re: Plugins separated API (Javadoc)?

[Jacques Le Roux]

It's not yet clear to me, but I guess at 99% the entire branch (only ASF has a 
repo, not products they have only branches)

Managing plugins as separated products would be a real pain for the release 
manager. Except if we can delegate...

Jacques


Le 20/03/2017 à 13:19, Pierre Smits a écrit :

Is the entire repo a product? Or are the individual components?

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Mar 20, 2017 at 12:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi,

Currently the plugins branch has no means to create Javadoc, nor any
others actually (not Gradle there)

If we want the Plugins to be a real apart product should we not worry
about that?

Thanks

Jacques

buildbot success in on ofbiz-trunk-framework

[buildbot]

The Buildbot has detected a restored build on builder ofbiz-trunk-framework 
while building . Full details are available at:
https://ci.apache.org/builders/ofbiz-trunk-framework/builds/51

Buildbot URL: https://ci.apache.org/

Buildslave for this Build: silvanus_ubuntu

Build Reason: forced: by IRC user  (privmsg): forces manual build 
after Buildbot conf change (bug fixed)
Build Source Stamp: HEAD
Blamelist: 

Build succeeded!

Sincerely,
 -The Buildbot

Re: Plugins separated API (Javadoc)?

[Pierre Smits]

Is the entire repo a product? Or are the individual components?

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Mar 20, 2017 at 12:56 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> Currently the plugins branch has no means to create Javadoc, nor any
> others actually (not Gradle there)
>
> If we want the Plugins to be a real apart product should we not worry
> about that?
>
> Thanks
>
> Jacques
>
>

Plugins separated API (Javadoc)?

[Jacques Le Roux]

Hi,

Currently the plugins branch has no means to create Javadoc, nor any others 
actually (not Gradle there)

If we want the Plugins to be a real apart product should we not worry about 
that?

Thanks

Jacques

Re: buildbot exception in on ofbiz-trunk-framework

[Jacques Le Roux]

+1

Looking forward

Jacques


Le 20/03/2017 à 11:24, Taher Alkhateeb a écrit :

Okay, given that we have removed the mystery of this whole thing, I suggest
to create a JIRA where we can slowly tackle this issue since most of the
commits go to trunk

On Mon, Mar 20, 2017 at 12:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Just try locally the same thing you did for trunk with the R16 branch, you
will reproduce

Jacques



Le 20/03/2017 à 10:32, Taher Alkhateeb a écrit :


Looking at the code, I don't see any port blocking for R15 or R16

On Mon, Mar 20, 2017 at 12:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Hi Taher,

Thanks for the fix, I have changed the log commit to refer to OFBIZ-9196

About your question below. Actually, the problem is not related with
Buildbot particularly. It's obvious since you were able to reproduce
locally using only a trunk instance.

Now, since it was introduced between R15 and R16, the same problem exists
in R16. But your fix can't be backported because things are handled
differently there.

I see 2 ways of fixing it

1) change the code in R16 in another way

2) (I guess) backport the changes which leaded to using the *.properties
files (like load-data.properties) and then backport your change

I'm inclined for the second

Jacques



Le 19/03/2017 à 14:15, Taher Alkhateeb a écrit :

Okay great!

Now the next question. Does buildbot fail on simultaneous commits to the
same branch or for different branches only? Meaning if we commit at the
same time to trunk it's okay but if we commit to trunk and 16.11 then it
fails?. I am asking because I assume only one build for one branch
happens
at a time. Is this correct?

Cheers,

Taher Alkhateeb

On Mar 19, 2017 3:28 PM, "Jacques Le Roux" <
jacques.le.r...@les7arts.com>
wrote:

Yes, that should do it


Jacques


Le 19/03/2017 à 13:01, Taher Alkhateeb a écrit :

Okay, so, to be absolutely exact, the repeat behavior is the following:


- checkout ofbiz r1744041
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests run successfully

And then

- checkout ofbiz r1744107
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests fail with the message Couldn't create server socket(/
127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java

Is this correct?

On Sun, Mar 19, 2017 at 2:47 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

yep, you got it. But you also need an OFBiz instance running
(previously)

to reproduce, of course!

Jacques


Le 19/03/2017 à 12:37, Taher Alkhateeb a écrit :

Sorry, I'm still lost, trying to explain it again:

Before the commit: "ant clean-all load-demo run-tests" works

after the commit: "ant clean-all load-demo run-tests" does not work
with
the socket error message?

Is this now what you mean?


On Sun, Mar 19, 2017 at 2:32 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

It's quite simple, I repeat.

It's not specifically  related with Buildbot despite the title. It
was


1st
identified there.

If you run an OFBiz instance (I ran one at the "beforeGradle" tag,
but
we
know any commit version fits since it's currently reproducible on
Buildbot)

Before your commit (r1744107 in disappeared trunk) below (ie using
the
last previous commit, to be even more clear r1744041) "ant
clean-all
load-demo run-tests" works

After (ie using r1744107) it fails with the error reported below. I
repeat
it here in case



--

run-tests:
[java] org.ofbiz.base.start.StartupException: Couldn't
create
server
socket(/127.0.0.1:10523) (Address already in use:
JVM_Bind)Start.java
using configuration file org/ofbiz/base/start/test.properties



--

I hope it's now clear. And yes it's in the commit and we need to
find
where!

You asked me to answer on HipChat, sorry I'll not, I must move
now...

HTH

Jacques


Le 19/03/2017 à 12:00, Taher Alkhateeb a écrit :

The commit in question is not important because there are too many

changes.


What we need is a "repeat" behavior. So my questions from this
thread
remain to be answered before we can investigate.

On Sun, Mar 19, 2017 at 1:53 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Here it is





--

git.exe bisect good

298c831a3aa1cea45b4aab66acebd9617f6615e0 is the first bad commit
commit 298c831a3aa1cea45b4aab66acebd9617f6615e0
Author: Taher A. Alkhateeb 
Date:   Mon May 16 18:40:49 2016 +

major change in the start component related to OFBIZ-6783

this is a big commit 

Re: buildbot exception in on ofbiz-trunk-framework

[Taher Alkhateeb]

Okay, given that we have removed the mystery of this whole thing, I suggest
to create a JIRA where we can slowly tackle this issue since most of the
commits go to trunk

On Mon, Mar 20, 2017 at 12:46 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Just try locally the same thing you did for trunk with the R16 branch, you
> will reproduce
>
> Jacques
>
>
>
> Le 20/03/2017 à 10:32, Taher Alkhateeb a écrit :
>
>> Looking at the code, I don't see any port blocking for R15 or R16
>>
>> On Mon, Mar 20, 2017 at 12:13 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Hi Taher,
>>>
>>> Thanks for the fix, I have changed the log commit to refer to OFBIZ-9196
>>>
>>> About your question below. Actually, the problem is not related with
>>> Buildbot particularly. It's obvious since you were able to reproduce
>>> locally using only a trunk instance.
>>>
>>> Now, since it was introduced between R15 and R16, the same problem exists
>>> in R16. But your fix can't be backported because things are handled
>>> differently there.
>>>
>>> I see 2 ways of fixing it
>>>
>>> 1) change the code in R16 in another way
>>>
>>> 2) (I guess) backport the changes which leaded to using the *.properties
>>> files (like load-data.properties) and then backport your change
>>>
>>> I'm inclined for the second
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 19/03/2017 à 14:15, Taher Alkhateeb a écrit :
>>>
>>> Okay great!

 Now the next question. Does buildbot fail on simultaneous commits to the
 same branch or for different branches only? Meaning if we commit at the
 same time to trunk it's okay but if we commit to trunk and 16.11 then it
 fails?. I am asking because I assume only one build for one branch
 happens
 at a time. Is this correct?

 Cheers,

 Taher Alkhateeb

 On Mar 19, 2017 3:28 PM, "Jacques Le Roux" <
 jacques.le.r...@les7arts.com>
 wrote:

 Yes, that should do it

> Jacques
>
>
> Le 19/03/2017 à 13:01, Taher Alkhateeb a écrit :
>
> Okay, so, to be absolutely exact, the repeat behavior is the following:
>
>> - checkout ofbiz r1744041
>> - ant clean-all load-demo
>> - ant start
>> - open a new terminal
>> - ant run-tests
>> - observe tests run successfully
>>
>> And then
>>
>> - checkout ofbiz r1744107
>> - ant clean-all load-demo
>> - ant start
>> - open a new terminal
>> - ant run-tests
>> - observe tests fail with the message Couldn't create server socket(/
>> 127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java
>>
>> Is this correct?
>>
>> On Sun, Mar 19, 2017 at 2:47 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> yep, you got it. But you also need an OFBiz instance running
>> (previously)
>>
>> to reproduce, of course!
>>>
>>> Jacques
>>>
>>>
>>> Le 19/03/2017 à 12:37, Taher Alkhateeb a écrit :
>>>
>>> Sorry, I'm still lost, trying to explain it again:
>>>
>>> Before the commit: "ant clean-all load-demo run-tests" works
 after the commit: "ant clean-all load-demo run-tests" does not work
 with
 the socket error message?

 Is this now what you mean?


 On Sun, Mar 19, 2017 at 2:32 PM, Jacques Le Roux <
 jacques.le.r...@les7arts.com> wrote:

 It's quite simple, I repeat.

 It's not specifically  related with Buildbot despite the title. It
 was

> 1st
> identified there.
>
> If you run an OFBiz instance (I ran one at the "beforeGradle" tag,
> but
> we
> know any commit version fits since it's currently reproducible on
> Buildbot)
>
> Before your commit (r1744107 in disappeared trunk) below (ie using
> the
> last previous commit, to be even more clear r1744041) "ant
> clean-all
> load-demo run-tests" works
>
> After (ie using r1744107) it fails with the error reported below. I
> repeat
> it here in case
>
> 
> 
> --
>
> run-tests:
>[java] org.ofbiz.base.start.StartupException: Couldn't
> create
> server
> socket(/127.0.0.1:10523) (Address already in use:
> JVM_Bind)Start.java
> using configuration file org/ofbiz/base/start/test.properties
>
> 
> 
> --
>
> I hope it's now clear. And yes it's in the commit and we need to
> find

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

[Pierre Smits]

Hey Jacques,

This appears to be the related issue: OFBIZ-7848

Best regards,

Pierre Smits

ORRTIZ.COM 
OFBiz based solutions & services

OFBiz Extensions Marketplace
http://oem.ofbizci.net/oci-2/

On Mon, Mar 20, 2017 at 11:19 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> What is the situation here, please? Is there a Jira? Should I take care of
> that?
>
> Thanks
>
> Jacques
>
>
>
> Le 01/09/2016 à 15:28, Harsh Vijaywargiya a écrit :
>
>> Thanks Jacques,
>>
>> Sounds good. I will take care of this suggestion in coming commits.
>>
>> Thanks & Regards,
>> Harsh
>> On Wednesday 31 August 2016 04:51 PM, Jacques Le Roux wrote:
>>
>>> OK I checked, the commented out lines were from pre Apache Era. So
>>> indeed it was not an easy decision.
>>>
>>> For
>>>
>>> public void print(List arr, BigDecimal quantity, int depth,
>>> boolean excludeWIPs) {
>>>
>>> I believe the lines were commented out because it's a recursive method.
>>> I still believe we should never let exceptions escape. The probability it
>>> happens is low. Another reason to not let it escape: it should not clutter
>>> the log but when really needed.
>>>
>>> So I simply suggest to add
>>>
>>> Debug.logError(e, "Problem calling the " + serviceName + " service
>>> (called by the createManufacturingOrder service)", module);
>>>
>>> there.
>>>
>>> Globally here is my take
>>>
>>> Index: applications/manufacturing/src/main/java/org/apache/ofbiz/
>>> manufacturing/bom/BOMNode.java
>>> ===
>>> --- 
>>> applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
>>> (revision 1758522)
>>> +++ 
>>> applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
>>> (working copy)
>>> @@ -292,7 +292,7 @@
>>>  variantProduct =
>>> variantProducts.get(0);
>>>  }
>>>  } catch (GenericServiceException e) {
>>> -if (Debug.infoOn())
>>> Debug.logInfo("Error calling getProductVariant service " + e.getMessage(),
>>> module);
>>> +Debug.logError("Error calling
>>> getProductVariant service " + e.getMessage(), module);
>>>  }
>>>  if (variantProduct != null) {
>>>  newNode = new
>>> BOMNode(variantProduct, dispatcher, userLogin);
>>> @@ -433,7 +433,7 @@
>>>  this.quantity = calcQuantity;
>>>  }
>>>  } catch (GenericServiceException e) {
>>> -
>>> +Debug.logError(e, "Problem calling the " + serviceName
>>> + " service (called by the createManufacturingOrder service)", module);
>>>  }
>>>  } else {
>>>  this.quantity = quantity.multiply(quantityMult
>>> iplier).multiply(scrapFactor);
>>> @@ -573,7 +573,7 @@
>>>  }
>>>  }
>>>  } catch (GenericEntityException e) {
>>> -
>>> +Debug.logError(e, "Problem calling the
>>> getManufacturingComponents service", module);
>>>  }
>>>  }
>>>  return UtilMisc.toMap("productionRunId", productionRunId,
>>> "endDate", endDate);
>>>
>>> What to you think?
>>>
>>> Jacques
>>>
>>>
>>> Le 30/08/2016 à 11:21, Jacques Le Roux a écrit :
>>>
 Le 30/08/2016 à 08:29, Jacopo Cappellato a écrit :

> Highlighting code that could be improved rather than fixing it is a
> good
> way to help potential contributors.
> However, and I think this is the reason for Scott's remark, you should
> not
> have addressed your review/request to individual committer/contributor
> (if
> the defect you have noticed was not introduced by their contribution,
> as in
> this case).
>
 OK, got the subtle nuance, thanks

 Jacques



>>>
>>
>>
>

Re: svn commit: r1757991 - in /ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manu facturing: bom/ jobshopmgt/ mrp/ techdata/

[Jacques Le Roux]

What is the situation here, please? Is there a Jira? Should I take care of that?

Thanks

Jacques


Le 01/09/2016 à 15:28, Harsh Vijaywargiya a écrit :

Thanks Jacques,

Sounds good. I will take care of this suggestion in coming commits.

Thanks & Regards,
Harsh
On Wednesday 31 August 2016 04:51 PM, Jacques Le Roux wrote:

OK I checked, the commented out lines were from pre Apache Era. So indeed it 
was not an easy decision.

For

public void print(List arr, BigDecimal quantity, int depth, 
boolean excludeWIPs) {

I believe the lines were commented out because it's a recursive method. I still believe we should never let exceptions escape. The probability it 
happens is low. Another reason to not let it escape: it should not clutter the log but when really needed.


So I simply suggest to add

Debug.logError(e, "Problem calling the " + serviceName + " service (called by 
the createManufacturingOrder service)", module);

there.

Globally here is my take

Index: 
applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
===
--- 
applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
 (revision 1758522)
+++ 
applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/bom/BOMNode.java
 (working copy)
@@ -292,7 +292,7 @@
 variantProduct = 
variantProducts.get(0);
 }
 } catch (GenericServiceException e) {
-if (Debug.infoOn()) Debug.logInfo("Error 
calling getProductVariant service " + e.getMessage(), module);
+Debug.logError("Error calling getProductVariant 
service " + e.getMessage(), module);
 }
 if (variantProduct != null) {
 newNode = new BOMNode(variantProduct, 
dispatcher, userLogin);
@@ -433,7 +433,7 @@
 this.quantity = calcQuantity;
 }
 } catch (GenericServiceException e) {
-
+Debug.logError(e, "Problem calling the " + serviceName + " service 
(called by the createManufacturingOrder service)", module);
 }
 } else {
 this.quantity = 
quantity.multiply(quantityMultiplier).multiply(scrapFactor);
@@ -573,7 +573,7 @@
 }
 }
 } catch (GenericEntityException e) {
-
+Debug.logError(e, "Problem calling the getManufacturingComponents 
service", module);
 }
 }
 return UtilMisc.toMap("productionRunId", productionRunId, "endDate", 
endDate);

What to you think?

Jacques


Le 30/08/2016 à 11:21, Jacques Le Roux a écrit :

Le 30/08/2016 à 08:29, Jacopo Cappellato a écrit :

Highlighting code that could be improved rather than fixing it is a good
way to help potential contributors.
However, and I think this is the reason for Scott's remark, you should not
have addressed your review/request to individual committer/contributor (if
the defect you have noticed was not introduced by their contribution, as in
this case).

OK, got the subtle nuance, thanks

Jacques

Re: buildbot exception in on ofbiz-trunk-framework

[Jacques Le Roux]

Just try locally the same thing you did for trunk with the R16 branch, you will 
reproduce

Jacques


Le 20/03/2017 à 10:32, Taher Alkhateeb a écrit :

Looking at the code, I don't see any port blocking for R15 or R16

On Mon, Mar 20, 2017 at 12:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:


Hi Taher,

Thanks for the fix, I have changed the log commit to refer to OFBIZ-9196

About your question below. Actually, the problem is not related with
Buildbot particularly. It's obvious since you were able to reproduce
locally using only a trunk instance.

Now, since it was introduced between R15 and R16, the same problem exists
in R16. But your fix can't be backported because things are handled
differently there.

I see 2 ways of fixing it

1) change the code in R16 in another way

2) (I guess) backport the changes which leaded to using the *.properties
files (like load-data.properties) and then backport your change

I'm inclined for the second

Jacques



Le 19/03/2017 à 14:15, Taher Alkhateeb a écrit :


Okay great!

Now the next question. Does buildbot fail on simultaneous commits to the
same branch or for different branches only? Meaning if we commit at the
same time to trunk it's okay but if we commit to trunk and 16.11 then it
fails?. I am asking because I assume only one build for one branch happens
at a time. Is this correct?

Cheers,

Taher Alkhateeb

On Mar 19, 2017 3:28 PM, "Jacques Le Roux" 
wrote:

Yes, that should do it

Jacques


Le 19/03/2017 à 13:01, Taher Alkhateeb a écrit :

Okay, so, to be absolutely exact, the repeat behavior is the following:

- checkout ofbiz r1744041
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests run successfully

And then

- checkout ofbiz r1744107
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests fail with the message Couldn't create server socket(/
127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java

Is this correct?

On Sun, Mar 19, 2017 at 2:47 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

yep, you got it. But you also need an OFBiz instance running
(previously)


to reproduce, of course!

Jacques


Le 19/03/2017 à 12:37, Taher Alkhateeb a écrit :

Sorry, I'm still lost, trying to explain it again:


Before the commit: "ant clean-all load-demo run-tests" works
after the commit: "ant clean-all load-demo run-tests" does not work
with
the socket error message?

Is this now what you mean?


On Sun, Mar 19, 2017 at 2:32 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

It's quite simple, I repeat.

It's not specifically  related with Buildbot despite the title. It was

1st
identified there.

If you run an OFBiz instance (I ran one at the "beforeGradle" tag,
but
we
know any commit version fits since it's currently reproducible on
Buildbot)

Before your commit (r1744107 in disappeared trunk) below (ie using
the
last previous commit, to be even more clear r1744041) "ant clean-all
load-demo run-tests" works

After (ie using r1744107) it fails with the error reported below. I
repeat
it here in case



--

run-tests:
   [java] org.ofbiz.base.start.StartupException: Couldn't
create
server
socket(/127.0.0.1:10523) (Address already in use:
JVM_Bind)Start.java
using configuration file org/ofbiz/base/start/test.properties



--

I hope it's now clear. And yes it's in the commit and we need to find
where!

You asked me to answer on HipChat, sorry I'll not, I must move now...

HTH

Jacques


Le 19/03/2017 à 12:00, Taher Alkhateeb a écrit :

The commit in question is not important because there are too many

changes.

What we need is a "repeat" behavior. So my questions from this
thread
remain to be answered before we can investigate.

On Sun, Mar 19, 2017 at 1:53 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Here it is





--

git.exe bisect good

298c831a3aa1cea45b4aab66acebd9617f6615e0 is the first bad commit
commit 298c831a3aa1cea45b4aab66acebd9617f6615e0
Author: Taher A. Alkhateeb 
Date:   Mon May 16 18:40:49 2016 +

major change in the start component related to OFBIZ-6783

this is a big commit that achieves the following new features in
ofbiz:

- add the commons-cli library
- fix build.xml in start menu to include the commons-cli. It is
done
in a way to ensure that the classpath continues to work when
ofbiz.jar
is copied to the root folder
- set a default portoffset value of 0 when not selected in
build.xml
- fully redefine the 

Re: buildbot exception in on ofbiz-trunk-framework

[Taher Alkhateeb]

Looking at the code, I don't see any port blocking for R15 or R16

On Mon, Mar 20, 2017 at 12:13 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Taher,
>
> Thanks for the fix, I have changed the log commit to refer to OFBIZ-9196
>
> About your question below. Actually, the problem is not related with
> Buildbot particularly. It's obvious since you were able to reproduce
> locally using only a trunk instance.
>
> Now, since it was introduced between R15 and R16, the same problem exists
> in R16. But your fix can't be backported because things are handled
> differently there.
>
> I see 2 ways of fixing it
>
> 1) change the code in R16 in another way
>
> 2) (I guess) backport the changes which leaded to using the *.properties
> files (like load-data.properties) and then backport your change
>
> I'm inclined for the second
>
> Jacques
>
>
>
> Le 19/03/2017 à 14:15, Taher Alkhateeb a écrit :
>
>> Okay great!
>>
>> Now the next question. Does buildbot fail on simultaneous commits to the
>> same branch or for different branches only? Meaning if we commit at the
>> same time to trunk it's okay but if we commit to trunk and 16.11 then it
>> fails?. I am asking because I assume only one build for one branch happens
>> at a time. Is this correct?
>>
>> Cheers,
>>
>> Taher Alkhateeb
>>
>> On Mar 19, 2017 3:28 PM, "Jacques Le Roux" 
>> wrote:
>>
>> Yes, that should do it
>>>
>>> Jacques
>>>
>>>
>>> Le 19/03/2017 à 13:01, Taher Alkhateeb a écrit :
>>>
>>> Okay, so, to be absolutely exact, the repeat behavior is the following:

 - checkout ofbiz r1744041
 - ant clean-all load-demo
 - ant start
 - open a new terminal
 - ant run-tests
 - observe tests run successfully

 And then

 - checkout ofbiz r1744107
 - ant clean-all load-demo
 - ant start
 - open a new terminal
 - ant run-tests
 - observe tests fail with the message Couldn't create server socket(/
 127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java

 Is this correct?

 On Sun, Mar 19, 2017 at 2:47 PM, Jacques Le Roux <
 jacques.le.r...@les7arts.com> wrote:

 yep, you got it. But you also need an OFBiz instance running
 (previously)

> to reproduce, of course!
>
> Jacques
>
>
> Le 19/03/2017 à 12:37, Taher Alkhateeb a écrit :
>
> Sorry, I'm still lost, trying to explain it again:
>
>> Before the commit: "ant clean-all load-demo run-tests" works
>> after the commit: "ant clean-all load-demo run-tests" does not work
>> with
>> the socket error message?
>>
>> Is this now what you mean?
>>
>>
>> On Sun, Mar 19, 2017 at 2:32 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> It's quite simple, I repeat.
>>
>> It's not specifically  related with Buildbot despite the title. It was
>>> 1st
>>> identified there.
>>>
>>> If you run an OFBiz instance (I ran one at the "beforeGradle" tag,
>>> but
>>> we
>>> know any commit version fits since it's currently reproducible on
>>> Buildbot)
>>>
>>> Before your commit (r1744107 in disappeared trunk) below (ie using
>>> the
>>> last previous commit, to be even more clear r1744041) "ant clean-all
>>> load-demo run-tests" works
>>>
>>> After (ie using r1744107) it fails with the error reported below. I
>>> repeat
>>> it here in case
>>>
>>> 
>>> 
>>> --
>>>
>>> run-tests:
>>>   [java] org.ofbiz.base.start.StartupException: Couldn't
>>> create
>>> server
>>> socket(/127.0.0.1:10523) (Address already in use:
>>> JVM_Bind)Start.java
>>> using configuration file org/ofbiz/base/start/test.properties
>>>
>>> 
>>> 
>>> --
>>>
>>> I hope it's now clear. And yes it's in the commit and we need to find
>>> where!
>>>
>>> You asked me to answer on HipChat, sorry I'll not, I must move now...
>>>
>>> HTH
>>>
>>> Jacques
>>>
>>>
>>> Le 19/03/2017 à 12:00, Taher Alkhateeb a écrit :
>>>
>>> The commit in question is not important because there are too many
>>>
>>> changes.

 What we need is a "repeat" behavior. So my questions from this
 thread
 remain to be answered before we can investigate.

 On Sun, Mar 19, 2017 at 1:53 PM, Jacques Le Roux <
 jacques.le.r...@les7arts.com> wrote:

 Here it is

 

> 

Re: buildbot exception in on ofbiz-trunk-framework

[Jacques Le Roux]

Hi Taher,

Thanks for the fix, I have changed the log commit to refer to OFBIZ-9196

About your question below. Actually, the problem is not related with Buildbot particularly. It's obvious since you were able to reproduce locally 
using only a trunk instance.


Now, since it was introduced between R15 and R16, the same problem exists in R16. But your fix can't be backported because things are handled 
differently there.


I see 2 ways of fixing it

1) change the code in R16 in another way

2) (I guess) backport the changes which leaded to using the *.properties files 
(like load-data.properties) and then backport your change

I'm inclined for the second

Jacques


Le 19/03/2017 à 14:15, Taher Alkhateeb a écrit :

Okay great!

Now the next question. Does buildbot fail on simultaneous commits to the
same branch or for different branches only? Meaning if we commit at the
same time to trunk it's okay but if we commit to trunk and 16.11 then it
fails?. I am asking because I assume only one build for one branch happens
at a time. Is this correct?

Cheers,

Taher Alkhateeb

On Mar 19, 2017 3:28 PM, "Jacques Le Roux" 
wrote:


Yes, that should do it

Jacques


Le 19/03/2017 à 13:01, Taher Alkhateeb a écrit :


Okay, so, to be absolutely exact, the repeat behavior is the following:

- checkout ofbiz r1744041
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests run successfully

And then

- checkout ofbiz r1744107
- ant clean-all load-demo
- ant start
- open a new terminal
- ant run-tests
- observe tests fail with the message Couldn't create server socket(/
127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java

Is this correct?

On Sun, Mar 19, 2017 at 2:47 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

yep, you got it. But you also need an OFBiz instance running (previously)

to reproduce, of course!

Jacques


Le 19/03/2017 à 12:37, Taher Alkhateeb a écrit :

Sorry, I'm still lost, trying to explain it again:

Before the commit: "ant clean-all load-demo run-tests" works
after the commit: "ant clean-all load-demo run-tests" does not work with
the socket error message?

Is this now what you mean?


On Sun, Mar 19, 2017 at 2:32 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

It's quite simple, I repeat.


It's not specifically  related with Buildbot despite the title. It was
1st
identified there.

If you run an OFBiz instance (I ran one at the "beforeGradle" tag, but
we
know any commit version fits since it's currently reproducible on
Buildbot)

Before your commit (r1744107 in disappeared trunk) below (ie using the
last previous commit, to be even more clear r1744041) "ant clean-all
load-demo run-tests" works

After (ie using r1744107) it fails with the error reported below. I
repeat
it here in case



--

run-tests:
  [java] org.ofbiz.base.start.StartupException: Couldn't create
server
socket(/127.0.0.1:10523) (Address already in use: JVM_Bind)Start.java
using configuration file org/ofbiz/base/start/test.properties



--

I hope it's now clear. And yes it's in the commit and we need to find
where!

You asked me to answer on HipChat, sorry I'll not, I must move now...

HTH

Jacques


Le 19/03/2017 à 12:00, Taher Alkhateeb a écrit :

The commit in question is not important because there are too many


changes.

What we need is a "repeat" behavior. So my questions from this thread
remain to be answered before we can investigate.

On Sun, Mar 19, 2017 at 1:53 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Here it is




--

git.exe bisect good

298c831a3aa1cea45b4aab66acebd9617f6615e0 is the first bad commit
commit 298c831a3aa1cea45b4aab66acebd9617f6615e0
Author: Taher A. Alkhateeb 
Date:   Mon May 16 18:40:49 2016 +

major change in the start component related to OFBIZ-6783

this is a big commit that achieves the following new features in
ofbiz:

- add the commons-cli library
- fix build.xml in start menu to include the commons-cli. It is done
in a way to ensure that the classpath continues to work when
ofbiz.jar
is copied to the root folder
- set a default portoffset value of 0 when not selected in build.xml
- fully redefine the commands passed in java -jar ofbiz.jar using the
commons-cli
api. The commands are now much more consistent and clean
- remove ofbiz dependency on String[] args across the different
components
and isolate
them in a new entity class called StartupCommand. This decouples
ofbiz
from both
String[] args and