Re: Keep javaScriptEnabled manage on the framework ?

2017-09-01 Thread Gareth Carter
Hi all We patch to force JavaScript enabled always Y. I honestly can't see any good reason why it's in ofbiz now. Most widgets require the use of JavaScript. Most sites use javascript. It has actually caused us problems in the past where, for some reason, JavaScript enabled was set to Not even

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Vaibhav Jain
+1 for introducing new attribute "tableName". Vaibhav Jain Hotwax Systems, vaibhav.j...@hotwaxsystems.com On Fri, Sep 1, 2017 at 5:16 PM, Rishi Solanki wrote: > I'm not sure this one is best practice or not, but it should be follow. We > should try to name the type

buildbot success in on ofbiz-trunk-framework-plugins

2017-09-01 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/442 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

Re: Tracking Data Model changes

2017-09-01 Thread Taher Alkhateeb
Groovy scripts are also great and can do the job. To comment on the "advantage" of something like flyway or liquibase I can try to list some: - The scripts might get too big or complex to accommodate different databases and platforms. - Out of the box, these solutions are database independent -

buildbot success in on ofbiz-trunk-framework

2017-09-01 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework/builds/457 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The

Re: svn commit: r1806764 - /ofbiz/site/README.md

2017-09-01 Thread Jacques Le Roux
Thanks Taher, Looking forward, then I guess we don't need temporary scripts for php compilation. Jacques Le 01/09/2017 à 15:09, Taher Alkhateeb a écrit : Thank you everyone for the votes, and Ashish for your kind words. I'll start to work on this in a few days once enough stabilization is

Re: OrderHeader And WebSite Relationship

2017-09-01 Thread Ratnesh Upadhyay
Thanks, Chandan!! Regards, Ratnesh Upadhyay HotWax Systems | www.hotwaxsystems.com On Thu, Aug 31, 2017 at 1:37 PM, Chandan Khandelwal < chandan.khandel...@hotwaxsystems.com> wrote: > Hi All, > > I have created parent ticket to manage this effort throughout the > application > > Ticket:

Re: svn commit: r1806764 - /ofbiz/site/README.md

2017-09-01 Thread Taher Alkhateeb
Thank you everyone for the votes, and Ashish for your kind words. I'll start to work on this in a few days once enough stabilization is done by everyone. On Fri, Sep 1, 2017 at 10:29 AM, Sharan Foga wrote: > Thanks for adding the Readme file Deepak. I just added a quick

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
Here is the part related to this thread, from the document shared. "If a table is associated with a given EntityType instance that has the same name as the entityTypeId field value then the hasTable field should have the value 'Y', otherwise it should have the value 'N'. A description field is

buildbot success in on ofbiz-trunk-framework-plugins

2017-09-01 Thread buildbot
The Buildbot has detected a restored build on builder ofbiz-trunk-framework-plugins while building . Full details are available at: https://ci.apache.org/builders/ofbiz-trunk-framework-plugins/builds/439 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
Thanks Jacques! Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Fri, Sep 1, 2017 at 5:46 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > It's described here

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Jacques Le Roux
It's described here https://cwiki.apache.org/confluence/display/OFBIZ/General+Entity+Overview#GeneralEntityOverview-ExtensibilityPattern What is the problem with ShipmentGatewayConfigType and PaymentGatewayConfigType (did not check)? Jacques Le 01/09/2017 à 13:18, Arun Patidar a écrit :

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Rishi Solanki
I'm not sure this one is best practice or not, but it should be follow. We should try to name the type same as entity name. Other examples; - PartyTpe >> PERSON and PARTY_GROUP - PaymentMethodType >> CREDIT_CARD, FIN_ACCOUNT, EFT_ACCOUNT, GIFT_CARD etc. IMO, best practice is to have the hasTable

Re: Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Taher Alkhateeb
Hmmm maybe a solution that enforces naming conventions is something like the following - if hasTable is defined, the entity engine automatically creates the table using the convention of id - if someone wants to intentionally change the table name, they can set an override field like tableName.

Re: Tracking Data Model changes

2017-09-01 Thread Nicolas Malin
I'm in favor to tracking the different migration but at this time I didn't see the advantage to use flyway or other instead of manage easily by ofbiz throw groovy script. I'm available to help for design or create a POC do realize it because many time in the past (and currently ow) I want to

Extend type entities to add name of detail entity where hasTable is true.

2017-09-01 Thread Arun Patidar
Hello All, 'hasTable' field of 'Type' entities is used to give an idea that detail entity exists or not. We generally get the name of detail entity on the basis of typeId field value. For example : ContactMechType,contactMechTypeId = "POSTAL_ADDRESS" then we go to PostalAddress for detail.

Re: Services with no definition and usage

2017-09-01 Thread Jacques Le Roux
There will be years before we rewrite all the Minilang services. It's just an hour to revive these services, I can do it It will then be easy to rewrite them with all the others. BTW I fear this moment of massive regressions if we don't put ALL the required tests before doing the rewriting.

Re: Services with no definition and usage

2017-09-01 Thread Taher Alkhateeb
Well .. according to you, the thoughts were put in these services before the apache era! I'm not sure if we want such _very_ old code revived. I also think the community is capable enough of rewriting basic CRUD services. There is no magic or incredibly sophisticated algorithms in this code. Juat

Re: svn commit: r1806907 - /ofbiz/site/.htaccess

2017-09-01 Thread Taher Alkhateeb
Hi Deepak ... I don't think you need a rewrite rule. You just need to set the default links inside the templates On Sep 1, 2017 12:14 PM, wrote: > Author: deepak > Date: Fri Sep 1 09:14:12 2017 > New Revision: 1806907 > > URL: http://svn.apache.org/viewvc?rev=1806907=rev >

Re: Services with no definition and usage

2017-09-01 Thread Jacques Le Roux
I disagree, some thoughts were put in these services. They are in Minilang admittedly, but we can still keep them and transform them later and anway we have tons of Minilang services. I'm not sure if I found them all but they seem to start from updateWorkEffortContactMech and end at

Re: Services with no definition and usage

2017-09-01 Thread Taher Alkhateeb
I agree, we need to remove from the pile not add to it. Deleting is the best course of action IMHO. Heck even some of the defined services should be deleted or heavily refactored for that matter. On Sep 1, 2017 11:33 AM, "Pierre Smits" wrote: If the services are not

Re: Services with no definition and usage

2017-09-01 Thread Pierre Smits
If the services are not used, we should ask ourselves whether it would not be best to remove these to keep the code base clean. If need be these can always be brought back from the repo. Pierre Smits ORRTIZ.COM OFBiz based solutions & services OEM: the unaffiliated OFBiz

Re: svn commit: r1806764 - /ofbiz/site/README.md

2017-09-01 Thread Sharan Foga
Thanks for adding the Readme file Deepak. I just added a quick update to it for header and footer changes. +1 Taher - if you are ready to start on the conversion to freemarker and a more automated solution then please go ahead, as I think apart from the site sychronisation issue that Infra