Jacques Le Roux writes:
> Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit :
>> I sympathise but I am not sure about this strategy, which depending on
>> the capabilities of your VCS might obscure the commit history. I would
>> recommend to simply use the “120 chars max” guideline for newly added
>
Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit :
I sympathise but I am not sure about this strategy, which depending on
the capabilities of your VCS might obscure the commit history. I would
recommend to simply use the “120 chars max” guideline for newly added
code and when refactoring existing o
+1 for not reformatting all at once but only if there are changes anyway.
The patch should mention this because it will make reviews more complex.
Regards,
Michael
Am 26.10.18 um 11:13 schrieb Mathieu Lirzin:
Hello Jacques,
Jacques Le Roux writes:
Yes you are right, the whole file should
Hello,
+1 to follow the 120char guideline for any commit that the purpose it
not to refactor line length :).
Gil
Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit :
> Hello Jacques,
>
> Jacques Le Roux writes:
>
> > Yes you are right, the whole file should be reformatted.
>
Hello Jacques,
Jacques Le Roux writes:
> Yes you are right, the whole file should be reformatted.
>
> This "around 120 chars max" rule is "new" (few years) and most of the
> code there is more than a decade.
OK, sure.
> If nobody disagree we could have a task Jira to reformat the code of
> the
