Re: Pursuing the “120 chars max” guideline
Jacques Le Roux writes: > Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit : >> I sympathise but I am not sure about this strategy, which depending on >> the capabilities of your VCS might obscure the commit history. I would >> recommend to simply use the “120 chars max” guideline for newly added >> code and when refactoring existing one. >> >> WDYT? > Yes, that's what we decided already and I'm all for it. It's indeed the only > way if we don't want to blur things in svn history. > > I simply forgot to format before committing > > I just did it at r1844909 Thanks! -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Re: Pursuing the “120 chars max” guideline
Le 26/10/2018 à 11:13, Mathieu Lirzin a écrit : I sympathise but I am not sure about this strategy, which depending on the capabilities of your VCS might obscure the commit history. I would recommend to simply use the “120 chars max” guideline for newly added code and when refactoring existing one. WDYT? Yes, that's what we decided already and I'm all for it. It's indeed the only way if we don't want to blur things in svn history. I simply forgot to format before committing I just did it at r1844909 Jacques
Re: Pursuing the “120 chars max” guideline
+1 for not reformatting all at once but only if there are changes anyway. The patch should mention this because it will make reviews more complex. Regards, Michael Am 26.10.18 um 11:13 schrieb Mathieu Lirzin: Hello Jacques, Jacques Le Roux writes: Yes you are right, the whole file should be reformatted. This "around 120 chars max" rule is "new" (few years) and most of the code there is more than a decade. OK, sure. If nobody disagree we could have a task Jira to reformat the code of the most important classes (with subtasks maybe, or simply patches for concerned classes). I sympathise but I am not sure about this strategy, which depending on the capabilities of your VCS might obscure the commit history. I would recommend to simply use the “120 chars max” guideline for newly added code and when refactoring existing one. WDYT? smime.p7s Description: S/MIME Cryptographic Signature
Re: Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler
Hello, +1 to follow the 120char guideline for any commit that the purpose it not to refactor line length :). Gil Le vendredi 26 oct. 2018 à 11:13:48 (+0200), Mathieu Lirzin a écrit : > Hello Jacques, > > Jacques Le Roux writes: > > > Yes you are right, the whole file should be reformatted. > > > > This "around 120 chars max" rule is "new" (few years) and most of the > > code there is more than a decade. > > OK, sure. > > > If nobody disagree we could have a task Jira to reformat the code of > > the most important classes (with subtasks maybe, or simply patches for > > concerned classes). > > I sympathise but I am not sure about this strategy, which depending on > the capabilities of your VCS might obscure the commit history. I would > recommend to simply use the “120 chars max” guideline for newly added > code and when refactoring existing one. > > WDYT? > > -- > Mathieu Lirzin > GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Pursuing the “120 chars max” guideline (was: svn commit: r1844729 - in /ofbiz/ofbiz-framework/trunk/framework/webapp: dtd/site-conf.xsd src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.jav
Hello Jacques, Jacques Le Roux writes: > Yes you are right, the whole file should be reformatted. > > This "around 120 chars max" rule is "new" (few years) and most of the > code there is more than a decade. OK, sure. > If nobody disagree we could have a task Jira to reformat the code of > the most important classes (with subtasks maybe, or simply patches for > concerned classes). I sympathise but I am not sure about this strategy, which depending on the capabilities of your VCS might obscure the commit history. I would recommend to simply use the “120 chars max” guideline for newly added code and when refactoring existing one. WDYT? -- Mathieu Lirzin GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
