Re: Upgrading Groovy 2.4.16 → 2.5.8

2019-10-29 Thread Mathieu Lirzin
Thanks Gil, Committed in revision 1869136 (BTW I made a mistake by referencing OFBIZ-11268 instead of OFBIZ-11263). Gil Portenseigne writes: > I've test the upgrade and saw no issue, so +1. > > Gil > > > > Le 18:19 - dimanche 27 oct., Mathieu Lirzin a écrit : >> Hello, >> >> I have open

Re: Upgrading Groovy 2.4.16 → 2.5.8

2019-10-29 Thread Gil Portenseigne
Hello Mathieu, I've test the upgrade and saw no issue, so +1. Gil Le 18:19 - dimanche 27 oct., Mathieu Lirzin a écrit : > Hello, > > I have open OFBIZ-11263 [1] to upgrade Groovy to its latest stable > release on ‘trunk’. > > I did not detect any issue with the upgrade so I intend to

Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-29 Thread Jacopo Cappellato
On Tue, Oct 29, 2019 at 2:18 PM Aditya Sharma wrote: > Hi team, > > Just to clarify, as per commit message template document[1] the template is > > [Implemented|Improved|Fixed|Completed|Documented|Reverted]: [Jira > title|Free text] > > Can we use "Free text" instead of "Jira title" when

Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-29 Thread Mathieu Lirzin
Hello Aditya, Aditya Sharma writes: > Just to clarify, as per commit message template document[1] the template is > > [Implemented|Improved|Fixed|Completed|Documented|Reverted]: [Jira > title|Free text] > > Can we use "Free text" instead of "Jira title" when committing specifically > for any

Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-29 Thread Jacques Le Roux
Hi Aditya, I see no problems with that since sometimes the Jira title is not right (though we can then fix it before copying it), convenient, not long enough, or ... Jacques Le 29/10/2019 à 14:17, Aditya Sharma a écrit : Hi team, Just to clarify, as per commit message template document[1]

Re: svn commit: r1869039 - /ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ControlServlet.java

2019-10-29 Thread Aditya Sharma
Hi team, Just to clarify, as per commit message template document[1] the template is [Implemented|Improved|Fixed|Completed|Documented|Reverted]: [Jira title|Free text] Can we use "Free text" instead of "Jira title" when committing specifically for any Jira? 1.