Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Suraj Khurana
Many congratulations Gil and Mathieu !! -- Best Regards, Suraj Khurana Technical Consultant HotWax Systems On Wed, Dec 4, 2019 at 1:17 AM sharanf wrote: > Congratulations and welcome Gil and Mathieu! > > Thanks > Sharan > > On 2019-12-03 12:09, Deepak Dixit wrote: > > Welcome aboard! > > Many

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread sharanf
Congratulations and welcome Gil and Mathieu! Thanks Sharan On 2019-12-03 12:09, Deepak Dixit wrote: Welcome aboard! Many Many congrats Gil and Mathieu. Kind Regards, Deepak Dixit On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: The OFBiz PMC has

Re: OFBizDebug and OFBIZ-11302

2019-12-03 Thread Nicolas Malin
I agree to use native process that offer more standardization. Nicolas On 03/12/2019 09:45, Jacques Le Roux wrote: Le 02/12/2019 à 18:18, Mathieu Lirzin a écrit : Hello, Jacques Le Roux writes: With OFBIZ-11302 Mathieu removed the ofbizDebug Gradle task, because "ofbiz --debug-jvm" can be

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Taher Alkhateeb
Congratulations gentlemen! On Tue, Dec 3, 2019 at 6:33 PM Rishi Solanki wrote: > > Congratulations Gil and Mathieu!! > > Best regards, > -- > Rishi Solanki > *CTO, Mindpath Technology* > Intelligent Solutions > cell: +91-98932-87847 > > On Tue, Dec 3, 2019 at 7:43 PM Swapnil M Mane > wrote: > >

Re: ContactNumber optional on service definition

2019-12-03 Thread Rishi Solanki
Hi Suraj, It seems writing this service just to wrap the create and update logic in one service. So it uses the same IN parameters and constraints as inner services have. IMO, we can change the wrapper service behavior based on business requirements and override it. +1 for changing it. Best

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Rishi Solanki
Congratulations Gil and Mathieu!! Best regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 On Tue, Dec 3, 2019 at 7:43 PM Swapnil M Mane wrote: > Many congratulations Gil and Mathieu!! :) > > Best regards, > Swapnil M Mane, > ofbiz.apache.org > > >

ContactNumber optional on service definition

2019-12-03 Thread Suraj Khurana
Hello team, There is a service named 'createUpdatePartyTelecomNumber' in which contactNumber field is optional on service definition. >From DB fields perspective it seems good to have it optional, ideally I think it should not. Whether you are creating or updating any party telecom details,

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Swapnil M Mane
Many congratulations Gil and Mathieu!! :) Best regards, Swapnil M Mane, ofbiz.apache.org On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become > members of the committee and we are glad

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Pawan Verma
Many Congratulations Gil and Mathieu!! More power to you guys :) -- Thanks & Regards Pawan Verma Technical Consultant *HotWax Systems* *Enterprise open source experts* http://www.hotwaxsystems.com On Tue, Dec 3, 2019 at 5:27 PM Chinmay Patidar < chinmay.pati...@hotwaxsystems.com> wrote: >

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Chinmay Patidar
Congratulations Gil and Mathieu !!! Kind Regards, Chinmay Patidar On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become > members of the committee and we are glad to announce that they

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Jacques Le Roux
Happy to have you both on board :) Jacques Le 03/12/2019 à 12:13, Nicolas Malin a écrit : Welcome on board my fellows :) Nicolas On 03/12/2019 11:25, Jacopo Cappellato wrote: The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become members of the committee and we are glad to

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Nicolas Malin
Welcome on board my fellows :) Nicolas On 03/12/2019 11:25, Jacopo Cappellato wrote: The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become members of the committee and we are glad to announce that they have accepted the nomination. On behalf of the OFBiz PMC, welcome on

Re: Github PRs and Jira

2019-12-03 Thread Gil Portenseigne
+1 to use gitlab features to work around code, that will help collaboration. I don't know if there is an Apache alternative to get the features without Microsoft. But having two official tools to get contribution is not desired. I guess that using existent Github should be ok for official pull

Re: Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Deepak Dixit
Welcome aboard! Many Many congrats Gil and Mathieu. Kind Regards, Deepak Dixit On Tue, Dec 3, 2019 at 3:56 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become > members of the committee and we are glad to

Re: Github PRs and Jira

2019-12-03 Thread Jacques Le Roux
Le 03/12/2019 à 08:21, Jacopo Cappellato a écrit : Now that we have migrated to Git, in my opinion we should really consider to adopt the workflow based on PR as our primary method for accepting contributions. I understand that it is a relevant change for the community, but I also see many

Welcome Gil Portenseigne and Mathieu Lirzin as new PMC members

2019-12-03 Thread Jacopo Cappellato
The OFBiz PMC has invited Gil Portenseigne and Mathieu Lirzin to become members of the committee and we are glad to announce that they have accepted the nomination. On behalf of the OFBiz PMC, welcome on board!

Re: Github PRs and Jira

2019-12-03 Thread Jacques Le Roux
Hi, Actually not, a good idea to create a sub-task of OFBIZ-11268 Thanks Jacques Le 03/12/2019 à 06:36, Rishi Solanki a écrit : Hi, Do we have committers practices document ready for git? Sorry if I missed the discussion if already done. Best Regards, -- Rishi Solanki *CTO, Mindpath

Re: OFBizDebug and OFBIZ-11302

2019-12-03 Thread Jacques Le Roux
Le 02/12/2019 à 18:18, Mathieu Lirzin a écrit : Hello, Jacques Le Roux writes: With OFBIZ-11302 Mathieu removed the ofbizDebug Gradle task, because "ofbiz --debug-jvm" can be used instead. This is now ‘gradlew "ofbiz" --debug-jvm’ with the --debug-jvm outside of the double quotes. g

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2019-12-03 Thread Jacques Le Roux
Hi Nicolas, Great, I think we should use it as a team, nobody against? Jacques Le 03/12/2019 à 09:21, Nicolas Malin a écrit : I haven't plugin installed, only famework. Thanks for your sharing a will use that. Nicolas On 02/12/2019 17:32, Jacques Le Roux wrote: Le 30/11/2019 à 08:58,

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2019-12-03 Thread Nicolas Malin
I haven't plugin installed, only famework. Thanks for your sharing a will use that. Nicolas On 02/12/2019 17:32, Jacques Le Roux wrote: Le 30/11/2019 à 08:58, Jacques Le Roux a écrit : I think we should rely on a  Checkstyle pre-commit hook: https://gist.github.com/davetron5000/37350 to