Re: General OFBiz release strategy

2020-02-14 Thread Jacques Le Roux
Le 14/02/2020 à 16:46, Nicolas Malin a écrit : Hi, On 08/02/2020 14:25, Michael Brohl wrote: Hi all, [...] A good roadmap would include a mix of core development tasks (making the framework better, new features in the applications and bugfixes). I can image a roadmap with certain goals might

Re: checkstyle improvements

2020-02-14 Thread Gil Portenseigne
Inline, > > I'm kinda prefer the "opposite approach", but we need to discuss if this > > improvement is worth the history lost. > > > > In the example you chose, i see no issue capitalizing module, > > resource and other. Updating the rule offer the ability to write a > > constant like : MoDuLe

Re: General OFBiz release strategy

2020-02-14 Thread Nicolas Malin
Hi, On 08/02/2020 14:25, Michael Brohl wrote: > Hi all, > > [...] > A good roadmap would include a mix of core development tasks (making > the framework better, new features in the applications and bugfixes). > I can image a roadmap with certain goals might also motivate more > contributors to

Re: checkstyle improvements

2020-02-14 Thread Gil Portenseigne
Hello Pierre, It is interesting but i guess that will be the next step. Thanks On Fri, Feb 14, 2020 at 09:04:49AM +0100, Pierre Smits wrote: > It seems many projects (including those Apache projects in the Hadoop > sphere) use the works of the Apache Yetus (see [1]) project to do > pre-commit

Re: Backport OFBIZ-11317

2020-02-14 Thread Michael Brohl
Please have a closer look at your commit, the controlPath functionality is implemented in the UrlRegexpTransform class... The implementing class for ofbizUrl is configured in the freemarkerTransforms.properties which is OfbizurlTransform for framework/webapp but UrlRegexpTransform for

Re: Backport OFBIZ-11317

2020-02-14 Thread Jacques Le Roux
Le 13/02/2020 à 13:06, Michael Brohl a écrit : There's currently only few questions left for me: we have one configuration which uses org.apache.ofbiz.webapp.ftl.OfbizUrlTransform for ofbizUrl and this would not support the controlPath configuration if I don't miss something. Wouldn't it be

Re: OFBiz contributions & Github Pull Requests

2020-02-14 Thread Jacques Le Roux
+1 Jacques Le 14/02/2020 à 12:29, Pierre Smits a écrit : Hi Nicolas, Your suggestion to show only open PRs is way better. I will update the page. Thanks! Best regards, Pierre Smits *Proud* *contributor* (but without privileges)* of* Apache OFBiz , since 2008

Re: OFBiz contributions & Github Pull Requests

2020-02-14 Thread Pierre Smits
Hi Nicolas, Your suggestion to show only open PRs is way better. I will update the page. Thanks! Best regards, Pierre Smits *Proud* *contributor* (but without privileges)* of* Apache OFBiz , since 2008 *Apache Trafodion , Vice

Re: OFBiz contributions & Github Pull Requests

2020-02-14 Thread Nicolas Malin
Hi, On 31/01/2020 15:53, Pierre Smits wrote: > Pull Request available on Github can be seen in the local clone. In order > to have this working, the following line should be added to the git > configuration of the local clone: > > fetch = +refs/pull/*/head:refs/remotes/origin/pr/* > > >

Re: checkstyle improvements

2020-02-14 Thread Pierre Smits
It seems many projects (including those Apache projects in the Hadoop sphere) use the works of the Apache Yetus (see [1]) project to do pre-commit checks (including IIUC checkstyle, in an automate way) on patch files attached to JIRA tickets and Pull Requests in Github against the latest commit in