Re: Codenarc integration, rules to use.

2022-07-08 Thread Jacques Le Roux
Hi Gil, Great initiative, so far it seems we have a lazy consensus We (almost*) did it for Java, why not for Groovy :) Jacques * OFBIZ-12341 Le 04/07/2022 à 17:24, Gil Portenseigne a écrit : Hello Devs, I would like to continue Codenarc integration in OFBiz (OFBIZ-11167). For those who ar

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-08 Thread Scott Gray
Hi Giulio, I think the hardcoded "N" is used there because a reservation is being deleted and then recreated. The assumption there is that if a reservation existed before the process, then it should also exist after the process and should not simply disappear because a physical inventory was reco

Re: Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-08 Thread Nicolas Malin
Hello Giulio, I thinks it's good to remove hard coded value and move it on the productStore. Keep the N as default if you didn't found any value. I use your focus on this subject to know if you want to help me to convert the minilang inventory service to groovy. I can realize the conversion with

https://ofbiz.apache.org/release-notes-17.12.02.html missing

2022-07-08 Thread Jacques Le Roux
Hi, We have a 404 at https://ofbiz.apache.org/release-notes-17.12.02.html TIA

Possible issue in balanceInventoryItems/reassignInventoryReservation service

2022-07-08 Thread Giulio Speri - MpStyle Srl
Hello devs, I hope you're doing good! I write because I think I found a possible issue in minilang service *reassignInventoryReservation*. This service is called as a SECA on createPhysicalInventoryAndVariance service and at the end it deletes inventory reservation for an order items that has qua