Re: Welcome Erwan De Ferrieres as a new OFBiz PMC member

2012-02-08 Thread Pranay Pandey
Congrats Erwan!

Thanks and Regards
---
Pranay Pandey




On Feb 7, 2012, at 1:51 AM, Erwan de FERRIERES wrote:

 Le 06/02/2012 19:29, Jacopo Cappellato a écrit :
 Welcome to Erwan as our new OFBiz PMC member.
 The current members of the OFBiz PMC have voted in favour of inviting Erwan 
 to join the PMC, the vote has been approved by the ASF Board and Erwan has 
 accepted our invitation.
 
 Thank you Erwan and thank you Jacques for your proposal.
 
 Kind regards,
 
 Jacopo
 
 
 Thanks Jacques for suggesting my name, and to the PMC for voting me in!
 
 -- 
 Erwan de FERRIERES
 www.nereide.biz



Do I need to restart the server when I change a controller entry

2009-02-07 Thread Pranay Pandey
I am observing that when ever I am changing a request in controller,  
for reflecting changes I have to restart the server.

Is there something which I am missing.

Thanks  Regards
--
Pranay Pandey




smime.p7s
Description: S/MIME cryptographic signature


Re: Do I need to restart the server when I change a controller entry

2009-02-08 Thread Pranay Pandey

Thank you so much David.

--
Pranay

On Feb 9, 2009, at 9:22 AM, Ashish Vijaywargiya wrote:


Thanks David for taking care of this one.

--
Ashish

On Sun, Feb 8, 2009 at 3:19 PM, David E Jones
david.jo...@hotwaxmedia.com wrote:


This is fixed in rev 742035.

-David


On Feb 7, 2009, at 5:01 AM, Pranay Pandey wrote:

I am observing that when ever I am changing a request in  
controller, for

reflecting changes I have to restart the server.
Is there something which I am missing.

Thanks  Regards
--
Pranay Pandey









smime.p7s
Description: S/MIME cryptographic signature


Re: Moving ecommerce to specialpurpose

2009-03-13 Thread Pranay Pandey

+1

This change will be good.

Thanks  Regards
--
Pranay Pandey



On Mar 13, 2009, at 12:26 PM, David E Jones wrote:



This was discussed a while back around the time that specialpurpose  
was introduce, and pos and other things were moved there, but we  
decided on not doing it at the time because of concerns about non- 
backward-compatible impact.


Since we are getting ready to do a release branch, probably in a  
couple of weeks, now might be a good time for it.


The probably impact will be for anything that refers to  
applications/ecommerce, and that will have to change to  
specialpurpose/ecommerce. That includes patches, custom code, etc.  
Most things that treat ecommerce just like any other component  
(especially using the component://ecommerce/... syntax) will not be  
affected by this.


Unless there are major objections I'll plan on doing this sometime  
in the next couple of days.


-David





smime.p7s
Description: S/MIME cryptographic signature


Re: Main New features

2009-03-24 Thread Pranay Pandey

Thanks Jacques for reminder.
I will do the needful for the recent improvements done in PO processing.

Kind Regards
--
Pranay Pandey


On Mar 24, 2009, at 3:30 AM, Jacques Le Roux wrote:

Please guys, don't forget to add your changes in Main New features  
with a short explanation
I think at Webslinger for instance, but I'm pretty sure there are  
others


http://docs.ofbiz.org/display/OFBIZ/Main+New+features

Thanks

JAcques





smime.p7s
Description: S/MIME cryptographic signature


Re: Main New features

2009-03-24 Thread Pranay Pandey

Hello Jacques,

Its done. Thanks again.

Kind Regards
--
Pranay Pandey


On Mar 24, 2009, at 11:50 AM, Pranay Pandey wrote:


Thanks Jacques for reminder.
I will do the needful for the recent improvements done in PO  
processing.


Kind Regards
--
Pranay Pandey


On Mar 24, 2009, at 3:30 AM, Jacques Le Roux wrote:

Please guys, don't forget to add your changes in Main New features  
with a short explanation
I think at Webslinger for instance, but I'm pretty sure there are  
others


http://docs.ofbiz.org/display/OFBIZ/Main+New+features

Thanks

JAcques







smime.p7s
Description: S/MIME cryptographic signature


Re: new functionality in the controller

2009-03-26 Thread Pranay Pandey

+1
This should be available on wiki.

Thanks  Regards
--
Pranay Pandey
On Mar 27, 2009, at 2:01 AM, Jacques Le Roux wrote:

Thanks for the clear explanation Hans! Maybe we could write  
something in the wiki about all that?


Jacques

From: Hans Bakker mailingl...@antwebsystems.com
In the development of the mypage/myportal component I ran into a  
problem
where i needed to show a screen (view) from different places and be  
able

to return to the place it was called from.
In the past we did that with donePage variables which was a bit  
messy.
We discussed this in the mailing list and David came up with a  
solution

to this problem which will save a lot of screen/form code.
how does it work?
In the controller.xml it is now possible to save the last view  
displayed

and return to it at a later stage.
In the response tag a parameter is added: 'save-last-view'
response name=success type=view value=justAView
save-last-view=true/
This will save the view that WAS displayed, not the one that is  
going to

be displayed.
Then later on it is possible to override a view with this saved view
with   response name=success type=view-last value=justAView/
This is working pretty good, however when i was using it in the new
portal functions i found the following problems:
1. it is only possible to store the last view, not the one that is  
going

the be displayed. If there was a 'lookup' view after the 'real' last
one, that lookup got saved. So there is a need to save the 'current'
view
2. sometimes you want to be able to save 2 views. A 'current' view  
and a
'home' view. An example is the portal page, create an email, add a  
role

(return to email) , send the email (return to portal page=home)
so i extended the implementation from David with the following tag
extensions using the same pattern as the 'view-last/save-last-view':
save-last-view
save-current-view
save-home-view
view-Last
view-home
This is all committed with a number of other changes in revision:
758522.
regards,
Hans
--
Antwebsystems.com: Quality OFBiz services for competitive rates







smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r761922 - in /ofbiz/trunk/applications/product: config/ servicedef/ src/org/ofbiz/shipment/verify/ webapp/facility/WEB-INF/ webapp/facility/WEB-INF/actions/shipment/ webapp/facility/sh

2009-04-04 Thread Pranay Pandey

Thanks Vikas, for all your support.

Kind Regards
--
Pranay Pandey




On Apr 4, 2009, at 6:55 AM, m...@apache.org wrote:


Author: mor
Date: Sat Apr  4 12:55:23 2009
New Revision: 761922

URL: http://svn.apache.org/viewvc?rev=761922view=rev
Log:
New screen in facility - Verify Pick to allow user to verify a pick.
Applied patch from jira issue OFBIZ-2226 (https://issues.apache.org/jira/browse/OFBIZ-2226 
)




Re: [VOTE] Create Release Branch 2009.04

2009-04-15 Thread Pranay Pandey

+1

Thanks  Regards
--
Pranay Pandey



On Apr 15, 2009, at 2:44 AM, David E Jones wrote:



Today is the day we have discussed for a while! A lot of  
improvements and fixes have gone in over the last few weeks, but it  
is important to remember that the release branch is primarily time- 
based and is a line in the sand as it were to begin the effort of  
stabilizing a specific code base so that end-users who want  
stability over features have that option. Some things make it in,  
and other things don't make it, and that is true no matter when we  
draw the line (but we don't want to delay it forever). What we have  
in place it a HUGE improvement over the release4.0 branch, and that  
is the most important point to keep in mind.


Along with that there is a planned press release coordinated with  
the Apache Software Foundation Public Relations Committee (that's a  
mouthful! no wonder we use acronyms like: ASF PRC) for tomorrow  
morning (Wed 15 April).


That said, the target date/time for the release branch is later  
tonight (and when I say tonight I mean according to USA time, just  
to clarify). To follow the date pattern we have discussed and make  
it clearly a date I'm thinking of the actual name for the branch  
directory to be release200904 (and please feel free to comment on  
that if you think something else is better).


However, that I will only do that IFF we have a positive vote for  
the release, hence this message!


Please vote:

[+1] Create the release branch tonight, April 14th (it will be April  
15th for GMT-0)

[+0] Abstain
[-1] Do not create the release branch tonight

Please remember that everyone is free to (and encouraged to!) vote,  
but only the PMC votes are binding.


Thanks to everyone who has made this possible with amazing  
contributions over the last 2 years, and a heightened activity in  
recent weeks and months to make this a spectacular release.


-David







smime.p7s
Description: S/MIME cryptographic signature


Re: [VOTE][RESULT] Create Release Branch 2009.04

2009-04-17 Thread Pranay Pandey

Thanks David.

This is another milestone achieved by OFBiz community. Congratulations  
to all involved in the project.


Regards
--
Pranay Pandey




On Apr 17, 2009, at 3:49 PM, Ashish Vijaywargiya wrote:


Thanks David for creating the branch release.

Thanks to everybody who is involved directly / indirectly in the  
project !


--
Ashish Vijaywargiya

On Fri, Apr 17, 2009 at 3:10 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

Yes, thank you David, and thank you also to all the people that  
made this

new step for OFBiz possible!

Jacques

From: Adrian Crum adrian.c...@yahoo.com


David,


Thank you so much for your work on this! Combined with the  
forthcoming

press release, I believe OFBiz will be entering a new era.

-Adrian







smime.p7s
Description: S/MIME cryptographic signature


Re: svn commit: r767394 - in /ofbiz/trunk/applications: accounting/config/ accounting/servicedef/ accounting/src/org/ofbiz/accounting/invoice/ order/config/ product/config/ product/servicedef/ product

2009-04-22 Thread Pranay Pandey

Thanks Vikas.

Regards
--
Pranay Pandey
HotWax Media
www.hotwaxmedia.com


On Apr 22, 2009, at 12:20 PM, m...@apache.org wrote:


Author: mor
Date: Wed Apr 22 06:50:16 2009
New Revision: 767394

URL: http://svn.apache.org/viewvc?rev=767394view=rev
Log:
Facilitate packing screen to use verified orders from Verify Pick  
screen by using existing shipment and invoice.
Patch from Akash Jain (reviewed and tested by Pranay Pandey), Part  
of OFBIZ-2329 (https://issues.apache.org/jira/browse/OFBIZ-2329).


Note: I have done little modifications to the new labels part of  
this patch.


This issue completes the functionality of the Verify Pick feature  
added recently. I would like to port these changes to release09.04  
later today

if I do not see any objections.



Modified:
   ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
   ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml
   ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
invoice/InvoiceServices.java

   ofbiz/trunk/applications/order/config/OrderErrorUiLabels.xml
   ofbiz/trunk/applications/product/config/ProductErrorUiLabels.xml
   ofbiz/trunk/applications/product/servicedef/services_shipment.xml
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/ 
PackingServices.java
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/ 
PackingSession.java
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSession.java
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSessionRow.java
   ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/ 
shipment/PackOrder.groovy
   ofbiz/trunk/applications/product/webapp/facility/WEB-INF/actions/ 
shipment/VerifyPick.groovy
   ofbiz/trunk/applications/product/webapp/facility/shipment/ 
PackOrder.ftl


Modified: ofbiz/trunk/applications/accounting/config/ 
AccountingUiLabels.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=767394r1=767393r2=767394view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/config/ 
AccountingUiLabels.xml (original)
+++ ofbiz/trunk/applications/accounting/config/ 
AccountingUiLabels.xml Wed Apr 22 06:50:16 2009

@@ -6390,6 +6390,9 @@
value xml:lang=thปัญหามีผลต่ภ 
โปรแกรมประยุกต์ใช้กาภ
£à¸Šà¸³à¸£à¸°à¹€à¸‡à¸´à¸™à¸ªà¸³à¸«à¸£à¸±à¸šà¸£à¸«à¸±à¸ªà¸à¸²à¸ 
£à¸Šà¸³à¸£à¸°à¹€à¸‡à¸´à¸™ [${invoiceId}]/value
value xml:lang=zh为发票编号[$ 
{invoiceId}]获得支付应用时出错/value

/property
+property key=AccountingProblemGettingShipmentItemBilling
+value xml:lang=enProblem getting ShipmentItemBilling  
records/value

+/property
property key=AccountingProblemLookingUpOrderItemBilling
value xml:lang=enProblem looking up OrderItemBilling  
records for ${billFields}/value
value xml:lang=esProblema buscando Elemento de orden de  
facturación para ${billFields}/value


Modified: ofbiz/trunk/applications/accounting/servicedef/ 
services_invoice.xml

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml?rev=767394r1=767393r2=767394view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/servicedef/ 
services_invoice.xml (original)
+++ ofbiz/trunk/applications/accounting/servicedef/ 
services_invoice.xml Wed Apr 22 06:50:16 2009

@@ -152,7 +152,7 @@
/description
attribute name=orderId type=String mode=IN  
optional=false/
attribute name=billItems type=List mode=IN  
optional=false/
-attribute name=invoiceId type=String mode=OUT  
optional=true/
+attribute name=invoiceId type=String mode=INOUT  
optional=true/
attribute name=invoiceTypeId type=String mode=OUT  
optional=true/

/service
service name=createInvoiceFromReturn engine=java

Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/ 
accounting/invoice/InvoiceServices.java

URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/invoice/InvoiceServices.java?rev=767394r1=767393r2=767394view=diff
= 
= 
= 
= 
= 
= 
= 
= 
==
--- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
invoice/InvoiceServices.java (original)
+++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/ 
invoice/InvoiceServices.java Wed Apr 22 06:50:16 2009

@@ -151,6 +151,7 @@

String orderId = (String) context.get(orderId);
List billItems = (List) context.get(billItems);
+String invoiceId = (String) context.get(invoiceId);
boolean previousInvoiceFound = false;

if (billItems == null || billItems.size() == 0

Re: [jira] Created: (OFBIZ-2341) The pages should be strechtable

2009-04-23 Thread Pranay Pandey

Hello Jacques,

I did few adjustments in the images attached their in Practice  
Application.
Now looks little better have a look Practice Application (Hello  
World...)


Thanks  Regards
--
Pranay Pandey


On Apr 22, 2009, at 5:40 PM, Jacques Le Roux (JIRA) wrote:


The pages should be strechtable
---

Key: OFBIZ-2341
URL: https://issues.apache.org/jira/browse/OFBIZ-2341
Project: OFBiz
 Issue Type: Sub-task
   Reporter: Jacques Le Roux


Pages in the doc should be able to strecht. Sometimes you need a  
wider table or \{code} block, etc.
For instance look what happens at the [Creating Practice Application  
(hello world) page|http://docs.ofbiz.org/display/OFBIZ/OFBiz+Beginners+Development+Guide+Using+Practice+Application+(helloworld) 
]. This page is a reference and often used...


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.





smime.p7s
Description: S/MIME cryptographic signature


User friendly error/sucess messages for customer facing application

2009-05-06 Thread Pranay Pandey

Hello Devs,

Initiating it here for discussion on this.

These are the contents from https://issues.apache.org/jira/browse/OFBIZ-2426 
.


=

I want to propose a change and want to ask for the suggestions for the  
way to go for it.


Proposal:
Should have appropriate user friendly success/error messages for  
eCommerce applicaiton on the execution of an event from user. As  
eCommerce is the customer facing application.

E.g.
1.  When user creates his/her profile then then the *success message*  
shown is *The following occurred:
The action was performed successfully. * while it should be shown  
something like: *New user created successfully.* or *User profile  
created successfully*
2.  When we talk about an error message then e.g. when user tries to  
login with wrong userId or pwd the message shown is *The Following  
Errors Occurred:
error following occurred during login: User not found.* which should  
be something like: *User not found* or when password is incorrect  
*Password is incorrect*


There are more places where this can observed well that the success/ 
error messages are not best suited for eCommerce application.


Right now for both of back-office and front-end(eCommerce) application  
we use the same common/webcommon/includes/messages.ftl which shows the  
same messages as of back office application for many operations.


The idea is we should introduce a new Messages.ftl file for ecommerce  
only which will show user friendly error/success messages to the front- 
end user who is the customer.


I would really appreciate comments from community members on this issue.

=

Please provide suggestions, thoughts in the reply to this email.


Thanks  Regards
--
Pranay Pandey
HotWax Media | http://www.hotwaxmedia.com
Direct: +919826035576
Skype: pranay.pandey



smime.p7s
Description: S/MIME cryptographic signature


Re: [jira] Updated: (OFBIZ-3379) Email sending process using one connection for To/CC/BCC causing issues

2009-12-24 Thread Pranay Pandey

Hi Ruth,

Thanks for looking into it and replying.
I imagine a case where customer is asking for the status of his order to 
Company CSR as he was successful in placing an order from ecommerce 
application with a wrong email address, which was syntactically correct. 
But company didn't receive any email because of email sending failure. I 
accept that there is a way for CSR to go to the order manager and  find 
the appropriate order but usually CSR or Company executive logs in to 
the order manager only when they receive an email for an order. Also the 
general behavior of mail client.


Also think of an organization where they don't want to login to the back 
office application and they manage their order in other systems based on 
the order email notifications. Then the only way to know about any order 
placed is the email notification that company receives as a BCC receiver.


There may be other ways of handling this or as you said this can be a 
configuration setting. I would love to hear community opinion on this.


Thanks  Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com
Direct: +91 98260 35576
Ext: 442



Ruth Hoffman wrote:
But, I would think in the normal business setting, if the original 
failed for some reason, you would not want to sent the BCC. Why send a 
copy if the original failed?

Ruth
Pranay Pandey (JIRA) wrote:
 [ 
https://issues.apache.org/jira/browse/OFBIZ-3379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel 
]


Pranay Pandey updated OFBIZ-3379:
-

Attachment: OFBIZ-3379.patch

Here is the patch for review.

 

Email sending process using one connection for To/CC/BCC causing issues
---

Key: OFBIZ-3379
URL: https://issues.apache.org/jira/browse/OFBIZ-3379
Project: OFBiz
 Issue Type: Bug
 Components: framework
   Affects Versions: Release Branch 9.04, SVN trunk
   Reporter: Pranay Pandey
Fix For: Release Branch 9.04, SVN trunk

Attachments: OFBIZ-3379.patch


Typically BCCs are handled via the sending mail client. That is, 
when the client sees a BCC in an email, it will open up two 
connections to the mail server, the first for the To/CC fields, the 
second for BCC fields, this way the addresses are masked from the 
headers and there is that layer of anonymity that BCC is used for.
What appears to be happening is that OFBiz is sending all of the 
information in one connection to the mail server and having the mail 
server sort out the details. So when sendTo encountering an invalid 
email, and then terminating the remaining execution of the outgoing 
process and no email sent to BCC address which is usually going to 
be a valid address from email settings for the company.
The fix the issue, we need to send this via two connection to mail 
client.



  


Re: [jira] Closed: (OFBIZ-4006) jQuery Test and Bug fixing

2010-12-01 Thread Pranay Pandey

I would say merge jQuery, and then release branch.

Thanks  Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com
pranay.pan...@hotwaxmedia.com


On Nov 28, 2010, at 11:49 PM, Jacques Le Roux wrote:


Other opinions?

Jacques

From: Bruno Busco bruno.bu...@gmail.com
I would prefer to have the release branch before the merge with  
jQuery.

-Bruno
2010/11/27 Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
We may want to create a new release branch (before or after the  
merge with

jQuery?) and officially release 10.04.

Jacopo

On Nov 27, 2010, at 10:57 AM, Jacques Le Roux wrote:

 Yes, there is no hurry to merge jQuery, and a branch before  
could be a

good idea indeed.
 This could be an answer for removing or not all Prototype/Dojo  
from the

trunk.
 With this branch people could rely on it for Prototype/Dojo. Those
interested by the trunk are already leaving on the leading-edge  
and should

not worry too much.

 On the other hand maybe some would prefer to have jQuery in the  
next
release? And also should we wait 11.xx? 11.01 would be okay for  
me...


 BTW for those interested  please be sure to check this thread  
(Bilgin
noticed that I mixed 2 subjects in it: jQuery docs and demo and  
removing

Prototype/Dojo from the trunk or not)
 http://markmail.org/message/mpdywy4ymkjddrpr

 Jacques

 From: Bruno Busco bruno.bu...@gmail.com
 What about creating a new release branch before merging the  
jquery ?


 -Bruno

 2010/11/26 Jacques Le Roux jacques.le.r...@les7arts.com

 Hi Rohit,

 Hopefully before new year, but we will need more testing,  
could you

help?

 Thanks

 Jacques

 From: rohit rohitksur...@yahoo.com


 hi,

 when can we expect the jQuery branch to be merged with the  
truck, it

that
 expected at all...

 thanks

 rohit

 --
 View this message in context:

http://ofbiz.135035.n4.nabble.com/jira-Created-OFBIZ-4006-jQuery-Test-and-Bug-fixing-tp3016706p3060540.html
 Sent from the OFBiz - Dev mailing list archive at Nabble.com.
















Re: ebay vs ebay store

2011-01-22 Thread Pranay Pandey
+1

Thanks  Regards
--
Pranay Pandey




On Jan 22, 2011, at 9:44 AM, Arun Patidar wrote:

 Hi,
 
 ebay component functionalities is working fine on latest trunk but ebaystore 
 component having some issues. So before removing ebay component we should 
 make sure that ebaystore component functionalities are working properly. I 
 have created task for ebay and ebaystore misc issues 
 https://issues.apache.org/jira/browse/OFBIZ-4118
 
 Thanks  Regards
 
 Arun Patidar
 
 BJ Freeman wrote:
 ok quick review.
 ebay was first.
 ebaystore had more of the ebay API fleshed out in services.
 ebaystore also has the help.
 I will put out a email on the user list to see if anyone has ebay in a 
 production server.
 
 if no response in a month then I suggest we remove ebay.
 
 =
 BJ Freeman
 Strategic Power Office with Supplier Automation  
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com  http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist
 
 Chat  Y! messenger: bjfr33man
 
 
 BJ Freeman sent the following on 1/21/2011 11:47 AM:
 sorry did not respond before, guess was hoping Hans would give some light.
 I have looked at it briefly will give you a response by Monday if no one
 else takes up the gauntlet.
 
 =
 BJ Freeman
 Strategic Power Office with Supplier Automation
 http://www.businessesnetwork.com/automation/viewforum.php?f=52
 Specialtymarket.com http://www.specialtymarket.com/
 Systems Integrator-- Glad to Assist
 
 Chat Y! messenger: bjfr33man
 
 
 Jacques Le Roux sent the following on 1/21/2011 9:59 AM:
 Hi,
 
 I have already asked this question, but does somebody knows why we have
 ebay and ebay store components? What are the key diffs between them?
 
 Thanks
 
 Jacques
 
 
 
 
 
 



Re: Welcome to Sascha Rodekamp as new committer

2011-02-16 Thread Pranay Pandey
Congratulations Sascha!

Thanks  Regards
--
Pranay Pandey
HotWax Media
www.hotwaxmedia.com

On Feb 15, 2011, at 1:27 PM, Jacopo Cappellato wrote:

 Sascha Rodekamp has accepted the invitation of the OFBiz PMC to become a new 
 committer.
 
 Welcome aboard Sascha!
 
 Jacopo
 
 With great power comes great responsibility.
 



Re: Moving demo data to their appropriate components

2011-08-22 Thread Pranay Pandey
+1
 

Thanks and Regards
---
Pranay Pandey




On Aug 21, 2011, at 7:09 PM, Scott Gray wrote:

 What does everyone think about moving the ton of demo data living in 
 ecommerce out to the components where the entities are defined?
 
 My main motivation for asking about this is for testing to ensure that we can 
 run all the framework and application tests even when all special purpose 
 components are removed.  With the increasing number of special purpose apps 
 containing extend-entity definitions I'm concerned about the possibility of 
 the base applications developing dependencies on that extended data model, 
 unintentionally or otherwise.
 
 We already have plenty of framework code that depends on base application 
 entities and I'd hate to see the situation get worse with dependencies in the 
 base apps or framework on the special purpose data model.
 
 I'm willing to move the data so this isn't one of those conversations where 
 nothing will actually get done.
 
 Thanks
 Scott
 



smime.p7s
Description: S/MIME cryptographic signature


Re: add person question

2008-08-02 Thread Pranay Pandey
Jose,

As Scott said the createPerson service is running fine(I was also saying
this only). You should check the service definition for importEmaisFromSite
which is calling createPerson.

-- 
Thanks  Regards
--
Pranay Pandey
Indore, India

On Sat, Aug 2, 2008 at 6:37 PM, jose junior malheiros barros 
[EMAIL PROTECTED] wrote:

 Thanks Pranay Pandey,

 I am trying to use the services already ready of partymgr component in
 folder applications/party. The service definition is this:

 service name=createPerson engine=java default-entity-name=Person
 location=org.ofbiz.party.party.PartyServices
 invoke=createPerson auth=false
 descriptionCreate a Person/description
 auto-attributes mode=INOUT include=pk optional=true/
 auto-attributes mode=IN include=nonpk optional=true/
 attribute name=statusId type=String mode=IN
  optional=true/
 attribute name=preferredCurrencyUomId type=String mode=IN
 optional=true/
 attribute name=description type=String mode=IN
 optional=true/
 override name=firstName optional=false/
 override name=lastName optional=false/
 /service

 --- Em sáb, 2/8/08, Pranay Pandey [EMAIL PROTECTED]
 escreveu:
 De: Pranay Pandey [EMAIL PROTECTED]
 Assunto: Re: add person question
 Para: dev@ofbiz.apache.org
 Data: Sábado, 2 de Agosto de 2008, 1:51

 Hello Jose,

 I think you should check the service definition you have given. Because
 you are returning serviceResults which is having the party Id and may be
 it has not been included in your service definition.
 Exception report says this only.

 --
 Thanks  Regards

 Pranay Pandey



 jose junior malheiros barros wrote:
  I am trying to add a person only with firsName and lastName. The code
 used:
 
  GenericDelegator delegator = dctx.getDelegator();
 GenericValue userLogin
 =delegator.findByPrimaryKey(UserLogin,
  context.put(firstName, chico);
  context.put(lastName, cesar);
  context.put(userLogin, userLogin);
  Map serviceResults = dispatcher.runSync(createPerson,
 context);
  return serviceResults;
 
  but receive the error Unknow parameter PartyId.
 
 
  2008-08-01
  13:37:07,407 (http-0.0.0.0-8080-Processor3) [
  RequestHandler.java:239:INFO ] [Processing Request]:
  importEmaisFromSite sessionId=824A77417DF7CE083D2E930C3055B63C.jvm1
  2008-08-01
 
  13:37:07,407 (http-0.0.0.0-8080-Processor3) [
  Integrator.java:38 :INFO ] Running method
  Integrator.processUreadEmailsFromSite
  2008-08-01
  13:37:07,422 (http-0.0.0.0-8080-Processor3) [
  SequenceUtil.java:258:INFO ] Got bank of sequenced IDs for [Party];
  curSeqId=10080, maxSeqId=10090, bankSize=10
  2008-08-01 13:37:07,438
  (http-0.0.0.0-8080-Processor3) [ ServiceEcaRule.java:140:INFO ]
  Running Service ECA Service: ensureNaPartyRole, triggered by rule on
  Service: createPerson
  2008-08-01 13:37:07,485
  (http-0.0.0.0-8080-Processor3) [UtilXml.java:246:DEBUG] XML
  Read 0.031s:
 

 file:/D:/opentaps-1.0/applications/party/script/org/ofbiz/party/party/PartySimpleMethods.xml
  2008-08-01 13:37:07,500 (http-0.0.0.0-8080-Processor3) [
 ServiceDispatcher.java:470:DEBUG] Sync service
   [pedido/ensureNaPartyRole] finished in [62] milliseconds
  2008-08-01
  13:37:07,500 (http-0.0.0.0-8080-Processor3) [
  ServiceDispatcher.java:470:DEBUG] Sync service [pedido/createPerson]
  finished in [78] milliseconds
  2008-08-01 13:37:07,500
  (http-0.0.0.0-8080-Processor3) [   ModelService.java:481:ERROR]
  [ModelService.validate] : {importEmaisFromSite} : (OUT) Required test
  error: org.ofbiz.service.ServiceValidationException: Unknown parameter
  found: [importEmaisFromSite.partyId]
  2008-08-01 13:37:07,500 (http-0.0.0.0-8080-Processor3) [
 ServiceDispatcher.java:377:ERROR]
   exception report
 --
  Outgoing result (in runSync : importEmaisFromSite) does not match
 expected
 requirements
  Exception: org.ofbiz.service.ServiceValidationException
  Message: Unknown parameter found: [importEmaisFromSite.partyId]
   stack trace
   ---
  org.ofbiz.service.ServiceValidationException: Unknown parameter found:
   [importEmaisFromSite.partyId]
  org.ofbiz.service.ModelService.validate(ModelService.java:549)
  org.ofbiz.service.ModelService.validate(ModelService.java:479)
  org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:375)
  org.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:214)
  org.ofbiz.service.GenericDispatcher.runSync(GenericDispatcher.java:152)
 

 org.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:310)
  org.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:448)
 
 org.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:277)
  org.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:192

Re: New promotions rules conditions

2008-11-06 Thread Pranay Pandey

Hello Jacques,

That really seems good for having these conditions inn. More  
variations will available for setting up promo condition.

So I would say +1 to this.


Thanks  Regards
--
Pranay Pandey
Manager, Enterprise Software Development
HotWax Media Pvt. Ltd.
[EMAIL PROTECTED]
www.hotwaxmedia.com

Office : +917314093684
Direct : +919826035576


On Nov 7, 2008, at 1:23 AM, Jacques Le Roux wrote:


I have recently written 2 new promotions rules condtions for a client.
They are derived from
   Order sub-total X in last Y Months
and are respectively
   Order sub-total X since beginning of current year
and
   Order sub-total X last year

They are a pretty trivial derviations from Order sub-total X in  
last Y Months, but I wonder though if it would be interesting to  
commit them, what do you think ?


Thanks

Jacques




Re: Selenium Presentation for OFBiz - Re: OOTB Unit Tests (was Re: Stable trunk?)

2008-11-07 Thread Pranay Pandey

Thanks Brett, Hans much appreciated.

Kind Regards
--
Pranay Pandey


On Nov 8, 2008, at 1:21 AM, Hans Bakker wrote:


Thank you Brett,

very interesting presentation. We sure should have these tests  
included

as part of the application test.

Actually all of the OFBiz presentations are available at the following
links:
http://us.apachecon.com/c/acus2008/schedule/2008/11/05
http://us.apachecon.com/c/acus2008/schedule/2008/11/06

go to the presentation you are interested in and from that page the
presentation slides can be downloaded.

Regards,
Hans

On Fri, 2008-11-07 at 11:21 -0700, Brett Palmer wrote:

FYI,

Here is the link to the presentation on Selenium that I gave at the
ApacheCon/OFBiz conference this week.  There were several good  
presentations
on OFBiz this week.  Most of these are available at the  
us.apahecon.comwebsite.


http://us.apachecon.com/presentation/materials/118/ApacheCon2008_SeleniumXml.pdf


Brett



On Fri, Oct 31, 2008 at 4:03 AM, Erwan de FERRIERES 
[EMAIL PROTECTED] wrote:

Will the slides be available on the Internet after your  
presentation ? I'm
not coming to the ApacheCon, but I am very interested to see what  
you've

done with Selenium.


Brett Palmer a écrit :

David,
We have been using SeleniumRC and an extension called SeleniumXml  
that I
will be presenting on at the ApacheCon conference next week.   
These could

be
called from a normal ant process or used in Cruise Control.

Let's talk more about this next week at the conference.


Brett

On Wed, Oct 29, 2008 at 2:34 PM, David E Jones [EMAIL PROTECTED]

wrote:


Erwan,


It would be great to have some tests that go through the user  
interface,
but we don't have tools for this yet that fit into the automated  
test

system
in OFBiz (ie so they can run along with other tests, and run
automatically).

The goal is for the tests to all work with an ant run- 
tests (or java
-jar ofbiz.jar tests), and to cover as much of OFBiz OOTB as  
possible,

and
then to also be easy to customize or comment out those that no  
longer

apply
after people customize or add on to OFBiz.

If you guys would like to work on getting Selenium tests to work  
this

way,
that would be great. Others have looked at this and run into  
troubles, so
the last idea I heard was to use something different and that  
might be

more
manual for initial test writing, but probably easier to maintain.

At Hotwax we've written/recorded a bunch of Selenium tests for  
clients,

but
they are difficult to maintain and as far as we've gone they  
also have to

be
manually run and watched.

-David



On Oct 29, 2008, at 12:09 PM, Erwan de FERRIERES wrote:

Here at Nereide, we are ready to make selenium tests (it's a  
task we

have


planned to do, but which is always postponed).
So, if it's ok with you and that you are interested in that, we  
are

going
to make it real !

David E Jones a écrit :

On Oct 29, 2008, at 11:54 AM, Adam Heath wrote:


BJ Freeman wrote:


there has been an effort to put in test units.

the only thing lacking, in making it complete is manpower.

And fixing the existing tests that are broken. :|


This is an area where it would be REALLY GREAT to have more  
effort go
into the project. Yep, great enough to capitalize REALLY and  
GREAT.

Who has worked on the unit tests that are in place? I'll admit I
haven't
much except on the toolset and some of the framework unit  
tests and

helping
some of the Hotwax Media people who wrote many of the tests  
that now

exist,
especially the ones in the various applications.
Is there anyone interested in working on this stuff? If there  
are

enough
people who want to actively work on it we can setup some  
coordination
resources (ie Jira tasks, confluence pages, etc). If there are  
only 2-3

then
coordination through the mailing list would be better, and  
more visible

to
others possibly interested.
-David

--

- Erwan -







--
- Erwan -


--
Antwebsystems.com: Quality OFBiz services for competitive prices





Re: svn commit: r643151 - /ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml

2008-03-31 Thread Pranay Pandey

Hello All,

This is just to notify that this patch was from Rashko Rejmer, so thanks 
to him for this patch.


--
Thanks and Regards
Pranay Pandey

[EMAIL PROTECTED] wrote:

Author: jleroux
Date: Mon Mar 31 14:14:18 2008
New Revision: 643151

URL: http://svn.apache.org/viewvc?rev=643151view=rev
Log:
A patch from Pranay Pandey Missing accounting UI labels 
(https://issues.apache.org/jira/browse/OFBIZ-1731) - OFBIZ-1731

Modified:
ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml

Modified: ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml?rev=643151r1=643150r2=643151view=diff
==
--- ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml (original)
+++ ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml Mon Mar 
31 14:14:18 2008
@@ -4312,6 +4312,11 @@
 value xml:lang=thจ่ายวันที่/value
 value xml:lang=zh支付日/value
 /property
+property key=AccountingPartyAccountsSummary
+value xml:lang=enAccounts Summary/value
+value xml:lang=frRésumé des comptes/value
+value xml:lang=itSommario Conti/value
+/property
 property key=AccountingPartyBilledFrom
 value xml:lang=arمفوترة من طرف/value
 value xml:lang=enParty Billed From/value
@@ -5896,6 +5901,11 @@
 value xml:lang=thUse regular expression validation pattern/value
 value xml:lang=zhä½¿ç”¨æ­£åˆ™è¡¨è¾¾å¼éªŒè¯æ ·å¼/value
 /property
+property key=AccountingVarianceReasonGlAccounts
+value xml:lang=enVariance Reason Gl Accounts/value
+value xml:lang=frRaison de la divergence du Grand Livre 
général/value
+value xml:lang=itMotivazione Varianza Conti Gl/value
+/property
 property key=AccountingVerifyTransaction
 value xml:lang=enVerify Transaction/value
 value xml:lang=thตรวจสอบรายการ/value
@@ -9077,10 +9087,6 @@
 value xml:lang=ruЕсть следующие закрытые 
периоды/value
 value 
xml:lang=thตามช่วงเวลานี้ปิด/value
 value xml:lang=zh下列期已经结束/value
-/property
-property key=VarianceReasonGlAccounts
-value xml:lang=enVariance Reason Gl Accounts /value
-value xml:lang=thVariance Reason Gl Accounts /value
 /property
 property key=de
 value xml:lang=enGerman/value


  






Re: [VOTE] [BRANCH] Creation of the Release Branch release10.04

2010-04-28 Thread Pranay Pandey

+1

Thanks  Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com

On Apr 28, 2010, at 6:31 PM, Anil Patel wrote:


+1

Thanks and Regards
Anil Patel
HotWax Media Inc
Find us on the web at www.hotwaxmedia.com or Google Keyword ofbiz

On Apr 28, 2010, at 4:10 AM, Jacopo Cappellato wrote:

This is the vote thread to create a new release branch (not a  
release yet) named release10.04.
This branch will represent a feature freeze and releases will be  
created over time out of it: all the commits in this  branch will  
be for bug fixes only, no new features.


Vote:

[ +1] create the branch release10.04
[ -1] do not create the branch

We will use the same rules for votes on releases (vote passes if  
there are more binding +1 than -1 and if there are at least 3  
binding +1)

For more details about this process please read this 
http://www.apache.org/foundation/voting.html

Kind Regards,

Jacopo






Reading weight from a scale and input into the browser

2010-08-02 Thread Pranay Pandey

Hello Devs,

Has anybody used OOTB ShipmentScaleApplet for reading weight from a  
scale into the browser? I tried but couldn't get success as no support  
for USB input. Here my main question is around reading input from a  
USB and also from serial port. As there are scales which works with  
USB. We will need to enhance the implementation to support both. Any  
pointer will be greatly appreciated. After some search around reading  
input from USB I got this http://javax-usb.org/  Share your thoughts  
on this. I think the support for reading weight from scale needs  
enhancement if its not there as this can be a real time requirement  
from many of the current and future customers using fulfillment  
process  in OFBiz.


Thanks in advance.

Regards
--
Pranay Pandey



Re: [jira] Commented: (OFBIZ-3894) Refactor Email handling

2010-08-27 Thread Pranay Pandey

+1

Thanks  Regards
--
Pranay Pandey
www.hotwaxmedia.com

On Aug 28, 2010, at 3:24 AM, Jacques Le Roux wrote:


Always better to comment in the Jira: for history sake it's easier...

Thanks

Jacques

From: Ruth Hoffman rhoff...@aesolves.com

Hi All:
This isn't really a re-factor of Email handling. It is more  
closely described as a re-factor of handling order notifications.  
It just so happens that that email Services are called on to do  
this. Hopefully, no email Service will be harmed in the making of  
this change ;-)


Just my 2 cents.
Ruth

BJ Freeman (JIRA) wrote:
   [ https://issues.apache.org/jira/browse/OFBIZ-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12903485 
#action_12903485 ]

BJ Freeman commented on OFBIZ-3894:
---

thanks Scott will look at a migration per your suggestion.
first stage for refactor is identify all the code that needs to  
modified and make a task for each. If someone wants to create task  
and patch for the content type that would be great also.




Refactor Email handling
---

   Key: OFBIZ-3894
   URL: https://issues.apache.org/jira/browse/ 
OFBIZ-3894

   Project: OFBiz
Issue Type: Improvement
Components: ALL COMPONENTS
  Affects Versions: SVN trunk
  Reporter: BJ Freeman
  Priority: Minor
   Fix For: SVN trunk

 Original Estimate: 1344h
Remaining Estimate: 1344h

with the addition of the Website for each component 1) create  
product store for Order entry, or use the B2C product store.

2) move the email  widgets from ecommerce to order compontent.
3) modify the seed data so that Order entry has it own emails  
from order component.this would be to add emails to note: as I go  
through the different items  this is turning out to be a bigger  
project than I first anticipated.

so consider this so far just ideas.
Maybe break down in to small tasks as I have time to do something.











Re: End of month : Main New features

2009-05-31 Thread Pranay Pandey

Thanks Jacques for reminder.
I have added mine.

Thanks  Regards
--
Pranay Pandey
HotWax Media | http://www.hotwaxmedia.com
Direct: +919826035576
Skype: pranay.pandey

On May 31, 2009, at 3:58 PM, Ashish Vijaywargiya wrote:


Done.

--
Ashish

On Sat, May 30, 2009 at 3:33 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

Please devs, don't forget to add your changes in Main New features  
with a

short explanation

http://docs.ofbiz.org/display/OFBIZ/Main+New+features

Google Checkout, etc.

Thanks

Jacques





Re: Discussion: Seed and Demo Data Files

2009-06-05 Thread Pranay Pandey

Hi Adrian,

The data which is client specific should go in ext, so When we say run- 
install-extseed it will go with seed data which is required for ext  
data.


Adding suffix like you suggested is a good idea IMO. Lets see what  
others have to say.



Thanks  Regards
--
Pranay Pandey
HotWax Media | http://www.hotwaxmedia.com


On Jun 4, 2009, at 10:41 PM, Adrian Crum wrote:

I'm getting ready to deploy the latest trunk to our production  
server, and I have encountered a few problems with the way the seed  
data is set up.


In order to get the latest features to work with my existing  
database, I have to run ant run-install-seed. The problem is, there  
is a lot of demo data in the seed files. And I really mean a LOT.  
After running run-install-seed, my database contains a lot of demo  
data that I had previously removed.


I would like to suggest the following best practices:

1. Keep seed-initial, seed, and demo data in separate XML files.
2. Name the files accordingly, so their purpose is clear. Example:  
[component name]InitialData.xml, [component name]SeedData.xml, and  
[component name]DemoData.xml.


Right now I'm working on sorting out the data for the accounting  
component. The AccountingSecurityData.xml file is loaded as seed  
data, but it contains both seed AND demo data: security permissions  
are seed data, assigning those permissions to demo security groups  
is demo data. The AccountingTypeData.xml file is loaded as seed  
data, but it also contains both seed and demo data. Those are just  
two examples.


I can commit some of my work as an example of what changes need to  
be made.


What do you think?

-Adrian




Re: shipment.fromPartyId not being set when shipment is created through Packing or Quick Ship process

2009-06-05 Thread Pranay Pandey

Thanks David.

I searched for this and didn't find any references which say it was  
being populated earlier.
What you have suggested seems reasonable to me. I have done changes in  
the code for three processes which create shipment which are:

1. Verify Pick
2. Packing
3. Quick Ship

Followed 4 points you gave here. I will soon create a jira issue and  
upload the patch for the same.


Thanks again.


Kind Regards
--
Pranay Pandey


On Jun 5, 2009, at 5:15 AM, David E Jones wrote:



NOTE: replying on the dev list since this involves development of  
OFBiz itself.


While we could have it look at a different role I agree that instead  
populating the SHIP_FROM_VENDOR is a better approach, with some  
issues though.


Part of the reason I think it's a better approach is that it is more  
flexible as this information can come from various places. On the  
other hand, that also makes it more difficult to implement because  
it can come from multiple places.


How this happened is a good question. If anyone wants to do some SVN  
forensics and see if this was ever populated, or the code used to  
look for a different role, or whatever the cause of this problem was  
it would be interesting.


Anyway, moving forward... the easiest way to populate this would be  
to set it to the same value as the BILL_FROM_VENDOR, but really they  
can be different and that's the point of having the different roles.


To make this more interesting there can be different  
SHIP_FROM_VENDOR parties for different OrderItemShipGroup records in  
an order. In other words, we can't look at the OrderRole or  
OrderItemRole values for this, it has to be per ship group.


Based on that here is what I think we should change it to do:

1. first look at the OrderItemShipGroup.vendorPartyId and use that  
if it is populated
2. if that is not populated look up the ship-from Facility using the  
OrderItemShipGroup.facilityId, and then look at the facility owner  
using the Facility.ownerPartyId field
3. if neither of those is populated look for an OrderRole for  
SHIP_FROM_VENDOR
4. if that is also not found then default to the OrderRole for  
BILL_FROM_VENDOR


Does that sounds reasonable? Does anyone else have any thoughts on  
how this can/should work?


-David


On Jun 4, 2009, at 9:37 AM, Pranay Pandey wrote:


Hello All,

Here I am giving details of the issue:

1. What I did:
a. Created a Sales order.
b. Completed Packing process.
c. Got a shipment created.
d. Viewed Shipment details.

2. What did I expect:
Wanted to check to and from parties there.

3. What did I get:
Got to party but didn't see from party there.


I looked in to the process and code and can see that there is no  
OrderRole is being set for Company to SHIP_FROM_VENDOR for sales  
orders. We are not setting it in the cart to go there for further  
processing.
So at the time when createShipment service called it doesn't find  
this role for shipment.partyIdFrom in ShipmentServices.xml lines  
437 to 447 and leaves it without partyId and we don't have it in  
created shipment.


So now the main concern is that should we set a OrderRole for  
Company to SHIP_FROM_VENDOR for a sales order which is not done at  
this moment.




Thanks  Regards
--
Pranay Pandey







Re: svn commit: r782190 - in /ofbiz/trunk/applications/product: script/org/ofbiz/shipment/shipment/ShipmentServices.xml src/org/ofbiz/shipment/packing/PackingSession.java src/org/ofbiz/shipment/verify

2009-06-05 Thread Pranay Pandey

Thanks David.

Kind Regards
--
Pranay Pandey

On Jun 6, 2009, at 10:31 AM, jone...@apache.org wrote:


Author: jonesde
Date: Sat Jun  6 05:01:28 2009
New Revision: 782190

URL: http://svn.apache.org/viewvc?rev=782190view=rev
Log:
Applied patch from Pranay Pandey in Jira #OFBIZ-2570 to improve how  
the Shipment partyIdTo/From fields are populated


Modified:
   ofbiz/trunk/applications/product/script/org/ofbiz/shipment/ 
shipment/ShipmentServices.xml
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/packing/ 
PackingSession.java
   ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/ 
VerifyPickSession.java




Improvements in UPS services

2009-06-08 Thread Pranay Pandey

Hello All,

While going through the code in UpsServices.java I have observed that  
there is a need of improvement in the code written there.

Specially it needs to be improved for 2 things:

1. I18n for error and success messages.
2. Putting values in elements which are required for XML must be  
checked for null values and other wise  should be sent in the  
request. Because there may be few fields which are not there in db for  
a specific record.


For #2 there are already checks on few like address2 field form  
PostalAddress which can be null at any moment. IMO this should also be  
done for the fields like attnName which can be sometimes null.
I want to do those changes to avoid null pointer exceptions which  
usually comes because of the lack of the information but can be  
processed with  without any harm.


I also may be wrong here so please correct me if this is the case.

There can be few more things. If some of you want to point.

Thoughts?

Thanks  Regards
--
Pranay Pandey
HotWax Media | http://www.hotwaxmedia.com



Re: Improvements in UPS services

2009-06-09 Thread Pranay Pandey
As I am always finding myself unable to understand your comments, BJ.  
Can you please rephrase your comments for me? Will be of help. :)


Thanks  Regards
--
Pranay Pandey

On Jun 9, 2009, at 1:01 AM, BJ Freeman wrote:


the only one at this point is don't depend on the attnName in
PostalAddress, at some point that will be refereence to a contactmech
that has the Type attnName
that is if my Address rework is accepted.

Pranay Pandey sent the following on 6/8/2009 6:20 AM:

Hello All,

While going through the code in UpsServices.java I have observed that
there is a need of improvement in the code written there.
Specially it needs to be improved for 2 things:

1. I18n for error and success messages.
2. Putting values in elements which are required for XML must be  
checked
for null values and other wise  should be sent in the request.  
Because
there may be few fields which are not there in db for a specific  
record.


For #2 there are already checks on few like address2 field form
PostalAddress which can be null at any moment. IMO this should also  
be

done for the fields like attnName which can be sometimes null.
I want to do those changes to avoid null pointer exceptions which
usually comes because of the lack of the information but can be
processed with  without any harm.

I also may be wrong here so please correct me if this is the case.

There can be few more things. If some of you want to point.

Thoughts?

Thanks  Regards
--
Pranay Pandey
HotWax Media | http://www.hotwaxmedia.com




--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=key=1237480locale=en_UStrk=tab_pro
Systems Integrator.





Re: svn commit: r786786 - /ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml

2009-06-20 Thread Pranay Pandey

Yes thats really a great coincidence Mridul  Ashish.

It seems I missed it by 1 :)


Thanks  Regards
--
Pranay Pandey

On Jun 20, 2009, at 4:23 PM, Ashish Vijaywargiya wrote:


I am memorizing the scene of Block Buster movie Coolie.
Did you remember Billa No 786 ?

--
Ashish

On Sat, Jun 20, 2009 at 4:18 PM, Mridul Pathak 
mridul.pat...@hotwaxmedia.com wrote:


Indeed Ashish.  What a great coincidence :).

--
Thanks,
Mridul Pathak


On 20-Jun-09, at 4:07 PM, Ashish Vijaywargiya wrote:

Interesting revision number ..  isn't it Mridul?

Happy to see that this number is assigned to me and you Mridul.

--
Ashish

On Sat, Jun 20, 2009 at 3:36 PM, ash...@apache.org wrote:

Author: ashish

Date: Sat Jun 20 10:06:34 2009
New Revision: 786786

URL: http://svn.apache.org/viewvc?rev=786786view=rev
Log:
Applied patch from jira issue OFBIZ-2639 (Replacement Order  
against Wait

Replacement Reserved Return is not being shipped)
Thanks Mridul for the contribution.

Modified:


ofbiz/trunk/applications/order/script/org/ofbiz/order/order/ 
OrderReturnServices.xml


Modified:

ofbiz/trunk/applications/order/script/org/ofbiz/order/order/ 
OrderReturnServices.xml

URL:

http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/script/org/ofbiz/order/order/OrderReturnServices.xml?rev=786786r1=786785r2=786786view=diff


= 
= 
= 
= 
= 
= 
= 
= 
= 
= 
= 
===

---

ofbiz/trunk/applications/order/script/org/ofbiz/order/order/ 
OrderReturnServices.xml

(original)
+++

ofbiz/trunk/applications/order/script/org/ofbiz/order/order/ 
OrderReturnServices.xml

Sat Jun 20 10:06:34 2009
@@ -901,6 +901,7 @@
 if-compare field=orderHeader.statusId
operator=equals value=ORDER_HOLD
 set field=changeOrderStatusMap.statusId
value=ORDER_APPROVED/
 set field=changeOrderStatusMap.orderId
from-field=returnItemResponse.replacementOrderId/
+set  
field=changeOrderStatusMap.setItemStatus

value=Y/
 call-service service-name=changeOrderStatus
in-map-name=changeOrderStatusMap/
 /if-compare
 if-compare field=orderHeader.statusId
operator=equals value=ORDER_CANCELLED










Re: Open Source for America

2009-07-26 Thread Pranay Pandey

+1

Thanks  Regards
--
Pranay Pandey

On Jul 22, 2009, at 1:46 PM, Mike Bates wrote:


Adam,

Super impressive.  Way to go and a nice win for OFBiz.

Best regards,

Mike
--  
Mike Bates

HotWax Media
CEO
http://www.hotwaxmedia.com


On Jul 22, 2009, at 1:18 PM, Adam Heath wrote:


As some of you may have heard by now, there is a new coalition, that
is pushing use of open source for the united states goverment.  This
site is at http://www.opensourceforamerica.org/

The reason why I am mentioning it here, is that the site is running
webslinger+ofbiz(with varnish in front).

We(brainfood) got involved with this middle of the day last friday.
Most of the content for the site was done by middle of the day
tuesday.  If the site hadn't been done in webslinger, it wouldn't  
have

happened.






Re: Update record is not working in OFBiz latest head

2009-09-04 Thread Pranay Pandey
It doesn't show you any error message and at the same time doesn't  
update a specific record in the db.


Thanks  Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com
Ext: 442 | Direct: +91 98260 35576 | Skype: pranay.pandey

On Sep 4, 2009, at 2:37 PM, Divesh Dutta wrote:


Hi Sumit,

This is not the problem with any particular entity or field. This is  
the case with all the entities.


Thanks
--
Divesh


Sumit Pandit wrote:

Hello Divesh,

Please name the entity and field for which you are trying to update  
the values.


Thanks And Regards
Sumit Pandit

On 04-Sep-09, at 2:14 PM, Divesh Dutta wrote:


Hello Developers,

I just found a weird problem while updating records in  
demo.ofbiz.org. I tried it by following three ways:


1) Processed sql query from sql processor.
 Results : 1) It shows me 1 row affected
2) But record does not get updated
2) Also tried to overwrite from XML data import
 Result : Record is not updated when I go that particular entity  
in webtools


3) Also tried to update directly by going to that particular entity.

 Result: But the result is same as above given.

Anyone else is coming across same problem? Also found same result  
in local machine.


Thanks
--
Divesh









Proposal for change in entity GoogleCoShippingMethod

2009-09-25 Thread Pranay Pandey

Hello Devs,

I want propose a change in entity GoogleCoShippingMethod.
We should change field shipmentMethodName from type id-ne to id- 
long-ne.
The reason is the name of Shipping method can be longer and this will  
not be accommodated in the present one.


As these changes have done before few days so I think no one will be  
using this on production and this change should not harm anything.


Thoughts?


Thanks  Regards
--
Pranay Pandey
HotWax Media | www.hotwaxmedia.com



Re: Welcome Nicolas Malin as new committer!

2014-09-27 Thread Pranay Pandey

Many Congratulations Nicolas.

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com

On Sep 26, 2014, at 10:25 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 The OFBiz PMC has invited Nicolas to become a new committer and he has 
 accepted the new role: Nicolas is a skilled developer and he knows the OFBiz 
 codebase quite well; but most of all Nicolas
 is committed to the project and has always showed a positive and 
 collaborative attitude. Please welcome him onboard!
 
 Thank you
 
 Jacopo



Re: Wiki Coding conventions

2014-09-29 Thread Pranay Pandey

Hi Nicolas,

Its a good idea to complete those TODOs, If you are not sure about any specific 
item you are planning to add, it can be discussed over mailing list for sure.

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com
ApacheCon US 2014 Silver Sponsor
http://na.apachecon.com/sponsor/our-sponsors


On Sep 29, 2014, at 5:33 PM, Nicolas Malin nicolas.ma...@nereide.fr wrote:

 In the wiki, we have some coding conventions here 
 https://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions with 
 a few TODO.
 
 I propose to complete some TODO directly on the wiki or you prefer exchange 
 before on the mailing list ?
 
 Nicolas
 
 -- 
 
 Nicolas Malin - Consultant - 06 17 66 40 06 -- http://nereide.fr
 



Re: svn commit: r1627940 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java

2014-09-30 Thread Pranay Pandey

+1

Thanks Scott.

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com



On Sep 27, 2014, at 3:29 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 This is really an amazing contribution! Thank you Scott.
 
 Jacopo
 
 On Sep 27, 2014, at 11:22 AM, lekt...@apache.org wrote:
 
 Author: lektran
 Date: Sat Sep 27 09:22:31 2014
 New Revision: 1627940
 
 URL: http://svn.apache.org/r1627940
 Log:
 OFBIZ-4053 Implement an entity query builder to be used as a friendlier API 
 for executing entity queries.
 
 Entry point is the static EntityQuery.use(Delegator) method which will then 
 return an EntityQuery instance whose methods support method chaining to set 
 query options.
 The query can then be executed using the first(), list(), iterator() and 
 one() methods which respectively return:
 - The first result from a result set
 - The full list of results from a result set
 - An EntityListIterator to iterate over a result set
 - The single record from a query that will return only one record (such as a 
 lookup by primary key)
 
 Added:
   ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java   
 (with props)
 
 Added: 
 ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java?rev=1627940view=auto
 ==
 --- ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java 
 (added)
 +++ ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityQuery.java 
 Sat Sep 27 09:22:31 2014
 @@ -0,0 +1,416 @@
 +/***
 + * Licensed to the Apache Software Foundation (ASF) under one
 + * or more contributor license agreements.  See the NOTICE file
 + * distributed with this work for additional information
 + * regarding copyright ownership.  The ASF licenses this file
 + * to you under the Apache License, Version 2.0 (the
 + * License); you may not use this file except in compliance
 + * with the License.  You may obtain a copy of the License at
 + *
 + * http://www.apache.org/licenses/LICENSE-2.0
 + *
 + * Unless required by applicable law or agreed to in writing,
 + * software distributed under the License is distributed on an
 + * AS IS BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
 + * KIND, either express or implied.  See the License for the
 + * specific language governing permissions and limitations
 + * under the License.
 + 
 ***/
 +package org.ofbiz.entity.util;
 +
 +import java.sql.Timestamp;
 +import java.util.Arrays;
 +import java.util.List;
 +import java.util.Map;
 +import java.util.Set;
 +
 +import org.ofbiz.base.util.Debug;
 +import org.ofbiz.base.util.UtilMisc;
 +import org.ofbiz.entity.Delegator;
 +import org.ofbiz.entity.GenericEntityException;
 +import org.ofbiz.entity.GenericValue;
 +import org.ofbiz.entity.condition.EntityCondition;
 +import org.ofbiz.entity.model.DynamicViewEntity;
 +import org.ofbiz.entity.util.EntityFindOptions;
 +import org.ofbiz.entity.util.EntityListIterator;
 +import org.ofbiz.entity.util.EntityUtil;
 +
 +/**
 + * Used to setup various options for and subsequently execute entity 
 queries.
 + *
 + * All methods to set options modify the EntityQuery instance then return 
 this modified object to allow method call chaining. It is
 + * important to note that this object is not immutable and is modified 
 internally, and returning EntityQuery is just a
 + * self reference for convenience.
 + *
 + * After a query the object can be further modified and then used to 
 perform another query if desired.
 + */
 +public class EntityQuery {
 +
 +public static final String module = EntityQuery.class.getName();
 +
 +private Delegator delegator;
 +private String entityName = null;
 +private DynamicViewEntity dynamicViewEntity = null;
 +private boolean useCache = false;
 +private EntityCondition whereEntityCondition = null;
 +private SetString fieldsToSelect = null;
 +private ListString orderBy = null;
 +private Integer resultSetType = EntityFindOptions.TYPE_FORWARD_ONLY;
 +private Integer fetchSize = null;
 +private Integer maxRows = null;
 +private Boolean distinct = null;
 +private EntityCondition havingEntityCondition = null;
 +private boolean filterByDate = false;
 +private Timestamp filterByDateMoment;
 +
 +
 +
 +/** Construct an EntityQuery object for use against the specified 
 Delegator
 + * @param delegator - The delegator instance to use for the query
 + * @return Returns a new EntityQuery object
 + */
 +public static EntityQuery use(Delegator delegator) {
 +return new EntityQuery(delegator);
 +}
 +
 +/** Construct an EntityQuery object for use against the specified 
 Delegator
 + * @param

Re: [VOTE] [RELEASE] Apache OFBiz 13.07.01 (2nd)

2014-10-01 Thread Pranay Pandey

+1

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com
ApacheCon US 2014 Silver Sponsor
http://na.apachecon.com/sponsor/our-sponsors


On Oct 1, 2014, at 12:11 PM, Jacopo Cappellato jacopo.cappell...@gmail.com 
wrote:

 This is the (second, after the first was cancelled) vote thread to publish 
 the first release from the release13.07 branch.
 For a description of release naming and strategy see 
 http://ofbiz.apache.org/download.html
 
 The release files can be downloaded from here:
 
 https://dist.apache.org/repos/dist/dev/ofbiz/
 
 and are:
 
 * apache-ofbiz-13.07.01.zip
 * KEYS: text file with keys
 * apache-ofbiz-13.07.01.zip.asc: the detached signature file
 * apache-ofbiz-13.07.01.zip.md5, apache-ofbiz-13.07.01.zip.sha: checksum 
 hashes
 
 Please download and test the zip file (*) and its signature and checksums 
 (for instructions see http://www.apache.org/info/verification.html).
 
 Vote:
 
 [ +1] release as Apache OFBiz 13.07.01
 [ -1] do not release
 
 This vote will be open for about 5 days.
 For more details about this process please read 
 http://www.apache.org/foundation/voting.html
 
 Kind Regards,
 
 Jacopo
 
 (*) run at least:
 ant load-demo run-tests
 and verify that all tests are successful



Re: svn commit: r1630079 - in /ofbiz/trunk/framework: entity/entitydef/entitymodel_test.xml service/servicedef/services_test_se.xml service/src/org/ofbiz/service/test/ServiceEntityAutoTests.java servi

2014-10-09 Thread Pranay Pandey

Nice addition Nicolas. Thanks.

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com
On Oct 8, 2014, at 5:47 PM, nma...@apache.org wrote:

 Author: nmalin
 Date: Wed Oct  8 12:17:55 2014
 New Revision: 1630079
 
 URL: http://svn.apache.org/r1630079
 Log:
 Add junit test to control entity-auto on create, update and delete to ensure 
 no regression when the entity-auto engine will be improve (like OFBIZ-5800)
 
 Added:

 ofbiz/trunk/framework/service/src/org/ofbiz/service/test/ServiceEntityAutoTests.java
(with props)
 Modified:
ofbiz/trunk/framework/entity/entitydef/entitymodel_test.xml
ofbiz/trunk/framework/service/servicedef/services_test_se.xml
ofbiz/trunk/framework/service/testdef/servicetests.xml
 
 Modified: ofbiz/trunk/framework/entity/entitydef/entitymodel_test.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/entitydef/entitymodel_test.xml?rev=1630079r1=1630078r2=1630079view=diff
 ==
 --- ofbiz/trunk/framework/entity/entitydef/entitymodel_test.xml (original)
 +++ ofbiz/trunk/framework/entity/entitydef/entitymodel_test.xml Wed Oct  8 
 12:17:55 2014
 @@ -123,6 +123,21 @@ under the License.
 prim-key field=testFieldTypeId/
 /entity
   !-- =
 +Testing Item entity : testing line on a Testing entity
 +  = --
 +entity entity-name=TestingItem
 +package-name=org.ofbiz.entity.test
 +title=Testing Item
 +field name=testingId type=id-ne/
 +field name=testingSeqId type=id-ne/
 +field name=testingHistory type=very-long/
 +prim-key field=testingId/
 +prim-key field=testingSeqId/
 +relation type=one fk-name=TESTING_IT_TEST 
 rel-entity-name=Testing
 +key-map field-name=testingId/
 +/relation
 +/entity
 +  !-- =
 Testing Node entity : hierarchy of nodes having
 'testing node member' as potential members
   = --
 
 Modified: ofbiz/trunk/framework/service/servicedef/services_test_se.xml
 URL: 
 http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/servicedef/services_test_se.xml?rev=1630079r1=1630078r2=1630079view=diff
 ==
 --- ofbiz/trunk/framework/service/servicedef/services_test_se.xml (original)
 +++ ofbiz/trunk/framework/service/servicedef/services_test_se.xml Wed Oct  8 
 12:17:55 2014
 @@ -48,6 +48,50 @@ under the License.
 location=org.ofbiz.service.test.ServiceEngineTestServices 
 invoke=testServiceLockWaitTimeoutRetryWaiter
 /service
 
 +!-- testing different entity-auto call--
 +service name=testEntityAutoCreateTestingPkPresent auth=false
 +engine=entity-auto default-entity-name=Testing invoke=create
 +auto-attributes include=pk mode=IN optional=false/
 +auto-attributes include=nonpk mode=IN optional=true/
 +/service
 +service name=testEntityAutoCreateTestingPkMissing auth=false
 +engine=entity-auto default-entity-name=Testing invoke=create
 +auto-attributes include=nonpk mode=IN optional=true/
 +attribute name=testingId mode=OUT type=String/
 +/service
 +service name=testEntityAutoCreateTestingItemPkPresent auth=false
 +engine=entity-auto default-entity-name=TestingItem 
 invoke=create
 +auto-attributes include=pk mode=IN optional=false/
 +auto-attributes include=nonpk mode=IN optional=true/
 +/service
 +service name=testEntityAutoCreateTestingItemPkMissing auth=false
 +engine=entity-auto default-entity-name=TestingItem 
 invoke=create
 +auto-attributes include=nonpk mode=IN optional=true/
 +attribute name=testingId mode=IN type=String/
 +attribute name=testingSeqId mode=OUT type=String/
 +/service
 +service name=testEntityAutoCreateTestingNodeMemberPkPresent 
 auth=false
 +engine=entity-auto default-entity-name=TestingNodeMember 
 invoke=create
 +auto-attributes include=pk mode=IN optional=false/
 +auto-attributes include=nonpk mode=IN optional=true/
 +/service
 +service name=testEntityAutoCreateTestingNodeMemberPkMissing 
 auth=false
 +engine=entity-auto default-entity-name=TestingNodeMember 
 invoke=create
 +auto-attributes include=nonpk mode=IN optional=true/
 +attribute name=testingId mode=IN type=String/
 +attribute name=testingNodeId mode=IN type=String/
 +attribute name=fromDate mode=OUT type=String/
 +/service
 +service name=testEntityAutoUpdateTesting auth=false
 +engine=entity-auto default-entity-name=Testing invoke=update
 +auto-attributes include=pk mode=IN optional=false/
 +auto-attributes include

Re: Ofbiz goes down every time the terminal connection becomes inactive

2014-10-30 Thread Pranay Pandey

Not specific to OFBiz but I think we should because it helps :)

Thanks

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
http://www.hotwaxmedia.com
ApacheCon US 2014 Silver Sponsor
http://na.apachecon.com/sponsor/our-sponsors

On Oct 31, 2014, at 1:35 AM, Ron Wheeler rwhee...@artifact-software.com wrote:

 
 Is this something that should be added to the docs?
 
 Ron
 
  Original Message 
 
 It worked perfectly. Thank you!
 
 On Thu, Oct 30, 2014 at 12:37 PM, Paul Mandeltort pman...@gmail.com wrote:
 
 Well ideally you should run it as a service.. :-)
 
 But if you’re starting it from the command line for testing/whatnot, use
 nohup ./startofbiz.sh  to keep it from getting killed when the terminal
 closes.
 —P
 
  On Oct 30, 2014, at 2:24 PM, Michael Gawrychowski 
 michael.gawr...@gaatu.com wrote:
 
  Hi everyone, I start the ofbiz app by ssh-ing to the server and typing in
  ./ant start and in a few seconds I have it working. However every time I
  close the terminal window the application stops working as well. Why is
  that and how do I get it to work so it works all the time?
 
 
 
 
 



Re: EntityQuery implementation and documentation

2014-11-11 Thread Pranay Pandey

Love it, thanks Jacopo :)

Thanks,

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
http://www.hotwaxmedia.com
ApacheCon US 2014 Silver Sponsor
http://na.apachecon.com/sponsor/our-sponsors

On Nov 11, 2014, at 6:19 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 I would like to add that today I have enhanced the DSL available in all 
 Groovy scripts in OFBiz by adding support for the EntityUtil class.
 
 From within a Groovy script you can now run queries in the following ways:
 
 // select all fields from one order header record
 orderHeader = from('OrderHeader').where('orderId', orderId).queryFirst()
 // ... or the equivalent
 orderHeader = select().from('OrderHeader').where('orderId', 
 orderId).queryFirst()
 
 // select only two fields from the order header record
 orderHeader = select(‘orderId’, 
 ‘orderDate’).from('OrderHeader').where('orderId', orderId).queryFirst()
 
 The OrderView.groovy file has some examples of its usage.
 
 I think this is a very user friendly way of running queries and I am sure 
 users will like it.
 
 Jacopo
 
 On Nov 10, 2014, at 6:49 PM, Pierre Smits pierre.sm...@gmail.com wrote:
 
 Scott,
 
 I noticed you recently started to change various areas of code from .find
 (functionality) to the new entityquery implementation. As find operations
 take place on various level throughout the entire set of functionalities in
 OFBiz there is a lot to get converted. This not only applies to java code,
 but also to groovy code and even to areas in simple services and screens
 and forms. All in all a enormous endeavour for this community, let alone
 for just one contributor.
 
 Could you do a page in the technical wiki explaining how it all works and
 provide some examples so that others can:
 
  - assist you in those areas
  - take proper notice of this new functionality when they are working on
  new applications and/or solutions.
 
 With such a page not only we can try to speed up the transition, but we
 also help to avoid regressions.
 
 Regards,
 
 Pierre Smits
 
 *ORRTIZ.COM http://www.orrtiz.com*
 Services  Solutions for Cloud-
 Based Manufacturing, Professional
 Services and Retail  Trade
 http://www.orrtiz.com
 



Re: Moving the bi component from framework to specialpurpose

2014-11-20 Thread Pranay Pandey
+1

Makes perfect sense.

Best regards,

Pranay Pandey
HotWax Media
On 20 Nov 2014 15:16, Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
wrote:

 Hi all,

 I would like to migrate the business intelligence component (bi) from
 framework to specialpurpose; in the process I would also like to migrate
 all the artifacts (dimension and fact entities and star schemas, and
 reports) from all the applications to the bi component.
 Then I would also like to set this component as disabled by default.
 When I initially design and contributed this component I have placed it in
 the framework to let application use some of its low level services to
 build their own reports: however over time I noticed that the need to
 configure the olap data model caused some confusion to users (especially
 the ones that do not use this feature); moreover, the definition of
 dimensions, facts and schemas is currently widespread over several
 components (whose boundaries don't match very well with the domains for
 business intelligence) and this makes more difficult to understand the bi
 data model. After the migration I am proposing here we will have all the bi
 data model in one place (the bi component).

 Regards,

 Jacopo


Re: Groovy DSL descriptors

2014-12-03 Thread Pranay Pandey
+1

On Wed, Dec 3, 2014 at 4:17 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 Hi all,

 is it ok if I commit to framework/base the two Groovy DSL descriptors for
 Eclipse and IntelliJ that I have implemented in order to get the
 autocompletion features and similar features while editing Groovy files in
 OFBiz?
 I usually don't like to see code that is only used by IDEs, but these
 files are small and then can be very useful, so I would like to do an
 exception here.
 The files are currently attached to this Wiki page:


 https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic

 Jacopo




-- 
Thanks,

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
www.hotwaxmedia.com


Re: Groovy DSL descriptors

2014-12-03 Thread Pranay Pandey

+1

Best Regards,

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
http://www.hotwaxmedia.com

On Dec 3, 2014, at 4:17 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 Hi all,
 
 is it ok if I commit to framework/base the two Groovy DSL descriptors for 
 Eclipse and IntelliJ that I have implemented in order to get the 
 autocompletion features and similar features while editing Groovy files in 
 OFBiz?
 I usually don't like to see code that is only used by IDEs, but these files 
 are small and then can be very useful, so I would like to do an exception 
 here.
 The files are currently attached to this Wiki page:
 
 https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic
 
 Jacopo
 



Re: Jira and releases change logs

2014-12-17 Thread Pranay Pandey
+1

Thanks,

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
www.hotwaxmedia.com

On Thu, Dec 18, 2014 at 4:50 AM, Nicolas Malin nicolas.ma...@nereide.fr
wrote:

 Ok Jacques,

 I propose to complete the page https://cwiki.apache.org/
 confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities
 with your sensible remarks !
 I will do that tomorrow.

 Nicolas

 Le 17/12/2014 15:29, Jacques Le Roux a écrit :

  Hi Committers,

 Please take the time to correctly fill the different Jira fields we now
 use for our releases change logs.

 For instance for  in
 * Improvement:s use either Done or Implemented Status as you feel right
 * New features: use either Implemented Status
 * Bug: use the Fixed Status

 Don't forget to fill the Fix version/s field according to your changes.
 Notably, use Upcoming Branch and not trunk there.

 Also, even if when the svn commits comments are correctly done with a
 reference to the Jira issue number we can then get to the commits in
 Fisheye from the Development section of the Jira issue, I'd still recommend
 to put the commits references in a comment. It's always handy, and insures
 we have those references at hand even if the commits comments don't contain
 the Jira issue reference.

 Thanks for all the good work  :)

 Jacques





Re: Proposal: remove fk constraints on Visitor/Visit/ServerHit* entities

2014-12-18 Thread Pranay Pandey
+1

It will be really great enhancement. Disabling logging to these entities
because of increased load shouldn't be a choice for sure.

Thanks,

Pranay Pandey
HotWax Media
www.hotwaxmedia.com

On Thu, Dec 18, 2014 at 2:17 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 Visit/Visitor/ServerHit/ServerHitBin (and the related *Type entities) are
 used to gather statistics about how clients use the OFBiz instance.
 The information in these entities is not used by business processes but it
 is very important to analyze the system performance, user's behavior etc...
 This simple data model is very powerful because can capture very granular
 information about each visit.

 The disadvantage is that it can add significant load on the database
 server and can impact performance; on servers with high users load these
 tables can be huge; in fact, in most production instances the granular
 logging is disabled.

 I am proposing here a change that should make the stat gathering
 subcomponent more flexible, clean and powerful, and increase the
 performance of the system:
 1) remove all the fk dependencies from business entities to the
 Visit/Visitor/ServerHit/ServerHitBin entities
 2) assign the Visit/Visitor/ServerHit/ServerHitBin (and the related *Type
 entities) entities to a separate entity-group
 3) in this way it will be easy to configure the entity engine to store
 them in a separate database (e.g. a NoSQL db); by default we could keep
 them in the same db where all the other entities are

 What do you think?

 Jacopo


Re: Creating a new release branch before the end of the year (release14.12)

2014-12-19 Thread Pranay Pandey
+1

Makes perfect sense.

Thanks,

Pranay Pandey
Senior Manager, Enterprise Software Development
HotWax Media
www.hotwaxmedia.com

On Thu, Dec 18, 2014 at 2:23 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxmedia.com wrote:

 Hi all,

 the end of 2014 is getting closer and it would be nice to have a new
 release branch created before it ends: its name will be release14.12
 (14=2014 and 12=December).
 In this way we will have a sequential numbering: 10, 11, 12, 13, 14.
 Pending the discussion on specialpurpose components (exclude them all
 apart from ecommerce as we did in 13.07, include some of them selectively
 etc...) I would temporarily include them all, and when we will have a clear
 plan of action we will adjust the branch accordingly.

 Any objections?

 Jacopo




Re: [jira] [Updated] (OFBIZ-5994) Have view-entity AgreementAndRole removed

2015-01-21 Thread Pranay Pandey
Making sense Gavin. 

We should also dig in history in case we take any decision like this. 

Best regards,

Pranay Pandey
HotWax Media
http://www.hotwaxmedia.com

 On Jan 21, 2015, at 7:03 PM, Gavin Mabie kwikst...@gmail.com wrote:
 
 I'm sure that there are a few of these cases - i.e. where entities are not
 referenced in any Screen, Form and Service definition. I suspect that this
 would be the case with especially view-entities which are used mainly in
 summary/report type screens and less so in transactional screens.  I just
 did a quick search on the BenefitTypeAndParty view-entity and could not
 find any reference to it in Screen, Form or Service definitions.  Does this
 qualify it for removal/deprecation?  I don't think so.  Just because it has
 not being used does not necessarily translate into it not being useful. We
 should approach deprecating entities with caution, particularly those which
 related to core ERP functionalities. Long story short - I don't think its a
 good idea to deprecate this entity or any other at this stage.  Entity
 deprecation should be done at a customization level and not at a Project
 level.
 
 Gavin
 
 On Wed, Jan 21, 2015 at 2:28 PM, Pierre Smits (JIRA) j...@apache.org
 wrote:
 
 
 [
 https://issues.apache.org/jira/browse/OFBIZ-5994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]
 
 Pierre Smits updated OFBIZ-5994:
 
Affects Version/s: Upcoming Branch
 
 Have view-entity AgreementAndRole removed
 -
 
Key: OFBIZ-5994
URL: https://issues.apache.org/jira/browse/OFBIZ-5994
Project: OFBiz
 Issue Type: Improvement
 Components: party
   Affects Versions: Trunk, Upcoming Branch
   Reporter: Pierre Smits
   Assignee: Jacques Le Roux
   Priority: Minor
 Labels: agreement(s), role, roles
 
 The view-entity is not referenced in any Screen, Form and Service
 definition. Having this in the entity-model is superfluous.
 
 
 
 --
 This message was sent by Atlassian JIRA
 (v6.3.4#6332)
 



OFBiz Bug Crush Day

2015-03-09 Thread Pranay Pandey
Hi Sharan,

If community members agree, as we discussed earlier on the mailing list,
March 21 2015 can be the day for doing Global OFBiz Bug Crush Event.

Is this a good time to prepare a news for OFBiz website and start planning
it? If we start doing it this month, by the end of the year we will have
4(1 each quarter) such big events.

Please share your thoughts on the topic and we will go from there.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com


Re: Welcome to Deepak Dixit as new committer!

2015-03-13 Thread Pranay Pandey
Many congratulations Deepak, welcome onboard.

Best regards,
Pranay Pandey
 On Mar 12, 2015 4:50 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxsystems.com wrote:

 The OFBiz PMC has invited Deepak Dixit to become a new committer and he
 has accepted the new role.
 Deepak, thank you for your continued commitment and valuable
 contributions. Welcome onboard!

 Jacopo


Re: New committers access to all Confluence workspaces

2015-03-13 Thread Pranay Pandey
I don't see option to edit the page. Is this expected?

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com

On Fri, Mar 13, 2015 at 1:55 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 Hi,

 Please
 Nicolas Malin,
 Mridul Pathak
 Sharan Foga
 check that you have (still?) acces to this page https://cwiki.apache.org/
 confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities

 I have just removed your Confluence contributors rights, and I want to be
 sure the infra team gave you access to all workspaces.
 Deepak reported he has an issue...

 Thanks

 Jacques



Re: Groovy at Apache

2015-03-03 Thread Pranay Pandey
Good one.
On Mar 4, 2015 9:49 AM, Ashish Vijaywargiya 
ashish.vijaywarg...@hotwaxsystems.com wrote:

 Wow, Excellent news!! Thanks for sharing it Jacques. :-)

 Kind Regards
 Ashish Vijaywargiya
 HotWax Systems - est. 1997

 On Tue, Mar 3, 2015 at 9:14 PM, jler...@apache.org jler...@apache.org
 wrote:

  Forwarded FYI
 
  Jacques
 
   Message transféré 
  Sujet : Groovy at Apache
  Date :  Tue, 3 Mar 2015 12:16:52 +0100
  De :Cédric Champeau cedric.champ...@gmail.com
  Pour :  elecha...@apache.org, bdelacre...@apache.org, Guillaume Laforge
 
  glafo...@gmail.com, Jochen Theodorou blackd...@gmx.org, Paul King 
  pa...@asert.com.au
  Copie à :   amania...@apache.org, r...@apache.org, ebo...@apache.org,
  jler...@apache.org
 
 
 
  Hi everyone!
 
  On behalf of the Groovy team, I am pleased to announce that we are going
  to submit a proposal to join the ASF. Thank you very much for the time
 you
  spent to answer our questions or concerns, and who knows maybe some of
 you
  will be willing to become mentors for the project?
 
  The decision will be made public soon, we wanted to let you know before
  the news goes out.
 
  Best regards,
 
  Cédric
 
 
 
 



Re: About the tutorial

2015-05-16 Thread Pranay Pandey
Thanks Jacques, I have been thinking to rewrite the tutorial. Planning to
start writing the new one shortly, please stay tuned.

This time I am thinking to do it differently-
1. Download and Setup - Clearly outlining system hardware requirements.
2. Developing Custom Apps
3. Customizations to Existing Apps

Also thinking to create videos for the same which can be embedded within
tutorial itself. Depending on preference by the learner he can choose
his/her source of learning OFBiz(Tutorial Doc or Videos).

If you or anyone have recommendations around it, lets discuss on this
thread. I strongly believe the time has come when this tutorial should be
rewritten.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Sat, May 9, 2015 at 3:11 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 Hi All, Adrian,

 Adrian I have looked at your ApacheCon 15 presentation, good it has been
 advertised on the user ML!

 One point, I read:

 The Best Practice to follow is:
 “When a screen is split up into multiple templates or screens thedata
 preparation action should be associated only with the individualsmall
 screen
 that it prepares data for. This makes it easier to move templates and
 content
 pieces around and reuse them in many places. “

 In other words, the data preparation logic should be contained within the
 screen widget that renders it –including forms, menus, and trees.

 But the tutorial found on the Wiki:

 https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide
 does not follow this best practice –the data preparation is done in the
 screen
 and not in the form that displays the data. Consequently, that form is not
 reusable –it will be empty (not contain any data) if it is used in any
 other  screen.

 It seems that the Hotwax System contribution policy has changed and this
 is no longer maintained by them (was mostly Pranay).

 Pranay, HS team, could you please confirm this tutorial is no longer
 maintained by you and if we should rather link a page on HS blog?

 Of course I'm not thinking about only the point Adrian outlined, but in
 general.

 Thanks

 Jacques



Re: [VOTE] [RELEASE] Apache OFBiz 13.07.02 - third attempt

2015-05-16 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Thu, May 14, 2015 at 3:40 PM, Jacopo Cappellato 
jacopo.cappell...@hotwaxsystems.com wrote:

 Let's try again!

 This is the vote thread to release a new bug fix release for the
 release13.07 branch. This new release, Apache OFBiz 13.07.02 will
 supersede previous releases from the same branch.

 The release files can be downloaded from here:
 https://dist.apache.org/repos/dist/dev/ofbiz/

 * apache-ofbiz-13.07.02.zip: the release archive
 * apache-ofbiz-13.07.02.zip.md5, apache-ofbiz-13.07.02.zip.sha: hashes
 * apache-ofbiz-13.07.02.zip.asc: the detached signature file
 * KEYS: text file with keys

 Please download and test the zip file and its signatures (for instructions
 on testing the signatures see http://www.apache.org/info/verification.html
 ).

 Release notes:

 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310500version=12328788

 Vote:

 [ +1] release as Apache OFBiz 13.07.02
 [ -1] do not release

 This vote will be open for 5 days.
 For more details about this process please read
 http://www.apache.org/foundation/voting.html

 Kind Regards,

 Jacopo


Re: svn commit: r1675852 - in /ofbiz/trunk/applications/accounting/servicedef: secas.xml secas_invoice.xml

2015-05-15 Thread Pranay Pandey
Thanks Jacopo.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Fri, May 15, 2015 at 10:39 AM, Jacopo Cappellato 
jacopo.cappell...@hotwaxsystems.com wrote:

 Done:

 https://issues.apache.org/jira/browse/OFBIZ-6369

 Jacopo

 On Apr 28, 2015, at 9:16 AM, Jacques Le Roux jacques.le.r...@les7arts.com
 wrote:

  Hi Pranay,
 
  That's cool, but is it not worth a Jira for releases logs?
 
  Thanks
 
  Jacques
 
  Le 24/04/2015 15:29, pran...@apache.org a écrit :
  Author: pranayp
  Date: Fri Apr 24 13:29:56 2015
  New Revision: 1675852
 
  URL: http://svn.apache.org/r1675852
  Log:
  Fixed the order in which invoice and payment transactions are created.
 
  Payment transactions were being created prior to invoice transactions,
 It causes confusion for accountants in real world.
 
  It was a seca execution order which was causing the issue on
 setInvoiceStatus. Moved the trigger on setInvoiceStatus for
 checkInvoicePaymentApplications and capturePaymentsByInvoice from secas.xml
 to secas_invoice.xml, so that we do invoice transactions prior to payment.
 
  Modified:
  ofbiz/trunk/applications/accounting/servicedef/secas.xml
  ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 
  Modified: ofbiz/trunk/applications/accounting/servicedef/secas.xml
  URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas.xml?rev=1675852r1=1675851r2=1675852view=diff
 
 ==
  --- ofbiz/trunk/applications/accounting/servicedef/secas.xml (original)
  +++ ofbiz/trunk/applications/accounting/servicedef/secas.xml Fri Apr 24
 13:29:56 2015
  @@ -158,13 +158,4 @@ under the License.
   condition field-name=productTypeId operator=equals
 value=ASSET_USAGE/
   action service=createFixedAssetAndLinkToProduct
 mode=sync/
   /eca
  -
  -eca service=setInvoiceStatus event=commit
  -condition field-name=invoiceId operator=is-not-empty/
  -condition field-name=statusId operator=equals
 value=INVOICE_READY/
  -condition field-name=oldStatusId operator=not-equals
 value=INVOICE_READY/
  -condition field-name=oldStatusId operator=not-equals
 value=INVOICE_PAID/
  -action service=checkInvoicePaymentApplications mode=sync/
  -action service=capturePaymentsByInvoice mode=sync/
  -/eca
   /service-eca
 
  Modified:
 ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
  URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml?rev=1675852r1=1675851r2=1675852view=diff
 
 ==
  --- ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 (original)
  +++ ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 Fri Apr 24 13:29:56 2015
  @@ -47,4 +47,12 @@ under the License.
   action service=createMatchingPaymentApplication
 mode=sync/
   /eca
   +eca service=setInvoiceStatus event=commit
  +condition field-name=invoiceId operator=is-not-empty/
  +condition field-name=statusId operator=equals
 value=INVOICE_READY/
  +condition field-name=oldStatusId operator=not-equals
 value=INVOICE_READY/
  +condition field-name=oldStatusId operator=not-equals
 value=INVOICE_PAID/
  +action service=checkInvoicePaymentApplications mode=sync/
  +action service=capturePaymentsByInvoice mode=sync/
  +/eca
   /service-eca
 
 
 




Re: svn commit: r1675852 - in /ofbiz/trunk/applications/accounting/servicedef: secas.xml secas_invoice.xml

2015-05-15 Thread Pranay Pandey
Thanks Jacques, he is doing better now.

As now you know I wasn't ignoring you, definitely it was worth adding a
JIRA ticket, thanks so much for reminder and persistence.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Fri, May 15, 2015 at 1:02 PM, Jacques Le Roux 
jacques.le.r...@les7arts.com wrote:

 Thanks Jacopo :)

 And all my wishes to Pranay and his son for a prompt recovery

 Jacques


 Le 15/05/2015 07:09, Jacopo Cappellato a écrit :

 Done:

 https://issues.apache.org/jira/browse/OFBIZ-6369

 Jacopo

 On Apr 28, 2015, at 9:16 AM, Jacques Le Roux 
 jacques.le.r...@les7arts.com wrote:

  Hi Pranay,

 That's cool, but is it not worth a Jira for releases logs?

 Thanks

 Jacques

 Le 24/04/2015 15:29, pran...@apache.org a écrit :

 Author: pranayp
 Date: Fri Apr 24 13:29:56 2015
 New Revision: 1675852

 URL: http://svn.apache.org/r1675852
 Log:
 Fixed the order in which invoice and payment transactions are created.

 Payment transactions were being created prior to invoice transactions,
 It causes confusion for accountants in real world.

 It was a seca execution order which was causing the issue on
 setInvoiceStatus. Moved the trigger on setInvoiceStatus for
 checkInvoicePaymentApplications and capturePaymentsByInvoice from secas.xml
 to secas_invoice.xml, so that we do invoice transactions prior to payment.

 Modified:
  ofbiz/trunk/applications/accounting/servicedef/secas.xml
  ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml

 Modified: ofbiz/trunk/applications/accounting/servicedef/secas.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas.xml?rev=1675852r1=1675851r2=1675852view=diff

 ==
 --- ofbiz/trunk/applications/accounting/servicedef/secas.xml (original)
 +++ ofbiz/trunk/applications/accounting/servicedef/secas.xml Fri Apr 24
 13:29:56 2015
 @@ -158,13 +158,4 @@ under the License.
   condition field-name=productTypeId operator=equals
 value=ASSET_USAGE/
   action service=createFixedAssetAndLinkToProduct
 mode=sync/
   /eca
 -
 -eca service=setInvoiceStatus event=commit
 -condition field-name=invoiceId operator=is-not-empty/
 -condition field-name=statusId operator=equals
 value=INVOICE_READY/
 -condition field-name=oldStatusId operator=not-equals
 value=INVOICE_READY/
 -condition field-name=oldStatusId operator=not-equals
 value=INVOICE_PAID/
 -action service=checkInvoicePaymentApplications mode=sync/
 -action service=capturePaymentsByInvoice mode=sync/
 -/eca
   /service-eca

 Modified:
 ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 URL:
 http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml?rev=1675852r1=1675851r2=1675852view=diff

 ==
 --- ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 (original)
 +++ ofbiz/trunk/applications/accounting/servicedef/secas_invoice.xml
 Fri Apr 24 13:29:56 2015
 @@ -47,4 +47,12 @@ under the License.
   action service=createMatchingPaymentApplication
 mode=sync/
   /eca
   +eca service=setInvoiceStatus event=commit
 +condition field-name=invoiceId operator=is-not-empty/
 +condition field-name=statusId operator=equals
 value=INVOICE_READY/
 +condition field-name=oldStatusId operator=not-equals
 value=INVOICE_READY/
 +condition field-name=oldStatusId operator=not-equals
 value=INVOICE_PAID/
 +action service=checkInvoicePaymentApplications mode=sync/
 +action service=capturePaymentsByInvoice mode=sync/
 +/eca
   /service-eca








Re: Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Pranay Pandey
Hi Taher,

There is one thing that I want to confirm based my understanding, as long
as I know, we can run tests independently as well e.g.

*Running tests for a component: *

java -jar ofbiz.jar -test component=‘order’

*Running a specific test Suite from a component:*

ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
ordertests'

*Running a test case from a component:*

java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'

I may be completely wrong here but just want to confirm and understand your
proposal.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <slidingfilame...@gmail.com>
wrote:

> Hello Everyone,
>
> After refactoring the start component and while starting on the base
> component I realized that the testing framework for OFBiz is not good. You
> cannot do real test driven development or red-green-refactor with the
> current setup, hence my proposal to change it. I explain below:
>
> Problem with current design
> 
> - What we have right now is not unit tests, it's really integration tests.
> You have to start the framework, the database, the service engine, the
> entity engine and pretty much everything.
> - Testing is very slow, because it's an integration test as I mentioned
> above. 10 minutes on a good computer!
> - There is zero mocking! We actually have to --load-data for things to
> work. Again, these are integration tests.
> - Too complex: Integration tests by their nature are grabbing too much.
> Mind you, I am not objecting to integration tests (I actually like them)
> but I am objecting to not having real unit-tests. Unit tests should all run
> in a few seconds.
>
> Proposed solution
> --
> - We keep what is considered real integration tests the way they are right
> now and keep using them
> - We move what should be unit tests into simple JUnit classes, and we do
> not run them using java -jar ofbiz.jar --test, but instead run them
> directly from the build.xml script, so these files are not identified in
> any XML document, but are simply called immediately from the build scripts.
> - We clearly mark the difference between integration tests and unit tests
> (inside the source files or in the suite declarations).
> - We change the run-tests target in build.xml to run both unit tests and
> integration tests.
>
> I intend to heavily refactor the framework and I would feel better about
> introducing this change while refactoring. What do you guys think? Ideas?
> Suggestions? Approvals and thumbs up?
>
> Regards,
>
> Taher Alkhateeb
>


Re: Proposal to modify the testing framework for OFBiz

2016-06-08 Thread Pranay Pandey
thanks so much Taher for the explaining it further, makes perfect sense.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 8, 2016 at 3:02 PM, Taher Alkhateeb <slidingfilame...@gmail.com>
wrote:

> Hi Pranay,
>
> What you are talking about is integration tests (ones that you can run per
> component)
>
> Unit tests do not need to be run per component. The entire unit test
> library for the entire framework should run in probably less than 5
> seconds. So there is no need to make them run per component.
>
> My proposal is to simply have a target like run-unit-tests which would run
> all the unit tests. These tests do not talk to the database or server or
> anything, You can run them while flying in an airplane 30,000 feet above
> the ocean.
>
> Mind you I will not remove the integration tests, I'm just adding unit
> tests (and probably moving some integration tests to unit tests).
>
> Naturally, my proposition means that those tests are only JUnit tests (for
> now) but that is a quick solution that I think is rather clean because
> we're not really radically modifying anything, we're just adding JUnit
> classes and running them.
>
> Regards,
>
> Taher Alkhateeb
>
> On Wed, Jun 8, 2016 at 12:23 PM, Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
>
> > Hi Taher,
> >
> > There is one thing that I want to confirm based my understanding, as long
> > as I know, we can run tests independently as well e.g.
> >
> > *Running tests for a component: *
> >
> > java -jar ofbiz.jar -test component=‘order’
> >
> > *Running a specific test Suite from a component:*
> >
> > ant run-single-test-suite -Dtest.component=‘order’ -Dtest.suiteName='
> > ordertests'
> >
> > *Running a test case from a component:*
> >
> > java -jar ofbiz.jar -test -component='order' -case='salesOrder-test'
> >
> > I may be completely wrong here but just want to confirm and understand
> your
> > proposal.
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
> >
> > On Wed, Jun 8, 2016 at 2:41 PM, Taher Alkhateeb <
> > slidingfilame...@gmail.com>
> > wrote:
> >
> > > Hello Everyone,
> > >
> > > After refactoring the start component and while starting on the base
> > > component I realized that the testing framework for OFBiz is not good.
> > You
> > > cannot do real test driven development or red-green-refactor with the
> > > current setup, hence my proposal to change it. I explain below:
> > >
> > > Problem with current design
> > > 
> > > - What we have right now is not unit tests, it's really integration
> > tests.
> > > You have to start the framework, the database, the service engine, the
> > > entity engine and pretty much everything.
> > > - Testing is very slow, because it's an integration test as I mentioned
> > > above. 10 minutes on a good computer!
> > > - There is zero mocking! We actually have to --load-data for things to
> > > work. Again, these are integration tests.
> > > - Too complex: Integration tests by their nature are grabbing too much.
> > > Mind you, I am not objecting to integration tests (I actually like
> them)
> > > but I am objecting to not having real unit-tests. Unit tests should all
> > run
> > > in a few seconds.
> > >
> > > Proposed solution
> > > --
> > > - We keep what is considered real integration tests the way they are
> > right
> > > now and keep using them
> > > - We move what should be unit tests into simple JUnit classes, and we
> do
> > > not run them using java -jar ofbiz.jar --test, but instead run them
> > > directly from the build.xml script, so these files are not identified
> in
> > > any XML document, but are simply called immediately from the build
> > scripts.
> > > - We clearly mark the difference between integration tests and unit
> tests
> > > (inside the source files or in the suite declarations).
> > > - We change the run-tests target in build.xml to run both unit tests
> and
> > > integration tests.
> > >
> > > I intend to heavily refactor the framework and I would feel better
> about
> > > introducing this change while refactoring. What do you guys think?
> Ideas?
> > > Suggestions? Approvals and thumbs up?
> > >
> > > Regards,
> > >
> > > Taher Alkhateeb
> > >
> >
>


Re: Proposal to modify the testing framework for OFBiz

2016-06-12 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 10, 2016 at 7:46 PM, Taher Alkhateeb <slidingfilame...@gmail.com
> wrote:

> Hello Everyone,
>
> I was able to get a few tests running and this is very doable. But I faced
> a big problem in designing the testing framework because of ANT.
>
> The problem
> 
> The way the build scripts are designed in OFBiz are very complex. A master
> file calls other files which call other files. And in the middle you have
> external libraries (ant-contrib) and macros, and variables, and class path
> declarations, and and and 
>
> I cannot declare the tests programmatically (with JUnit test suites)
> because this means lower level components would depend on higher level
> components. So I have to do it in ANT, by navigating this maze of build
> scripts, and it was a headache for me just to read them, let alone modify
> them to create a testing framework.
>
> Suggested Solution
> 
> I suggest to implement the testing framework in Gradle, and simply call it
> from within ant. This is a middle solution that sustains ant for now, but
> can allow us to switch out later.
>
> This means I will just add one more file called build.gradle in the top
> level directory, and figure out the business logic for calling the test
> suites from that file
>
> I look forward to your feedback.
>
> Regards,
>
> Taher Alkhateeb
>
> On Wed, Jun 8, 2016 at 6:00 PM, Taher Alkhateeb <
> slidingfilame...@gmail.com>
> wrote:
>
> > Hi Everyone,
> >
> > Thank you all for your support, JIRA created in
> > https://issues.apache.org/jira/browse/OFBIZ-7254
> >
> > I will start working on it and try to implement ASAP to get my focus back
> > on refactoring.
> >
> > Cheers!
> >
> > Taher Alkhateeb
> >
> > On Wed, Jun 8, 2016 at 4:58 PM, Deepak Dixit <
> > deepak.di...@hotwaxsystems.com> wrote:
> >
> >> +1
> >>
> >> Thanks & Regards
> >> --
> >> Deepak Dixit
> >> www.hotwaxsystems.com
> >>
> >> On Wed, Jun 8, 2016 at 7:12 PM, Mridul Pathak <
> >> mridul.pat...@hotwaxsystems.com> wrote:
> >>
> >> > +1
> >> >
> >> > Makes perfect sense.
> >> >
> >> > --
> >> > Thanks & Regards,
> >> > Mridul Pathak
> >> > Senior Manager
> >> > HotWax Systems
> >> > http://www.hotwaxsystems.com
> >> >
> >> > > On Jun 8, 2016, at 2:41 PM, Taher Alkhateeb <
> >> slidingfilame...@gmail.com>
> >> > wrote:
> >> > >
> >> > > Hello Everyone,
> >> > >
> >> > > After refactoring the start component and while starting on the base
> >> > > component I realized that the testing framework for OFBiz is not
> good.
> >> > You
> >> > > cannot do real test driven development or red-green-refactor with
> the
> >> > > current setup, hence my proposal to change it. I explain below:
> >> > >
> >> > > Problem with current design
> >> > > 
> >> > > - What we have right now is not unit tests, it's really integration
> >> > tests.
> >> > > You have to start the framework, the database, the service engine,
> the
> >> > > entity engine and pretty much everything.
> >> > > - Testing is very slow, because it's an integration test as I
> >> mentioned
> >> > > above. 10 minutes on a good computer!
> >> > > - There is zero mocking! We actually have to --load-data for things
> to
> >> > > work. Again, these are integration tests.
> >> > > - Too complex: Integration tests by their nature are grabbing too
> >> much.
> >> > > Mind you, I am not objecting to integration tests (I actually like
> >> them)
> >> > > but I am objecting to not having real unit-tests. Unit tests should
> >> all
> >> > run
> >> > > in a few seconds.
> >> > >
> >> > > Proposed solution
> >> > > --
> >> > > - We keep what is considered real integration tests the way they are
> >> > right
> >> > > now and keep using them
> >> > > - We move what should be unit tests into simple JUnit classes, and
> we
> >> do
> >> > > not run them using java -jar ofbiz.jar --test, but instead run them
> >> > > directly from the build.xml script, so these files are not
> identified
> >> in
> >> > > any XML document, but are simply called immediately from the build
> >> > scripts.
> >> > > - We clearly mark the difference between integration tests and unit
> >> tests
> >> > > (inside the source files or in the suite declarations).
> >> > > - We change the run-tests target in build.xml to run both unit tests
> >> and
> >> > > integration tests.
> >> > >
> >> > > I intend to heavily refactor the framework and I would feel better
> >> about
> >> > > introducing this change while refactoring. What do you guys think?
> >> Ideas?
> >> > > Suggestions? Approvals and thumbs up?
> >> > >
> >> > > Regards,
> >> > >
> >> > > Taher Alkhateeb
> >> >
> >> >
> >>
> >
> >
>


Re: Commits and especially backports suggest best practice

2016-06-09 Thread Pranay Pandey
Makes perfect sense.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 10, 2016 at 1:18 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi,
>
> I understand that every committer is free to commit and backport or not,
> but I'd like to propose a best practice.
> When you backport something, if you know that it should not be backported
> in older releases, please pass the information. It makes reviewers task
> much easier.
> I put a note at
> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Committers+Roles+and+Responsibilities#OFBizCommittersRolesandResponsibilities-Howshouldcommittershandlebackporting
> ?
>
> Thanks
>
> Jacques
>
>


Re: Taher Alkhateeb joins the OFBiz PMC

2016-06-10 Thread Pranay Pandey
Many congratulations Taher, great job, keep it up.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 10, 2016 at 11:35 AM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> Welcome, Taher! Keep up the great work.
>
> Jacopo
>


Re: svn commit: r1746460 - /ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl

2016-06-03 Thread Pranay Pandey
Hi Deepak,

Thanks for your comment, surely this one could be the other way to fix the
issue. But Amardeep has tried to follow the structure which is being
followed by other fields on this pdf.

Amardeep, please feel free to add further details.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 3, 2016 at 11:54 AM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:

> Hi Amardeep,
>
> I think Here instead of showing empty terms we can move condition before
> fo:table-row,
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Wed, Jun 1, 2016 at 7:02 PM, <pran...@apache.org> wrote:
>
> > Author: pranayp
> > Date: Wed Jun  1 13:32:24 2016
> > New Revision: 1746460
> >
> > URL: http://svn.apache.org/viewvc?rev=1746460=rev
> > Log:
> > [OFBIZ-7146] Applied patch from the ticket to fix error in rendering
> Quote
> > PDF which is not having terms associated to it.
> >
> > Thanks Amardeep Singh Jhajj for reporting the issue and providing patch.
> >
> > Modified:
> >
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> >
> > Modified:
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > URL:
> >
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl?rev=1746460=1746459=1746460=diff
> >
> >
> ==
> > ---
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > (original)
> > +++
> >
> ofbiz/trunk/applications/order/template/quote/QuoteReportContactMechs.fo.ftl
> > Wed Jun  1 13:32:24 2016
> > @@ -74,9 +74,9 @@ under the License.
> >
> >
> ${(quote.validThruDate.toString())!}
> >  
> >  
> > +
> >
> ${uiLabelMap.CommonQuoteTerms}:
> >  <#assign quoteLevelTerms =
> > Static["org.ofbiz.entity.util.EntityUtil"].filterByAnd(quoteTerms,
> > {"quoteItemSeqId": "_NA_"})!>
> >  <#if quoteLevelTerms?has_content &&
> > quoteLevelTerms.size() gt 0>
> > -
> >
> ${uiLabelMap.CommonQuoteTerms}:
> >  
> >  <#list quoteLevelTerms as quoteLevelTerm>
> >  
> >
> >
> >
>


Re: Publish OFBiz 15.12 repository's address

2016-06-04 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 4, 2016 at 2:40 PM, Divesh Dutta <divesh.du...@hotwaxsystems.com
> wrote:

> Hello team,
>
> I think now we should publish address of  OFBiz 15.12 repository on
> https://ofbiz.apache.org/source-repositories.html
>
>
> Thanks
> --
> Divesh Dutta.
>


Re: Publish OFBiz 15.12 repository's address

2016-06-04 Thread Pranay Pandey
Thanks Jacques :)

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 4, 2016 at 3:30 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Thanks Pranay,
>
> It's done :)
>
> Jacques
>
>
>
> Le 04/06/2016 à 11:43, Pranay Pandey a écrit :
>
>> Thanks Jacques and Divesh I have committed the addition to ofbiz-website
>> revision 1746797.
>>
>> Jacques,
>> Please let me know if any further action is required.
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>> On Sat, Jun 4, 2016 at 2:58 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> Pranay, Divesh,
>>>
>>> +1
>>>
>>> As committers you can do it by using
>>> https://svn.apache.org/repos/asf/ofbiz/site
>>>
>>> Thanks
>>>
>>> Jacques
>>>
>>>
>>>
>>> Le 04/06/2016 à 11:20, Pranay Pandey a écrit :
>>>
>>> +1
>>>>
>>>> Best regards,
>>>>
>>>> Pranay Pandey
>>>> HotWax Systems
>>>> http://www.hotwaxsystems.com/
>>>>
>>>> On Sat, Jun 4, 2016 at 2:40 PM, Divesh Dutta <
>>>> divesh.du...@hotwaxsystems.com
>>>>
>>>> wrote:
>>>>> Hello team,
>>>>>
>>>>> I think now we should publish address of  OFBiz 15.12 repository on
>>>>> https://ofbiz.apache.org/source-repositories.html
>>>>>
>>>>>
>>>>> Thanks
>>>>> --
>>>>> Divesh Dutta.
>>>>>
>>>>>
>>>>>
>


Re: Publish OFBiz 15.12 repository's address

2016-06-04 Thread Pranay Pandey
Thanks Jacques and Divesh I have committed the addition to ofbiz-website
revision 1746797.

Jacques,
Please let me know if any further action is required.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 4, 2016 at 2:58 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Pranay, Divesh,
>
> +1
>
> As committers you can do it by using
> https://svn.apache.org/repos/asf/ofbiz/site
>
> Thanks
>
> Jacques
>
>
>
> Le 04/06/2016 à 11:20, Pranay Pandey a écrit :
>
>> +1
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>> On Sat, Jun 4, 2016 at 2:40 PM, Divesh Dutta <
>> divesh.du...@hotwaxsystems.com
>>
>>> wrote:
>>> Hello team,
>>>
>>> I think now we should publish address of  OFBiz 15.12 repository on
>>> https://ofbiz.apache.org/source-repositories.html
>>>
>>>
>>> Thanks
>>> --
>>> Divesh Dutta.
>>>
>>>
>


Re: Error on pagination at some screens when we do any operation (like update, delete) from list

2016-06-15 Thread Pranay Pandey
Hi Amardeep,

What you have recommended is looking good to me i.e. pagination target URL
should be independent of page URL and it should be added on form using
paginate-target attribute of form widget.

The approach you are planning to take is also looking good to me i.e. to
create on parent ticket and add a child ticket for each of component to
check and fix.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, Jun 14, 2016 at 9:43 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hi Everyone,
>
> I found issue in pagination on some screens when we do any operation (like
> update, delete) on list item.
>
> For example: I have updated the content type from list in Content Setup
> Menu in Content application and then clicked on next link of pagination, I
> got the following error:
>
> The Following Errors Occurred:
>
> Error calling event: org.ofbiz.webapp.event.EventHandlerException: Found
> URL
> parameter [contentTypeId] passed to secure (https) request-map with uri
> [updateContentType] with an event that calls service [updateContentType];
> this is not allowed for security reasons!
>
> The above error is unexpected as I just tried to see next list records of
> ContentType. The reason of error is pagination URL which is same as URL of
> page i.e. updateContentType. This URL is the update operation URL and it is
> not redirected to appropriate page after operation.
>
> IMO, pagination target URL should be independent of page URL and it should
> be added on form using paginate-target attribute of form widget.
>
> This issue can be possible in all components. I am planning to create one
> parent ticket and will add their child tickets wherever needed for each
> component for adding "paginate-target" to the forms.
>
> Please let us know your thoughts.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
> http://www.hotwaxsystems.com/
>


Re: Support of passing placeholder values in while using UiLabels for error reporting

2016-06-05 Thread Pranay Pandey
Hi Swapnil, Jacques

Yes, it looks like a required improvement in fail-property usage.

Though we can go the groovy route if service/event written using it.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sun, Jun 5, 2016 at 9:40 AM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Hi Swapnil,
>
> This is possible with fail-message but seems indeed impossible with
> fail-property
>
> Jacques
>
>
>
> Le 04/06/2016 à 13:14, Swapnil Mane a écrit :
>
>> Dear team,
>>
>> As per the current OOTB code, In  tag, we don't have
>> support
>> for fetching the property message along with updated value of placeholder.
>> for e.g. We have UiLabel AccountingInvoiceUpdateOnlyWithInProcessStatus
>>
>>
>> {code}
>>
>> 
>>
>> Can only update Invoice, when status is
>>
>>> in-process...current status: ${lookedUpValue.statusId}
>>>
>> {code}
>>
>>
>>
>> (*Here placeholder is  ${lookedUpValue.statusId}*)
>>
>> Now, In simple method 'InvoiceStatusInProgress'
>> (accounting/widget/InvoiceScreens.xml), we used fail-property
>>
>> {code}
>>
>> >
>>> property="AccountingInvoiceUpdateOnlyWithInProcessStatus" />
>>>
>> {code}
>>
>>
>>
>> using this, we are unable to pass the value of statusId, for getting
>> the message like
>>
>> Can only update Invoice, when status is in-process...current status:
>>
>>> *INVOICE_PAID*
>>>
>>
>> Kindly let me know if I am missing anything while using the
>> 
>> or if it is the current limitation, we can proceed to create Jira ticket
>> (Please confirm :)
>>
>> - Best Regards,
>> Swapnil M Mane
>> HotWax Systems,
>> www.hotwaxsystems.com
>>
>>
>


Re: PDF's missing child block element errors

2016-06-04 Thread Pranay Pandey
+1 to keep the validation enabled.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 4, 2016 at 4:15 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:

> Hi Amardeep,
>
> Thanks for bringing it up. I believe we should keep validation enabled to
> follow best practices and better code quality. It’s good that we are
> noticing these issues due to change in validation jars.
>
> --
> Thanks & Regards,
> Mridul Pathak
> Senior Manager
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 4, 2016, at 12:57 PM, Amardeep Singh Jhajj <
> amardeep.jh...@hotwaxsystems.com> wrote:
> >
> > Hi Community,
> >
> > We have recently seen many issues related to missing child block elements
> > in PDF, we normally fix it by adding missing elements. Some of the
> tickets-
> > OFBIZ-7090 <https://issues.apache.org/jira/browse/OFBIZ-7090>,
> OFBIZ-6898
> > <https://issues.apache.org/jira/browse/OFBIZ-6898> etc.
> >
> > Today, I found this issue again in trunk in accounting trans PDF. Please
> > refer OFBIZ-7171 <https://issues.apache.org/jira/browse/OFBIZ-7171>
> >
> > I also checked it in our other releases 13.07 and 14.12, it worked. So it
> > was the question that what is changed after 14.12 release that causes
> this
> > issue.
> >
> > I done some research and found that we have changed the fop jar from
> > fop-1.1.jar to fop-2.0.jar at -r1691852 in trunk, now change available in
> > both the 15.12 (cut from trunk after change) and trunk.
> >
> > In release 14.12, in ApacheFopWorker.java "getFactoryInstance" method, we
> > have below code snippet
> >
> > fopFactory.setStrictValidation(false);
> >
> > Actually, XSL-FO validation is by default active. By above code,
> validation
> > was deactivated.
> >
> > On looking at commit at -r1691852, we have upgraded to fop-2.0 and
> removed
> > the above code which deactivates validation. In 2.0, setStrictValidation
> > method is not present instead we can use configuration property
> > "strict-validation" with value "false". This configuration property
> exists
> > in both the fop 1.0 and 2.0.
> >
> > Please refer:
> >
> > https://xmlgraphics.apache.org/fop/1.0/configuration.html
> > https://xmlgraphics.apache.org/fop/2.0/configuration.html
> >
> > We can disable validation using below code snippet in fop.xconf.
> >
> > false
> >
> > I am able to open PDF using it. We can say, no strict validation of
> markup
> > done here.
> >
> > But, I would prefer validation enabled as it helps us to write correct
> > markup of XSL-FO. We may see similar kind of issues in future due to
> strict
> > validation and we can fix it.
> >
> > Should we do validation false or not? Please let me know your thoughts.
> >
> > Thanks and Regards
> > --
> > Amardeep Singh Jhajj
> > www.hotwaxsystems.com
>
>


Re: JIRA Ticket for Documentation Effort

2016-05-31 Thread Pranay Pandey
Hi Community,

Here is the link to ticket for the renewal of OFBiz Tutorial -
https://issues.apache.org/jira/browse/OFBIZ-7145

Please put your comments on the ticket for the improvements you would like
to see in the existing tutorial or any ideas that you would like to
incorporate in this new tutorial.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Mon, May 23, 2016 at 4:56 PM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> Thanks for giving thoughts to it.
> Looks like everyone is in favor. Will plan the effort further with JIRA
> Ticket.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Sat, May 21, 2016 at 5:10 PM, Pierre Smits <pierre.sm...@gmail.com>
> wrote:
>
>> +1
>> Documentation is also a product of the project. Incorporating it into
>> release notes, helps communication. Helps adoption.
>>
>> Pierre Smits
>>
>> ORRTIZ.COM <http://www.orrtiz.com>
>> OFBiz based solutions & services
>>
>> OFBiz Extensions Marketplace
>> http://oem.ofbizci.net/oci-2/
>>
>> On Sat, May 21, 2016 at 1:18 PM, Jacques Le Roux <
>> jacques.le.r...@les7arts.com> wrote:
>>
>> > +1!
>> >
>> > Things are clearer in/with Jira
>> >
>> > Jacques
>> >
>> >
>> >
>> > Le 21/05/2016 à 06:59, Pranay Pandey a écrit :
>> >
>> >> Hi Community,
>> >>
>> >> What do you think of this option, should we create a Ticket in JIRA for
>> >> any
>> >> of the documentation effort?
>> >>
>> >> I am going to start work on OFBiz Beginners Tutorial overhaul(Will
>> create
>> >> a
>> >> new one and open it for review to the community for feedback) and was
>> >> thinking to map the effort with a JIRA Ticket. Please let me know your
>> >> thoughts.
>> >>
>> >>
>> >>
>> >> Best regards,
>> >>
>> >> Pranay Pandey
>> >> HotWax Systems
>> >> http://www.hotwaxsystems.com/
>> >>
>> >>
>> >
>>
>
>


Re: Product base promotion calculation

2016-06-16 Thread Pranay Pandey
+1 Mridul.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Jun 16, 2016 at 1:32 PM, Mridul Pathak <
mridul.pat...@hotwaxsystems.com> wrote:

> Hi Arvind,
>
> While I agree that current behavior can be improved as per your suggestion
> but at the same time considering different behaviors of the range of
> promotions we have, implementing a proper fix would be tricky. I think a
> JIRA ticket can be logged and solution can be discussed over there. If you
> have patch available please provide it on the ticket you create.
>
> --
> Thanks & Regards,
> Mridul Pathak
> Senior Manager
> HotWax Systems
> http://www.hotwaxsystems.com
>
> > On Jun 16, 2016, at 12:21 PM, Pranay Pandey <
> pranay.pan...@hotwaxsystems.com> wrote:
> >
> > Hi Arvind,
> >
> > Yes I agree, If it's the promotion for one product than orderAdjustment
> > should also be one. Also please create a JIRA issue and attach your
> > screenshots there.
> >
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
> >
> > On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
> > arvindtomar1...@gmail.com> wrote:
> >
> >> Hi Everyone,
> >>
> >> I found the behavior of product base promotion calculation a bit
> strange.
> >> Need your advice on whether it is correct behaviour or need some
> >> improvement in promotion calculation.
> >>
> >> The promotion which I used was to give 30% discount for the item (i.e.
> >> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
> >> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
> >> for each quantity for the same promotion type.
> >>
> >> I was expecting that in the case if same Promotion is applicable for
> more
> >> than one quantity of a product then a single OrderAdjustment should be
> >> created instead of creating one for each quantity. It is also messing up
> >> the UI.
> >>
> >> Attached the screenshots for the same.
> >>
> >>
> >> Thanks and Regards
> >> --
> >> Arvind Singh Tomar
> >>
>
>


Re: Use of utility method for checking null GenericValue

2016-06-17 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 17, 2016 at 8:00 PM, Ratnesh Upadhyay <
upadhyay.ratn...@gmail.com> wrote:

> Hello community,
>
> There are lots of places in code where we have used
> UtilValidate.isNotEmpty() or UtilValidate.isEmpty() for GenericValue object
> . GenericValue is never empty. Its always null or not null. So should we
> use directly null or not null check instead of UtilValidate.isNotEmpty()
> and UtilValidate.isEmpty() for GenericValue objects ?
>
> Basically these validation methods should preferably be used on Strings or
> Lists and normal Maps.
>
> Thanks!!
>
> Regards,
> Ratnesh Upadhyay
> HotWax Systems | www.hotwaxsystems.com
>


Re: Use of utility method for checking null GenericValue

2016-06-18 Thread Pranay Pandey
Yes Deepak, IMO we should change it for existing code as well, because this
type of checks some times cause functional issues on null checks on
GenericValue.

My vote will be to go for it.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 18, 2016 at 3:09 PM, Deepak Dixit <
deepak.di...@hotwaxsystems.com> wrote:

> I think we can make it part of best practice and use for new code.
> For old code, Do we need to change existing code?
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
>
> On Sat, Jun 18, 2016 at 1:36 PM, Michael Brohl <michael.br...@ecomify.de>
> wrote:
>
> > +1
> >
> > Michael Brohl
> > ecomify GmbH
> > www.ecomify.de
> >
> >
> > Am 17.06.16 um 16:30 schrieb Ratnesh Upadhyay:
> >
> > Hello community,
> >>
> >> There are lots of places in code where we have used
> >> UtilValidate.isNotEmpty() or UtilValidate.isEmpty() for GenericValue
> >> object
> >> . GenericValue is never empty. Its always null or not null. So should we
> >> use directly null or not null check instead of UtilValidate.isNotEmpty()
> >> and UtilValidate.isEmpty() for GenericValue objects ?
> >>
> >> Basically these validation methods should preferably be used on Strings
> or
> >> Lists and normal Maps.
> >>
> >> Thanks!!
> >>
> >> Regards,
> >> Ratnesh Upadhyay
> >> HotWax Systems | www.hotwaxsystems.com
> >>
> >>
> >
> >
>


Re: svn commit: r1748958 - /ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml

2016-06-18 Thread Pranay Pandey
Oops my bad, very sorry. Going to revert this unwanted change and commit
actual patch.

Pranay

On Saturday 18 June 2016, <pran...@apache.org> wrote:

> Author: pranayp
> Date: Sat Jun 18 10:54:23 2016
> New Revision: 1748958
>
> URL: http://svn.apache.org/viewvc?rev=1748958=rev
> Log:
> [OFBIZ-7367] Fixed: 'From Date' and 'Through Date' is not setting up on
> adding a new task member as weren't being sent to service. Thanks Aditi
> Patidar for the contribution.
>
> Modified:
> ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml
>
> Modified: ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml?rev=1748958=1748957=1748958=diff
>
> ==
> --- ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml
> (original)
> +++ ofbiz/trunk/applications/order/minilang/quote/QuoteServices.xml Sat
> Jun 18 10:54:23 2016
> @@ -29,7 +29,6 @@ under the License.
>  
>   value-field="partyAcctgPreference"/>
>  
> -
>  
>  value-field="partyAcctgPreference" to-value-field="customMethod"/>
> 
>
>
>

-- 
Thanks and regards,
Pranay Pandey


Re: Use of utility method for checking null GenericValue

2016-06-20 Thread Pranay Pandey
+ Jacques.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 18, 2016 at 5:19 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> And also because else people tends to reproduce by C/P blocks of code
>
> Jacques
>
>
>
> Le 18/06/2016 à 12:21, Pranay Pandey a écrit :
>
>> Yes Deepak, IMO we should change it for existing code as well, because
>> this
>> type of checks some times cause functional issues on null checks on
>> GenericValue.
>>
>> My vote will be to go for it.
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>> On Sat, Jun 18, 2016 at 3:09 PM, Deepak Dixit <
>> deepak.di...@hotwaxsystems.com> wrote:
>>
>> I think we can make it part of best practice and use for new code.
>>> For old code, Do we need to change existing code?
>>>
>>> Thanks & Regards
>>> --
>>> Deepak Dixit
>>> www.hotwaxsystems.com
>>>
>>> On Sat, Jun 18, 2016 at 1:36 PM, Michael Brohl <michael.br...@ecomify.de
>>> >
>>> wrote:
>>>
>>> +1
>>>>
>>>> Michael Brohl
>>>> ecomify GmbH
>>>> www.ecomify.de
>>>>
>>>>
>>>> Am 17.06.16 um 16:30 schrieb Ratnesh Upadhyay:
>>>>
>>>> Hello community,
>>>>
>>>>> There are lots of places in code where we have used
>>>>> UtilValidate.isNotEmpty() or UtilValidate.isEmpty() for GenericValue
>>>>> object
>>>>> . GenericValue is never empty. Its always null or not null. So should
>>>>> we
>>>>> use directly null or not null check instead of
>>>>> UtilValidate.isNotEmpty()
>>>>> and UtilValidate.isEmpty() for GenericValue objects ?
>>>>>
>>>>> Basically these validation methods should preferably be used on Strings
>>>>>
>>>> or
>>>
>>>> Lists and normal Maps.
>>>>>
>>>>> Thanks!!
>>>>>
>>>>> Regards,
>>>>> Ratnesh Upadhyay
>>>>> HotWax Systems | www.hotwaxsystems.com
>>>>>
>>>>>
>>>>>
>>>>
>


Re: Use of utility method for checking null GenericValue

2016-06-20 Thread Pranay Pandey
+1 Jacques.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Mon, Jun 20, 2016 at 11:35 AM, Pranay Pandey <
pranay.pan...@hotwaxsystems.com> wrote:

> + Jacques.
>
> Best regards,
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
>
> On Sat, Jun 18, 2016 at 5:19 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
>> And also because else people tends to reproduce by C/P blocks of code
>>
>> Jacques
>>
>>
>>
>> Le 18/06/2016 à 12:21, Pranay Pandey a écrit :
>>
>>> Yes Deepak, IMO we should change it for existing code as well, because
>>> this
>>> type of checks some times cause functional issues on null checks on
>>> GenericValue.
>>>
>>> My vote will be to go for it.
>>>
>>> Best regards,
>>>
>>> Pranay Pandey
>>> HotWax Systems
>>> http://www.hotwaxsystems.com/
>>>
>>> On Sat, Jun 18, 2016 at 3:09 PM, Deepak Dixit <
>>> deepak.di...@hotwaxsystems.com> wrote:
>>>
>>> I think we can make it part of best practice and use for new code.
>>>> For old code, Do we need to change existing code?
>>>>
>>>> Thanks & Regards
>>>> --
>>>> Deepak Dixit
>>>> www.hotwaxsystems.com
>>>>
>>>> On Sat, Jun 18, 2016 at 1:36 PM, Michael Brohl <
>>>> michael.br...@ecomify.de>
>>>> wrote:
>>>>
>>>> +1
>>>>>
>>>>> Michael Brohl
>>>>> ecomify GmbH
>>>>> www.ecomify.de
>>>>>
>>>>>
>>>>> Am 17.06.16 um 16:30 schrieb Ratnesh Upadhyay:
>>>>>
>>>>> Hello community,
>>>>>
>>>>>> There are lots of places in code where we have used
>>>>>> UtilValidate.isNotEmpty() or UtilValidate.isEmpty() for GenericValue
>>>>>> object
>>>>>> . GenericValue is never empty. Its always null or not null. So should
>>>>>> we
>>>>>> use directly null or not null check instead of
>>>>>> UtilValidate.isNotEmpty()
>>>>>> and UtilValidate.isEmpty() for GenericValue objects ?
>>>>>>
>>>>>> Basically these validation methods should preferably be used on
>>>>>> Strings
>>>>>>
>>>>> or
>>>>
>>>>> Lists and normal Maps.
>>>>>>
>>>>>> Thanks!!
>>>>>>
>>>>>> Regards,
>>>>>> Ratnesh Upadhyay
>>>>>> HotWax Systems | www.hotwaxsystems.com
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>
>


Re: is not working as expected in Form Widget

2016-06-20 Thread Pranay Pandey
+1 Pritam, we should log it in JIRA.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, Jun 18, 2016 at 5:49 PM, Pritam Kute <pritam.k...@hotwaxsystems.com>
wrote:

> Hello Devs,
>
> Any thoughts on this? Should I log JIRA issue for the same??
>
> Thanks & Regards,
> --
> *Pritam Kute*
> *HotWax Systems* | www.hotwaxsystems.com
>
> On Wed, Jun 15, 2016 at 2:26 PM, Pritam Kute <
> pritam.k...@hotwaxsystems.com>
> wrote:
>
> > Hello OFBiz Developers,
> >
> > While working on the issue OFBIZ-7252
> > <https://issues.apache.org/jira/browse/OFBIZ-7252>, I found one problem
> > in Form Widgets. When we use  attribute in child form, the
> > system should consider overridden  in child form. This is
> > default expected behaviour. But in this case, it is always considering
> the
> >  of the parent form.
> >
> > For example:
> >
> > **
> > *   *
> > *  *
> > **
> >
> > * *
> > *  *
> > **
> >
> > In above example, expectation is 'executeChildTarget' target should get
> > executed but actually 'executeParentTarget' is getting executed.
> >
> > When we looked into framework level code of Form Widgets, we got the
> > following code snippets:
> >
> > *ModelForm.java* (Line: 380-388)
> >
> > *ArrayList altTargets = new ArrayList();*
> > *if (parentModel != null) {*
> > *altTargets.addAll(parentModel.altTargets);*
> > *}*
> > *for (Element altTargetElement : UtilXml.childElementList(formElement,
> > "alt-target")) {*
> > *altTargets.add(new AltTarget(altTargetElement));*
> > *}*
> > *altTargets.trimToSize();*
> > *this.altTargets = Collections.unmodifiableList(altTargets);*
> >
> > Here we can see that all alt-targets present in parent form are added to
> > the list first and then all alt-targets present in child form are added.
> >
> > This causes a problem as method getTarget() of ModelForm.java (Line:
> > 1352-1384) returns the first element in the list as alt-target.
> >
> > Is this is intentionally done or we are missing something?
> >
> > Thanks & Regards,
> > --
> > *Pritam Kute*
> > *HotWax Systems* | www.hotwaxsystems.com
> >
>


Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Pranay Pandey
Thanks for the explanation Taher, making perfect sense.

+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, Jun 21, 2016 at 11:41 AM, Taher Alkhateeb <
slidingfilame...@gmail.com> wrote:

> Hi Deepak,
>
> Ant would be removed completely for the following reasons:
>
> - First to resolve the ASF issue about the libraries mentioned by Sharan
> below without expending effort on both build systems.
> - Ant is an obstacle to refactoring the framework. If we keep both systems
> side by side we gain nothing, actually we lose value because the builds
> become more complex. For example, we will not be able to intrduce the unit
> tests, and we will have two build outputs, and we will have two ways of
> running the framework (java -jar ofbiz.jar and gradlew ofbiz) and we will
> have other incompatibility issues.
>
> With that being said, we will not make the switch before a thorough and
> full testing. That is why we ask everyone who is willing to please help us
> out to make this transition smooth by testing and providing feedback and
> comments.
>
> Taher Alkhateeb
>
> On Tuesday, 21 June 2016, Deepak Dixit <deepak.di...@hotwaxsystems.com>
> wrote:
>
> > +1 for Gradle.
> >
> > Are we going to remove ant from framework completely or planning to keep
> > both ant and gradle?
> >
> >
> >
> > Thanks & Regards
> > --
> > Deepak Dixit
> > www.hotwaxsystems.com
> >
> > On Mon, Jun 20, 2016 at 6:20 PM, Sharan Foga <sharan.f...@gmail.com
> > <javascript:;>> wrote:
> >
> > > Hi Everyone
> > >
> > > This is the second of two emails to inform the community about what has
> > > been happening around how we are planning to handle external
> dependencies
> > > in the trunk. Two weeks ago the community discussed and agreed to the
> use
> > > of Gradle to help us put together a unit test framework. While trying
> to
> > > get this set up while Ant remained as our build tool became very
> > difficult.
> > > This was because our Ant scripts:
> > >
> > >- are massive and contain a lot of code
> > >- are complex
> > >- are very brittle and make it very hard to change things
> > >- have no dependency management
> > >- need everything to be declared
> > >
> > > We realised very quickly that the re-factoring issues and limitations
> we
> > > are facing are because of our build tool – Ant.
> > >
> > > Ant is verbose so it needs everything to be declared. We did a brief
> > > assessment of Maven and found it better than Ant but not a good fit for
> > > OFBiz because it has strict requirements for the
> > > convention-over-configuration rules to work. Instead we decided to
> take a
> > > closer look at Gradle.
> > >
> > > So why Gradle?
> > > As Taher was already looking at Gradle for unit testing, we decided to
> > > look at what we would need to do to totally replace Ant with Gradle. We
> > > received some great support and feedback from David, who is already
> using
> > > Gradle with Moqui.
> > >
> > > After some preliminary tests we found that Gradle has some very good
> > > features such as:
> > >
> > >- a much shorter code base (e.g. one single file of around 250 lines
> > of
> > > code replaces all the build.xml files and thousands of lines of code)
> > >-  Programming is DSL based and links in well with Groovy (e.g. the
> > > script is short because despite heavy custom requirements for OFBiz,
> two
> > > small functions took care of the complex directory structure)
> > >- It handles all the external jar files by downloading any
> > dependencies
> > > directly via internet
> > >- Jars can be upgraded by simply changing a string
> > >- It has matured a lot and has a high level of support in
> tools,IDEs,
> > > books, documentation
> > >- It also has a lot of plugins which means that it works with pretty
> > > much all build systems, supports multiple programming languages, and
> many
> > > other features (e.g. OSGi)
> > >
> > > We understand that it can help us make OFBiz more modular and also
> > setting
> > > up a framework for managing addons would be a lot easier.
> > >
> > > So what's been done?
> > > Taher has been working very hard on a patch for the trunk that
> completely
> > > replaces Ant with Gradle.  (Huge thanks to David for providing s

Re: Javascript clean up and improvements

2016-06-24 Thread Pranay Pandey
+1 for the recommendation Amardeep.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 24, 2016 at 12:50 PM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello everyone,
>
> Currently, OFBiz javascript code (except third party libraries) is not
> written with the best practices which can cause following problems -
>
> 1. Increases the code maintenance effort.
> 2. Impact page performance.
> 3. Present not good examples to new contributors which leads to C/P to
> various areas of js code.
>
> Here are things we should do for cleanup and improvements in js code.
>
> 1. Remove unused javascript code and files if any.
> 2. Use best practices for javascript coding to improve performance (I have
> listed some of it below).
> 3. Move utility js functions to one js file.
> 4. Remove deprecated code and use latest. For ex: We are still using
> "language='javascript'" attribute at script tag which is deprecated a years
> ago.
> 5. js should be loaded at bottom of the page, currently its in Header. Its
> a tedious task now to move it into footer because we have lot of js code
> inline in ftls.
> 6. js should not be written inline, it should be enough generic to be in
> minimum number of files and have generic code for doing the common set of
> operations over DOM.
> 7. Currently our macros of rendering pages has inline scripts, they can be
> moved to one macrorenderer.js with generic code as we can use classes, ids
> and data-attributes for doing any operation over html DOM.
> 8. After all cleanup work, we can think of build tool (like grunt) for
> various javascript build tasks (minification, concatenation of files) if
> needed. Its just a thought.
>
> I know its a huge effort and need to be done carefully. So before doing any
> major changes, I would like to start work with first 4 points.
>
> Here is the list of some best practices to start with:
>
> 1. Use [] Instead of New Array()
> 2. Long list of variables? Omit the "Var" keyword and use commas instead.
> 3. Reduce global variables
> 4. Use explicit blocks
> 5. Start blocks on the same line
> 6. Always, Always Use Semicolons - Having said that, this is a very bad
> practice that can potentially lead to much bigger, and harder to find,
> issues.
> 7. Optimize loops. Avoid calculating the length of array in for loop
> iteration.
> 8. Avoid multiple redundant jQuery DOM manupulation by saving reference to
> any object.
> 9. Try to use meaningful comments.
> 10. Many more.
>
> Here are some links of best practices information-
>
> https://www.w3.org/wiki/JavaScript_best_practices
> http://www.codeproject.com/Articles/580165/JavaScript-Best-Practices
> https://developer.yahoo.com/performance/rules.html
>
> If everyone agrees, I would like to start on this work.
>
> Please let me know your thoughts on it.
>
> Thanks and Regards
> --
> Amardeep Singh Jhajj
>


Re: Javascript clean up and improvements

2016-06-27 Thread Pranay Pandey
+1 Amardeep, mentioned approach is looking reasonable to me.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, Jun 28, 2016 at 11:21 AM, Amardeep Singh Jhajj <
amardeep.jh...@hotwaxsystems.com> wrote:

> Hello Jacques,
>
> Making branch is a good idea to handle regressions but I would prefer to
> work in trunk itself. Here are the things we should consider before
> creating new branch:
>
> 1. Branch can be abandoned, I would prefer to have code changes in trunk in
> proper steps instead of merging the complete branch work later in trunk.
> 2. Currently, lot of changes is coming in trunk, so different branch need
> to updated regularly. Its also an additional work.
>
> To avoid regressions, we can do our work in granular level tasks for
> various functionality (wherever needed) and proper testing steps will be
> there. The code changes will only be committed after thorough testing.
>
> First, I would like to start with cleanup of inline javascripts so that all
> javascript code will only in js files which helps us to follow best
> practices of javascript.
> Here is the steps can be taken to do it:
>
> 1. Start with one component. For example: Accounting.
> 2. Pick its various functionality one by one where javascript is added
> inline.
> 3. Do cleanup in it.
> 4. Do thorough testing for it with testing steps over ticket.
>
> Once the all cleanup (inline js cleanup) is done, we would have javascript
> files for further work. We can further break the js work by functionality
> (if needed) for improvements.
>
> The above process will assure us that nothing will break. I will not work
> on this effort alone, the team of developers having two or more year
> experience in javascript will work with me.
>
> I will create the parent ticket for selenium tests as well and we will see
> how we can work on it.
>
> Thanks & Regards
> --
> Amardeep Singh Jhajj
> www.hotwaxsystems.com
>
> On Sat, Jun 25, 2016 at 1:06 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > Hi Amardeep,
> >
> > What I mean is we should be cautious. Hence the suggestion to create a
> > branch for the refactoring. And to benefit from this opportunity to put
> > some Selenium tests related with js (eg: calendar - could also use HTML5
> > now -, autocompletion, lookups, dependent dropdowns). That would be a
> start
> > for Selenium, no needs to have tons of it. A Jira subtask would be
> perfect.
> >
> > Hope I'm clearer
> >
> > Thanks
> >
> > Jacques
> >
> >
> >
> > Le 24/06/2016 à 15:53, Amardeep Singh Jhajj a écrit :
> >
> >> Thanks all for approval.
> >>
> >> Thanks Taher and Deepak for valuable suggestions. I will think on them.
> >>
> >> Jacques,
> >>
> >> I am bit confused by your reply, could you please elaborate your point.
> >>
> >> Regards,
> >> --
> >> Amardeep Singh Jhajj
> >>
> >>
> >> On Fri, Jun 24, 2016 at 4:17 PM, Jacques Le Roux <
> >> jacques.le.r...@les7arts.com> wrote:
> >>
> >> Amardeep,
> >>>
> >>> I agree with your points, I'd just request that we do that in a branch
> >>> with a load of UI tests (good occasion to use Selenium).
> >>> Our js code is complex and fragile, I think notably at the global
> >>> variables in fieldlookup.js and selectall.js which are maybe hard to
> >>> avoid.
> >>> IMO those files are the main pains.
> >>>
> >>> Thanks
> >>>
> >>> Jacques
> >>>
> >>>
> >>>
> >>> Le 24/06/2016 à 09:20, Amardeep Singh Jhajj a écrit :
> >>>
> >>> Hello everyone,
> >>>>
> >>>> Currently, OFBiz javascript code (except third party libraries) is not
> >>>> written with the best practices which can cause following problems -
> >>>>
> >>>> 1. Increases the code maintenance effort.
> >>>> 2. Impact page performance.
> >>>> 3. Present not good examples to new contributors which leads to C/P to
> >>>> various areas of js code.
> >>>>
> >>>> Here are things we should do for cleanup and improvements in js code.
> >>>>
> >>>> 1. Remove unused javascript code and files if any.
> >>>> 2. Use best practices for javascript coding to improve performance (I
> >>>> have
> >>>> listed some of it below).
> >>>> 3. Move utility js functi

Re: OFBiz Increased Activity

2016-06-28 Thread Pranay Pandey
Big +1 Sharan.

Thanks everyone who helping directly or indirectly to make it even better.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, Jun 28, 2016 at 4:10 PM, Ashish Vijaywargiya <
ashish.vijaywarg...@hotwaxsystems.com> wrote:

> Thanks Sharan for the note, same feeling here. Amazing contribution
> everyone. Thanks so much! :-)
>
> Kind Regards
> Ashish Vijaywargiya
> HotWax Systems - est. 1997
>
> On Tue, Jun 28, 2016 at 2:44 PM, Sharan Foga <sharan.f...@gmail.com>
> wrote:
>
> > Hi Everyone
> >
> > A quick note to say thank you to everyone that is working on helping us
> > improve OFBiz. Over the last few weeks OFBiz is consistently in the top 5
> > most active SVN projects. (At the moment of writing this we are number 1
> > with 23 commits so far today).
> >
> > Our dev mailing list is also consistently in the top 5 most active
> mailing
> > lists – so shows that we are busy discussing things too. I've included
> the
> > link the status monitor below.
> >
> > https://status.apache.org/
> >
> > It's not only about the number of commits, but also the interactions and
> > discussions we are all having. I really like the community vibe and
> > enthusiasm we have at the moment. Thanks everyone for contributing to it
> > and continuing to making it happen!
> >
> > Thanks
> > Sharan
> >
>


Re: Track user for status change

2016-06-26 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Jun 24, 2016 at 6:56 PM, Nameet Jain <nameet.j...@hotwaxsystems.com>
wrote:

> Hello everyone,
>
> Currently in OFBiz, 'changedByUserLoginId' field is missing from status
> entities (like: ShipmentStatus). Using this field we can maintain the
> history for each status change made by user.
>
> I will recommend here to add 'changedByUserLoginId' field to track the
> userlogin detail. Here is the list of entities with missing such type of
> field.
>
> 1. BudgetStatus
> 2. ContactListCommStatus
> 3. CustRequestStatus
> 4. ExampleStatus
> 5. FinAccountStatus
> 6. InventoryItemStatus
> 7. InvoiceStatus
> 8. PartyStatus
> 9. RequirementStatus
> 10. ShipmentStatus
>
> Please let me know your thoughts. If it looks good I will open a ticket for
> the same.
>
> Thanks
>
> --
> Regards,
> Nameet Jain
>


Re: Product base promotion calculation

2016-06-16 Thread Pranay Pandey
Hi Arvind,

Yes I agree, If it's the promotion for one product than orderAdjustment
should also be one. Also please create a JIRA issue and attach your
screenshots there.


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, Jun 15, 2016 at 7:16 PM, Arvind singh tomar <
arvindtomar1...@gmail.com> wrote:

> Hi Everyone,
>
> I found the behavior of product base promotion calculation a bit strange.
> Need your advice on whether it is correct behaviour or need some
> improvement in promotion calculation.
>
> The promotion which I used was to give 30% discount for the item (i.e.
> RAM1GB_BRAND). I created a sales order with 10 quantity of the product.
> During the promotion calculation, OFBiz created 10 OrderAdjustments, one
> for each quantity for the same promotion type.
>
> I was expecting that in the case if same Promotion is applicable for more
> than one quantity of a product then a single OrderAdjustment should be
> created instead of creating one for each quantity. It is also messing up
> the UI.
>
> Attached the screenshots for the same.
>
>
> Thanks and Regards
> --
> Arvind Singh Tomar
>


Release Branch Demo URLs

2016-04-07 Thread Pranay Pandey
Shouldn't we open these four URLs in new tab with target="_BLANK".

- 13.07 Release Branch Demo (stable)

   - Front-End Store
   <http://demo-stable-ofbiz.apache.org/ecommerce/control/main>
   - Management Apps
   
<http://demo-stable-ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y>

- 12.04 Release Branch Demo (old)

   - Front-End Store
   <http://demo-old-ofbiz.apache.org/ecommerce/control/main>
   - Management Apps
   
<http://demo-old-ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y>


Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/


Re: Accessible Rich Internet Applications

2016-04-07 Thread Pranay Pandey
Hi James,

I am referring to a website which has to be accessible rich.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Apr 7, 2016 at 2:58 PM, james yong <i_yon...@yahoo.com.sg> wrote:

> Hi Pranay,
>
> Are you referring to the management apps?
>
> Regards,
> James
>
>
>
> Pranay Pandey-3 wrote
> > Hello Devs,
> >
> > We have got an opportunity to work on ARIA
> > <https://www.w3.org/WAI/intro/aria>. Accessibility is the core of
> > this
> > delivery. Currently this project is under development.
> > Just wanted to check-in here if someone is having experience building
> such
> > applications top of OFBiz and would like to share their experiences and
> > learnings.
> > Do you think having one sample application OOTB following these
> guidelines
> > will be a good addition?
> >
> > Best regards,
> >
> > Pranay Pandey
> > HotWax Systems
> > http://www.hotwaxsystems.com/
>
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/Accessible-Rich-Internet-Applications-tp4679037p4679050.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


Re: Design and Integration questions on OFBiz

2016-04-06 Thread Pranay Pandey
Hi Gopal,

Welcome to the community, glad to know that you are choosing OFBiz for this
integration. Please find response inline

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Tue, Apr 5, 2016 at 10:00 PM, Gopal Nayak <gna...@mcfadyen.com> wrote:

> Hi OFBiz Dev Team,
>
>
>
> Brief background: We, McFadyen Solutions are trying to integrate our
> Oracle eCommerce Application with OFBiz OMS services. We would be using the
> REST API services exposed by OFBiz to create orders in OFBiz from the
> eCommerce application.
>
> We also want to integrate credit card authorization for post-auth purpose
> from OFBiz.
>
>
>
> We have some questions on the integrations which we could not find in the
> documentation provided on the site:
>
>
>
> 1) Since OFBiz has fulfillment features, when an item is shipped, how and
> where should the integration happen so that OFBiz application gets the
> "shipped" event?
>


Are you willing to manage inventory as well in OFBiz? or OFBiz will get
notified for any shipment completed from other system?

OOTB OFBiz fulfillment process creates a Shipment which has it's status
transitions from PICKED ==> PACKED ==> SHIPPED. Answers to the above given
questions will help in guiding better.

For initiating the order fulfillment process you have to go to facility
manager here
<http://demo-stable-ofbiz.apache.org/facility/control/main?externalLoginKey=EL731114747043>
.
and start the Picking process from here
<http://demo-stable-ofbiz.apache.org/facility/control/PicklistOptions?facilityId=WebStoreWarehouse>
.

Once items are picked you can go ahead and do Packing and then move it for
shipping.

The other way is to do quickship from Order view itself on sales order
view, you will find a quickship.

You can try both of these and find the best fit for your system.



>
> 2) How do we integrate with the warehouse which would tell us when item is
> shipped?
>



Please refer details given for #1.




>
>
> 3) When any changes related to Order are made in OFBiz application, how
> can we extend the OFBiz application to pass those change events to any
> external system(eg. the Oracle eCommerce Application in this case). How do
> we get a handle on the change event and what the change was?
>


You can write service on order change which posts data to desired server.
OOTB OFBiz services can be referred from here
<http://demo-stable-ofbiz.apache.org/webtools/control/ServiceList;jsessionid=9AE0C7CDDBA9BD41C8754BDC575E6434.jvm1>
.




>
>
> 4) Once we update the status of the order to "Shipped" in OFBiz, how
> should we trigger the post-auth on the credit card for funds capture?
>



What do you mean by post auth?

When order is placed, if you do pre-auth for required payment for the
order, at the time of fulfillment that authorized amount is captured, do
you mean- you want to cross verify if the payment was successfully captured
or not on previously authorized transaction?



>
>
> Please provide pointers on the above questions. It would really help us in
> doing a successful integration between the Oracle eCommerce Application and
> OfBiz application framework
>


There are few questions that I have put inline, please let us know the
answers and we can find the best possible solutions with OFBiz.



>
>
> All help in highly appreciated.
>
>
>
>
>
> Thanks
>
> -Gopal.
>
> *GOPAL*
>
> *NAYAK*
>
>
>
> [image: McFadyen Solutions] <http://mcfadyen.com/>
> *eBusiness Integrators*
> Offices in the US and India
> Specializing in eCommerce, Content Management & Social Media
>
> http://www.mcfadyen.com <http://mcfadyen.com/>
> [image: McFadyen Solutions on LinkedIn]
> <https://www.linkedin.com/company/mcfadyen-solutions>[image: McFadyen
> Solutions on Twitter] <https://twitter.com/mcfadyen_solns>[image:
> McFadyen Solutions on Facebook]
> <https://www.facebook.com/McFadyenConsulting>
>
> *Delivery Lead / Sr. ATG Architect*
> gna...@mcfadyen.com
> tel 972.381.2721  |  cell 210.863.5564   |   fax 703.821.4005
> 6860 Dallas Pkwy, STE 219, Plano, TX 75024
>
>
>
>
>


Re: Design and Integration questions on OFBiz

2016-04-06 Thread Pranay Pandey
Hi Narayanan,

The approach you are following is good i.e. not to change any existing
implementation instead doing extension as required. Just to give one add-on
information on managing customization, here
<https://cwiki.apache.org/confluence/display/OFBIZ/Addressing+Custom+Requirements+In+OFBiz>
is a document that will guide you for the best practices for addressing any
custom requirement.

Please find rest of the details inline:

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Wed, Apr 6, 2016 at 11:54 AM, Narayanan Ramachandran <
nramachand...@mcfadyen.com> wrote:

> Hi Pranay,
>
>
>
> Thanks a lot for your quick reply.
>
>
>
> This is specific to Question No. 3 below.
>
>
>
> So, let me make the question more specific:
>
>
>
> (i)We are changing the order status, which would be
> invoking any out of the box logic which you have in Ofbiz.
>

You can have look varous triggers (ECAs) written on service
"changeOrderItemStatus" and "changeOrderStatus" in
applications/order/servicedef/secas.xml.



> (ii)  We don’t want to touch that. That part should work as
> it is.
>

Good to know that.



> (iii) But we want to do some post processing. Sending the
> order object to another system, (to update order or commerce item status).
>

It depends on the integration type you want to have.
You can define API(If you don't already have one) in your system where you
want to import and processing as it's done in OFBiz. This way whenever an
order placed or any change is made you can make calls to your system
through API based on details expected specific method being called.

For this definitely you will need to write a custom service in OFBiz
without touching anything in OOTB impelementation i.e. in your hot-deploy
component and you can call that as needed, as trigger basically. This
service will take care of calling the required service from your system to
import changes.



> (iv) Could you please guide, how exactly we should do this?
>


Please refer details given for last point.



> (v)  Can we subscribe for some events or something.
>


I don't actually understand this point. Please elaborate.



> (vi) FYI.We don’t want to touch the Out of the box ofbiz
> functionality. We need to extend it.
>


Very good to know that, please refer the document link I have given in this
email for best practices for addressing custom requirements in OFBiz.
Towards the end of the document you will also find link to other good
document on How to Extend an existing component in customized application
<https://cwiki.apache.org/confluence/display/OFBIZ/FAQ+-+Tips+-+Tricks+-+Cookbook+-+HowTo#FAQ-Tips-Tricks-Cookbook-HowTo-ExtendExistingComponent>
.

HTH.



>
>
>
>
> *NARAYANAN*
>
> *RAMACHANDRAN*
>
>
>
> [image: McFadyen Solutions] <http://mcfadyen.com/>
> *eBusiness Integrators*
> Offices in the US and India
> Specializing in eCommerce, Content Management & Social Media
>
> http://www.mcfadyen.com <http://mcfadyen.com/>
> [image: McFadyen Solutions on LinkedIn]
> <https://www.linkedin.com/company/mcfadyen-solutions> [image: McFadyen
> Solutions on Twitter] <https://twitter.com/mcfadyen_solns> [image:
> McFadyen Solutions on Facebook]
> <https://www.facebook.com/McFadyenConsulting>
>
> *Technical Lead*
> nramachand...@mcfadyen.com
> cell +91.8884642760
> #648/L, 3rd Floor, BKN Ambaram Estates, 1st Stage, 1st Main Road, Indira
> Nagar, Bangalore 560038 India
> [image: View my profile on LinkedIn]
> <https://in.linkedin.com/pub/narayanan-ramachandran/62/b/972> [image:
> Contact me on Skype]
>
>
>
>
>
> *From:* Pranay Pandey [mailto:pranay.pan...@hotwaxsystems.com]
> *Sent:* Wednesday, April 06, 2016 11:34 AM
> *To:* dev@ofbiz.apache.org
> *Cc:* Anna Kalra <ska...@mcfadyen.com>; Umapathy Gandhi <
> ugan...@mcfadyen.com>; Narayanan Ramachandran <nramachand...@mcfadyen.com>;
> Rohitash Laul <rl...@mcfadyen.com>; Kossi Kpante <kkpa...@mcfadyen.com>;
> Hemalatha Mohan <hmo...@mcfadyen.com>; Shubham Roy <s...@mcfadyen.com>;
> Narinder Garg <ng...@mcfadyen.com>
> *Subject:* Re: Design and Integration questions on OFBiz
>
>
>
> Hi Gopal,
>
>
>
> Welcome to the community, glad to know that you are choosing OFBiz for
> this integration. Please find response inline
>
>
> Best regards,
>
>
> Pranay Pandey
> HotWax Systems
> http://www.hotwaxsystems.com/
> skype: pranay.pandey
>
> cell: +91 982.603.5576
>
>
>
> On Tue, Apr 5, 2016 at 10:00 PM, Gopal Nayak <gna...@mcfadyen.com> w

Accessible Rich Internet Applications

2016-04-07 Thread Pranay Pandey
Hello Devs,

We have got an opportunity to work on ARIA
<https://www.w3.org/WAI/intro/aria>. Accessibility is the core of this
delivery. Currently this project is under development.
Just wanted to check-in here if someone is having experience building such
applications top of OFBiz and would like to share their experiences and
learnings.
Do you think having one sample application OOTB following these guidelines
will be a good addition?

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/


Re: Framework & Code Re-Factoring: Maintaining Quality

2016-04-08 Thread Pranay Pandey
+1 will be extra careful going forward.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Fri, Apr 8, 2016 at 12:36 PM, Sharan-F <sharan.f...@gmail.com> wrote:

> Hi Everyone
>
> It's great to see the progress happening on the framework and code
> re-factoring.  Tasks from our to do list are being picked up and worked on,
> so thank you to everyone involved in this.
>
> As this is a code clean-up, I'd really like to emphasize that we need to be
> extra careful because we are changing the way we currently code. This means
> that there is some extra responsibility for the committers in the review
> process to ensure that the quality of the code going in is an improvement
> to
> the existing code (I.e we dont want to commit anything that keeps our code
> untidy or makes it even worse)
>
> If we can include stronger quality checks while the re-factoring is going
> on, we can be sure that we are definitely making and delivering code
> improvements.
>
> What do people think?
>
> Thanks
> Sharan
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/Framework-Code-Re-Factoring-Maintaining-Quality-tp4679123.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


Re: Release Branch Demo URLs

2016-04-07 Thread Pranay Pandey
Sounds good, thanks Jacques.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Apr 7, 2016 at 11:04 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> Yes indeed!
>
> Also we will soon change stable to use R14 and old to be R13...
>
> Jacques
>
> Le 07/04/2016 16:55, Pranay Pandey a écrit :
>
>> Shouldn't we open these four URLs in new tab with target="_BLANK".
>>
>> - 13.07 Release Branch Demo (stable)
>>
>> - Front-End Store
>> <http://demo-stable-ofbiz.apache.org/ecommerce/control/main>
>> - Management Apps
>> <
>> http://demo-stable-ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y
>> >
>>
>> - 12.04 Release Branch Demo (old)
>>
>> - Front-End Store
>> <http://demo-old-ofbiz.apache.org/ecommerce/control/main>
>> - Management Apps
>> <
>> http://demo-old-ofbiz.apache.org/catalog/control/main?USERNAME=admin=ofbiz=Y
>> >
>>
>>
>> Best regards,
>>
>> Pranay Pandey
>> HotWax Systems
>> http://www.hotwaxsystems.com/
>>
>>


Re: [VOTE] [RELEASE] Apache OFBiz 12.04.06

2016-03-30 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Wed, Mar 30, 2016 at 2:46 PM, Michael Brohl <michael.br...@ecomify.de>
wrote:

> +1
>
> Thanks,
>
> Michael
> http://www.ecomify.de
>
> Am 29.03.16 um 11:05 schrieb Jacopo Cappellato:
>
> This is the vote thread to release a new bug fix release for the
>> release12.04 branch. This new release, "Apache OFBiz 12.04.06" will
>> supersede all the previous releases from the same branch and it will be
>> the
>> last release of the 12.06 series.
>>
>> The release files can be downloaded from here:
>>
>> https://dist.apache.org/repos/dist/dev/ofbiz/
>>
>> and are:
>>
>> * apache-ofbiz-12.04.06.zip
>>
>> * KEYS: text file with keys
>>
>> * apache-ofbiz-12.04.06.zip.asc: the detached signature file
>>
>> * apache-ofbiz-12.04.06.zip.md5, apache-ofbiz-12.04.06.zip.sha: hashes
>>
>> Please download and test the zip file and its signatures (for instructions
>> on testing the signatures see
>> http://www.apache.org/info/verification.html).
>>
>> Vote:
>>
>> [ +1] release as Apache OFBiz 12.04.06
>>
>> [ -1] do not release
>>
>> This vote will be open for approximately 5 days.
>>
>> For more details about this process please read
>> http://www.apache.org/foundation/voting.html
>>
>>
>
>


Re: [VOTE] [RELEASE] Apache OFBiz 13.07.03

2016-03-30 Thread Pranay Pandey
+1

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/
skype: pranay.pandey
cell: +91 982.603.5576

On Tue, Mar 29, 2016 at 3:12 PM, Jacopo Cappellato <
jacopo.cappell...@hotwaxsystems.com> wrote:

> This is the vote thread to release a new bug fix release for the
> release13.07 branch. This new release, "Apache OFBiz 13.07.03", will
> supersede all the previous releases from the same branch.
>
> The release files can be downloaded from here:
>
> https://dist.apache.org/repos/dist/dev/ofbiz/
>
> and are:
>
> * apache-ofbiz-13.07.03.zip
>
> * KEYS: text file with keys
>
> * apache-ofbiz-13.07.03.zip.asc: the detached signature file
>
> * apache-ofbiz-13.07.03.zip.md5, apache-ofbiz-13.07.03.zip.sha: hashes
>
> Please download and test the zip file and its signatures (for instructions
> on testing the signatures see http://www.apache.org/info/verification.html
> ).
>
> Vote:
>
> [ +1] release as Apache OFBiz 13.07.03
>
> [ -1] do not release
>
> This vote will be open for approximately 5 days.
>
> For more details about this process please read
> http://www.apache.org/foundation/voting.html
>


Re: OFBiz Committers Survey

2016-05-20 Thread Pranay Pandey
Done, thanks for the initiative Sharan.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, May 19, 2016 at 6:54 PM, Sharan-F <sharan.f...@gmail.com> wrote:

> Hi Everyone
>
> I've sent out the survey today so all our committers (including emeritus
> and
> inactive) should get an email with a link to it.
> I'll plan to keep the survey open for 7 days (less if I get all the
> responses back beforehand!) to give people enough time to complete it.
>
> Thanks in advance for your feedback.
>
> Thanks
> Sharan
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727p4680804.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


JIRA Ticket for Documentation Effort

2016-05-20 Thread Pranay Pandey
Hi Community,

What do you think of this option, should we create a Ticket in JIRA for any
of the documentation effort?

I am going to start work on OFBiz Beginners Tutorial overhaul(Will create a
new one and open it for review to the community for feedback) and was
thinking to map the effort with a JIRA Ticket. Please let me know your
thoughts.



Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/


Re: OFBiz Committers Survey

2016-05-18 Thread Pranay Pandey
Sounds great, thanks for the initiative Sharan.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Wed, May 18, 2016 at 8:40 PM, Sharan-F <sharan.f...@gmail.com> wrote:

> Hi Everyone
>
> It's been a long while since I last did any kind of community survey and
> this time I'd like to survey our committers – so I'm hoping our committers
> are willing to participate. :-)
>
> I'm currently working on finalising it all and hope that it can be sent out
> by the end of this week. I'll keep it open for a fixed time (maybe up to a
> week) and then will summarise and publish the results.
>
> Thanks
> Sharan
>
>
>
>
> --
> View this message in context:
> http://ofbiz.135035.n4.nabble.com/OFBiz-Committers-Survey-tp4680727.html
> Sent from the OFBiz - Dev mailing list archive at Nabble.com.
>


Re: JIRA Ticket for Documentation Effort

2016-05-23 Thread Pranay Pandey
Thanks for giving thoughts to it.
Looks like everyone is in favor. Will plan the effort further with JIRA
Ticket.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Sat, May 21, 2016 at 5:10 PM, Pierre Smits <pierre.sm...@gmail.com>
wrote:

> +1
> Documentation is also a product of the project. Incorporating it into
> release notes, helps communication. Helps adoption.
>
> Pierre Smits
>
> ORRTIZ.COM <http://www.orrtiz.com>
> OFBiz based solutions & services
>
> OFBiz Extensions Marketplace
> http://oem.ofbizci.net/oci-2/
>
> On Sat, May 21, 2016 at 1:18 PM, Jacques Le Roux <
> jacques.le.r...@les7arts.com> wrote:
>
> > +1!
> >
> > Things are clearer in/with Jira
> >
> > Jacques
> >
> >
> >
> > Le 21/05/2016 à 06:59, Pranay Pandey a écrit :
> >
> >> Hi Community,
> >>
> >> What do you think of this option, should we create a Ticket in JIRA for
> >> any
> >> of the documentation effort?
> >>
> >> I am going to start work on OFBiz Beginners Tutorial overhaul(Will
> create
> >> a
> >> new one and open it for review to the community for feedback) and was
> >> thinking to map the effort with a JIRA Ticket. Please let me know your
> >> thoughts.
> >>
> >>
> >>
> >> Best regards,
> >>
> >> Pranay Pandey
> >> HotWax Systems
> >> http://www.hotwaxsystems.com/
> >>
> >>
> >
>


Re: svn commit: r1745270 - in /ofbiz/branches/release13.07: ./ applications/accounting/widget/GlobalGlAccountsForms.xml

2016-05-24 Thread Pranay Pandey
Hi Jacques,

Just out of curiosity, did you refer comment from Amardeep on the ticket?

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, May 24, 2016 at 2:18 AM, <jler...@apache.org> wrote:

> Author: jleroux
> Date: Mon May 23 20:48:24 2016
> New Revision: 1745270
>
> URL: http://svn.apache.org/viewvc?rev=1745270=rev
> Log:
> "Applied fix from trunk for revision: 1745264  "  (Conflict handled by
> hand)
> 
> r1745264 | jleroux | 2016-05-23 22:42:00 +0200 (lun. 23 mai 2016) | 5
> lignes
>
> A patch from Kongrath Suankaewmanee for "The number of gl account when
> printing/exporting chart of account pdf report in global gl setting alway
> show 20 items. " https://issues.apache.org/jira/browse/OFBIZ-7038
>
> At https://localhost:8443/accounting/control/globalGLSettings
> the number of GL accounts is wrong: always 20 items in PDF report list and
> same problem with XML export in the same screen.
>
> 
>
> Modified:
> ofbiz/branches/release13.07/   (props changed)
>
> ofbiz/branches/release13.07/applications/accounting/widget/GlobalGlAccountsForms.xml
>
> Propchange: ofbiz/branches/release13.07/
>
> --
> --- svn:mergeinfo (original)
> +++ svn:mergeinfo Mon May 23 20:48:24 2016
> @@ -5,4 +5,4 @@
>  /ofbiz/branches/jquery:952958-1044489
>  /ofbiz/branches/multitenant20100310:921280-927264
>  /ofbiz/branches/release12.04:1557118
>
> -/ofbiz/trunk:1506269,1506499,1506504,1506828,1509164,1510042,1511279,1512376,1512573,1516094,1517629,1517702,1517780,1517947,1518336,1518950,1519245,151,1520319,1520321,1520326,1524361,1524676,1524704,1524769,1524835,1524950,1525523,1526276,1526387,1526463,1527212,1527254,1527609,1527626,1527810,1528144,1528146,1528149,1528298,1529412,1529418,1529588,1530273,1530634,1530876,1530972,1530976,1531848,1532342,1532366,1533542,1533839,1534062,1535961,1536170,1536656,1537023,1537086,1537179,1537996,1538096,1539147,1539156,1539781,1542264,1542388,1542442,1543744,1543766,1543781,1543994,154,1547548,1548143,1549015,1550255,1550258,1550515,1551585,1551744,1552149,1552290,1552500,1552901,1552908,1554064,1554242,1554265,1554290,1554373,1554536,1554681,1554685,1554706,1554764,1554787,1555142,1557409-1557410,1557427,1557440,1557443,1557447,1557456-1557457,1557462,1557593,1558145,1558241,1558373,1558774,1559814,1560048,1560056,1560176,1560203,1560205,1560699,1561286,1561290,1561305,1561311,
>
>  
> 1561327,1561467,1562767,1563238,1563683,1563958,1564111,1564113,1564463,1564473,1564493,1566096,1566273,1569078,1569743,1570611,1570622,1570639-1570640,1571207,1571219,1571247,1573161,1573498,1573639,1574019,1574201,1574404,1575508,1576259,1576331,1576378,1576506,1576511,1576757,1576839,1577268,1577744,1579155,1579161,1579277,1579309,1580455,1580850,1581386,1581972,1581997,1582762,1583040,1583427-1583428,1583551,1583674,1583681,1583689,1583696,1584873,1585033,1585574,1585958-1585959,1586987,1587841,1587843,1588733,1589589,1589602,1589606,1589612,1589625,1589669,1592530,1592588,1592745,1592977,1593902,1593908,1593952,1597239,1597464,1598113,1598327,1598475,1598544,1598913,1603439,1603732,1603739,1604357,1604363,1604522,1604554,1605029,1605269,1605348,1605354,1605707,1607457,1608355,1608495,1608526,1608698,1609047,1609065,1609076,1609087,1609149,1609155,1609167,1609184,1609389,1609394,1609398,1609406,1609418,1609885,1609889,1610355,1610420,1610425,1610685,1610918,1610925,1611321,16121
>
>  
> 90,1612202,1613121,1614019,1614025,1614280,1614355,1614366,1614556,1615296-1615297,1616272,1616684,1616940,1617229,1617473,1617480,1617936,1617938,1618395,1618397,1618570,1618831,1619087,1619098,1619300,1621335,1621363,1621413,1621436,1621438-1621439,1621442,1621599,1621683,1622050,1622170,1622672,1623370,1624538,1624767,1624809,1624817,1626425,1626797,1627230,1627763,1628096,1628130,1628937,1628940,1629382,1629391,1629426,1631203,1631299-1631300,1632764,1632793,1633100,1633188,1633550,1636864,1637883,1639606,1639835,1639840-1639841,1639846,1639863,1639887,1640288,1640299,1640515,1640717,1641066,1641131,1641165,1641548,1641804,1642423,1643341,1644904,1645950,1646204,1646935,1646977,1646984,1647266,1647338,1647559,1647606,1648668,1649239,1649393,1650240,1650583,1650642,1650678,1650882,1650938,1651593,1652361,1652725,1652731,1652739,1653456,1654175,1654273,1655046,1655795,1656983,1660389,1660444,1661358,1661612,1661778,1661853,1661873,1661940,1661951,1661977,1662361,1662500,1663912,16
>
>  
> 63979,1664602,1664604,133,1666836,

Re: svn commit: r1745270 - in /ofbiz/branches/release13.07: ./ applications/accounting/widget/GlobalGlAccountsForms.xml

2016-05-24 Thread Pranay Pandey
Yes that's the reason I am asking. Knowing the exact reason why it's not
working is important even prior to committing it in Trunk.

Regards,
Pranay Pandey

On Tuesday 24 May 2016, Jacques Le Roux <jacques.le.r...@les7arts.com>
wrote:

> I just glanced at the code, and it could be indeed interesting to know
> what we had to change that in newer releases; other surprises could appear
> (regressions)
>
> Jacques
>
>
> Le 24/05/2016 à 12:03, Jacques Le Roux a écrit :
>
>> Ha forgot, indeed it was already working in R13.07
>>
>> We could revert, I must say I simply tested and it was OK
>>
>> See
>>
>>
>> http://demo-stable-ofbiz.apache.org/accounting/control/ListGlAccountsReport
>>
>>
>> http://demo-stable-ofbiz.apache.org/accounting/control/ListGlAccountsExport
>>
>> Jacques
>>
>>
>> Le 24/05/2016 à 11:19, Pranay Pandey a écrit :
>>
>>> Hi Jacques,
>>>
>>> Just out of curiosity, did you refer comment from Amardeep on the ticket?
>>>
>>> Best regards,
>>>
>>> Pranay Pandey
>>> HotWax Systems
>>> http://www.hotwaxsystems.com/
>>>
>>> On Tue, May 24, 2016 at 2:18 AM, <jler...@apache.org> wrote:
>>>
>>> Author: jleroux
>>>> Date: Mon May 23 20:48:24 2016
>>>> New Revision: 1745270
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1745270=rev
>>>> Log:
>>>> "Applied fix from trunk for revision: 1745264  "  (Conflict handled by
>>>> hand)
>>>> 
>>>> r1745264 | jleroux | 2016-05-23 22:42:00 +0200 (lun. 23 mai 2016) | 5
>>>> lignes
>>>>
>>>> A patch from Kongrath Suankaewmanee for "The number of gl account when
>>>> printing/exporting chart of account pdf report in global gl setting
>>>> alway
>>>> show 20 items. " https://issues.apache.org/jira/browse/OFBIZ-7038
>>>>
>>>> At https://localhost:8443/accounting/control/globalGLSettings
>>>> the number of GL accounts is wrong: always 20 items in PDF report list
>>>> and
>>>> same problem with XML export in the same screen.
>>>>
>>>> 
>>>>
>>>> Modified:
>>>>  ofbiz/branches/release13.07/   (props changed)
>>>>
>>>>
>>>> ofbiz/branches/release13.07/applications/accounting/widget/GlobalGlAccountsForms.xml
>>>>
>>>> Propchange: ofbiz/branches/release13.07/
>>>>
>>>>
>>>> --
>>>> --- svn:mergeinfo (original)
>>>> +++ svn:mergeinfo Mon May 23 20:48:24 2016
>>>> @@ -5,4 +5,4 @@
>>>>   /ofbiz/branches/jquery:952958-1044489
>>>>   /ofbiz/branches/multitenant20100310:921280-927264
>>>>   /ofbiz/branches/release12.04:1557118
>>>>
>>>> -/ofbiz/trunk:1506269,1506499,1506504,1506828,1509164,1510042,1511279,1512376,1512573,1516094,1517629,1517702,1517780,1517947,1518336,1518950,1519245,151,1520319,1520321,1520326,1524361,1524676,1524704,1524769,1524835,1524950,1525523,1526276,1526387,1526463,1527212,1527254,1527609,1527626,1527810,1528144,1528146,1528149,1528298,1529412,1529418,1529588,1530273,1530634,1530876,1530972,1530976,1531848,1532342,1532366,1533542,1533839,1534062,1535961,1536170,1536656,1537023,1537086,1537179,1537996,1538096,1539147,1539156,1539781,1542264,1542388,1542442,1543744,1543766,1543781,1543994,154,1547548,1548143,1549015,1550255,1550258,1550515,1551585,1551744,1552149,1552290,1552500,1552901,1552908,1554064,1554242,1554265,1554290,1554373,1554536,1554681,1554685,1554706,1554764,1554787,1555142,1557409-1557410,1557427,1557440,1557443,1557447,1557456-1557457,1557462,1557593,1558145,1558241,1558373,1558774,1559814,1560048,1560056,1560176,1560203,1560205,1560699,1561286,1561290,1561305,1561311,
>>>>
>>>>
>>>>
>>>> 1561327,1561467,1562767,1563238,1563683,1563958,1564111,1564113,1564463,1564473,1564493,1566096,1566273,1569078,1569743,1570611,1570622,1570639-1570640,1571207,1571219,1571247,1573161,1573498,1573639,1574019,1574201,1574404,1575508,1576259,1576331,1576378,1576506,1576511,1576757,1576839,1577268,1577744,1579155,1579161,1579277,1579309,1580455,1580850,1581386,1581972,1581997,1582762,1583040,1583427-1583428,1583551,1583674,1583681,15836

Re: svn commit: r1745270 - in /ofbiz/branches/release13.07: ./ applications/accounting/widget/GlobalGlAccountsForms.xml

2016-05-24 Thread Pranay Pandey
Sounds good, thanks Jacques.

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Tue, May 24, 2016 at 5:15 PM, Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

> I propose we keep the commits as is while investigating if a better
> solution is possible.
>
> Would you take care of the investigation? If you do maybe we should reopen
> the issue?
>
> Jacques
>
>
>
> Le 24/05/2016 à 12:30, Pranay Pandey a écrit :
>
>> Yes that's the reason I am asking. Knowing the exact reason why it's not
>> working is important even prior to committing it in Trunk.
>>
>> Regards,
>> Pranay Pandey
>>
>> On Tuesday 24 May 2016, Jacques Le Roux <jacques.le.r...@les7arts.com>
>> wrote:
>>
>> I just glanced at the code, and it could be indeed interesting to know
>>> what we had to change that in newer releases; other surprises could
>>> appear
>>> (regressions)
>>>
>>> Jacques
>>>
>>>
>>> Le 24/05/2016 à 12:03, Jacques Le Roux a écrit :
>>>
>>> Ha forgot, indeed it was already working in R13.07
>>>>
>>>> We could revert, I must say I simply tested and it was OK
>>>>
>>>> See
>>>>
>>>>
>>>>
>>>> http://demo-stable-ofbiz.apache.org/accounting/control/ListGlAccountsReport
>>>>
>>>>
>>>>
>>>> http://demo-stable-ofbiz.apache.org/accounting/control/ListGlAccountsExport
>>>>
>>>> Jacques
>>>>
>>>>
>>>> Le 24/05/2016 à 11:19, Pranay Pandey a écrit :
>>>>
>>>> Hi Jacques,
>>>>>
>>>>> Just out of curiosity, did you refer comment from Amardeep on the
>>>>> ticket?
>>>>>
>>>>> Best regards,
>>>>>
>>>>> Pranay Pandey
>>>>> HotWax Systems
>>>>> http://www.hotwaxsystems.com/
>>>>>
>>>>> On Tue, May 24, 2016 at 2:18 AM, <jler...@apache.org> wrote:
>>>>>
>>>>> Author: jleroux
>>>>>
>>>>>> Date: Mon May 23 20:48:24 2016
>>>>>> New Revision: 1745270
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=1745270=rev
>>>>>> Log:
>>>>>> "Applied fix from trunk for revision: 1745264  "  (Conflict handled by
>>>>>> hand)
>>>>>>
>>>>>> 
>>>>>> r1745264 | jleroux | 2016-05-23 22:42:00 +0200 (lun. 23 mai 2016) | 5
>>>>>> lignes
>>>>>>
>>>>>> A patch from Kongrath Suankaewmanee for "The number of gl account when
>>>>>> printing/exporting chart of account pdf report in global gl setting
>>>>>> alway
>>>>>> show 20 items. " https://issues.apache.org/jira/browse/OFBIZ-7038
>>>>>>
>>>>>> At https://localhost:8443/accounting/control/globalGLSettings
>>>>>> the number of GL accounts is wrong: always 20 items in PDF report list
>>>>>> and
>>>>>> same problem with XML export in the same screen.
>>>>>>
>>>>>>
>>>>>> 
>>>>>>
>>>>>> Modified:
>>>>>>   ofbiz/branches/release13.07/   (props changed)
>>>>>>
>>>>>>
>>>>>>
>>>>>> ofbiz/branches/release13.07/applications/accounting/widget/GlobalGlAccountsForms.xml
>>>>>>
>>>>>> Propchange: ofbiz/branches/release13.07/
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> --- svn:mergeinfo (original)
>>>>>> +++ svn:mergeinfo Mon May 23 20:48:24 2016
>>>>>> @@ -5,4 +5,4 @@
>>>>>>/ofbiz/branches/jquery:952958-1044489
>>>>>>/ofbiz/branches/multitenant20100310:921280-927264
>>>>>>/ofbiz/branches/release12.04:1557118
>>>>>>
>>>>>>
>>>>>> -/ofbiz/trunk:1506269,1

Re: Permission service not on the same transaction

2016-04-15 Thread Pranay Pandey
Hi Nicolas,

Calling it as permission service is tricky. I see the comment in
implementation above the simple method in ShipmentServices.xml-



It was implemented with a purpose to be called inline, may be supporting
the traditional way of doing things. Reviewing at a complete patch with all
the modifications you have done for making shipment CRUD operations can
help here getting the opinion. WDYT?

Best regards,

Pranay Pandey
HotWax Systems
http://www.hotwaxsystems.com/

On Thu, Apr 7, 2016 at 1:30 PM, Nicolas Malin <nicolas.ma...@nereide.fr>
wrote:

> Hello,
>
> Currently I continue the conversion on shipment  crud service and I
> detected that many service use the same mini-lang call to check if the
> shipment status is ok for editing "checkCanChangeShipmentStatusPacked"
>
> I convert it on service to call it directly by the permission-service like
> that :
>
>  default-entity-name="ShipmentPackageContent" engine="entity-auto"
> invoke="create" auth="true">...
>  service-name="checkCanChangeShipmentStatusPacked" main-action="CREATE"/>
> ...
> 
>
> The problem with this change that when I run the unit tests, I have some
> failed to due database lock on shipment.
> After some analyse I founded that the permission service wasn't call on
> the same service's transaction.
> I a realize this change :
>
> Index: framework/service/src/org/ofbiz/service/ModelService.java
> ===
> --- framework/service/src/org/ofbiz/service/ModelService.java(révision
> 1737860)
> +++ framework/service/src/org/ofbiz/service/ModelService.java(copie de
> travail)
> @@ -985,7 +985,7 @@
>  LocalDispatcher dispatcher = dctx.getDispatcher();
>  Map<String, Object> resp;
>  try {
> -resp = dispatcher.runSync(permission.name, ctx, 300,
> true);
> +resp = dispatcher.runSync(permission.name, ctx);
>  } catch (GenericServiceException e) {
>  Debug.logError(e, module);
>  Map<String, Object> result =
> ServiceUtil.returnSuccess();
>
> All unit test pass.
> Anyone know the reason to call the permission service on a new transaction
> ?
> I couldn't spot any valid reason.
>
> Thnaks for help ;)
>
> Nicolas
>
> --
> #jeSuisCharlie
> [image: logoNrd] <http://nereide.fr/>
> Nicolas Malin
> Ingénieur d'étude. Dernier sujet : "Les vaches portant un prénom pouvent
> trouver la sortie d'un labyrinthe en cas de toxoplasmose
> informat...@nereide.fr
> 8 rue des Déportés 37000 TOURS, 02 47 50 30 54
> Apache OFBiz <http://ofbiz.apache.org/> |  ofbiz-fr
> <http://www.ofbiz-fr.org/> |  | réseau LE
> <http://www.libre-entreprise.org/>
>


  1   2   3   4   5   6   7   8   9   10   >