Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-17 Thread Justin Mclean
HI, > So as suggested Jacopo (not sure you got a copy), we can remove the mention > in LICENSE file. I'll do so right now… Yes that sounds like the right thing to do to me. Either way it not an issue for this release, having extra info in a license file is just a documentation issue. Kind

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-17 Thread Jacques Le Roux
Thanks Justin, So as suggested Jacopo (not sure you got a copy), we can remove the mention in LICENSE file. I'll do so right now... Jacques Le 17/06/2021 à 14:37, Justin Mclean a écrit : Hi, I did not find any such files. Good to hear and I'm sure you're right, as I said I'm not familiar

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-17 Thread Justin Mclean
Hi, > I did not find any such files. Good to hear and I'm sure you're right, as I said I'm not familiar with your codebase. These directories are the ones I noticed: ./plugins/birt/widget/birt ./plugins/birt/webapp/birt ./plugins/birt/src/main/java/org/apache/ofbiz/birt Kind Regards, Justin

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-17 Thread Jacques Le Roux
Hi Justin, I did not find any such files. I mean files part of the Birt project. AFAIK we only depends on org.eclipse.birt.runtime:viewservlets:4.5.0 that is only "loaded at runtime" bu Gradle (cf https://github.com/apache/ofbiz-plugins/blob/trunk/birt/build.gradle) So, which files did you

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-17 Thread Jacopo Cappellato
Thank you Justin, We will definitely double check this issue but I am rather sure it is an old reference that should be removed from the LICENSE file: afaik the folder (and its content/subfolders) birt/webapp/birt/webcontent/ no longer exists and thus it is not distributed in any release. Jacopo

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-16 Thread Justin Mclean
Hi, I could see the some of the files in question covered by that license in your source release so I'm not 100% sure that is correct, but I'm not familiar with your code base. You might want to double check just to be sure. If it not in the source release then there no need to mention that

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-16 Thread Jacques Le Roux
Hi Justin, Actually to avoid embedding several libs with incompatible licenses we use Gradle to build OFBiz since few years now. So the libs are not embedded but loaded at "runtime" by Gradle (Gradle uses a local cache). So I think we should remove this notice (and those alike) in our LICENSE

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-06-16 Thread Justin Mclean
HI, I'm not on your PMC but I noticed something a little odd with this release . Your LICENSE states: This product bundles files from the "Birt" technology platform (www.eclipse.org/birt/) which are available under the "Eclipse Public License - v 1.0". For details, see

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-19 Thread Aditya Sharma
+1 All tests passed on macOS Big Sur 11.2.3, AdoptOpenJDK openjdk version "1.8.0_282" (build 1.8.0_282-b08) Thanks and Regards, Aditya Sharma On Fri, Mar 19, 2021 at 2:19 PM Suraj Khurana wrote: > +1 > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Fri, Mar 19,

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-19 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Fri, Mar 19, 2021 at 1:43 PM Jacopo Cappellato < jacopo.cappell...@gmail.com> wrote: > +1 > > Jacopo > > On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato > wrote: > > > > This is the vote thread (second attempt) to release a

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-19 Thread Jacopo Cappellato
+1 Jacopo On Sun, Mar 14, 2021 at 10:39 AM Jacopo Cappellato wrote: > > This is the vote thread (second attempt) to release a new bug fix > release for the > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will > supersede all the previous releases from the same branch. > > The

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-16 Thread Girish Vasmatkar
+1 All tests passed on macOS Catalina 10.15.7, openjdk version "1.8.0_242" (build 1.8.0_242-b08) Best, Girish On Tue, Mar 16, 2021 at 5:39 PM Christian Geisert < christian.geis...@isu-gmbh.de> wrote: > +1 > > (Ubuntu 18.04.5 LTS, openjdk version "1.8.0_282") > > Christian > > > Am 14.03.21 um

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-16 Thread Christian Geisert
+1 (Ubuntu 18.04.5 LTS, openjdk version "1.8.0_282") Christian Am 14.03.21 um 10:39 schrieb Jacopo Cappellato: This is the vote thread (second attempt) to release a new bug fix release for the release17.12 branch. This new release, "Apache OFBiz 17.12.06" will supersede all the previous

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-15 Thread Michael Brohl
+1 I've checked again while testing the verify script and this time all tests pass on the 1st attempt. Thanks, Michael Am 14.03.21 um 10:39 schrieb Jacopo Cappellato: This is the vote thread (second attempt) to release a new bug fix release for the release17.12 branch. This new release,

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-15 Thread Nicolas Malin
+1 All tests passed on debian 10.7 and AdoptOpenJDK build 1.8.0_282-b08 Nicolas On 14/03/2021 10:39, Jacopo Cappellato wrote: > This is the vote thread (second attempt) to release a new bug fix > release for the > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will > supersede

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Michael Brohl
Like Jacques, I had to do a second pass of ./gradlew cleanAll loadAll testIntegration and then the build was successful. Everything else worked fine: ~/Projects/apache-ofbiz/dist  ../ofbiz-tools/download-ofbiz-release.sh apache-ofbiz-17.12.06 Getting files for $ZIP... --2021-03-14

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Jacques Le Roux
+1 Works here on Windows: Jacques@LDLC MINGW64 /C/projectsASF/Git/ofbiz-framework/tools (master) $ ./verify-ofbiz-release.sh apache-ofbiz-17.12.06.zip sha check of file: apache-ofbiz-17.12.06.zip Using sha file: apache-ofbiz-17.12.06.zip.sha512 apache-ofbiz-17.12.06.zip: 3B302353

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Jacopo Cappellato
weird, I didn't notice the errors and all tests were successful. Jacopo On Sun, Mar 14, 2021 at 11:40 AM Michael Brohl wrote: > > -1 > > Unfortunately I get several Freemarker errors during > > ./gradlew cleanAll loadAll testIntegration > > like this > > 2021-03-14 11:34:49,334 |main

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Michael Brohl
-1 Unfortunately I get several Freemarker errors during ./gradlew cleanAll loadAll testIntegration like this 2021-03-14 11:34:49,334 |main |ServiceDispatcher |T| Sync service [test-dispatcher-R437fRXV8X/getPartyEmail] finished in [2] milliseconds 2021-03-14 11:34:49,336 |main

Re: [VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Nicola Mazzoni
+1 Il dom 14 mar 2021, 10:40 Jacopo Cappellato ha scritto: > This is the vote thread (second attempt) to release a new bug fix > release for the > release17.12 branch. This new release, "Apache OFBiz 17.12.06" will > supersede all the previous releases from the same branch. > > The release

[VOTE] [RELEASE] Apache OFBiz 17.12.06 - Second attempt

2021-03-14 Thread Jacopo Cappellato
This is the vote thread (second attempt) to release a new bug fix release for the release17.12 branch. This new release, "Apache OFBiz 17.12.06" will supersede all the previous releases from the same branch. The release files can be downloaded from here: