Re: Change commit message template?

2019-11-25 Thread Jacques Le Roux
Hi All, Samuel, The reason we use only the ref and a not a link to Jira is because so far the commits template is/was(?[1]) used by Michael to deliver the information you can find a the bottom of our monthly blog entries, eg: https://blogs.apache.org/ofbiz/ I'd like to get ahead. It seems we

Re: Change commit message template?

2019-11-18 Thread Samuel Trégouët
Hi, agree with Mathieu: I prefer keeping issue id in footer (at the end of commit message) so we can save some characters in subject line to express something meaningful. In addition if we put this information in commit footer (or body) we can copy the complete link to issue (for example

Re: Change commit message template?

2019-11-18 Thread Mathieu Lirzin
Hello, Jacques Le Roux writes: > Le 17/11/2019 à 19:16, Taher Alkhateeb a écrit : > >> I'm not sure what convention over configuration has to do with what >> you're saying :) > > It was because of this sentence in the reference link > >"This is a project specific convention that has no

Re: Change commit message template?

2019-11-17 Thread Jacques Le Roux
Hi Gil, Yes actually from start that's what I supposed to be the best "solution" too. In Eclipse I can use that for instance: https://bugs.eclipse.org/bugs/show_bug.cgi?id=471421 Thanks Jacques Le 17/11/2019 à 21:08, Gil Portenseigne a écrit : Hello, When we first decided on the current

Re: Change commit message template?

2019-11-17 Thread Jacques Le Roux
Hi Taher, Le 17/11/2019 à 19:16, Taher Alkhateeb a écrit : Hi Jacques, I'm not sure what convention over configuration has to do with what you're saying :) It was because of this sentence in the reference link "This is a project specific convention that has no relation to any

Re: Change commit message template?

2019-11-17 Thread Gil Portenseigne
Hello, When we first decided on the current template, i did understood that jira number was at the end of the first line, that was logical in my view. I was mistaken and did not discussed it by then. Setting Jira number at the end of the first line is fine for me. Gil Le 21:16 - dimanche 17

Re: Change commit message template?

2019-11-17 Thread Taher Alkhateeb
Hi Jacques, I'm not sure what convention over configuration has to do with what you're saying :) Anyway, it makes sense. Most GIT editors consider the first line to be subject, and third line onward is the body of the message. So perhaps we can move the (OFBIZ-) to the end of the first line

Change commit message template?

2019-11-17 Thread Jacques Le Roux
Hi, While working in Eclipse with Git (ie using eGit which is not my favourite tool). I found a warning telling me: "Second line should be empty to separate commit message header from body" It was argued that it's only a convention[1], but don't we prefer "convention over configuration"?