Re: Github PRs and Jira

2020-01-28 Thread Jacques Le Roux
complicated with github/gitlab pull requests. But I have no idea on how to do this on jira. Samuel Quoting Jacques Le Roux (2019-11-29 08:50:05) Hi, Yesterday I have a short discussion with Pierre Smits about Github PRs and Jira. Pierre was asking about https://github.com/apache/ofbiz-framework

Re: Github PRs and Jira

2019-12-09 Thread Samuel Trégouët
have no idea on how to do this on jira. Samuel Quoting Jacques Le Roux (2019-11-29 08:50:05) > Hi, > > Yesterday I have a short discussion with Pierre Smits about Github PRs and > Jira. > > Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I > answe

Re: Github PRs and Jira

2019-12-04 Thread Gil Portenseigne
Hello, > > > I guess that using existent Github should be ok for official pull > > request, if not, it's always ok to have and attached patch or > > other gitlab reference. > > You mean "Github reference" I guess ? > For this one a really mean gitlab reference like the nereide public gitlab

Re: Github PRs and Jira

2019-12-04 Thread Mathieu Lirzin
Hello, As far as I am concerned, I will never be enthousiastic regarding adopting yet another proprietary platform. Gil Portenseigne writes: > +1 to use gitlab features to work around code, that will help > collaboration. > > I don't know if there is an Apache alternative to get the features

Re: Github PRs and Jira

2019-12-03 Thread Gil Portenseigne
+1 to use gitlab features to work around code, that will help collaboration. I don't know if there is an Apache alternative to get the features without Microsoft. But having two official tools to get contribution is not desired. I guess that using existent Github should be ok for official pull

Re: Github PRs and Jira

2019-12-03 Thread Jacques Le Roux
Le 03/12/2019 à 08:21, Jacopo Cappellato a écrit : Now that we have migrated to Git, in my opinion we should really consider to adopt the workflow based on PR as our primary method for accepting contributions. I understand that it is a relevant change for the community, but I also see many

Re: Github PRs and Jira

2019-12-03 Thread Jacques Le Roux
Hi, Actually not, a good idea to create a sub-task of OFBIZ-11268 Thanks Jacques Le 03/12/2019 à 06:36, Rishi Solanki a écrit : Hi, Do we have committers practices document ready for git? Sorry if I missed the discussion if already done. Best Regards, -- Rishi Solanki *CTO, Mindpath

Re: Github PRs and Jira

2019-12-02 Thread Jacopo Cappellato
On Fri, Nov 29, 2019 at 8:51 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Yesterday I have a short discussion with Pierre Smits about Github PRs and > Jira. > > Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I >

Re: Github PRs and Jira

2019-12-02 Thread Rishi Solanki
Hi, Do we have committers practices document ready for git? Sorry if I missed the discussion if already done. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 On Tue, Dec 3, 2019 at 10:57 AM Rishi Solanki wrote: > I don't have any better

Re: Github PRs and Jira

2019-12-02 Thread Rishi Solanki
I don't have any better idea around this. But adding contributors best practice and Readme should be good start to go with, later we can rethink on it. +1 Jacques and Pierre to start with. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 On

Re: Github PRs and Jira

2019-11-28 Thread Jacques Le Roux
I created https://issues.apache.org/jira/browse/OFBIZ-11301 for that Le 29/11/2019 à 08:50, Jacques Le Roux a écrit : our workflow is to contribute patches through Jira. I want to clearly document that in https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices But

Github PRs and Jira

2019-11-28 Thread Jacques Le Roux
Hi, Yesterday I have a short discussion with Pierre Smits about Github PRs and Jira. Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I answered that our workflow is to contribute patches through Jira. I want to clearly document that in https://cwiki.apache.org