Re: Important Changes to Trunk and Use of Ant & Gradle

2016-07-03 Thread Taher Alkhateeb
Hello Everyone, I am very happy and thrilled to announce that OFBiz now has a skeleton for a plug-in system without any changes to the code base :) How did we design it -- - Add all the components defined in framework/component-load.xml as gradle subprojects - Add all

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-27 Thread Taher Alkhateeb
Hey Everyone, I am exhausted, but I have a working patch in https://issues.apache.org/jira/browse/OFBIZ-7534 This patch introduces gradle with all tests passing. I have also added a new README.md file which documents how to use this system. I think you will find the README.md file valuable for

INFRA-12138 resolved [was Re: Important Changes to Trunk and Use of Ant & Gradle]

2016-06-24 Thread Jacques Le Roux
Le 21/06/2016 à 23:30, Jacques Le Roux a écrit : Unfortunately currently the link between Confluence and Jira is broken: https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-12138 Just FYI *INFRA-12138*

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-23 Thread Taher Alkhateeb
Hey Guys, I've attached a text file in https://issues.apache.org/jira/browse/OFBIZ-7534 This text file shows the old ant commands and how I implemented them (most of them anyway) in Gradle. Please review it and provide your feedback: - Does it look correct? - Are the parameters corrects? - Are

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
Hi Jacques, Thank you for the explanation. OK, between your feedback and the votes from other members, I'll keep them. Working on integration in gradle ... Cheers Taher Alkhateeb On Wed, Jun 22, 2016 at 11:08 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi Taher, > > Inline...

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Jacques Le Roux
Hi Taher, Inline... Le 22/06/2016 à 16:23, Taher Alkhateeb a écrit : Hi Michael Jacques and everyone, So I also want to confirm that you really need the following tasks: - build-dev - build-production - build-qa - build-test - revert-dev I introduced those for a custom project and improved

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS
For me, no problem to drop it. Julien. On 22/06/2016 16:23, Taher Alkhateeb wrote: Hi Michael Jacques and everyone, So I also want to confirm that you really need the following tasks: - build-dev - build-production - build-qa - build-test - revert-dev Are you using them yourselves? Here are

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
Hi Michael Jacques and everyone, So I also want to confirm that you really need the following tasks: - build-dev - build-production - build-qa - build-test - revert-dev Are you using them yourselves? Here are the reasons why I suggest to remove them: - First, you must have the patch command

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Jacques Le Roux
I wonder though why this was introduced. If we have no feedback from any member of the community I think we can drop it. I don't see how to use it. Jacques Le 22/06/2016 à 14:43, Michael Brohl a écrit : Hi Taher, no, I don't use it myself. This was just a guess by looking what the task does

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Michael Brohl
Hi Taher, no, I don't use it myself. This was just a guess by looking what the task does and it seemed to me this should be preserved. No problem to drop it from my side. Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 22.06.16 um 14:37 schrieb Taher Alkhateeb: Hi Michael, Are you

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
Hi Michael, Are you sure you are using "run-test-list"? This is an old task using a target on the server called --testlist which essentially creates an ant file of all the suites in OFBiz and runs them one-by-one stopping OFBiz in between each run. To me it seems like run-tests is doing the same

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Jacques Le Roux
Taher, Right, it was not a problem of space but licence. With the Gradle solution we no longer have licence issues with external jars, another good point to this solution :) Jacques Le 22/06/2016 à 10:46, Taher Alkhateeb a écrit : Hi Jacques, How about we actually download all JDBC

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Taher Alkhateeb
Hi Jacques, How about we actually download all JDBC drivers automatically regardless of the selected database. Their size is very small and it is worth making the build script smaller no? And also anyway some people use different versions of the database and have to change the driver version, in

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Jacques Le Roux
Le 22/06/2016 à 10:05, Julien NICOLAS a écrit : On 22/06/2016 09:53, Julien NICOLAS wrote: On 21/06/2016 22:09, Taher Alkhateeb wrote: - download-PG-JDBC If it's possible, keep this one :) Ok, I don't see the information of Michael that with Graddle, we don't need a task for that because

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS
On 22/06/2016 09:53, Julien NICOLAS wrote: On 21/06/2016 22:09, Taher Alkhateeb wrote: - download-PG-JDBC If it's possible, keep this one :) Ok, I don't see the information of Michael that with Graddle, we don't need a task for that because of the Graddle dependency functionality. So my

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-22 Thread Julien NICOLAS
On 21/06/2016 22:09, Taher Alkhateeb wrote: - download-PG-JDBC If it's possible, keep this one :) Second Question --- it seems many of the load tasks are too specific. So I suggest to only implement loadDemo and the rest are executed manually by users, for example:

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Jacopo Cappellato
On Tue, Jun 21, 2016 at 11:30 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > - gen-kek >> > > Never used it, but Jacopo put it in recent > Actually, I didn't create it: it has been created long ago by Adam; but I edited it to work with Shiro. In my opinion it can be dropped and

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Pierre Smits
Inline Op dinsdag 21 juni 2016 heeft Taher Alkhateeb het volgende geschreven: > Hi Everyone, > > I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 > for > this project > > I have two questions in this thread > > First Question >

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Jacques Le Roux
Inline... Le 21/06/2016 à 23:00, Michael Brohl a écrit : Hi Taher, First question: Don't drop: - build-dev - build-production - build-qa - build-test - refresh - revert-dev - run-test-list Drop: - clean-ivy (assuming this is not needed if we use Gradle) - copy-dtds Nope, this one is

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Michael Brohl
Hi Taher, First question: Don't drop: - build-dev - build-production - build-qa - build-test - refresh - revert-dev - run-test-list Drop: - clean-ivy (assuming this is not needed if we use Gradle) - copy-dtds - download-PG-JDBC - download-activemq - download-mySQL-JDBC (download tasks:

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread gil portenseigne
Hello Taher, First question, from the given list I personally only use : - download-PG-JDBC to easily get through ivy the last postgresql driver - start-batch that can be avoided using shell tricks, so no problem No opinions against others removal For the load-task, if its easily documented

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
Hi Everyone, I have create the JIRA https://issues.apache.org/jira/browse/OFBIZ-7534 for this project I have two questions in this thread First Question -- Can I drop the below tasks from the build system? They currently exist in Ant but I am not sure whether they are actively

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
Hi Everyone, Thank you all for your support and kinds words. This is truly a wonderful atmosphere and I am lucky, honoured, and privileged to work with you all on this project. My patch is almost done, but definitely there is a lot of work to be done which includes the following: - I have one

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Nicolas Malin
I'm in over for these technical aspects but the motivation and enthusiasm for many PMC and commiter tells me that seems a good way. So now I will learn gradle ;) and I'm in favor to realize this change directly on trunk Thks Taher to your engine energy on this subject ! Nicolas Le

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Divesh Dutta
Also as Michael mentioned : "So it would be really helpful to break down the todos in smaller pieces to be assigned to contributors. " It will help other contributors to pick tasks and help in this effort. Thanks -- Divesh Dutta. On Tue, Jun 21, 2016 at 2:32 PM, Divesh Dutta <

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Divesh Dutta
Thanks for detailed email Sharan. It was very informative. After reading all the details it totally makes sense that why should we move to Gradle from Ant. Overall work going in community to improve OFBiz is really amazing and I am really excited about this. Thanks -- Divesh Dutta. On Mon, Jun

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Jacques Le Roux
As Gavin mentioned, Gradle can run Ant so no worries using only Gradle https://docs.gradle.org/current/userguide/ant.html Jacques Le 21/06/2016 à 09:59, Michael Brohl a écrit : I have no strong opinion for/against Gradle (I simply have no experience with it) but I agree that it should be

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Jacopo Cappellato
+1 for switching to Gradle. Jacopo On Mon, Jun 20, 2016 at 2:50 PM, Sharan Foga wrote: > Hi Everyone > > This is the second of two emails to inform the community about what has > been happening around how we are planning to handle external dependencies > in the trunk.

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread gil portenseigne
Same opinion here, so +1 Best regards, Gil On 21/06/2016 09:59, Michael Brohl wrote: I have no strong opinion for/against Gradle (I simply have no experience with it) but I agree that it should be either Ant or Gradle. Running two build tools in parallel would make it too complex an gain

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Ashish Vijaywargiya
+1 for moving to Gradle! Kind Regards Ashish Vijaywargiya HotWax Systems - est. 1997 On Mon, Jun 20, 2016 at 6:20 PM, Sharan Foga wrote: > Hi Everyone > > This is the second of two emails to inform the community about what has > been happening around how we are planning

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Michael Brohl
I have no strong opinion for/against Gradle (I simply have no experience with it) but I agree that it should be either Ant or Gradle. Running two build tools in parallel would make it too complex an gain nothing. I'm in favor for learning new things so Gradle sounds fine for me :-) Regards,

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Michael Brohl
Hi Sharan, thank you very much for this well-written summary of the changes to come! Very exciting and I pretty much like the momentum that OFBiz is gaining in the last months. We would like to help as much as possible to make this work but are facing a lot of customer projects in the

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Julien NICOLAS
+1 to go forward with Gradle Julien. On 21/06/2016 08:11, Taher Alkhateeb wrote: Hi Deepak, Ant would be removed completely for the following reasons: - First to resolve the ASF issue about the libraries mentioned by Sharan below without expending effort on both build systems. - Ant is an

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Gavin Mabie
+1 for Graddle. I have been using groovyant (which is included with Graddle) to integrate build tasks with GUI, leveraging application logic achievable with Groovy. On Tue, Jun 21, 2016 at 9:04 AM, Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Thanks for the explanation Taher,

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Pranay Pandey
Thanks for the explanation Taher, making perfect sense. +1 Best regards, Pranay Pandey HotWax Systems http://www.hotwaxsystems.com/ On Tue, Jun 21, 2016 at 11:41 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Hi Deepak, > > Ant would be removed completely for the following

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Deepak Dixit
Thanks Taher, Sounds good to me. Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com On Tue, Jun 21, 2016 at 11:41 AM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Hi Deepak, > > Ant would be removed completely for the following reasons: > > - First to resolve the ASF issue

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-21 Thread Taher Alkhateeb
Hi Deepak, Ant would be removed completely for the following reasons: - First to resolve the ASF issue about the libraries mentioned by Sharan below without expending effort on both build systems. - Ant is an obstacle to refactoring the framework. If we keep both systems side by side we gain

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Deepak Dixit
+1 for Gradle. Are we going to remove ant from framework completely or planning to keep both ant and gradle? Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com On Mon, Jun 20, 2016 at 6:20 PM, Sharan Foga wrote: > Hi Everyone > > This is the second of two emails

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Pierre Smits
Where can the community find this work already done, for investigation and evaluation purposes? Best regards, Pierre On Monday, June 20, 2016, Sharan Foga wrote: > Hi Everyone > > This is the second of two emails to inform the community about what has > been happening

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Pierre Smits
Sharan, If and when you refer to some notes from a refactoring team meeting a few months ago, please have the decency to include the reference in the mail thread yourself, as I can't find a vote thread (and its resolution notification) in this ml on abandoning development branches, Best regards,

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Taher Alkhateeb
Hi Pierre Sharan and all, In reply to your question Pierre, I will create a JIRA to which people can contribute. Although I worked very hard on this feature, I really need help with thorough testing and feedback. I look forward to your help if you'd like to contribute. Regards, Taher Alkhateeb

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Pierre Smits
So how does the PMC envision the way contributors collaborate on this new feature? Best regards, Pierre On Monday, June 20, 2016, Sharan Foga wrote: > Hi Pierre > > My understanding is that this will not be done as a branch - it will done > directly onto the trunk. If

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Sharan Foga
Hi Pierre My understanding is that this will not be done as a branch - it will done directly onto the trunk. If you refer back to the notes from the re-factoring team meeting a few months ago, we decided not to use branches as they become abandoned and hard to integrate. We also wanted to use

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Ron Wheeler
This sounds like a great step forward. In addition to the technical benefits, this identifies OFBiz as a "modern" project which will help in market acceptance when technical analysts are asked to comment. Ron On 20/06/2016 8:50 AM, Sharan Foga wrote: Hi Everyone This is the second of two

Re: Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Pierre Smits
Will this be done in a separate dev branch available in the OFBiz repo, so that contributors can assist? Best regards, Pierre Smits ORRTIZ.COM OFBiz based solutions & services OFBiz Extensions Marketplace http://oem.ofbizci.net/oci-2/ On Mon, Jun 20, 2016 at 2:50 PM,

Important Changes to Trunk and Use of Ant & Gradle

2016-06-20 Thread Sharan Foga
Hi Everyone This is the second of two emails to inform the community about what has been happening around how we are planning to handle external dependencies in the trunk. Two weeks ago the community discussed and agreed to the use of Gradle to help us put together a unit test framework. While