Re: Invoice Item type copied into GL Account type?

2018-02-08 Thread Paul Foxworthy
Once again I find Kongrath has been ahead of us. See https://issues.apache.org/jira/browse/OFBIZ-6722 - -- Coherent Software Australia Pty Ltd http://www.coherentsoftware.com.au/ Bonsai ERP, the all-inclusive ERP system http://www.bonsaierp.com.au/ -- Sent from:

Re: Invoice Item type copied into GL Account type?

2017-02-14 Thread Jacopo Cappellato
Hi Paul, thanks, this is really a valuable conversation; please see inline: On Tue, Feb 14, 2017 at 1:36 AM, Paul Foxworthy wrote: > [...] > I have been writing up some notes on categorising GL accounts, which I will > post here soon. Great! > It seems very messy. At

Re: Invoice Item type copied into GL Account type?

2017-02-13 Thread Paul Foxworthy
On 14 February 2017 at 01:00, Jacopo Cappellato wrote: > > One way to go to preserve the existing functionalities would be that of > creating one GlAccountType for each InvoiceItemType and VarianceReason > records. Then we would need to define a mechanism to

Re: Invoice Item type copied into GL Account type?

2017-02-13 Thread Jacopo Cappellato
On Mon, Feb 13, 2017 at 5:37 AM, Paul Foxworthy wrote: > [...] > I think we need separate parameters invoiceItemTypeId and varianceReasonId, > instead of attempting to overload the meaning of the glAccountTypeId > parameter. > > What do you think? One way to go to preserve

Re: Invoice Item type copied into GL Account type?

2017-02-12 Thread Paul Foxworthy
On 10 February 2017 at 21:50, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > It is not a bug, because the system use that value to decode the account > id. > Thanks Jacopo. I still think we have a serious problem. I see in getGlAccountFromAccountType at line 533

Re: Invoice Item type copied into GL Account type?

2017-02-10 Thread Jacopo Cappellato
On Fri, Feb 10, 2017 at 9:04 AM, Paul Foxworthy wrote: > Hi all, > > As you might guess if you've been looking at Jira and the dev list lately, > I've been working on purchases and sales generating GL transactions. > > Please have a look at the

Re: Invoice Item type copied into GL Account type?

2017-02-10 Thread Christian Geisert
Paul, I too stumbled over this some time ago, changed it to a glAccountTypeId and was surprised that the glAccountId wasn't found anymore. Yes, it's irritating and should be changed.. And I agree with Taher to convert this to Groovy (all Minilang ;) Let's start with tests. Christian Am

Re: Invoice Item type copied into GL Account type?

2017-02-10 Thread Taher Alkhateeb
Looks very wrong to me. Two different type sets should not be just copied over. While we're at, it might be better to rewrite this in Java or Groovy On Feb 10, 2017 11:05 AM, "Paul Foxworthy" wrote: > Hi all, > > As you might guess if you've been looking at Jira and the dev

Invoice Item type copied into GL Account type?

2017-02-10 Thread Paul Foxworthy
Hi all, As you might guess if you've been looking at Jira and the dev list lately, I've been working on purchases and sales generating GL transactions. Please have a look at the createAcctgTransForPurchaseInvoice method in applications/accounting/minilang/ledger/GeneralLedgerServices.xml line