Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Taher Alkhateeb
Hi Adrian, Thank you. I really appreciate and value the guidance and honest advice. I will be more careful and hope it's okay to consult with you from time to time on these issues. Taher Alkhateeb On Jun 8, 2015 7:16 PM, Adrian Crum adrian.c...@sandglass-software.com wrote: I went ahead and

Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Adrian Crum
Please revert this. Removing specific types is NOT an acceptable way to fix compiler errors! Taher - please stop trying to fix compiler warnings/errors by hiding them. Take some time to understand how Java Generics work before you change anything else. Adrian Crum Sandglass Software

Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Taher Alkhateeb
Hi Adrian, Thank you for the feedback. Please note this patch is not related to a compiler warning but rather a compiler error which _only_ happens with the ECJ and not with javac. That is why I posted it specifically as a seperate patch in the JIRA. When you upgrade to JDK 8 you get a compiler

Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Adrian Crum
You are getting an error because the types don't match. Like I said, take some time to understand how Java Generics work. Adrian Crum Sandglass Software www.sandglass-software.com On 6/8/2015 7:56 AM, Taher Alkhateeb wrote: Hi Adrian, Thank you for the feedback. Please note this patch is not

Re: svn commit: r1684133 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/condition/EntityFieldMap.java

2015-06-08 Thread Adrian Crum
I went ahead and fixed this myself. Adrian Crum Sandglass Software www.sandglass-software.com On 6/8/2015 8:08 AM, Adrian Crum wrote: You are getting an error because the types don't match. Like I said, take some time to understand how Java Generics work. Adrian Crum Sandglass Software