Hi Suraj,
my interpretion of the feedbacks was that the commit has problems or is
incomplete.
If it does break anything or introduces functionality which is not
working completely, we should revert.
If this is not the case and you have the chance to implement the
discussed issues in due ti
Hello,
Thanks Deepak for pointing this out.
I noted down your feedback and soon will update things accordingly.
@Nicolas, Gil
Yes, I think you are suggesting right. It would be better to change things
as per your suggestion. I am working on it as soon provide patch for review.
@Michael,
Please s
There's also a remark by Deepak.
I'm in favor of reverting and providing a new solution once it covers
all remarks. We should not leave it in the codebase in this state.
Best regards,
Michael Brohl
ecomify GmbH
www.ecomify.de
Am 30.07.18 um 10:14 schrieb Gil Portenseigne:
Hello Suraj,
Rega
Hello Suraj,
Regarding Nicolas feedback and mine onto Jira
https://issues.apache.org/jira/browse/OFBIZ-7598, did you find time to look
into it ?
Thanks,
Gil
Le mardi 17 juil. 2018 à 14:04:06 (+0200), Nicolas Malin a écrit :
> Hello Suraj,
>
> On 14/07/2018 07:10, sur...@apache.org wrote:
>
Hello Suraj,
On 14/07/2018 07:10, sur...@apache.org wrote:
Modified:
ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelForm.java
URL:http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/widget/src/main/java/org/apache/ofbiz/widget/model/
Hi Suraj,
You need to add renderEmptyFormDataMessage macro for rest of the macro
template file as well.
Thanks & Regards
--
Deepak Dixit
On Sat, Jul 14, 2018 at 10:40 AM, wrote:
> Author: surajk
> Date: Sat Jul 14 05:10:00 2018
> New Revision: 1835869
>
> URL: http://svn.apache.org/viewvc?rev
