Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/#review6380 --- Ship it! Sounds good LGTM. - Chris On 2012-03-26 20:55:22, brian

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/ --- (Updated 2012-03-26 20:55:22.461160) Review request for oodt, Chris Mattmann,

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread brian Foster
On 2012-03-26 14:22:31, Chris Mattmann wrote: trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/cli/option/handler/CrawlerBeansPropHandler.java, line 60 https://reviews.apache.org/r/4454/diff/1/?file=94689#file94689line60 Agree with Tom here, do we need a check on if