Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-27 Thread brian Foster
On July 27, 2012, 4:31 a.m., Chris Mattmann wrote: trunk/pushpull/src/main/java/org/apache/oodt/cas/pushpull/protocol/ProtocolHandler.java, line 60 https://reviews.apache.org/r/6166/diff/1/?file=130080#file130080line60 I think making these vars final is orthogonal, but certainly

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- (Updated July 27, 2012, 12:15 a.m.) Review request for oodt, Chris Mattmann,

Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/ --- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9526 --- I think we need to add the pom.xml dep update for the Google

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread Chris Mattmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9525 ---