Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-07 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review168189 --- Ship it! Ship It! - Robert Kanter On March 7, 2017, 8:36

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-07 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/ --- (Updated March 7, 2017, 8:36 p.m.) Review request for oozie. Bugs:

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-07 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/ --- (Updated March 7, 2017, 8:39 a.m.) Review request for oozie. Bugs:

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-06 Thread Robert Kanter
> On March 6, 2017, 9:30 p.m., Robert Kanter wrote: > > There also seems to be a ton of findbug errors on the JIRA - Robert --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-06 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review168048 --- core/src/main/resources/oozie-default.xml Line 298 (original),

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-06 Thread Robert Kanter
> On March 6, 2017, 9:30 p.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > > Line 35 (original) > > > > > > Unrelated change. Sorry. Ignore this.

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-06 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review168043 ---

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-06 Thread Robert Kanter
> On March 4, 2017, 7:06 a.m., Peter Cseh wrote: > > core/src/main/resources/oozie-default.xml > > Lines 2884-2891 (original), 2884-2892 (patched) > > > > > > Should I remove this property instead of adding this

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-05 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/ --- (Updated March 5, 2017, 9:53 p.m.) Review request for oozie. Bugs:

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-05 Thread Peter Cseh
> On March 3, 2017, 9:47 p.m., Peter Cseh wrote: > > core/src/main/resources/oozie-default.xml > > Line 293 (original), 293 (patched) > > > > > > It looks like IDEA did something funny here. I'll remove the > >

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-05 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/ --- (Updated March 5, 2017, 9:46 p.m.) Review request for oozie. Bugs:

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-05 Thread Peter Cseh
- Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review167920 --- On March 3, 2017, 9:45 p.m., Peter Cseh wrote: > >

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-03 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review167932 --- core/src/main/resources/oozie-default.xml Lines 2884-2891

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-03 Thread Robert Kanter
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review167920 ---

Re: Review Request 57305: OOZIE-2811 Add support for filtering out properties from SparkConfigurationService

2017-03-03 Thread Peter Cseh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review167871 --- core/src/main/resources/oozie-default.xml Line 293 (original),