Re: Errors after recent commits

2021-04-23 Thread Francesco Chicchiriccò
On 22/04/21 19:38, Romain Manni-Bucau wrote: Im not sure the gain to have it marked synthetic since other cases will be problematic anyway with our proxies so I guess we can leave it this way. +1 Regards. Le jeu. 22 avr. 2021 à 19:07, Mark Struberg a écrit : Hi! Thanks for catching this!

Re: Errors after recent commits

2021-04-22 Thread Romain Manni-Bucau
Im not sure the gain to have it marked synthetic since other cases will be problematic anyway with our proxies so I guess we can leave it this way. Le jeu. 22 avr. 2021 à 19:07, Mark Struberg a écrit : > Hi! > > Thanks for catching this! > > Does this mean we should rather close 2800 as won't fi

Re: Errors after recent commits

2021-04-22 Thread Mark Struberg
Hi! Thanks for catching this! Does this mean we should rather close 2800 as won't fix? LieGrue, strub > Am 21.04.2021 um 15:43 schrieb Romain Manni-Bucau : > > Oh would make sense since it is 2 compile cycles so cant really be > synthetic. > > Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiri

Re: Errors after recent commits

2021-04-21 Thread Romain Manni-Bucau
Oh would make sense since it is 2 compile cycles so cant really be synthetic. Le mer. 21 avr. 2021 à 13:49, Francesco Chicchiriccò a écrit : > I think that the issue is occurring when: > > 1. a parent entity is enhanced in a module > 2. a child entity is enhanced in another module > > In my case

Re: Errors after recent commits

2021-04-21 Thread Francesco Chicchiriccò
I think that the issue is occurring when: 1. a parent entity is enhanced in a module 2. a child entity is enhanced in another module In my case, the error was occurring only for child entities in a different module. Regards. On 21/04/21 13:46, Romain Manni-Bucau wrote: Hi, I think it is ok

Re: Errors after recent commits

2021-04-21 Thread Romain Manni-Bucau
Hi, I think it is ok to revert when it breaks and reapply with the fix. I tested on our opentrader application where there is a hierarchy with Ask entity and the method seems well generated with Mark's commit so I guess we need to refine the actual issue. Romain Manni-Bucau @rmannibucau

Re: Errors after recent commits

2021-04-21 Thread Francesco Chicchiriccò
Hi again, I went ahead, revert the commit and re-opened OPENJPA-2800. I am not sure to fully understand what is the actual reason for failure, though... Regards. On 21/04/21 11:29, Francesco Chicchiriccò wrote: Update: I've found the actual issues is that the pcSetDetachedState() method is n

Re: Errors after recent commits

2021-04-21 Thread Francesco Chicchiriccò
Update: I've found the actual issues is that the pcSetDetachedState() method is not generated in the parent class AbstractProvidedKeyEntity; as you can see from https://gist.github.com/ilgrosso/7ba7d41c7114ee8cbfc834f357865470#file-abstractprovidedkeyentity-java-L243-L245 in fact, the method wa

Re: Errors after recent commits

2021-04-21 Thread Francesco Chicchiriccò
Hi, from the last successful build that was deployed to repository.a.o by Jenkins (the day before yesterday, Monday 19th): https://repository.apache.org/content/repositories/snapshots/org/apache/syncope/ext/camel/syncope-ext-camel-persistence-jpa/3.0.0-SNAPSHOT/syncope-ext-camel-persistence-jpa-

Re: Errors after recent commits

2021-04-20 Thread Romain Manni-Bucau
Hi Francesco, Did you try to decompile previous and current version (with jd-gui for example) to see the diff? Normally Mark only changed synthetic flag on fields, nothing else should have changed AFAIK. Romain Manni-Bucau @rmannibucau | Blog

Errors after recent commits

2021-04-20 Thread Francesco Chicchiriccò
Hi there, with latest 3.1.3-SNAPSHOT artifacts I am getting errors while building Syncope. In particular, we have a Maven module [1] which runs openjpa-maven-plugin:enhance [2] as part of the build, and several modules (like [3][4][5] and others) which are depending on [1], adding more entities