Re: merge TrainingParameters and PluggableParameters

2017-01-10 Thread Russ, Daniel (NIH/CIT) [E]
Sounds goods. I’ll take care of both of them. Daniel On 1/10/17, 10:12 AM, "Joern Kottmann" wrote: 1. Yes, there are historic reasons, opennlp-tools used to depend on maxent, but maxent didn't depend on opennlp-tools. Therefore maxent couldn't use any

Re: merge TrainingParameters and PluggableParameters

2017-01-10 Thread Joern Kottmann
1. Yes, there are historic reasons, opennlp-tools used to depend on maxent, but maxent didn't depend on opennlp-tools. Therefore maxent couldn't use any opennlp-tools classes. It would be good to open a jira for this and get this re-factored. 2. The cutoff code from GISTrainer should be removed.

merge TrainingParameters and PluggableParameters

2017-01-10 Thread Russ, Daniel (NIH/CIT) [E]
Hi, The point of PluggableParameters was to move the “get(Int/String/Boolean)Parmeters” out of AbstractTrainer and into a parameters. I would like to merge the functionality of PluggableParameters into trainingParameters. Before I start, is there any reason why the GISTrainer and the