Re: [discussion] refactoring OpenOffice

2019-03-03 Thread Peter Kovacs
Hello Jim, I agree we should move together, that's why I started the conversation. However I think we should not only focus on 4.2.0.  I think we should not only work on STL transformation, and we should not only do the gmake transformation. All three topics are quite concrete and important

Re: [discussion] refactoring OpenOffice

2019-03-02 Thread Patricia Shanahan
My motivation for wanting to update data structures is bug fixing. I've already had to track down and fix buffer overflows. A general move to self-expanding buffers and bounds checking would fix bugs we do not yet know about. On 3/2/2019 7:16 AM, Jim Jagielski wrote: FWIW, I agree. We've

Re: [discussion] refactoring OpenOffice

2019-03-02 Thread Jim Jagielski
FWIW, I agree. We've already seen how simple, obvious changes have a nasty ripple effect. Having a major restructure "now" would, from what I can see, have a major impact on us being able to release 4.2.0 in anything close to "soon"... I also have issues w/ fixing/restructuring things that

Re: [discussion] refactoring OpenOffice

2019-03-02 Thread Patricia Shanahan
One starting point is my last few patches, which involved a bug in one of the string implementations, and buffer overflows. On 3/1/2019 11:58 PM, Peter Kovacs wrote: Do you have an example or can you explain how to find these. I'll have a look. On 02.03.19 04:31, Patricia Shanahan wrote: The

Re: [discussion] refactoring OpenOffice

2019-03-02 Thread Peter Kovacs
Do you have an example or can you explain how to find these. I'll have a look. On 02.03.19 04:31, Patricia Shanahan wrote: > The OpenOffice build system is both complicated and fragile. If you do > move things around, you MUST test the ability to build and install for > each supported OS. > > To

Re: [discussion] refactoring OpenOffice

2019-03-01 Thread Peter Kovacs
On 01.03.19 23:53, Marcus wrote: > > depends on how many time you want to invest and how many developers > are with you. I've always understood that you haven't much time for > developing. ;-) I always did a lot of talking, since I felt it is necessary. I still believe we should do more

Re: [discussion] refactoring OpenOffice

2019-03-01 Thread Patricia Shanahan
The OpenOffice build system is both complicated and fragile. If you do move things around, you MUST test the ability to build and install for each supported OS. To me, this change seems high risk for low benefit. I would far rather see any available cycles put into replacing ad-hoc data

Re: [discussion] refactoring OpenOffice

2019-03-01 Thread Marcus
Am 01.03.19 um 20:05 schrieb Peter Kovacs: I am really annoyed by the Code. I see repentance and to me a code concept is totally lacking. What I would like to do is a general cleanup / refactoring pass. I would like to start with similar features and move them together in the same module,

[discussion] refactoring OpenOffice

2019-03-01 Thread Peter Kovacs
Hello all, I am really annoyed by the Code. I see repentance and to me a code concept is totally lacking. What I would like to do is a general cleanup / refactoring pass. I would like to start with similar features and move them together in the same module, maybe even merge them. As a process