Re: ext_libraries/apr-util module
I found apr_rules.mk and apr_rules.mk.in so I'll use these as templates to build apr_util and see how it goes. If I'm heading in wrong direction please feel free to let me know, thanks. Dylan On Wed, Jan 27, 2021 at 2:48 PM Dylan Pham wrote: > Hello, > > I'm building trunk/450 on macos big sur and got an error below: > > Makefile:50: /Users/devops1/aoodev/openoffice/ext_libraries/apr-util/ > unxmaccx.pro/misc/build/apr-util-1.6.1/build/rules.mk: No such file or > directory > make: *** No rule to make target > `/Users/devops1/aoodev/openoffice/ext_libraries/apr-util/ > unxmaccx.pro/misc/build/apr-util-1.6.1/build/rules.mk'. Stop. > dmake: Error code 2, while making './ > unxmaccx.pro/misc/build/so_built_aprutil' > > Questions: > 1. the apr module version is 1.6.5, does apr-util version need to match it? > 2. I checked the apr module and there is no rules.mk file there and it > built successfully. Not sure why it's required for apr-util, as specified > in the makefile.in as below: > > # bring in rules.mk for standard functionality > @INCLUDE_RULES@ > @INCLUDE_OUTPUTS@ > > 3. If I need to have a rules.mk what do I need to do? Is there a template? > > Thank you, > Dylan > > >
ext_libraries/apr-util module
Hello, I'm building trunk/450 on macos big sur and got an error below: Makefile:50: /Users/devops1/aoodev/openoffice/ext_libraries/apr-util/ unxmaccx.pro/misc/build/apr-util-1.6.1/build/rules.mk: No such file or directory make: *** No rule to make target `/Users/devops1/aoodev/openoffice/ext_libraries/apr-util/ unxmaccx.pro/misc/build/apr-util-1.6.1/build/rules.mk'. Stop. dmake: Error code 2, while making './ unxmaccx.pro/misc/build/so_built_aprutil' Questions: 1. the apr module version is 1.6.5, does apr-util version need to match it? 2. I checked the apr module and there is no rules.mk file there and it built successfully. Not sure why it's required for apr-util, as specified in the makefile.in as below: # bring in rules.mk for standard functionality @INCLUDE_RULES@ @INCLUDE_OUTPUTS@ 3. If I need to have a rules.mk what do I need to do? Is there a template? Thank you, Dylan
[GitHub] [openoffice] leginee commented on pull request #121: translated various comments
leginee commented on pull request #121: URL: https://github.com/apache/openoffice/pull/121#issuecomment-768553149 Thank you for the quick review. I have some really bad mistakes there. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565607126
##
File path: main/sw/inc/shellio.hxx
##
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
-// suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+// search next bookmark position from the bookmark table
sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
// build a bookmark table, which is sort by the node position. The
// OtherPos of the bookmarks also inserted.
void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
xub_StrLen nStt, xub_StrLen
nEnd,
SvPtrarr& rArr );
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
static SwPaM * NewSwPaM(SwDoc & rDoc,
sal_uLong const nStartIdx, sal_uLong const
nEndIdx);
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
sal_Bool CopyLocalFileToINet( String& rFileNm );
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
SvStream& OutLong( SvStream& rStrm, long nVal );
SvStream& OutULong( SvStream& rStrm, sal_uLong nVal );
- // Hex-Zahl ausgeben, default ist 2.stellige Zahl
+ // print Hex-Zahl, default is 2. digit number
Review comment:
Ohh man I missed that. :facepalm:
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565606703
##
File path: main/sw/inc/shellio.hxx
##
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
-// suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+// search next bookmark position from the bookmark table
sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
// build a bookmark table, which is sort by the node position. The
// OtherPos of the bookmarks also inserted.
void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
xub_StrLen nStt, xub_StrLen
nEnd,
SvPtrarr& rArr );
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
static SwPaM * NewSwPaM(SwDoc & rDoc,
sal_uLong const nStartIdx, sal_uLong const
nEndIdx);
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
sal_Bool CopyLocalFileToINet( String& rFileNm );
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
Review comment:
optimization is indeed better
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121: URL: https://github.com/apache/openoffice/pull/121#discussion_r565606170 ## File path: main/sw/inc/shellio.hxx ## @@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML(); // END source/filter/basflt/fltini.cxx -extern sal_Bool SetHTMLTemplate( SwDoc ); //Fuer Vorlagen aus HTML.vor laden shellio.cxx +extern sal_Bool SetHTMLTemplate( SwDoc ); // HTML templates (pre?)load shellio.cxx Review comment: I am not sure, what the german comment means. It could mean before loading or only loading. :( This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121: URL: https://github.com/apache/openoffice/pull/121#discussion_r565603678 ## File path: main/sw/inc/shellio.hxx ## @@ -367,32 +363,32 @@ public: void SetBaseURL( const String& rURL ); sal_Bool IsOld() const; - sal_uLong ConvertToNew(); // Textbausteine konvertieren + sal_uLong ConvertToNew(); // convert AutoText entries (ger: Textbausteine) Review comment: Well, yea Leo translates Textbaustein to Text building blog or boilerplate, but in the OpenOffice help it is translated to AutoText entry, which is a feature of OpenOffice. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121: URL: https://github.com/apache/openoffice/pull/121#discussion_r565603037 ## File path: main/sw/inc/shellio.hxx ## @@ -161,32 +160,32 @@ class SwReader: public SwDocFac SvStream* pStrm; SotStorageRef pStg; com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg; - SfxMedium* pMedium; // wer ein Medium haben will (W4W) + SfxMedium* pMedium; // describes file or storage (W4W) SwPaM* pCrsr; String aFileName; String sBaseURL; public: /* -* Initiales Einlesen. Dokument wird erst beim Read(..) angelegt. -* JP 25.04.95: oder falls es mitgegeben wird, in dieses. -* Sonderfall fuer Load mit Sw3Reader +* Initial read. document is created when function Read(...) os called Review comment: thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] leginee commented on a change in pull request #121: translated various comments
leginee commented on a change in pull request #121: URL: https://github.com/apache/openoffice/pull/121#discussion_r565602584 ## File path: main/sw/inc/shellio.hxx ## @@ -106,11 +105,11 @@ public: }; / SwReader/Reader / -// Basisklasse der moeglichen Optionen fuer einen speziellen Reader +// base class for different specialized readers class Reader; -// Ruft den Reader mit seinen Optionen, Dokument, Cursor etc. +// calls a document with its options, document, cursor etc. Review comment: yea, you are right. I fix this This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [GitHub] [openoffice] ardovm commented on a change in pull request #121: translated various comments
It seems here a German-native speaker should help as the context is important and needs to be considered when translating the text. How urgent do you need this? I would try to help you after the release is done. Marcus Am 27.01.21 um 20:27 schrieb GitBox: ardovm commented on a change in pull request #121: URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978 ## File path: main/sw/inc/shellio.hxx ## @@ -367,32 +363,32 @@ public: void SetBaseURL( const String& rURL ); sal_Bool IsOld() const; - sal_uLong ConvertToNew(); // Textbausteine konvertieren + sal_uLong ConvertToNew(); // convert AutoText entries (ger: Textbausteine) Review comment: Could Textbaustein be translated as "text building block"? I have no idea what it would mean... in both languages, though [...] - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[GitHub] [openoffice] ardovm commented on a change in pull request #121: translated various comments
ardovm commented on a change in pull request #121:
URL: https://github.com/apache/openoffice/pull/121#discussion_r565566978
##
File path: main/sw/inc/shellio.hxx
##
@@ -106,11 +105,11 @@ public:
};
/ SwReader/Reader /
-// Basisklasse der moeglichen Optionen fuer einen speziellen Reader
+// base class for different specialized readers
class Reader;
-// Ruft den Reader mit seinen Optionen, Dokument, Cursor etc.
+// calls a document with its options, document, cursor etc.
Review comment:
should it this call a Reader instead? It makes sense if "Reader" is the
class
##
File path: main/sw/inc/shellio.hxx
##
@@ -367,32 +363,32 @@ public:
void SetBaseURL( const String& rURL );
sal_Bool IsOld() const;
- sal_uLong ConvertToNew(); //
Textbausteine konvertieren
+ sal_uLong ConvertToNew(); // convert
AutoText entries (ger: Textbausteine)
Review comment:
Could Textbaustein be translated as "text building block"?
I have no idea what it would mean... in both languages, though
##
File path: main/sw/inc/shellio.hxx
##
@@ -226,12 +225,12 @@ protected:
SvStream* pStrm;
SotStorageRef pStg;
com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
SwgReaderOption aOpt;
sal_Bool bInsertMode : 1;
sal_Bool bTmplBrowseMode : 1;
- sal_Bool bReadUTF8: 1; // Stream als UTF-8 interpretieren
+ sal_Bool bReadUTF8: 1; // interpred stream as UTF-8
Review comment:
maybe "interpre**te**d"
##
File path: main/sw/inc/shellio.hxx
##
@@ -414,18 +410,18 @@ SW_DLLPUBLIC SwRead SwGetReaderXML();
// END source/filter/basflt/fltini.cxx
-extern sal_Bool SetHTMLTemplate( SwDoc ); //Fuer Vorlagen aus HTML.vor
laden shellio.cxx
+extern sal_Bool SetHTMLTemplate( SwDoc ); // HTML templates (pre?)load
shellio.cxx
Review comment:
Or "before loading"? I have no idea :-(
##
File path: main/sw/inc/shellio.hxx
##
@@ -161,32 +160,32 @@ class SwReader: public SwDocFac
SvStream* pStrm;
SotStorageRef pStg;
com::sun::star::uno::Reference < com::sun::star::embed::XStorage > xStg;
- SfxMedium* pMedium; // wer ein Medium haben will (W4W)
+ SfxMedium* pMedium; // describes file or storage (W4W)
SwPaM* pCrsr;
String aFileName;
String sBaseURL;
public:
/*
-* Initiales Einlesen. Dokument wird erst beim Read(..) angelegt.
-* JP 25.04.95: oder falls es mitgegeben wird, in dieses.
-* Sonderfall fuer Load mit Sw3Reader
+* Initial read. document is created when function Read(...) os called
Review comment:
"os" or "is" ?
##
File path: main/sw/inc/shellio.hxx
##
@@ -501,32 +497,32 @@ public:
const String& GetBaseURL() const { return sBaseURL;}
-// suche die naechste Bookmark-Position aus der Bookmark-Tabelle
+// search next bookmark position from the bookmark table
sal_Int32 FindPos_Bkmk( const SwPosition& rPos ) const;
// build a bookmark table, which is sort by the node position. The
// OtherPos of the bookmarks also inserted.
void CreateBookmarkTbl();
- // search alle Bookmarks in the range and return it in the Array
+ // search all bookmarks in the range and return it in the Array
sal_uInt16 GetBookmarks( const SwCntntNode& rNd,
xub_StrLen nStt, xub_StrLen
nEnd,
SvPtrarr& rArr );
- // lege einen neuen PaM an der Position an
+ // create a new PaM at the position
static SwPaM * NewSwPaM(SwDoc & rDoc,
sal_uLong const nStartIdx, sal_uLong const
nEndIdx);
- // kopiere ggfs. eine lokale Datei ins Internet
+ // upload a local file to the internet / cloud
sal_Bool CopyLocalFileToINet( String& rFileNm );
- // Stream-spezifische Routinen, im Storage-Writer NICHT VERWENDEN!
+ // Stream-specific routines, DO NOT USE IN Storage-Writer!
- // Optimierung der Ausgabe auf den Stream.
+ // Optimize of the output stream
SvStream& OutLong( SvStream& rStrm, long nVal );
SvStream& OutULong( SvStream& rStrm, sal_uLong nVal );
- // Hex-Zahl ausgeben, default ist 2.stellige Zahl
+ // print Hex-Zahl, default is 2. digit number
Review comment:
Hex-Zahl could be translated into "hexadecimal number" unless Hex-Zahl
is an actual class or type name
##
File path: main/sw/inc/shellio.hxx
##
@@ -45,7 +45,7 @@
Re: Keep issues@ in bug reports [Was: Request for Bugzilla karma]
On Tue, Jan 26, 2021 at 07:56:24PM +0100, Marcus wrote: > Am 25.01.21 um 09:15 schrieb Arrigo Marchiori: > > FWIW... > > > > On Sun, Jan 24, 2021 at 09:10:51PM +0100, Andrea Pescetti wrote: > > > > [...] > > > If I recall correctly, we relied on a "trick" that would set the "QA > > > contact" field for any new issues to the issues mailing list. Even if the > > > assignee is changed, the "QA contact" is not reset and this meant the > > > issues > > > list received all notifications. > > > > > > But I don't see it set even for issues recently created such as > > > https://bz.apache.org/ooo/show_bug.cgi?id=128420 > > > > Confirmed. My last report: > > https://bz.apache.org/ooo/show_bug.cgi?id=128424 > > has empty "QA contact" and I cannot change it. > > > > issues@ is the default "Assignee" and I cannot change it as well. > > IMHO we just ned to make sure that isues@ is either the assignee - this > works as long as nobody is taking over the issue for working on it - or it's > in the CC list. Then every update on the issue will be posted to issues@. I understand. > I'm quite sure I've done it already, but I've enabled you for the following > BZ groups in BZ: > > canconfirm: Can confirm a bug or mark it a duplicate > editbugs: Can edit all bug fields > qa-team: Members of the AOO QA team Confirmed! Thank you! Best regards, -- Arrigo http://rigo.altervista.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
